Commit Graph

176 Commits

Author SHA1 Message Date
Thierry Crozat
f125dce608 GUI: Initialise _hotkey in ButtonWidget constructor
One of the two ButtonWidget constructor did not initialise _hotkey
when given a non-null value. This caused valgrind to report an
access to uninitialised variable in Dialog::handleKeyDown().
2013-08-10 23:26:53 +01:00
Johannes Schickel
b1bd9322a1 GUI: Take advantage of Surface::getPixels. 2013-08-03 04:02:50 +02:00
Johannes Schickel
103e926c07 GUI: Prefer getBasePtr instead of direct Surface::pixels access. 2013-08-03 04:02:48 +02:00
Torbjörn Andersson
85beaf6fed GUI: Change value by one on mouse wheel, not by one pixel
On file-grained sliders, changing the value by one pixel was
unpredictable because it wouldn't change by the same amount every
time. (And of course, some values were not possible to set.)

On course-grained sliders, changing the value by one pixel would
sometimes not change it at all, causing the slider to seem stuck.

Now the slider can be set to any value.
2012-12-27 10:13:48 +01:00
Johannes Schickel
c2971374cd Merge pull request #257 from lordhoto/graphics-conversion
Extend crossBlit for abitrary (in-place) conversions and add a in-place conversion to Surface
2012-10-08 14:18:33 -07:00
Johannes Schickel
89abab97e3 JANITORIAL: Remove trailing whitespaces.
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-09-26 04:17:55 +02:00
Johannes Schickel
a1e56adad8 GUI: Use in-place Surface conversion in widget code. 2012-08-28 02:28:17 +02:00
Johannes Schickel
90eb773c5d GUI: Implement saving in the grid based save/load chooser. 2012-07-24 23:23:06 +02:00
Johannes Schickel
0cf00ddfe2 GUI: Make container widget a bit more container like.
Now it is possible to add sub widgets to a ContainerWidget and allow for these
to get events too.
2012-07-09 02:18:22 +02:00
Johannes Schickel
c1426f783d GUI: Use a black rect when no thumbnail is available in the thumbnail load chooser. 2012-06-29 16:16:28 +02:00
Johannes Schickel
cebbc11dac GUI: Allow Surfaces with abitrary RGB pixel formats to be used in PicButtonWidget and GraphicsWidget.
Only 1Bpp aka paletted surfaces are not supported.
2012-06-13 04:48:34 +02:00
Johannes Schickel
13f9349457 GUI: Take advantage of Surface::fillRect in GraphicsWidget::setGfx. 2012-06-12 04:18:59 +02:00
Oleksiy Kurochko
97065c95e6 GUI: Fix bug with button pressed state 2012-05-07 09:54:32 +03:00
Oleksiy Kurochko
e6c317a922 GUI: Implemented pressed state for buttons 2012-05-03 19:32:08 +03:00
Johannes Schickel
f41bc8bd98 GUI: Slight formatting fix. 2012-01-29 21:17:01 +01:00
Tarek Soliman
be0f8407b6 GUI: Handle adding clear buttons that don't exist in layouts
The buttons in the keymapper are dynamically generated and don't exist in
the layout; They have no name.
2011-12-13 08:37:18 -06:00
Tarek Soliman
c6e001a1f5 GUI: Move addClearButton() from options.cpp to widget.cpp
This is so it can be used outside options.cpp
2011-12-13 08:36:41 -06:00
Eugene Sandulenko
b0fe2bbaf9 GUI: Made PicButtonWidget derivative of ButtonWidget 2011-10-25 14:56:04 +01:00
Eugene Sandulenko
9e0c1a38e1 GUI: Consistent behavior of ButtonWidget::setLabel() 2011-08-06 11:30:58 +01:00
Max Horn
333be9c072 GUI: Replace some s(n)printf uses by Common::String::format 2011-06-02 00:07:18 +02:00
strangerke
69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Johannes Schickel
71bdb86e02 Merge pull request #16 "Add a PixelFormat to Graphics::Surface.".
For further discussion check here:
https://github.com/scummvm/scummvm/pull/16

Conflicts:
	graphics/png.cpp
2011-05-01 16:54:45 +02:00
Ori Avtalion
9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Johannes Schickel
41586398ab GUI: Do not access Surface::bytesPerPixel anymore. 2011-04-17 20:58:07 +02:00
Johannes Schickel
2329a00873 GUI: Prefer Surface::create taking a PixelFormat over the one taking a byte depth. 2011-04-17 16:34:58 +02:00
Max Horn
2d1c8a3533 ALL: Fix whitespaces / indention
svn-id: r55818
2011-02-07 23:01:06 +00:00
David Turner
6412b1d2c7 GUI: Fix Memory Leak from PicButtonWidget _gfx Member.
This widget is only currently used by Hugo.

svn-id: r55364
2011-01-20 22:32:30 +00:00
Eugene Sandulenko
04a9082d02 GUI: Implement PicButtonWidget
It is a button with picture intead of text. To be used by Hugo engine

svn-id: r55099
2011-01-03 12:23:50 +00:00
Max Horn
668adaa461 GUI: Rename gui/GuiManager.* to gui/gui-manager.*
svn-id: r54265
2010-11-16 10:19:01 +00:00
Neeraj Kumar
8e7cce6e5b fixed a typo with hotkeys in ButtonWidget
svn-id: r51830
2010-08-07 12:13:12 +00:00
Eugene Sandulenko
d6695e180c GUI: Fix tooltip drawing
With help of Tanoku tooltips were switched from widgets to dialogs
which helped to fix nasty bug with background not being restored.
Although it is basically a hack around inconsistent font backbuffering
in our GUI code, for the time being it is feasible.

The patch was extended with way to specify tooltip background in the
theme file.

svn-id: r51217
2010-07-23 19:36:47 +00:00
Johannes Schickel
e5e94d4511 Strip trailing whitespaces in our common code base.
svn-id: r51094
2010-07-21 18:17:51 +00:00
Johannes Schickel
052d2ab6f1 Prevent GraphicsWidget from being assigned a surface which wouldn't fit in the widget.
svn-id: r50641
2010-07-04 01:18:49 +00:00
Johannes Schickel
acecfcaf69 Center the surface of a GraphicsWidget in case it is smaller than the widget's size.
svn-id: r50639
2010-07-04 01:11:18 +00:00
David Turner
8f962a8fc3 Fix for Tooltip calls causing valgrind errors.
svn-id: r49901
2010-06-16 06:24:21 +00:00
Eugene Sandulenko
dc57c68454 GUI: Fix crash.
svn-id: r49784
2010-06-15 10:56:30 +00:00
Eugene Sandulenko
01f9006ee7 GUI: Implement tooltips. FR #2821513.
FR #2821513: "GUI: add tooltips".
Added tooltips for Add Game button, clear field buttons and couple
other.

Current problem: Only first call correctly restores text. I could
not find where restore information gets lost.

svn-id: r49774
2010-06-15 10:52:35 +00:00
Eugene Sandulenko
dc040aa867 GUI: Implement radiobuttons.
Implement radiobuttons in GUI. Also closes FR #2821529:
"GUI: volume and subtitles speed sliders".

Subtitle toggle button is replaced by three radiobuttons grouped
by a single group.

Updated translations and themes.

svn-id: r49767
2010-06-15 10:48:39 +00:00
Eugene Sandulenko
3fafa07ab0 GUI: Added in-place hotkeys for widgets.
Now it is possible to specify hotkeys in place for ButtonWidget
and CheckboxWidget (the only widgets with hotkeys now).

Use de-facto standard with putting hotkey between tildes (~).
Like '~O~pen'. The tildes gets stripped before after hotkey
is extracted.

This is done for giving translators possibility to specify
their own hotkeys.

Old hotkeys defined at widget instance creation are left for
leaving possibility to specify non-printable hotkeys such as
Common::ASCII_ESCAPE.

Translation files were updated respectively.

svn-id: r49766
2010-06-15 10:47:31 +00:00
Eugene Sandulenko
b0db1b5ed0 Implement FR#2507667: "GUI: Improve PopupWidget rendering / theme layouting".
- Split out label from PopUp widget
- Aligned every widget on all layouts so GUI becomes to look nice again
- Moved textHAlign to layout properties

svn-id: r41266
2009-06-06 17:52:44 +00:00
Eugene Sandulenko
b0f7f2e8d4 Implement widget property "textalign". Added it to all theme layouts
svn-id: r41265
2009-06-06 17:51:41 +00:00
Johannes Schickel
b3c6751b9b Strip trailing whitespaces in the whole code base.
svn-id: r40867
2009-05-24 15:17:42 +00:00
Vicent Marti
8fe3735f69 Fixed bug #2706939 (Enabled button not drawn correctly) and other similar cases.
Fixed background shading weirdness when opening many dialogs on top of each other.
Fixed some modal dialogs not redrawing properly when closed.

svn-id: r39938
2009-04-11 17:12:17 +00:00
Vicent Marti
e7ee119603 Fixed regression in Options menu and disabled Save/Load buttons.
svn-id: r38524
2009-02-19 00:37:34 +00:00
Vicent Marti
ad4f3fb410 Last minute fix (enabling/disabling widgets mid-frame).
svn-id: r38520
2009-02-19 00:17:08 +00:00
Vicent Marti
341873c9d3 Third attemp at fixing release-critical #2472185. Also fixes regression reported in #2555710.
svn-id: r36227
2009-02-07 00:23:53 +00:00
Vicent Marti
108d4cfbd0 Reverted previous commit.
svn-id: r36226
2009-02-06 23:28:08 +00:00
Vicent Marti
30189f09d9 Removed special case when redrawing the dialog stack. Fixes bug #2555710 and several lesser graphical glitches with classic theme.
svn-id: r36225
2009-02-06 22:16:04 +00:00
Max Horn
abc06ca18e Moved Graphics::PixelFormat into its own header file; turned RGBToColor etc. into methods, and added an operator==
svn-id: r35993
2009-01-22 04:35:10 +00:00
Vicent Marti
d638ddd3d6 Fixed release critical bug #2472185. All transparent buttons should now properly refresh their text when changed between redrawing frames. This includes the launcher "Add game" button and the options "subtitle mode" button.
svn-id: r35789
2009-01-08 18:09:13 +00:00