Commit Graph

102 Commits

Author SHA1 Message Date
Sven Hesse
1fa0197229 GOB: Make the currently playing CD track all-uppercase
This is what the original game does too, and the scripts query for
all-uppercase CD track names.

Interestingly, this being wrong has been mostly inconsequential. It
does, however, manifest in one bug in the underwater wreck level of
Gobliins 2. After calling the Moray Eel by lighting the lamp with
Winkle, speaking to said eel has the scripts wait for the currently
playing background track to end before playing the voice lines,
instead of ending the audio track forcefully. The track is only about
a minute long, so it's "only" annoying, not a game-stopper.

The scripts also try to compare the CD track name with some different,
all-uppercase names, so this is possibly relevant in some other places
as well. No such bug report exists at the moment, though.

See also the forum post with the bug report:
http://forums.scummvm.org/viewtopic.php?p=81733#81733

A somewhat related bug report is #2999 "GOB2 : Moray Eel Game Freeze
(Wreck Scene)" (<http://sourceforge.net/p/scummvm/bugs/2999/>). At
that time, the script expression parser still did a stricmp for the
NEQ expression (which is wrong), and that made the bug not trigger.
Commit 5c58b9a3a4, which fixed that
incorrect NEQ behaviour, then made this bug here appear.
2015-09-02 20:38:16 +02:00
Max Horn
91e925d8ce GOB: Get rid of unused Audio::mixer references
Also remove the unused AdLib::_rate member variable.
2015-07-19 17:06:18 +02:00
Matthew Hoops
bed9da8b9d AUDIO: Remove all AudioStream access to OPL 2015-07-07 20:19:47 -04:00
Walter van Niftrik
e31da911c9 GOB: Implement custom AdLib volume control 2015-07-07 20:19:45 -04:00
Matthew Hoops
73e8ac2a9b GOB: Use the built-in OPL timer 2015-07-07 20:19:45 -04:00
Matthew Hoops
2e8f9dcec9 AUDIO: Remove the sample rate configuration from the OPL code 2015-07-07 20:19:42 -04:00
Johannes Schickel
ea21bc939a GOB: Make GPL headers consistent in themselves. 2014-02-18 02:39:34 +01:00
Sven Hesse
bbe4372f5b GOB: Add another sanity check 2013-04-15 18:42:46 +02:00
Sven Hesse
3540b943cf GOB: Fix a potential array overrun 2013-04-15 18:30:12 +02:00
Sven Hesse
658608d0dd GOB: Correct a delete/delete[]-mismatch 2013-04-15 18:24:09 +02:00
Sven Hesse
3189729c97 GOB: Don't leak in sampleLoad() when loading fails 2012-07-30 01:44:46 +02:00
Sven Hesse
2d05974b5c GOB: const correctness in SoundBlaster::playComposition() 2012-07-30 01:24:18 +02:00
Sven Hesse
95d9052c8d GOB: Fix a very stupid mistake in the Gob1 background track selection
Thanks to salty-horse for catching that. :)
2012-06-23 18:24:29 +02:00
Sven Hesse
892ca3a9c5 GOB: Don't loop /all/ sounds in Little Red
Just the title music... *cough*
2012-06-18 17:14:04 +02:00
Sven Hesse
08c0fa9105 GOB: Remove a superfluous semicolon 2012-06-16 03:04:35 +02:00
Sven Hesse
a24cb57c9d GOB: Loop the Little Red title music 2012-06-16 02:58:53 +02:00
Sven Hesse
f538b76586 GOB: Don't recalculate the AdLib frequencies table on every player reset 2012-06-11 15:10:59 +02:00
Sven Hesse
fe44939eba GOB: Play the music on the title screen of Gob1 EGA
The EGA version of Gobliiins comes with an MDY track.
While the original doesn't play it, we thought it might
be a nice idea to play it nevertheless.
2012-06-11 06:20:34 +02:00
Sven Hesse
03ef6689c0 GOB: Rewrite the AdLib players
This is a complete rewrite of the AdLib players for ADL and MDY/TBR
files in the Gob engine.

Major changes
1) The AdLib base class is now completely separated from all file
   format code and can theoretically be used by any OPL2-based
   format (within reason)
2) The new code is far better documented and more readable
3) The MDY player now actually works. The MDY/TBR format is
   in reality the MUS/SND format created by AdLib as a simpler
   alternative to the ROL format
4) Since the MAME emulator is quite buggy and leads to noticable
   wrong percussion in the Gobliins 2 title music, the new AdLib
   player will try to create a DOSBox OPL. If it's not compiled in,
   or if the user configured opl_driver to "mame", it will print
   out appropriate warnings.
2012-06-11 05:18:06 +02:00
Sven Hesse
8414627216 GOB: Play Oko's breathing sound 2012-01-27 14:45:41 +01:00
Sven Hesse
1998ab500e GOB: Tell Geisha that we have no AdLib
The title music is then played from SND files instead of
MDY/TBR files (that we still don't yet support).
2011-09-14 21:42:18 +02:00
Johannes Schickel
44068338e5 GOB: Made some static data const. 2011-09-08 20:03:30 +02:00
D G Turner
8356656575 GOB: Replace snprintf() usage with Common::String::format()
Safer and less portability issues.
2011-06-02 02:20:51 +01:00
Max Horn
4cbe4ede66 COMMON: Registers RandomSources in constructor with the event recorder
This also removes the dependency of engines on the event recorder header
and API, and will make it easier to RandomSources that are not properly
registered.
2011-05-17 12:17:26 +02:00
strangerke
69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion
9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Ori Avtalion
765540a5fd GOB: Avoid hiding overloaded virtual methods 2011-02-26 20:25:44 +02:00
Max Horn
42ab839dd6 AUDIO: Rename sound/ dir to audio/
svn-id: r55850
2011-02-09 01:09:01 +00:00
Max Horn
2d1c8a3533 ALL: Fix whitespaces / indention
svn-id: r55818
2011-02-07 23:01:06 +00:00
Sven Hesse
0793e5c0a3 GOB: Adibou has background atmosphere
svn-id: r55644
2011-01-30 00:02:14 +00:00
Sven Hesse
65bc46d3ab GOB: Add Script::evalInt() and Script::evalString()
svn-id: r55634
2011-01-29 22:47:53 +00:00
Sven Hesse
ce3d4b5d1b GOB: Add GobEngine::isCurrentTot()
svn-id: r55630
2011-01-29 22:45:51 +00:00
Sven Hesse
0c3a33c354 GOB: Change _curTotFile and _totToLoad into Common::String
svn-id: r55629
2011-01-29 22:45:15 +00:00
Sven Hesse
95ed10adde GOB: Add SoundDesc::swap()
svn-id: r55564
2011-01-27 13:27:29 +00:00
Max Horn
2180b2d6b5 COMMON: Split common/stream.h into several headers
svn-id: r54385
2010-11-19 17:03:07 +00:00
Max Horn
059944e59c COMMON: Push #include audiocd.h in system.h out to .cpp files
svn-id: r54148
2010-11-08 23:07:42 +00:00
Max Horn
82e473bc3b BACKENDS: Partial merge of gsoc2010-opengl: Audio CD changes only
This commit contains the AudioCDManager changes from the gsoc2010-opengl
branch. The other changes in that branch are restricted to the backends
directory only (plus configure).

The Nintendo DS and Dreamcast ports still need to be ported over to
the new Audio CD system, but that should be fairly easy to do.

svn-id: r54147
2010-11-08 22:53:36 +00:00
Sven Hesse
16a3cc8a84 GOB: Clean up class DataIO
Removing the need for class DataStream and that handle mess.

svn-id: r53984
2010-10-31 20:07:14 +00:00
Sven Hesse
835455798f GOB: Remove the now useless helper.h
svn-id: r53491
2010-10-15 13:55:18 +00:00
Sven Hesse
5c48c3fd2b GOB: Remove strncpy0()
Replacing it (and some strncpy + manual terminating) with
Common::strlcpy()

svn-id: r53490
2010-10-15 13:54:23 +00:00
Sven Hesse
089988c11c GOB: Fix Code analysis warnings
See bug report #3087831

svn-id: r53464
2010-10-15 04:37:44 +00:00
Johannes Schickel
75e8452b6e OPENGL: Merged from trunk, from rev 52105 to 53396.
This includes an rather hacky attempt to merge all the recent gp2x backend
changes into the branch. I suppose the gp2x backend and probably all new
backends, i.e. gph, dingux etc., might not compile anymore.

Since I have no way of testing those it would be nice if porters could look
into getting those up to speed in this branch.

svn-id: r53399
2010-10-13 03:57:44 +00:00
Arnaud Boutonné
5cd3ea41db GOB: Clean up of Fascination code
Move Fascination specific function to appropriate classes, plus some style modifications

svn-id: r52267
2010-08-21 18:16:04 +00:00
Arnaud Boutonné
bdedf90c59 Suppress one more useless debug message
svn-id: r52162
2010-08-17 19:04:04 +00:00
Arnaud Boutonné
8b649178ce Fascination - Add workaround for script bug: wrong track name is called in storage room
svn-id: r52107
2010-08-15 23:40:24 +00:00
Alejandro Marzini
e1ef3cd9fc Renamed getAudioCD to getAudioCDManager.
svn-id: r49678
2010-06-15 04:13:12 +00:00
Alejandro Marzini
e991cd8c53 - Revised abstract AudioCDManager.
- Removed AudioCDManager Singleton, and changed code for using AudioCDManager in OSystem.
- Added initialization code for new AudioCDManager in BaseBackend and OSystem_SDL.

svn-id: r49548
2010-06-09 20:09:57 +00:00
Johannes Schickel
cbbb78d9f2 Enforce conversion formatting on pointer casts in the DEV code.
svn-id: r49068
2010-05-17 22:46:53 +00:00
Max Horn
a1840bd573 AUDIO: Rename Mixer::playInputStream to playStream
svn-id: r48637
2010-04-12 09:14:17 +00:00
Max Horn
d78dba3bca COMMON: Move Common::RandomSource to common/random.*
svn-id: r48279
2010-03-18 15:07:11 +00:00