Commit Graph

471 Commits

Author SHA1 Message Date
Alexander Tkachev
b665fc933d ALL: Make simpleSaveNames() a MetaEngineFeature
Added it into hasFeature() of all engines which returned `true` in
simpleSaveNames() before.

As mentioned in #788, SCI is not always using simple names, so it
doesn't have such feature now.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
ab1d160ec8 ALL: Add MetaEngine::simpleSaveNames()
Engines with "simple" savenames would support "Run in background" in
save/load dialog and gradual save slots unlocking. Other engines
save/load feature would be locked until save sync is over.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
f1a56eaf36 GUI: Show "locked" saves during sync 2016-08-24 16:07:55 +06:00
Hubert Maier
a6786c28f4 Fix CGE copyright sign 2016-05-29 15:11:02 +03:00
Eugene Sandulenko
33abb6118f ALL: Change main engine header guard defines to <directory>_<engine>_H
Recently we started to use this as new semantics, although in the past
we used simly <engine>_H. Now these guard defines are consistent with
rest of the files which are used in the engines.
2016-05-17 18:21:30 +02:00
Ori Avtalion
3564032330 JANITORIAL: Reduce audio header dependencies 2016-04-14 16:10:21 +03:00
Ori Avtalion
253e18c440 JANITORIAL: Reduce GUI header dependencies 2016-04-14 13:30:14 +03:00
Johannes Schickel
0b6befdcc5 ENGINES: Make variable names of AdvancedMetaEngine conform to our guidelines.
_singleid   -> _singleId
_gameids    -> _gameIds
_guioptions -> _guiOptions
2016-03-08 19:01:13 +01:00
Johannes Schickel
e428dfc744 CGE: Let listSaves return list sorted on slot numbers. 2016-02-25 21:39:45 +01:00
Thierry Crozat
742d33d703 CGE: Add events.cpp to POTFILE 2016-02-20 21:24:38 +00:00
Thierry Crozat
245afb1fcb CGE: Translate buttons in load and save dialogs. 2016-02-20 21:08:34 +00:00
Johannes Schickel
24daecd8f3 CGE: Only request actual save slots in listSaves. 2016-01-26 16:35:30 +01:00
Filippos Karapetis
62c2e46566 CGE: Remove trailing whitespace 2014-10-28 16:04:11 +02:00
Strangerke
96d99c480b CGE: Add a safeguard in getPage() 2014-10-11 09:19:09 +02:00
Thierry Crozat
7daa9f7850 CGE: Add list of files that contain translatable strings 2014-10-04 01:01:03 +01:00
Strangerke
690c6cc8d4 CGE: Fix a crash when detecting an empty set of VOL files 2014-09-26 23:41:51 +02:00
Strangerke
9cb37636cf CGE: Cleanup detection, implement fallbackDetect 2014-09-17 23:09:34 +02:00
Peter Bozsó
11872dfb91 CGE: Remove fallback detection. 2014-09-16 14:01:54 +02:00
Johannes Schickel
007548f314 CGE: Get rid of superflous game name in extra field. 2014-08-12 17:41:29 +02:00
Eugene Sandulenko
c6033e0467 Merge pull request #488 from urukgit/cge2
CGE2: Add Sfinx engine
2014-08-12 08:09:28 +02:00
uruk
51ac9cadd4 CGE: Fix EncryptedStream::err(). 2014-08-11 16:16:54 +02:00
Strangerke
61e3115b1f CGE: Remove (broken) variable length specification 2014-06-15 21:52:06 +02:00
Strangerke
c57991ddfa CGE: Use booleans instead of uint16 in flag structure 2014-06-15 19:47:37 +02:00
uruk
bb2f8dd68e Merge branch 'master' of https://github.com/scummvm/scummvm into cge2 2014-05-30 11:14:47 +02:00
Johannes Schickel
ae4ffe01f0 ALL: Rename Debugger::DCmd_Register to Debugger::registerCmd. 2014-05-27 02:04:08 +02:00
Johannes Schickel
daa8d57a86 ALL: Rename Debugger::DebugPrintf to Debugger::debugPrintf. 2014-05-27 02:04:07 +02:00
uruk
5b105566a5 Merge remote-tracking branch 'origin/master' into cge2 2014-04-29 11:26:39 +02:00
uruk
5512711434 CGE: Replace magic numbers with defines. 2014-04-29 09:39:24 +02:00
uruk
b429e746a7 CGE2: Remove detection of Sfinx from CGE1. 2014-04-25 17:34:38 +02:00
Strangerke
8f41fc10b2 CGE: Remove a useless structure member, reduce a variable scope 2014-03-15 11:31:43 +01:00
Strangerke
0a9b8978ee CGE: Remove a useless variable, remove some associated dead code 2014-03-15 11:19:21 +01:00
Strangerke
62c4062841 CGE: Reorder CGEEngine constructor 2014-03-15 11:15:55 +01:00
Strangerke
1cf283bfa7 CGE: Move several variable initializations to the constructor 2014-03-15 11:09:52 +01:00
Strangerke
e9189b57b3 CGE: Get rid of a magic value in file seek 2014-03-11 07:52:46 +01:00
Strangerke
2822df856d CGE: Remove the useless return value of XCrypt() 2014-03-11 07:31:12 +01:00
Strangerke
820d96f41c CGE: Fix 2 more obsolete debug messages 2014-03-10 23:09:53 +01:00
Strangerke
f2a0d591fd CGE: Fix obsolete debug message 2014-03-10 21:58:11 +01:00
Strangerke
2be4c69939 CGE: Fix some uninitialized variables 2014-03-02 20:44:25 +01:00
Strangerke
bd66fc0e1a CGE: Add a comment about an intended fall-through 2014-03-02 20:44:23 +01:00
Strangerke
bc58a42574 CGE: Move hero shadow check inside hero check in sceneUp() 2014-03-02 20:44:22 +01:00
Strangerke
3c41d9b9cb CGE: Add a safeguard in pocFul 2014-03-02 20:44:21 +01:00
Strangerke
2c7f6a9d1d CGE: Some British to American english 2014-02-19 21:45:20 +01:00
Johannes Schickel
ed40653105 CGE: Make GPL headers consistent in themselves. 2014-02-18 02:39:33 +01:00
Johannes Schickel
299c74bd46 CGE: Indent REGISTER_PLUGIN_* for consistency. 2014-02-17 23:01:13 +01:00
Strangerke
54dbb67777 CGE: Janitorial - Remove trailing spaces 2014-02-16 18:35:14 +01:00
Strangerke
12e9c31f41 CGE: Add an option to toggle color blind mode from the launcher 2014-02-13 00:01:41 +01:00
Strangerke
a1ab4cb062 CGE: Reduce the scope of some variables 2014-02-09 11:22:21 +01:00
Johannes Schickel
417064e311 Merge pull request #417 from digitall/STACK_fixes
ALL: Fix optimization unstable code on checking for null after new.
2014-01-17 17:48:16 -08:00
D G Turner
3cf79e0792 CGE: Further alignment fixes to Bitmap class.
This fixes bug #6476 - "DC: Soltys (CGE) crashes at start up".
2014-01-17 04:32:13 +00:00
D G Turner
ac4087856f ALL: Remove optimization unstable code on checking for null after new.
These issues were identified by the STACK tool.

By default, the C++ new operator will throw an exception on allocation
failure, rather than returning a null pointer.

The result is that testing the returned pointer for null is redundant
and _may_ be removed by the compiler. This is thus optimization
unstable and may result in incorrect behaviour at runtime.

However, we do not use exceptions as they are not supported by all
compilers and may be disabled.

To make this stable without removing the null check, you could qualify
the new operator call with std::nothrow to indicate that this should
return a null, rather than throwing an exception.

However, using (std::nothrow) was not desirable due to the Symbian
toolchain lacking a <new> header.
A global solution to this was also not easy by redefining "new" as "new
(std::nothrow)" due to custom constructors in NDS toolchain and various
common classes.

Also, this would then need explicit checks for OOM adding to all new
usages as per C malloc which is untidy.

For now to remove this optimisation unstable code is best as it is
likely to not be present anyway, and OOM will cause a system library
exception instead, even without exceptions enabled in the application
code.
2014-01-15 02:36:19 +00:00