Merge branch 'master' of https://github.com/scp-fs2open/fs2open.github.com into fotg

Fix for Coverity 1093600: Negative array index read

.editorconfig

@@ -0,0 +1,4 @@
+root = true
+
+[*.{h,cpp}]
+indent_style = tab

README.md

@@ -0,0 +1,18 @@
+[![Coverity](https://scan.coverity.com/projects/870/badge.svg)](https://scan.coverity.com/projects/870)
+
+Welcome to Freespace Open!
+
+In 2002 Volition released the source code for Freespace2. In the years since dedicated individuals have added countless new features to create a flexible and powerful space combat simulation engine. More info can be found on our [wiki](http://www.hard-light.net/wiki/index.php/Source_Code_Project)
+
+People interested in contributing are encouraged to read [this thread](http://www.hard-light.net/forums/index.php?topic=82688.0)
+
+The "projects" directory contains ready projects for:
+* Microsoft Visual C++ 6, 2005, 2008, 2010, 2011, 2013, 2015
+* Apple Xcode
+* Code::Blocks
+* Eclipse
+
+
+Review the commit logs to see what's new.
+
+See the INSTALL file for instructions on how to build fs2_open, or open the relevant MSVC project

code/ai/ai_profiles.cpp

@@ -69,454 +69,457 @@ int ai_path_type_match(char *p)
 
 void parse_ai_profiles_tbl(const char *filename)
 {
-	int i, rval;
+	int i;
 	char profile_name[NAME_LENGTH];
 	ai_profile_t dummy_profile;
 	char *saved_Mp = NULL;
 	char buf[NAME_LENGTH];
 
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", (filename) ? filename : "<default ai_profiles.tbl>", rval));
-		return;
-	}
-
-	if (filename == NULL)
-		read_file_text_from_array(defaults_get_file("ai_profiles.tbl"));
-	else
-		read_file_text(filename, CF_TYPE_TABLES);
-
-	reset_parse();		
-
-
-	// start parsing
-	required_string("#AI Profiles");
-
-	// new default?
-	if (optional_string("$Default Profile:"))
-		stuff_string(Default_profile_name, F_NAME, NAME_LENGTH);
-
-	// begin reading data
-	while (required_string_either("#End","$Profile Name:"))
-	{
-		ai_profile_t *profile = &dummy_profile;
-		ai_profile_t *previous_profile = NULL;
-		bool no_create = false;
-		
-		// get the name
-		required_string("$Profile Name:");
-		stuff_string(profile_name, F_NAME, NAME_LENGTH);
-
-		// see if it exists
-		for (i = 0; i < Num_ai_profiles; i++)
-		{
-			if (!stricmp(Ai_profiles[i].profile_name, profile_name))
-			{
-				previous_profile = &Ai_profiles[i];
-				break;
-			}
-		}
-
-		// modular table stuff
-		if (optional_string("+nocreate"))
-		{
-			no_create = true;
-
-			// use the previous one if possible,
-			// otherwise continue to use the dummy one
-			if (previous_profile != NULL)
-				profile = previous_profile;
-		}
+		if (filename == NULL)
+			read_file_text_from_array(defaults_get_file("ai_profiles.tbl"));
 		else
+			read_file_text(filename, CF_TYPE_TABLES);
+
+		reset_parse();
+
+
+		// start parsing
+		required_string("#AI Profiles");
+
+		// new default?
+		if (optional_string("$Default Profile:"))
+			stuff_string(Default_profile_name, F_NAME, NAME_LENGTH);
+
+		// begin reading data
+		while (required_string_either("#End", "$Profile Name:"))
 		{
-			// don't create multiple profiles with the same name
-			if (previous_profile != NULL)
+			ai_profile_t *profile = &dummy_profile;
+			ai_profile_t *previous_profile = NULL;
+			bool no_create = false;
+
+			// get the name
+			required_string("$Profile Name:");
+			stuff_string(profile_name, F_NAME, NAME_LENGTH);
+
+			// see if it exists
+			for (i = 0; i < Num_ai_profiles; i++)
 			{
-				Warning(LOCATION, "An ai profile named '%s' already exists!  The new one will not be created.\n", profile_name);
-			}
-			else
-			{
-				// make sure we're under the limit
-				if (Num_ai_profiles >= MAX_AI_PROFILES)
+				if (!stricmp(Ai_profiles[i].profile_name, profile_name))
 				{
-					Warning(LOCATION, "Too many profiles in ai_profiles.tbl!  Max is %d.\n", MAX_AI_PROFILES-1);	// -1 because one is built-in
-					skip_to_string("#End", NULL);
+					previous_profile = &Ai_profiles[i];
 					break;
 				}
-
-				profile = &Ai_profiles[Num_ai_profiles];
-				Num_ai_profiles++;
 			}
-		}
 
-		// initialize profile if we're not building from a previously parsed one
-		if (!no_create)
-		{
-			// base profile, so zero it out
-			if (profile == &Ai_profiles[0])
+			// modular table stuff
+			if (optional_string("+nocreate"))
 			{
-				memset(profile, 0, sizeof(ai_profile_t));
+				no_create = true;
+
+				// use the previous one if possible,
+				// otherwise continue to use the dummy one
+				if (previous_profile != NULL)
+					profile = previous_profile;
 			}
-			// brand new profile, so set it to the base defaults
 			else
 			{
-				memcpy(profile, &Ai_profiles[0], sizeof(ai_profile_t));
-			}
-		}
-
-		// set the name
-		strcpy_s(profile->profile_name, profile_name);
-
-
-		// fill in any and all settings; they're all optional and can be in any order
-		while (!check_for_string("$Profile Name:") && !check_for_string("#End"))
-		{
-			if (optional_string("$Player Afterburner Recharge Scale:"))
-				parse_float_list(profile->afterburner_recharge_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Beam Friendly Fire Damage:"))
-				parse_float_list(profile->beam_friendly_damage_cap, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Player Countermeasure Life Scale:"))
-				parse_float_list(profile->cmeasure_life_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI Countermeasure Firing Chance:"))
-				parse_float_list(profile->cmeasure_fire_chance, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI In Range Time:"))
-				parse_float_list(profile->in_range_time, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI Always Links Ammo Weapons:"))
-				parse_float_list(profile->link_ammo_levels_always, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI Maybe Links Ammo Weapons:"))
-				parse_float_list(profile->link_ammo_levels_maybe, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Primary Ammo Burst Multiplier:"))
-				parse_float_list(profile->primary_ammo_burst_mult, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI Always Links Energy Weapons:"))
-				parse_float_list(profile->link_energy_levels_always, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI Maybe Links Energy Weapons:"))
-				parse_float_list(profile->link_energy_levels_maybe, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Missles Locked on Player:") || optional_string("$Max Missiles Locked on Player:"))
-				parse_int_list(profile->max_allowed_player_homers, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Player Attackers:"))
-				parse_int_list(profile->max_attackers, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Incoming Asteroids:"))
-				parse_int_list(profile->max_incoming_asteroids, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Player Damage Factor:") || optional_string("$AI Damage Reduction to Player Hull:"))
-				parse_float_list(profile->player_damage_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Player Subsys Damage Factor:") || optional_string("$AI Damage Reduction to Player Subsys:"))
-				parse_float_list(profile->subsys_damage_scale, NUM_SKILL_LEVELS);
-
-			// represented in fractions of F1_0
-			if (optional_string("$Predict Position Delay:"))
-			{
-				int iLoop;
-				float temp_list[NUM_SKILL_LEVELS];
-
-				parse_float_list(temp_list, NUM_SKILL_LEVELS);
-
-				for (iLoop = 0; iLoop < NUM_SKILL_LEVELS; iLoop++)
-					profile->predict_position_delay[iLoop] = fl2f(temp_list[iLoop]);
-			}
-
-			if (optional_string("$AI Shield Manage Delay:") || optional_string("$AI Shield Manage Delays:"))
-				parse_float_list(profile->shield_manage_delay, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Friendly AI Fire Delay Scale:"))
-				parse_float_list(profile->ship_fire_delay_scale_friendly, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Hostile AI Fire Delay Scale:"))
-				parse_float_list(profile->ship_fire_delay_scale_hostile, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Friendly AI Secondary Fire Delay Scale:"))
-				parse_float_list(profile->ship_fire_secondary_delay_scale_friendly, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Hostile AI Secondary Fire Delay Scale:"))
-				parse_float_list(profile->ship_fire_secondary_delay_scale_hostile, NUM_SKILL_LEVELS);
-
-			if (optional_string("$AI Turn Time Scale:"))
-				parse_float_list(profile->turn_time_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Glide Attack Percent:")) {
-				parse_float_list(profile->glide_attack_percent, NUM_SKILL_LEVELS);
-				//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
-				//While we're at it, verify the range
-				for (i = 0; i < NUM_SKILL_LEVELS; i++) {
-					if (profile->glide_attack_percent[i] < 0.0f || profile->glide_attack_percent[i] > 100.0f) {
-						Warning(LOCATION, "$Glide Attack Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->glide_attack_percent[i]);
-						profile->glide_attack_percent[i] = 0.0f;
-					}
-					profile->glide_attack_percent[i] /= 100.0;
-				}
-			}
-
-			if (optional_string("$Circle Strafe Percent:")) {
-				parse_float_list(profile->circle_strafe_percent, NUM_SKILL_LEVELS);
-				//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
-				//While we're at it, verify the range
-				for (i = 0; i < NUM_SKILL_LEVELS; i++) {
-					if (profile->circle_strafe_percent[i] < 0.0f || profile->circle_strafe_percent[i] > 100.0f) {
-						Warning(LOCATION, "$Circle Strafe Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->circle_strafe_percent[i]);
-						profile->circle_strafe_percent[i] = 0.0f;
-					}
-					profile->circle_strafe_percent[i] /= 100.0;
-				}
-			}
-
-			if (optional_string("$Glide Strafe Percent:")) {
-				parse_float_list(profile->glide_strafe_percent, NUM_SKILL_LEVELS);
-				//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
-				//While we're at it, verify the range
-				for (i = 0; i < NUM_SKILL_LEVELS; i++) {
-					if (profile->glide_strafe_percent[i] < 0.0f || profile->glide_strafe_percent[i] > 100.0f) {
-						Warning(LOCATION, "$Glide Strafe Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->glide_strafe_percent[i]);
-						profile->glide_strafe_percent[i] = 0.0f;
-					}
-					profile->glide_strafe_percent[i] /= 100.0;
-				}
-			}
-
-			if (optional_string("$Random Sidethrust Percent:")) {
-				parse_float_list(profile->random_sidethrust_percent, NUM_SKILL_LEVELS);
-				//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
-				//While we're at it, verify the range
-				for (i = 0; i < NUM_SKILL_LEVELS; i++) {
-					if (profile->random_sidethrust_percent[i] < 0.0f || profile->random_sidethrust_percent[i] > 100.0f) {
-						Warning(LOCATION, "$Random Sidethrust Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->random_sidethrust_percent[i]);
-						profile->random_sidethrust_percent[i] = 0.0f;
-					}
-					profile->random_sidethrust_percent[i] /= 100.0;
-				}
-			}
-
-			if (optional_string("$Stalemate Time Threshold:"))
-				parse_float_list(profile->stalemate_time_thresh, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Stalemate Distance Threshold:"))
-				parse_float_list(profile->stalemate_dist_thresh, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Player Shield Recharge Scale:"))
-				parse_float_list(profile->shield_energy_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Player Weapon Recharge Scale:"))
-				parse_float_list(profile->weapon_energy_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Turret Target Ownage:"))
-				parse_int_list(profile->max_turret_ownage_target, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Turret Player Ownage:"))
-				parse_int_list(profile->max_turret_ownage_player, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Percentage Required For Kill Scale:"))
-				parse_float_list(profile->kill_percentage_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Percentage Required For Assist Scale:"))
-				parse_float_list(profile->assist_percentage_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Percentage Awarded For Capship Assist:"))
-				parse_float_list(profile->assist_award_percentage_scale, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Repair Penalty:"))
-				parse_int_list(profile->repair_penalty, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Delay Before Allowing Bombs to Be Shot Down:"))
-				parse_float_list(profile->delay_bomb_arm_timer, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Chance AI Has to Fire Missiles at Player:"))
-				parse_int_list(profile->chance_to_use_missiles_on_plr, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Max Aim Update Delay:"))
-				parse_float_list(profile->max_aim_update_delay, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Turret Max Aim Update Delay:"))
-				parse_float_list(profile->turret_max_aim_update_delay, NUM_SKILL_LEVELS);
-
-			if (optional_string("$Player Autoaim FOV:"))
-			{
-				float fov_list[NUM_SKILL_LEVELS];
-				parse_float_list(fov_list, NUM_SKILL_LEVELS);
-				for (i = 0; i < NUM_SKILL_LEVELS; i++)
+				// don't create multiple profiles with the same name
+				if (previous_profile != NULL)
 				{
-					//Enforce range
-					if (fov_list[i] < 0.0f || fov_list[i] >= 360.0f)
+					Warning(LOCATION, "An ai profile named '%s' already exists!  The new one will not be created.\n", profile_name);
+				}
+				else
+				{
+					// make sure we're under the limit
+					if (Num_ai_profiles >= MAX_AI_PROFILES)
 					{
-						Warning(LOCATION, "$Player Autoaim FOV should be >= 0 and < 360.0 (read %f). Setting to 0.", fov_list[i]);
-						fov_list[i] = 0.0f;
+						Warning(LOCATION, "Too many profiles in ai_profiles.tbl!  Max is %d.\n", MAX_AI_PROFILES - 1);	// -1 because one is built-in
+						skip_to_string("#End", NULL);
+						break;
 					}
 
-					//Convert units
-					profile->player_autoaim_fov[i] = fov_list[i] * PI / 180.0f;
+					profile = &Ai_profiles[Num_ai_profiles];
+					Num_ai_profiles++;
 				}
 			}
 
-			if (optional_string("$Detail Distance Multiplier:"))
-				parse_float_list(profile->detail_distance_mult, NUM_SKILL_LEVELS);
-
-			set_flag(profile, "$big ships can attack beam turrets on untargeted ships:", AIPF_BIG_SHIPS_CAN_ATTACK_BEAM_TURRETS_ON_UNTARGETED_SHIPS, AIP_FLAG);
-
-			set_flag(profile, "$smart primary weapon selection:", AIPF_SMART_PRIMARY_WEAPON_SELECTION, AIP_FLAG);
-
-			set_flag(profile, "$smart secondary weapon selection:", AIPF_SMART_SECONDARY_WEAPON_SELECTION, AIP_FLAG);
-
-			set_flag(profile, "$smart shield management:", AIPF_SMART_SHIELD_MANAGEMENT, AIP_FLAG);
-
-			set_flag(profile, "$smart afterburner management:", AIPF_SMART_AFTERBURNER_MANAGEMENT, AIP_FLAG);
-
-			set_flag(profile, "$allow rapid secondary dumbfire:", AIPF_ALLOW_RAPID_SECONDARY_DUMBFIRE, AIP_FLAG);
-			
-			set_flag(profile, "$huge turret weapons ignore bombs:", AIPF_HUGE_TURRET_WEAPONS_IGNORE_BOMBS, AIP_FLAG);
-
-			set_flag(profile, "$don't insert random turret fire delay:", AIPF_DONT_INSERT_RANDOM_TURRET_FIRE_DELAY, AIP_FLAG);
-
-			set_flag(profile, "$hack improve non-homing swarm turret fire accuracy:", AIPF_HACK_IMPROVE_NON_HOMING_SWARM_TURRET_FIRE_ACCURACY, AIP_FLAG);
-
-			set_flag(profile, "$shockwaves damage small ship subsystems:", AIPF_SHOCKWAVES_DAMAGE_SMALL_SHIP_SUBSYSTEMS, AIP_FLAG);
-
-			set_flag(profile, "$navigation subsystem governs warpout capability:", AIPF_NAVIGATION_SUBSYS_GOVERNS_WARP, AIP_FLAG);
-
-			set_flag(profile, "$ignore lower bound for minimum speed of docked ship:", AIPF_NO_MIN_DOCK_SPEED_CAP, AIP_FLAG);
-
-			set_flag(profile, "$disable linked fire penalty:", AIPF_DISABLE_LINKED_FIRE_PENALTY, AIP_FLAG);
-
-			set_flag(profile, "$disable weapon damage scaling:", AIPF_DISABLE_WEAPON_DAMAGE_SCALING, AIP_FLAG);
-
-			set_flag(profile, "$use additive weapon velocity:", AIPF_USE_ADDITIVE_WEAPON_VELOCITY, AIP_FLAG);
-
-			set_flag(profile, "$use newtonian dampening:", AIPF_USE_NEWTONIAN_DAMPENING, AIP_FLAG);
-
-			set_flag(profile, "$include beams for kills and assists:", AIPF_INCLUDE_BEAMS_IN_STAT_CALCS, AIP_FLAG);
-
-			set_flag(profile, "$score kills based on damage caused:", AIPF_KILL_SCORING_SCALES_WITH_DAMAGE, AIP_FLAG);
-
-			set_flag(profile, "$score assists based on damage caused:", AIPF_ASSIST_SCORING_SCALES_WITH_DAMAGE, AIP_FLAG);
-
-			set_flag(profile, "$allow event and goal scoring in multiplayer:", AIPF_ALLOW_MULTI_EVENT_SCORING, AIP_FLAG);
-
-			set_flag(profile, "$fix linked primary weapon decision bug:", AIPF_FIX_LINKED_PRIMARY_BUG, AIP_FLAG);
-
-			set_flag(profile, "$prevent turrets targeting too distant bombs:", AIPF_PREVENT_TARGETING_BOMBS_BEYOND_RANGE, AIP_FLAG);
-
-			set_flag(profile, "$smart subsystem targeting for turrets:", AIPF_SMART_SUBSYSTEM_TARGETING_FOR_TURRETS, AIP_FLAG);
-
-			set_flag(profile, "$fix heat seekers homing on stealth ships bug:", AIPF_FIX_HEAT_SEEKER_STEALTH_BUG, AIP_FLAG);
-
-			set_flag(profile, "$multi allow empty primaries:", AIPF_MULTI_ALLOW_EMPTY_PRIMARIES, AIP_FLAG);
-
-			set_flag(profile, "$multi allow empty secondaries:", AIPF_MULTI_ALLOW_EMPTY_SECONDARIES, AIP_FLAG);
-
-			set_flag(profile, "$allow turrets target weapons freely:", AIPF_ALLOW_TURRETS_TARGET_WEAPONS_FREELY, AIP_FLAG);
-
-			set_flag(profile, "$use only single fov for turrets:", AIPF_USE_ONLY_SINGLE_FOV_FOR_TURRETS, AIP_FLAG);
-
-			set_flag(profile, "$allow vertical dodge:", AIPF_ALLOW_VERTICAL_DODGE, AIP_FLAG);
-
-			set_flag(profile, "$force beam turrets to use normal fov:", AIPF_FORCE_BEAM_TURRET_FOV, AIP_FLAG);
-
-			set_flag(profile, "$fix ai class bug:", AIPF_FIX_AI_CLASS_BUG, AIP_FLAG);
-
-			set_flag(profile, "$turrets ignore targets radius in range checks:", AIPF2_TURRETS_IGNORE_TARGET_RADIUS, AIP_FLAG2);
-
-			set_flag(profile, "$no extra collision avoidance vs player:", AIPF2_NO_SPECIAL_PLAYER_AVOID, AIP_FLAG2);
-
-			set_flag(profile, "$perform fewer checks for death screams:", AIPF2_PERFORM_FEWER_SCREAM_CHECKS, AIP_FLAG2);
-
-			set_flag(profile, "$advanced turret fov edge checks:", AIPF2_ADVANCED_TURRET_FOV_EDGE_CHECKS, AIP_FLAG2);
-
-			set_flag(profile, "$require turrets to have target in fov:", AIPF2_REQUIRE_TURRET_TO_HAVE_TARGET_IN_FOV, AIP_FLAG2);
-
-			set_flag(profile, "$all ships manage shields:", AIPF2_ALL_SHIPS_MANAGE_SHIELDS, AIP_FLAG2);
-
-			set_flag(profile, "$ai aims from ship center:", AIPF2_AI_AIMS_FROM_SHIP_CENTER, AIP_FLAG2);
-
-			set_flag(profile, "$allow primary link at mission start:", AIPF2_ALLOW_PRIMARY_LINK_AT_START, AIP_FLAG2);
-
-			set_flag(profile, "$allow beams to damage bombs:", AIPF2_BEAMS_DAMAGE_WEAPONS, AIP_FLAG2);
-
-			set_flag(profile, "$disable weapon damage scaling for player:", AIPF2_PLAYER_WEAPON_SCALE_FIX, AIP_FLAG2);
-
-			set_flag(profile, "$countermeasures affect aspect seekers:", AIPF2_ASPECT_LOCK_COUNTERMEASURE, AIP_FLAG2);
-
-			set_flag(profile, "$ai guards specific ship in wing:", AIPF2_AI_GUARDS_SPECIFIC_SHIP_IN_WING, AIP_FLAG2);
-
-			profile->ai_path_mode = AI_PATH_MODE_NORMAL;
-			if(optional_string("$ai path mode:"))
+			// initialize profile if we're not building from a previously parsed one
+			if (!no_create)
 			{
-				stuff_string(buf, F_NAME, NAME_LENGTH);
-				int j = ai_path_type_match(buf);
-				if(j >= 0) {
-					profile->ai_path_mode = j;
-				} else {
-					Warning(LOCATION, "Invalid ai path mode '%s' specified", buf);
+				// base profile, so zero it out
+				if (profile == &Ai_profiles[0])
+				{
+					memset(profile, 0, sizeof(ai_profile_t));
+				}
+				// brand new profile, so set it to the base defaults
+				else
+				{
+					memcpy(profile, &Ai_profiles[0], sizeof(ai_profile_t));
 				}
 			}
 
-			set_flag(profile, "$no warp camera:", AIPF2_NO_WARP_CAMERA, AIP_FLAG2);
+			// set the name
+			strcpy_s(profile->profile_name, profile_name);
 
-			set_flag(profile, "$fix ai path order bug:", AIPF2_FIX_AI_PATH_ORDER_BUG, AIP_FLAG2);
 
-			set_flag(profile, "$strict turret-tagged-only targeting:", AIPF2_STRICT_TURRET_TAGGED_ONLY_TARGETING, AIP_FLAG2);
-
-			profile->bay_arrive_speed_mult = 1.0f;
-			profile->bay_depart_speed_mult = 1.0f;
-			if (optional_string("$bay arrive start speed multiplier:")) {
-				stuff_float(&profile->bay_arrive_speed_mult);
-			}
-			if (optional_string("$bay depart end speed multiplier:")) {
-				stuff_float(&profile->bay_depart_speed_mult);
-			}
-
-			// ----------
-
-			// compatibility
-			if (optional_string("$perform less checks for death screams:"))
+			// fill in any and all settings; they're all optional and can be in any order
+			while (!check_for_string("$Profile Name:") && !check_for_string("#End"))
 			{
-				mprintf(("Warning: \"$perform less checks for death screams\" flag is deprecated in favor of \"$perform fewer checks for death screams\"\n"));
-				bool temp;
-				stuff_boolean(&temp);
-				if (temp)
-					profile->flags2 |= AIPF2_PERFORM_FEWER_SCREAM_CHECKS;
-				else
-					profile->flags2 &= ~AIPF2_PERFORM_FEWER_SCREAM_CHECKS;
+				if (optional_string("$Player Afterburner Recharge Scale:"))
+					parse_float_list(profile->afterburner_recharge_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Beam Friendly Fire Damage:"))
+					parse_float_list(profile->beam_friendly_damage_cap, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Player Countermeasure Life Scale:"))
+					parse_float_list(profile->cmeasure_life_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI Countermeasure Firing Chance:"))
+					parse_float_list(profile->cmeasure_fire_chance, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI In Range Time:"))
+					parse_float_list(profile->in_range_time, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI Always Links Ammo Weapons:"))
+					parse_float_list(profile->link_ammo_levels_always, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI Maybe Links Ammo Weapons:"))
+					parse_float_list(profile->link_ammo_levels_maybe, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Primary Ammo Burst Multiplier:"))
+					parse_float_list(profile->primary_ammo_burst_mult, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI Always Links Energy Weapons:"))
+					parse_float_list(profile->link_energy_levels_always, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI Maybe Links Energy Weapons:"))
+					parse_float_list(profile->link_energy_levels_maybe, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Missles Locked on Player:") || optional_string("$Max Missiles Locked on Player:"))
+					parse_int_list(profile->max_allowed_player_homers, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Player Attackers:"))
+					parse_int_list(profile->max_attackers, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Incoming Asteroids:"))
+					parse_int_list(profile->max_incoming_asteroids, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Player Damage Factor:") || optional_string("$AI Damage Reduction to Player Hull:"))
+					parse_float_list(profile->player_damage_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Player Subsys Damage Factor:") || optional_string("$AI Damage Reduction to Player Subsys:"))
+					parse_float_list(profile->subsys_damage_scale, NUM_SKILL_LEVELS);
+
+				// represented in fractions of F1_0
+				if (optional_string("$Predict Position Delay:"))
+				{
+					int iLoop;
+					float temp_list[NUM_SKILL_LEVELS];
+
+					parse_float_list(temp_list, NUM_SKILL_LEVELS);
+
+					for (iLoop = 0; iLoop < NUM_SKILL_LEVELS; iLoop++)
+						profile->predict_position_delay[iLoop] = fl2f(temp_list[iLoop]);
+				}
+
+				if (optional_string("$AI Shield Manage Delay:") || optional_string("$AI Shield Manage Delays:"))
+					parse_float_list(profile->shield_manage_delay, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Friendly AI Fire Delay Scale:"))
+					parse_float_list(profile->ship_fire_delay_scale_friendly, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Hostile AI Fire Delay Scale:"))
+					parse_float_list(profile->ship_fire_delay_scale_hostile, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Friendly AI Secondary Fire Delay Scale:"))
+					parse_float_list(profile->ship_fire_secondary_delay_scale_friendly, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Hostile AI Secondary Fire Delay Scale:"))
+					parse_float_list(profile->ship_fire_secondary_delay_scale_hostile, NUM_SKILL_LEVELS);
+
+				if (optional_string("$AI Turn Time Scale:"))
+					parse_float_list(profile->turn_time_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Glide Attack Percent:")) {
+					parse_float_list(profile->glide_attack_percent, NUM_SKILL_LEVELS);
+					//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
+					//While we're at it, verify the range
+					for (i = 0; i < NUM_SKILL_LEVELS; i++) {
+						if (profile->glide_attack_percent[i] < 0.0f || profile->glide_attack_percent[i] > 100.0f) {
+							Warning(LOCATION, "$Glide Attack Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->glide_attack_percent[i]);
+							profile->glide_attack_percent[i] = 0.0f;
+						}
+						profile->glide_attack_percent[i] /= 100.0;
+					}
+				}
+
+				if (optional_string("$Circle Strafe Percent:")) {
+					parse_float_list(profile->circle_strafe_percent, NUM_SKILL_LEVELS);
+					//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
+					//While we're at it, verify the range
+					for (i = 0; i < NUM_SKILL_LEVELS; i++) {
+						if (profile->circle_strafe_percent[i] < 0.0f || profile->circle_strafe_percent[i] > 100.0f) {
+							Warning(LOCATION, "$Circle Strafe Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->circle_strafe_percent[i]);
+							profile->circle_strafe_percent[i] = 0.0f;
+						}
+						profile->circle_strafe_percent[i] /= 100.0;
+					}
+				}
+
+				if (optional_string("$Glide Strafe Percent:")) {
+					parse_float_list(profile->glide_strafe_percent, NUM_SKILL_LEVELS);
+					//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
+					//While we're at it, verify the range
+					for (i = 0; i < NUM_SKILL_LEVELS; i++) {
+						if (profile->glide_strafe_percent[i] < 0.0f || profile->glide_strafe_percent[i] > 100.0f) {
+							Warning(LOCATION, "$Glide Strafe Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->glide_strafe_percent[i]);
+							profile->glide_strafe_percent[i] = 0.0f;
+						}
+						profile->glide_strafe_percent[i] /= 100.0;
+					}
+				}
+
+				if (optional_string("$Random Sidethrust Percent:")) {
+					parse_float_list(profile->random_sidethrust_percent, NUM_SKILL_LEVELS);
+					//Percent is nice for modders, but here in the code we want it betwwen 0 and 1.0
+					//While we're at it, verify the range
+					for (i = 0; i < NUM_SKILL_LEVELS; i++) {
+						if (profile->random_sidethrust_percent[i] < 0.0f || profile->random_sidethrust_percent[i] > 100.0f) {
+							Warning(LOCATION, "$Random Sidethrust Percent should be between 0 and 100.0 (read %f). Setting to 0.", profile->random_sidethrust_percent[i]);
+							profile->random_sidethrust_percent[i] = 0.0f;
+						}
+						profile->random_sidethrust_percent[i] /= 100.0;
+					}
+				}
+
+				if (optional_string("$Stalemate Time Threshold:"))
+					parse_float_list(profile->stalemate_time_thresh, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Stalemate Distance Threshold:"))
+					parse_float_list(profile->stalemate_dist_thresh, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Player Shield Recharge Scale:"))
+					parse_float_list(profile->shield_energy_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Player Weapon Recharge Scale:"))
+					parse_float_list(profile->weapon_energy_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Turret Target Ownage:"))
+					parse_int_list(profile->max_turret_ownage_target, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Turret Player Ownage:"))
+					parse_int_list(profile->max_turret_ownage_player, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Percentage Required For Kill Scale:"))
+					parse_float_list(profile->kill_percentage_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Percentage Required For Assist Scale:"))
+					parse_float_list(profile->assist_percentage_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Percentage Awarded For Capship Assist:"))
+					parse_float_list(profile->assist_award_percentage_scale, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Repair Penalty:"))
+					parse_int_list(profile->repair_penalty, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Delay Before Allowing Bombs to Be Shot Down:"))
+					parse_float_list(profile->delay_bomb_arm_timer, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Chance AI Has to Fire Missiles at Player:"))
+					parse_int_list(profile->chance_to_use_missiles_on_plr, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Max Aim Update Delay:"))
+					parse_float_list(profile->max_aim_update_delay, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Turret Max Aim Update Delay:"))
+					parse_float_list(profile->turret_max_aim_update_delay, NUM_SKILL_LEVELS);
+
+				if (optional_string("$Player Autoaim FOV:"))
+				{
+					float fov_list[NUM_SKILL_LEVELS];
+					parse_float_list(fov_list, NUM_SKILL_LEVELS);
+					for (i = 0; i < NUM_SKILL_LEVELS; i++)
+					{
+						//Enforce range
+						if (fov_list[i] < 0.0f || fov_list[i] >= 360.0f)
+						{
+							Warning(LOCATION, "$Player Autoaim FOV should be >= 0 and < 360.0 (read %f). Setting to 0.", fov_list[i]);
+							fov_list[i] = 0.0f;
+						}
+
+						//Convert units
+						profile->player_autoaim_fov[i] = fov_list[i] * PI / 180.0f;
+					}
+				}
+
+				if (optional_string("$Detail Distance Multiplier:"))
+					parse_float_list(profile->detail_distance_mult, NUM_SKILL_LEVELS);
+
+				set_flag(profile, "$big ships can attack beam turrets on untargeted ships:", AIPF_BIG_SHIPS_CAN_ATTACK_BEAM_TURRETS_ON_UNTARGETED_SHIPS, AIP_FLAG);
+
+				set_flag(profile, "$smart primary weapon selection:", AIPF_SMART_PRIMARY_WEAPON_SELECTION, AIP_FLAG);
+
+				set_flag(profile, "$smart secondary weapon selection:", AIPF_SMART_SECONDARY_WEAPON_SELECTION, AIP_FLAG);
+
+				set_flag(profile, "$smart shield management:", AIPF_SMART_SHIELD_MANAGEMENT, AIP_FLAG);
+
+				set_flag(profile, "$smart afterburner management:", AIPF_SMART_AFTERBURNER_MANAGEMENT, AIP_FLAG);
+
+				set_flag(profile, "$allow rapid secondary dumbfire:", AIPF_ALLOW_RAPID_SECONDARY_DUMBFIRE, AIP_FLAG);
+
+				set_flag(profile, "$huge turret weapons ignore bombs:", AIPF_HUGE_TURRET_WEAPONS_IGNORE_BOMBS, AIP_FLAG);
+
+				set_flag(profile, "$don't insert random turret fire delay:", AIPF_DONT_INSERT_RANDOM_TURRET_FIRE_DELAY, AIP_FLAG);
+
+				set_flag(profile, "$hack improve non-homing swarm turret fire accuracy:", AIPF_HACK_IMPROVE_NON_HOMING_SWARM_TURRET_FIRE_ACCURACY, AIP_FLAG);
+
+				set_flag(profile, "$shockwaves damage small ship subsystems:", AIPF_SHOCKWAVES_DAMAGE_SMALL_SHIP_SUBSYSTEMS, AIP_FLAG);
+
+				set_flag(profile, "$navigation subsystem governs warpout capability:", AIPF_NAVIGATION_SUBSYS_GOVERNS_WARP, AIP_FLAG);
+
+				set_flag(profile, "$ignore lower bound for minimum speed of docked ship:", AIPF_NO_MIN_DOCK_SPEED_CAP, AIP_FLAG);
+
+				set_flag(profile, "$disable linked fire penalty:", AIPF_DISABLE_LINKED_FIRE_PENALTY, AIP_FLAG);
+
+				set_flag(profile, "$disable weapon damage scaling:", AIPF_DISABLE_WEAPON_DAMAGE_SCALING, AIP_FLAG);
+
+				set_flag(profile, "$use additive weapon velocity:", AIPF_USE_ADDITIVE_WEAPON_VELOCITY, AIP_FLAG);
+
+				set_flag(profile, "$use newtonian dampening:", AIPF_USE_NEWTONIAN_DAMPENING, AIP_FLAG);
+
+				set_flag(profile, "$include beams for kills and assists:", AIPF_INCLUDE_BEAMS_IN_STAT_CALCS, AIP_FLAG);
+
+				set_flag(profile, "$score kills based on damage caused:", AIPF_KILL_SCORING_SCALES_WITH_DAMAGE, AIP_FLAG);
+
+				set_flag(profile, "$score assists based on damage caused:", AIPF_ASSIST_SCORING_SCALES_WITH_DAMAGE, AIP_FLAG);
+
+				set_flag(profile, "$allow event and goal scoring in multiplayer:", AIPF_ALLOW_MULTI_EVENT_SCORING, AIP_FLAG);
+
+				set_flag(profile, "$fix linked primary weapon decision bug:", AIPF_FIX_LINKED_PRIMARY_BUG, AIP_FLAG);
+
+				set_flag(profile, "$prevent turrets targeting too distant bombs:", AIPF_PREVENT_TARGETING_BOMBS_BEYOND_RANGE, AIP_FLAG);
+
+				set_flag(profile, "$smart subsystem targeting for turrets:", AIPF_SMART_SUBSYSTEM_TARGETING_FOR_TURRETS, AIP_FLAG);
+
+				set_flag(profile, "$fix heat seekers homing on stealth ships bug:", AIPF_FIX_HEAT_SEEKER_STEALTH_BUG, AIP_FLAG);
+
+				set_flag(profile, "$multi allow empty primaries:", AIPF_MULTI_ALLOW_EMPTY_PRIMARIES, AIP_FLAG);
+
+				set_flag(profile, "$multi allow empty secondaries:", AIPF_MULTI_ALLOW_EMPTY_SECONDARIES, AIP_FLAG);
+
+				set_flag(profile, "$allow turrets target weapons freely:", AIPF_ALLOW_TURRETS_TARGET_WEAPONS_FREELY, AIP_FLAG);
+
+				set_flag(profile, "$use only single fov for turrets:", AIPF_USE_ONLY_SINGLE_FOV_FOR_TURRETS, AIP_FLAG);
+
+				set_flag(profile, "$allow vertical dodge:", AIPF_ALLOW_VERTICAL_DODGE, AIP_FLAG);
+
+				set_flag(profile, "$force beam turrets to use normal fov:", AIPF_FORCE_BEAM_TURRET_FOV, AIP_FLAG);
+
+				set_flag(profile, "$fix ai class bug:", AIPF_FIX_AI_CLASS_BUG, AIP_FLAG);
+
+				set_flag(profile, "$turrets ignore targets radius in range checks:", AIPF2_TURRETS_IGNORE_TARGET_RADIUS, AIP_FLAG2);
+
+				set_flag(profile, "$no extra collision avoidance vs player:", AIPF2_NO_SPECIAL_PLAYER_AVOID, AIP_FLAG2);
+
+				set_flag(profile, "$perform fewer checks for death screams:", AIPF2_PERFORM_FEWER_SCREAM_CHECKS, AIP_FLAG2);
+
+				set_flag(profile, "$advanced turret fov edge checks:", AIPF2_ADVANCED_TURRET_FOV_EDGE_CHECKS, AIP_FLAG2);
+
+				set_flag(profile, "$require turrets to have target in fov:", AIPF2_REQUIRE_TURRET_TO_HAVE_TARGET_IN_FOV, AIP_FLAG2);
+
+				set_flag(profile, "$all ships manage shields:", AIPF2_ALL_SHIPS_MANAGE_SHIELDS, AIP_FLAG2);
+
+				set_flag(profile, "$ai aims from ship center:", AIPF2_AI_AIMS_FROM_SHIP_CENTER, AIP_FLAG2);
+
+				set_flag(profile, "$allow primary link at mission start:", AIPF2_ALLOW_PRIMARY_LINK_AT_START, AIP_FLAG2);
+
+				set_flag(profile, "$allow beams to damage bombs:", AIPF2_BEAMS_DAMAGE_WEAPONS, AIP_FLAG2);
+
+				set_flag(profile, "$disable weapon damage scaling for player:", AIPF2_PLAYER_WEAPON_SCALE_FIX, AIP_FLAG2);
+
+				set_flag(profile, "$countermeasures affect aspect seekers:", AIPF2_ASPECT_LOCK_COUNTERMEASURE, AIP_FLAG2);
+
+				set_flag(profile, "$ai guards specific ship in wing:", AIPF2_AI_GUARDS_SPECIFIC_SHIP_IN_WING, AIP_FLAG2);
+
+				profile->ai_path_mode = AI_PATH_MODE_NORMAL;
+				if (optional_string("$ai path mode:"))
+				{
+					stuff_string(buf, F_NAME, NAME_LENGTH);
+					int j = ai_path_type_match(buf);
+					if (j >= 0) {
+						profile->ai_path_mode = j;
+					}
+					else {
+						Warning(LOCATION, "Invalid ai path mode '%s' specified", buf);
+					}
+				}
+
+				set_flag(profile, "$no warp camera:", AIPF2_NO_WARP_CAMERA, AIP_FLAG2);
+
+				set_flag(profile, "$fix ai path order bug:", AIPF2_FIX_AI_PATH_ORDER_BUG, AIP_FLAG2);
+
+				set_flag(profile, "$strict turret-tagged-only targeting:", AIPF2_STRICT_TURRET_TAGGED_ONLY_TARGETING, AIP_FLAG2);
+
+				profile->bay_arrive_speed_mult = 1.0f;
+				profile->bay_depart_speed_mult = 1.0f;
+				if (optional_string("$bay arrive start speed multiplier:")) {
+					stuff_float(&profile->bay_arrive_speed_mult);
+				}
+				if (optional_string("$bay depart end speed multiplier:")) {
+					stuff_float(&profile->bay_depart_speed_mult);
+				}
+
+				// ----------
+
+				// compatibility
+				if (optional_string("$perform less checks for death screams:"))
+				{
+					mprintf(("Warning: \"$perform less checks for death screams\" flag is deprecated in favor of \"$perform fewer checks for death screams\"\n"));
+					bool temp;
+					stuff_boolean(&temp);
+					if (temp)
+						profile->flags2 |= AIPF2_PERFORM_FEWER_SCREAM_CHECKS;
+					else
+						profile->flags2 &= ~AIPF2_PERFORM_FEWER_SCREAM_CHECKS;
+				}
+				if (optional_string("$allow primary link delay:"))
+				{
+					mprintf(("Warning: \"$allow primary link delay\" flag is deprecated in favor of \"$allow primary link at mission start\"\n"));
+					bool temp;
+					stuff_boolean(&temp);
+					if (temp)
+						profile->flags2 &= ~AIPF2_ALLOW_PRIMARY_LINK_AT_START;
+					else
+						profile->flags2 |= AIPF2_ALLOW_PRIMARY_LINK_AT_START;
+				}
+
+
+				// if we've been through once already and are at the same place, force a move
+				if (saved_Mp && (saved_Mp == Mp))
+				{
+					char tmp[60];
+					memset(tmp, 0, 60);
+					strncpy(tmp, Mp, 59);
+					mprintf(("WARNING: Unrecognized parameter in ai_profiles: %s\n", tmp));
+
+					Mp++;
+				}
+
+				// find next valid option
+				skip_to_start_of_string_either("$", "#");
+				saved_Mp = Mp;
 			}
-			if (optional_string("$allow primary link delay:"))
-			{
-				mprintf(("Warning: \"$allow primary link delay\" flag is deprecated in favor of \"$allow primary link at mission start\"\n"));
-				bool temp;
-				stuff_boolean(&temp);
-				if (temp)
-					profile->flags2 &= ~AIPF2_ALLOW_PRIMARY_LINK_AT_START;
-				else
-					profile->flags2 |= AIPF2_ALLOW_PRIMARY_LINK_AT_START;
-			}
-
-
-			// if we've been through once already and are at the same place, force a move
-			if ( saved_Mp && (saved_Mp == Mp) )
-			{
-				char tmp[60];
-				memset(tmp, 0, 60);
-				strncpy(tmp, Mp, 59);
-				mprintf(("WARNING: Unrecognized parameter in ai_profiles: %s\n", tmp));
-
-				Mp++;
-			}
-
-			// find next valid option
-			skip_to_start_of_string_either("$", "#");
-			saved_Mp = Mp;
 		}
+
+		required_string("#End");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", (filename) ? filename : "<default ai_profiles.tbl>", e.what()));
+		return;
 	}
-	
-	required_string("#End");
 
 	// add tbl/tbm to multiplayer validation list
 	extern void fs2netd_add_table_validation(const char *tblname);

code/ai/aicode.cpp

@@ -826,13 +826,14 @@ LOCAL int ai_inited = 0;
 void ai_init()
 {
 	if ( !ai_inited )	{
-		// Do the first time initialization stuff here
-		int	rval;
-
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "ai.tbl", rval));
-		} else {			
-			parse_aitbl();			
+		// Do the first time initialization stuff here		
+		try
+		{
+			parse_aitbl();
+		}
+		catch (const parse::ParseException& e)
+		{
+			mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "ai.tbl", e.what()));
 		}
 
 		ai_inited = 1;

code/ai/aigoals.cpp

@@ -171,7 +171,7 @@ void ai_post_process_mission()
 		// Goober5000 - MK originally iterated on only the first wing; now we iterate on only the player wing
 		// because the player wing may not be first
 		for ( i = 0; i < MAX_STARTING_WINGS; i++ ) {	
-			if ( Starting_wings[i] == Player_ship->wingnum ) {
+			if (Starting_wings[i] >= 0 && Starting_wings[i] == Player_ship->wingnum) {
 				wing *wingp;
 
 				wingp = &Wings[Starting_wings[i]];
@@ -528,7 +528,7 @@ int ai_goal_find_dockpoint(int shipnum, int dock_type)
 }
 
 // function to fix up dock point references for objects.
-// passed are the pointer to goal we are working with.  aip if the ai_info pointer
+// passed are the pointer to goal we are working with.  aip is the ai_info pointer
 // of the ship with the order.  aigp is a pointer to the goal (of aip) of which we are
 // fixing up the docking points
 void ai_goal_fixup_dockpoints(ai_info *aip, ai_goal *aigp)
@@ -537,6 +537,7 @@ void ai_goal_fixup_dockpoints(ai_info *aip, ai_goal *aigp)
 
 	Assert ( aip->shipnum != -1 );
 	shipnum = ship_name_lookup( aigp->target_name );
+	Assertion ( shipnum != -1, "Couldn't find ai goal's target_name (%s); get a coder!\n", aigp->target_name );
 	docker_index = -1;
 	dockee_index = -1;
 

code/asteroid/asteroid.cpp

@@ -1887,143 +1887,148 @@ that is being protected.
 void asteroid_parse_tbl()
 {
 	char impact_ani_file[MAX_FILENAME_LEN];
-	int rval;
 
 	// How did we get here without having any species defined?
 	Assertion(Species_info.size() > 0,
 		"Cannot parse asteroids/debris if there "
 		"are no species for them to belong to."
 		);
-
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "asteroid.tbl", rval));
-		return;
-	}
-
-	read_file_text("asteroid.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	required_string("#Asteroid Types");
-
-	int tally = 0;
-	int max_asteroids =
-		NUM_DEBRIS_SIZES + Species_info.size() * NUM_DEBRIS_SIZES;
-
-#ifndef NDEBUG
-	SCP_vector<SCP_string> parsed_asteroids;
-#endif
-
-	// parse and tally each asteroid
-	while (required_string_either("#End","$Name:"))
+	
+	try
 	{
-		asteroid_info new_asteroid;
+		read_file_text("asteroid.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-		asteroid_parse_section( &new_asteroid );
+		required_string("#Asteroid Types");
+
+		int tally = 0;
+		int max_asteroids =
+			NUM_DEBRIS_SIZES + Species_info.size() * NUM_DEBRIS_SIZES;
 
-		int species = tally / NUM_DEBRIS_SIZES;
-		if (tally >= max_asteroids)
-		{
-#ifdef NDEBUG
-			// Bump the warning count in release so they get something
-			// even if the message never gets displayed.
-			Warning(LOCATION, "Ignoring extra asteroid/debris");
-#else
-			SCP_string msg("Ignoring extra asteroid/debris '");
-			msg.append(new_asteroid.name);
-			msg.append("'\n");
-			Warning(LOCATION,msg.c_str());
-			parsed_asteroids.push_back(msg);
-#endif
-		}
-		else
-		{
 #ifndef NDEBUG
-			SCP_string msg;
-			msg.append("Parsing asteroid: '");
-			msg.append(new_asteroid.name);
-			msg.append("' as a '");
-			msg.append((species == 0)?"generic":Species_info[species-1].species_name);
-			msg.append("'");
-			switch(tally % NUM_DEBRIS_SIZES) {
-			case ASTEROID_TYPE_SMALL:
-				msg.append(" small\n");
-				break;
-			case ASTEROID_TYPE_MEDIUM:
-				msg.append(" medium\n");
-				break;
-			case ASTEROID_TYPE_LARGE:
-				msg.append(" large\n");
-				break;
-			default:
-				Error(LOCATION, "Get a coder! Math has broken!\n"
-					"Important numbers:\n"
-					"\ttally: %d\n"
-					"\tNUM_DEBRIS_SIZES: %d\n",
-					tally, NUM_DEBRIS_SIZES
-					);
-				msg.append(" unknown\n");
+		SCP_vector<SCP_string> parsed_asteroids;
+#endif
+
+		// parse and tally each asteroid
+		while (required_string_either("#End", "$Name:"))
+		{
+			asteroid_info new_asteroid;
+
+			asteroid_parse_section(&new_asteroid);
+
+			int species = tally / NUM_DEBRIS_SIZES;
+			if (tally >= max_asteroids)
+			{
+#ifdef NDEBUG
+				// Bump the warning count in release so they get something
+				// even if the message never gets displayed.
+				Warning(LOCATION, "Ignoring extra asteroid/debris");
+#else
+				SCP_string msg("Ignoring extra asteroid/debris '");
+				msg.append(new_asteroid.name);
+				msg.append("'\n");
+				Warning(LOCATION, msg.c_str());
+				parsed_asteroids.push_back(msg);
+#endif
 			}
-			parsed_asteroids.push_back(msg);
-#endif
-			Asteroid_info.push_back(new_asteroid);
-		}
-		tally++;
-	}
-	required_string("#End");
-
-	if (tally != max_asteroids)
-	{
+			else
+			{
 #ifndef NDEBUG
-		for(SCP_vector<SCP_string>::iterator iter = parsed_asteroids.begin();
-			iter != parsed_asteroids.end(); ++iter)
-		{
-			mprintf(("Asteroid.tbl as parsed:\n"));
-			mprintf((iter->c_str()));
+				SCP_string msg;
+				msg.append("Parsing asteroid: '");
+				msg.append(new_asteroid.name);
+				msg.append("' as a '");
+				msg.append((species == 0) ? "generic" : Species_info[species - 1].species_name);
+				msg.append("'");
+				switch (tally % NUM_DEBRIS_SIZES) {
+				case ASTEROID_TYPE_SMALL:
+					msg.append(" small\n");
+					break;
+				case ASTEROID_TYPE_MEDIUM:
+					msg.append(" medium\n");
+					break;
+				case ASTEROID_TYPE_LARGE:
+					msg.append(" large\n");
+					break;
+				default:
+					Error(LOCATION, "Get a coder! Math has broken!\n"
+						"Important numbers:\n"
+						"\ttally: %d\n"
+						"\tNUM_DEBRIS_SIZES: %d\n",
+						tally, NUM_DEBRIS_SIZES
+						);
+					msg.append(" unknown\n");
+				}
+				parsed_asteroids.push_back(msg);
+#endif
+				Asteroid_info.push_back(new_asteroid);
+			}
+			tally++;
 		}
+		required_string("#End");
+
+		if (tally != max_asteroids)
+		{
+#ifndef NDEBUG
+			for (SCP_vector<SCP_string>::iterator iter = parsed_asteroids.begin();
+				iter != parsed_asteroids.end(); ++iter)
+			{
+				mprintf(("Asteroid.tbl as parsed:\n"));
+				mprintf((iter->c_str()));
+			}
 #endif
-		Error(LOCATION,
-			"Found %d asteroids/debris when %d expected\n\n"
-			"<Number expected> = <Number of species> * %d + %d generic asteroids\n"
-			"%d = %d*%d + %d\n\n"
+			Error(LOCATION,
+				"Found %d asteroids/debris when %d expected\n\n"
+				"<Number expected> = <Number of species> * %d + %d generic asteroids\n"
+				"%d = %d*%d + %d\n\n"
 #ifdef NDEBUG
-			"Run a debug build to see a list of all parsed asteroids\n",
+				"Run a debug build to see a list of all parsed asteroids\n",
 #else
-			"See the debug.log for a listing of all parsed asteroids\n",
+				"See the debug.log for a listing of all parsed asteroids\n",
 #endif
-			tally, max_asteroids,
-			NUM_DEBRIS_SIZES, NUM_DEBRIS_SIZES,
-			max_asteroids, Species_info.size(), NUM_DEBRIS_SIZES, NUM_DEBRIS_SIZES
-			);
+				tally, max_asteroids,
+				NUM_DEBRIS_SIZES, NUM_DEBRIS_SIZES,
+				max_asteroids, Species_info.size(), NUM_DEBRIS_SIZES, NUM_DEBRIS_SIZES
+				);
+		}
+
+		Asteroid_impact_explosion_ani = -1;
+		required_string("$Impact Explosion:");
+		stuff_string(impact_ani_file, F_NAME, MAX_FILENAME_LEN);
+
+		if (VALID_FNAME(impact_ani_file)) {
+			int num_frames;
+			Asteroid_impact_explosion_ani = bm_load_animation(impact_ani_file, &num_frames, NULL, NULL, 1);
+		}
+
+		required_string("$Impact Explosion Radius:");
+		stuff_float(&Asteroid_impact_explosion_radius);
+
+		if (optional_string("$Briefing Icon Closeup Model:")) {
+			stuff_string(Asteroid_icon_closeup_model, F_NAME, NAME_LENGTH);
+		}
+		else {
+			strcpy_s(Asteroid_icon_closeup_model, Asteroid_info[ASTEROID_TYPE_LARGE].pof_files[0]);	// magic file from retail
+		}
+
+		if (optional_string("$Briefing Icon Closeup Position:")) {
+			stuff_vec3d(&Asteroid_icon_closeup_position);
+		}
+		else {
+			vm_vec_make(&Asteroid_icon_closeup_position, 0.0f, 0.0f, -334.0f);  // magic numbers from retail
+		}
+
+		if (optional_string("$Briefing Icon Closeup Zoom:")) {
+			stuff_float(&Asteroid_icon_closeup_zoom);
+		}
+		else {
+			Asteroid_icon_closeup_zoom = 0.5f;	// magic number from retail
+		}
 	}
-
-	Asteroid_impact_explosion_ani = -1;
-	required_string("$Impact Explosion:");
-	stuff_string(impact_ani_file, F_NAME, MAX_FILENAME_LEN);
-
-	if ( VALID_FNAME(impact_ani_file) ) {
-		int num_frames;
-		Asteroid_impact_explosion_ani = bm_load_animation( impact_ani_file, &num_frames, NULL, NULL, 1);
-	}
-
-	required_string("$Impact Explosion Radius:");
-	stuff_float(&Asteroid_impact_explosion_radius);
-
-	if (optional_string("$Briefing Icon Closeup Model:")) {
-		stuff_string(Asteroid_icon_closeup_model, F_NAME, NAME_LENGTH);
-	} else {
-		strcpy_s(Asteroid_icon_closeup_model, Asteroid_info[ASTEROID_TYPE_LARGE].pof_files[0]);	// magic file from retail
-	}
-
-	if (optional_string("$Briefing Icon Closeup Position:")) {
-		stuff_vec3d(&Asteroid_icon_closeup_position);
-	} else {
-		vm_vec_make(&Asteroid_icon_closeup_position, 0.0f, 0.0f, -334.0f);  // magic numbers from retail
-	}
-
-	if (optional_string("$Briefing Icon Closeup Zoom:")) {
-		stuff_float(&Asteroid_icon_closeup_zoom);
-	} else {
-		Asteroid_icon_closeup_zoom = 0.5f;	// magic number from retail
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "asteroid.tbl", e.what()));
+		return;
 	}
 }
 

code/autopilot/autopilot.cpp

@@ -1271,68 +1271,69 @@ void NavSystem_Init()
 
 void parse_autopilot_table(char *filename)
 {
-	int rval;
 	SCP_vector<SCP_string> lines;
 
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", (filename) ? filename : "<default autopilot.tbl>", rval));
+		if (filename == NULL)
+			read_file_text_from_array(defaults_get_file("autopilot.tbl"));
+		else
+			read_file_text(filename, CF_TYPE_TABLES);
+
+		reset_parse();
+
+
+		required_string("#Autopilot");
+
+		// autopilot link distance
+		required_string("$Link Distance:");
+		stuff_int(&NavLinkDistance);
+
+		if (optional_string("$Interrupt autopilot if enemy within distance:"))
+			stuff_int(&AutopilotMinEnemyDistance);
+		else
+			AutopilotMinEnemyDistance = 5000;
+
+		if (optional_string("$Interrupt autopilot if asteroid within distance:"))
+			stuff_int(&AutopilotMinAsteroidDistance);
+		else
+			AutopilotMinAsteroidDistance = 1000;
+
+		if (optional_string("$Lock Weapons During Autopilot:"))
+			stuff_boolean(&LockWeaponsDuringAutopilot);
+		else
+			LockWeaponsDuringAutopilot = false;
+
+		// optional no cutscene bars
+		if (optional_string("+No_Cutscene_Bars"))
+			UseCutsceneBars = false;
+		// optional no cutscene bars
+		if (optional_string("+No_Autopilot_Interrupt"))
+			Cmdline_autopilot_interruptable = 0;
+
+		// No Nav selected message
+		char *msg_tags[] = { "$No Nav Selected:", "$Gliding:",
+			"$Too Close:", "$Hostiles:", "$Linked:", "$Hazard:",
+			"$Support Present:", "$Support Working:" };
+		for (int i = 0; i < NP_NUM_MESSAGES; i++)
+		{
+			required_string(msg_tags[i]);
+
+			required_string("+Msg:");
+			stuff_string(NavMsgs[i].message, F_MESSAGE, 256);
+
+			required_string("+Snd File:");
+			stuff_string(NavMsgs[i].filename, F_NAME, 256);
+		}
+
+
+		required_string("#END");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", (filename) ? filename : "<default autopilot.tbl>", e.what()));
 		return;
 	}
-
-	if (filename == NULL)
-		read_file_text_from_array(defaults_get_file("autopilot.tbl"));
-	else
-		read_file_text(filename, CF_TYPE_TABLES);
-
-	reset_parse();		
-
-	
-	required_string("#Autopilot");
-
-	// autopilot link distance
-	required_string("$Link Distance:");
-	stuff_int(&NavLinkDistance);
-
-	if (optional_string("$Interrupt autopilot if enemy within distance:"))
-		stuff_int(&AutopilotMinEnemyDistance);
-	else
-		AutopilotMinEnemyDistance = 5000;
-
-	if (optional_string("$Interrupt autopilot if asteroid within distance:"))
-		stuff_int(&AutopilotMinAsteroidDistance);
-	else
-		AutopilotMinAsteroidDistance = 1000;
-
-	if (optional_string("$Lock Weapons During Autopilot:"))
-		stuff_boolean(&LockWeaponsDuringAutopilot);
-	else
-		LockWeaponsDuringAutopilot = false;
-
-	// optional no cutscene bars
-	if (optional_string("+No_Cutscene_Bars"))
-		UseCutsceneBars = false;
-	// optional no cutscene bars
-	if (optional_string("+No_Autopilot_Interrupt"))
-		Cmdline_autopilot_interruptable = 0;
-
-	// No Nav selected message
-	char *msg_tags[] = { "$No Nav Selected:", "$Gliding:",
-		"$Too Close:", "$Hostiles:", "$Linked:", "$Hazard:",
-		"$Support Present:", "$Support Working:" };
-	for (int i = 0; i < NP_NUM_MESSAGES; i++)
-	{
-		required_string(msg_tags[i]);
-		
-		required_string("+Msg:");
-		stuff_string(NavMsgs[i].message, F_MESSAGE, 256);
-
-		required_string("+Snd File:");
-		stuff_string(NavMsgs[i].filename, F_NAME, 256);
-	}
-
-
-	required_string("#END");
 }
 
 

code/bmpman/bmpman.cpp

@@ -1043,7 +1043,7 @@ int bm_load(const SCP_string& filename) {
 }
 
 int bm_load_and_parse_eff(const char *filename, int dir_type, int *nframes, int *nfps, int *key, ubyte *type, bool *in_subdir) {
-	int frames = 0, fps = 30, keyframe = 0, rval;
+	int frames = 0, fps = 30, keyframe = 0;
 	bool subdir = false;
 	char ext[8];
 	ubyte c_type = BM_TYPE_NONE;
@@ -1057,28 +1057,31 @@ int bm_load_and_parse_eff(const char *filename, int dir_type, int *nframes, int
 	// pause anything that may happen to be parsing right now
 	pause_parse();
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("BMPMAN: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+	try
+	{
+		// now start parsing the EFF
+		read_file_text(filename, dir_type, file_text, file_text_raw);
+		reset_parse(file_text);
+
+		required_string("$Type:");
+		stuff_string(ext, F_NAME, sizeof(ext));
+
+		required_string("$Frames:");
+		stuff_int(&frames);
+
+		if (optional_string("$FPS:"))
+			stuff_int(&fps);
+
+		if (optional_string("$Keyframe:"))
+			stuff_int(&keyframe);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("BMPMAN: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		unpause_parse();
 		return -1;
 	}
 
-	// now start parsing the EFF
-	read_file_text(filename, dir_type, file_text, file_text_raw);
-	reset_parse(file_text);
-
-	required_string("$Type:");
-	stuff_string(ext, F_NAME, sizeof(ext));
-
-	required_string("$Frames:");
-	stuff_int(&frames);
-
-	if (optional_string("$FPS:"))
-		stuff_int(&fps);
-
-	if (optional_string("$Keyframe:"))
-		stuff_int(&keyframe);
-
 	if (optional_string( "$Subdir:" )) {
 		stuff_boolean(&subdir);}
 
@@ -2170,10 +2173,10 @@ void bm_page_in_stop() {
 		if ((bm_bitmaps[i].type != BM_TYPE_NONE) && (bm_bitmaps[i].type != BM_TYPE_RENDER_TARGET_DYNAMIC) && (bm_bitmaps[i].type != BM_TYPE_RENDER_TARGET_STATIC)) {
 			if (bm_bitmaps[i].preloaded) {
 				if (bm_preloading) {
-                    if (bm_bitmaps[i].type == BM_TYPE_EFF && bm_bitmaps[i].info.ani.eff.in_subdir) {
+					if (bm_bitmaps[i].type == BM_TYPE_EFF && bm_bitmaps[i].info.ani.eff.in_subdir) {
 						set_temp_subdir_pathtype(bm_bitmaps[i].filename);
 					}
-                    
+
 					if (!gr_preload(bm_bitmaps[i].handle, (bm_bitmaps[i].preloaded == 2))) {
 						mprintf(("Out of VRAM.  Done preloading.\n"));
 						bm_preloading = 0;

code/camera/camera.cpp

@@ -540,8 +540,15 @@ void warp_camera::get_info(vec3d *position, matrix *orientation)
 //*************************subtitle*************************
 
 #define MAX_SUBTITLE_LINES		64
-subtitle::subtitle(int in_x_pos, int in_y_pos, const char* in_text, const char* in_imageanim, float in_display_time, float in_fade_time, const color *in_text_color, int in_text_fontnum, bool center_x, bool center_y, int in_width, int in_height, bool in_post_shaded)
+subtitle::subtitle(int in_x_pos, int in_y_pos, const char* in_text, const char* in_imageanim, float in_display_time,
+	float in_fade_time, const color *in_text_color, int in_text_fontnum, bool center_x, bool center_y, int in_width,
+	int in_height, bool in_post_shaded)
+	:display_time(-1.0f), fade_time(-1.0f), text_fontnum(-1), time_displayed(-1.0f), time_displayed_end(-1.0f),
+	post_shaded(false)
 {
+	// Initialize color
+	gr_init_color(&text_color, 0, 0, 0);
+	
 	SCP_string text_buf;
 
 	// basic init, this always has to be done

code/cfile/cfile.cpp

@@ -502,7 +502,7 @@ int cf_exists(const char *filename, int dir_type)
 	if ( (filename == NULL) || !strlen(filename) )
 		return 0;
 
-	return (cf_find_file_location(filename, dir_type, 0, NULL, &offset, NULL) && !offset);
+	return (cf_find_file_location(filename, dir_type, 0, NULL, NULL, &offset) && !offset);
 }
 
 // Goober5000

code/cutscene/cutscenes.cpp

@@ -52,59 +52,61 @@ void cutscene_init()
 {
 	atexit(cutscene_close);
 	char buf[MULTITEXT_LENGTH];
-	int rval;
-    cutscene_info cutinfo;
+	cutscene_info cutinfo;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "cutscenes.tbl", rval));
+	try
+	{
+		read_file_text("cutscenes.tbl", CF_TYPE_TABLES);
+		reset_parse();
+
+		// parse in all the cutscenes
+		Cutscenes.clear();
+		skip_to_string("#Cutscenes");
+		ignore_white_space();
+
+		bool isFirstCutscene = true;
+
+		while (required_string_either("#End", "$Filename:"))
+		{
+			required_string("$Filename:");
+			stuff_string(cutinfo.filename, F_PATHNAME, MAX_FILENAME_LEN);
+
+			required_string("$Name:");
+			stuff_string(cutinfo.name, F_NAME, NAME_LENGTH);
+
+			required_string("$Description:");
+			stuff_string(buf, F_MULTITEXT, sizeof(buf));
+			drop_white_space(buf);
+			compact_multitext_string(buf);
+			cutinfo.description = vm_strdup(buf);
+
+			if (optional_string("$cd:"))
+				stuff_int(&cutinfo.cd);
+			else
+				cutinfo.cd = 0;
+
+			cutinfo.viewable = false;
+
+			if (isFirstCutscene) {
+				isFirstCutscene = false;
+				// The original code assumes the first movie is the intro, so always viewable
+				cutinfo.viewable = true;
+			}
+
+			if (optional_string("$Always Viewable:")) {
+				stuff_boolean(&cutinfo.viewable);
+			}
+
+			Cutscenes.push_back(cutinfo);
+		}
+
+		required_string("#End");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "cutscenes.tbl", e.what()));
 		return;
 	}
-
-	read_file_text("cutscenes.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	// parse in all the cutscenes
-	Cutscenes.clear();
-	skip_to_string("#Cutscenes");
-	ignore_white_space();
-
-	bool isFirstCutscene = true;
-
-	while ( required_string_either("#End", "$Filename:") ) 
-    {
-		required_string("$Filename:");
-		stuff_string( cutinfo.filename, F_PATHNAME, MAX_FILENAME_LEN );
-
-		required_string("$Name:");
-		stuff_string( cutinfo.name, F_NAME, NAME_LENGTH );
-
-		required_string("$Description:");
-		stuff_string(buf, F_MULTITEXT, sizeof(buf));
-		drop_white_space(buf);
-		compact_multitext_string(buf);
-		cutinfo.description = vm_strdup(buf);
-
-		if (optional_string("$cd:"))
-			stuff_int( &cutinfo.cd );
-		else
-			cutinfo.cd = 0;
-
-		cutinfo.viewable = false;
-
-		if (isFirstCutscene) {
-			isFirstCutscene = false;
-			// The original code assumes the first movie is the intro, so always viewable
-			cutinfo.viewable = true;
-		}
-
-		if (optional_string("$Always Viewable:")) {
-			stuff_boolean(&cutinfo.viewable);
-		}
-
-        Cutscenes.push_back(cutinfo);
-	}
-
-	required_string("#End");
 }
 
 // function to return 0 based index of which CD a particular movie is on

code/fireball/fireballs.cpp

@@ -159,84 +159,93 @@ static void fireball_set_default_color(int idx)
  */
 void parse_fireball_tbl(const char *filename)
 {
-	int rval;
 	lod_checker lod_check;
 	color fb_color;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
+
+		required_string("#Start");
+
+		while (required_string_either("#End", "$Name:")) {
+			memset(&lod_check, 0, sizeof(lod_checker));
+
+			// base filename
+			required_string("$Name:");
+			stuff_string(lod_check.filename, F_NAME, MAX_FILENAME_LEN);
+
+			lod_check.override = -1;
+
+			// these entries should only be in TBMs, and it has to include at least one
+			if (Parsing_modular_table) {
+				if (optional_string("+Explosion_Medium")) {
+					lod_check.override = FIREBALL_EXPLOSION_MEDIUM;
+				}
+				else if (optional_string("+Warp_Effect")) {
+					lod_check.override = FIREBALL_WARP;
+				}
+				else if (optional_string("+Knossos_Effect")) {
+					lod_check.override = FIREBALL_KNOSSOS;
+				}
+				else if (optional_string("+Asteroid")) {
+					lod_check.override = FIREBALL_ASTEROID;
+				}
+				else if (optional_string("+Explosion_Large1")) {
+					lod_check.override = FIREBALL_EXPLOSION_LARGE1;
+				}
+				else if (optional_string("+Explosion_Large2")){
+					lod_check.override = FIREBALL_EXPLOSION_LARGE2;
+				}
+				else {
+					required_string("+Custom_Fireball");
+					stuff_int(&lod_check.override);
+				}
+			}
+
+			lod_check.num_lods = 1;
+
+			// Do we have an LOD num
+			if (optional_string("$LOD:")) {
+				stuff_int(&lod_check.num_lods);
+			}
+
+			if (lod_check.num_lods > MAX_FIREBALL_LOD) {
+				lod_check.num_lods = MAX_FIREBALL_LOD;
+			}
+
+			// check for particular lighting color
+			if (optional_string("$Light color:")) {
+				int r, g, b;
+
+				stuff_int(&r);
+				stuff_int(&g);
+				stuff_int(&b);
+
+				CLAMP(r, 0, 255);
+				CLAMP(g, 0, 255);
+				CLAMP(b, 0, 255);
+
+				gr_init_color(&fb_color, r, g, b);
+			}
+			else {
+				// to keep things simple, we just use 0 alpha to indicate that a default value should be used
+				memset(&fb_color, 0, sizeof(color));
+			}
+
+			// we may use one filename for multiple entries so we'll have to handle dupes post parse
+			LOD_checker.push_back(lod_check);
+			LOD_color.push_back(fb_color);
+		}
+
+		required_string("#End");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	required_string("#Start");
-
-	while (required_string_either("#End", "$Name:")) {
-		memset( &lod_check, 0, sizeof(lod_checker) );
-
-		// base filename
-		required_string("$Name:");
-		stuff_string(lod_check.filename, F_NAME, MAX_FILENAME_LEN);
-
-		lod_check.override = -1;
-
-		// these entries should only be in TBMs, and it has to include at least one
-		if ( Parsing_modular_table ) {
-			if (optional_string("+Explosion_Medium")) {
-				lod_check.override = FIREBALL_EXPLOSION_MEDIUM;
-			} else if (optional_string("+Warp_Effect")) {
-				lod_check.override = FIREBALL_WARP;
-			} else if (optional_string("+Knossos_Effect")) {
-				lod_check.override = FIREBALL_KNOSSOS;
-			} else if (optional_string("+Asteroid")) {
-				lod_check.override = FIREBALL_ASTEROID;
-			} else if (optional_string("+Explosion_Large1")) {
-				lod_check.override = FIREBALL_EXPLOSION_LARGE1;
-			} else if (optional_string("+Explosion_Large2")){
-				lod_check.override = FIREBALL_EXPLOSION_LARGE2;
-			} else {
-				required_string("+Custom_Fireball");
-				stuff_int(&lod_check.override);
-			}
-		}
-
-		lod_check.num_lods = 1;
-
-		// Do we have an LOD num
-		if (optional_string("$LOD:")) {
-			stuff_int(&lod_check.num_lods);
-		}
-
-		if (lod_check.num_lods > MAX_FIREBALL_LOD) {
-			lod_check.num_lods = MAX_FIREBALL_LOD;
-		}
-
-		// check for particular lighting color
-		if ( optional_string("$Light color:") ) {
-			int r, g, b;
-
-			stuff_int(&r);
-			stuff_int(&g);
-			stuff_int(&b);
-
-			CLAMP(r, 0, 255);
-			CLAMP(g, 0, 255);
-			CLAMP(b, 0, 255);
-
-			gr_init_color(&fb_color, r, g, b);
-		} else {
-			// to keep things simple, we just use 0 alpha to indicate that a default value should be used
-			memset( &fb_color, 0, sizeof(color) );
-		}
-
-		// we may use one filename for multiple entries so we'll have to handle dupes post parse
-		LOD_checker.push_back(lod_check);
-		LOD_color.push_back(fb_color);
-	}
-
-	required_string("#End");
 }
 
 void fireball_parse_tbl()

code/fred2/bgbitmapdlg.cpp

@@ -1267,7 +1267,7 @@ void bg_bitmap_dlg::OnImportBackground()
 {
 	CFileDialog cfd(TRUE, ".fs2", NULL, 0, "FreeSpace2 Missions (*.fs2)|*.fs2||\0");
 	char filename[256], error_str[1024];
-	int rval, temp, count;
+	int temp, count;
 	char *saved_mp;
 
 	//warn on pressing the button
@@ -1280,59 +1280,62 @@ void bg_bitmap_dlg::OnImportBackground()
 
 	strcpy_s(filename, cfd.GetPathName());
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("BGBITMAPDLG: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		sprintf(error_str, "Could not parse file: %s", filename);
-
-		MessageBox((LPCTSTR) error_str, (LPCTSTR) "Unable to import mission background!", MB_ICONERROR | MB_OK);
-		return;
-	}
-
-	// parse in the new file
-	read_file_text(filename);
-	reset_parse();
-
-	if (!skip_to_start_of_string("#Background bitmaps"))
-		return;
-
-	// skip beginning stuff
-	required_string("#Background bitmaps");
-	required_string("$Num stars:");
-	stuff_int(&temp);
-	required_string("$Ambient light level:");
-	stuff_int(&temp);
-
-	saved_mp = Mp;
-
-	// see if we have more than one background in this mission
-	count = 0;
-	while(skip_to_string("$Bitmap List:"))
-		count++;
-
-	Mp = saved_mp;
-
-	// pick one (if count is 0, it's retail with just one background)
-	if (count > 0)
+	try
 	{
-		int i, which = 0;
+		// parse in the new file
+		read_file_text(filename);
+		reset_parse();
 
-		if (count > 1)
+		if (!skip_to_start_of_string("#Background bitmaps"))
+			return;
+
+		// skip beginning stuff
+		required_string("#Background bitmaps");
+		required_string("$Num stars:");
+		stuff_int(&temp);
+		required_string("$Ambient light level:");
+		stuff_int(&temp);
+
+		saved_mp = Mp;
+
+		// see if we have more than one background in this mission
+		count = 0;
+		while (skip_to_string("$Bitmap List:"))
+			count++;
+
+		Mp = saved_mp;
+
+		// pick one (if count is 0, it's retail with just one background)
+		if (count > 0)
 		{
-			BackgroundChooser dlg(count);
-			if (dlg.DoModal() == IDCANCEL)
-				return;
+			int i, which = 0;
 
-			which = dlg.GetChosenBackground();
+			if (count > 1)
+			{
+				BackgroundChooser dlg(count);
+				if (dlg.DoModal() == IDCANCEL)
+					return;
+
+				which = dlg.GetChosenBackground();
+			}
+
+			for (i = 0; i < which + 1; i++)
+				skip_to_string("$Bitmap List:");
 		}
 
-		for (i = 0; i < which + 1; i++)
-			skip_to_string("$Bitmap List:");
+		// now parse the background we've selected
+		parse_one_background(&Backgrounds[get_active_background()]);
+
+		reinitialize_lists();
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("BGBITMAPDLG: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		sprintf(error_str, "Could not parse file: %s\n\nError message: %s", filename, e.what());
 
-	// now parse the background we've selected
-	parse_one_background(&Backgrounds[get_active_background()]);
-
-	reinitialize_lists();
+		MessageBox((LPCTSTR)error_str, (LPCTSTR) "Unable to import mission background!", MB_ICONERROR | MB_OK);
+		return;
+	}
 }
 
 void bg_bitmap_dlg::reinitialize_lists()

code/freespace2/freespace.cpp

@@ -1259,7 +1259,7 @@ void game_loading_callback_close()
 	// Make sure bar shows all the way over.
 	game_loading_callback(COUNT_ESTIMATE);
 	
-	int real_count = game_busy_callback( NULL );
+	int real_count __attribute__((__unused__)) = game_busy_callback( NULL );
  	Mouse_hidden = 0;
 
 	Game_loading_callback_inited = 0;
@@ -1423,7 +1423,7 @@ int game_start_mission()
 {
 	mprintf(( "=================== STARTING LEVEL LOAD ==================\n" ));
 
-	int s1 = timer_get_milliseconds();
+	int s1 __attribute__((__unused__)) = timer_get_milliseconds();
 
 	// clear post processing settings
 	gr_post_process_set_defaults();
@@ -1480,7 +1480,7 @@ int game_start_mission()
 
 	bm_print_bitmaps();
 
-	int e1 = timer_get_milliseconds();
+	int e1 __attribute__((__unused__)) = timer_get_milliseconds();
 
 	mprintf(("Level load took %f seconds.\n", (e1 - s1) / 1000.0f ));
 
@@ -1739,7 +1739,7 @@ char full_path[1024];
  */
 void game_init()
 {
-	int s1, e1;
+	int s1 __attribute__((__unused__)), e1 __attribute__((__unused__));
 	const char *ptr;
 	char whee[MAX_PATH_LEN];
 

code/gamehelp/contexthelp.cpp

@@ -323,7 +323,7 @@ void parse_helptbl(const char *filename)
 	int overlay_id, currcount, vtxcount;
 	char name[HELP_MAX_NAME_LENGTH];
 	char buf[HELP_MAX_STRING_LENGTH + 1];
-	int i, j, rval;
+	int i, j;
 
 	SCP_vector<help_pline> pline_temp;
 	help_pline pline_temp2;
@@ -335,160 +335,166 @@ void parse_helptbl(const char *filename)
 	help_left_bracket lbracket_temp2;
 	vec3d vec3d_temp;
 	
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	} 
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
+		// for each overlay...
+		while (optional_string("$")) {
 
-	// for each overlay...
-	while (optional_string("$")) {
+			stuff_string(name, F_NAME, HELP_MAX_NAME_LENGTH);
 
-		stuff_string(name, F_NAME, HELP_MAX_NAME_LENGTH);
+			overlay_id = help_overlay_get_index(name);
 
-		overlay_id = help_overlay_get_index(name);
+			if (overlay_id < 0) {
+				if (num_help_overlays >= MAX_HELP_OVERLAYS) {
+					Warning(LOCATION, "Could not load help overlay after '%s' as maximum number of help overlays was reached (Max is %d)", help_overlaylist[overlay_id - 1].name, MAX_HELP_OVERLAYS);
 
-		if (overlay_id < 0) {
-			if (num_help_overlays >= MAX_HELP_OVERLAYS) {
-				Warning(LOCATION, "Could not load help overlay after '%s' as maximum number of help overlays was reached (Max is %d)", help_overlaylist[overlay_id - 1].name, MAX_HELP_OVERLAYS);
-
-				if (!skip_to_string("$end")) {
-					Error(LOCATION, "Couldn't find $end. Help.tbl or -hlp.tbm is invalid.\n");
-				}
-
-				continue;
-			} else {
-				overlay_id = num_help_overlays;
-				strcpy_s(help_overlaylist[overlay_id].name, name);
-				num_help_overlays++;
-			}
-		}
-
-		// clear out counters in the overlay struct
-		help_overlaylist[overlay_id].plinecount = 0;
-		help_overlaylist[overlay_id].textcount = 0;
-		help_overlaylist[overlay_id].rbracketcount = 0;
-		help_overlaylist[overlay_id].lbracketcount = 0;
-
-		help_overlaylist[overlay_id].fontlist.clear();
-		help_overlaylist[overlay_id].plinelist.clear();
-		help_overlaylist[overlay_id].textlist.clear();
-		help_overlaylist[overlay_id].rbracketlist.clear();
-		help_overlaylist[overlay_id].lbracketlist.clear();
-
-		if (optional_string("+resolutions")) {
-			stuff_int(&help_overlaylist[overlay_id].num_resolutions);
-		} else {
-			help_overlaylist[overlay_id].num_resolutions = 2;
-		}
-
-		if (help_overlaylist[overlay_id].num_resolutions < 1) {
-			Error(LOCATION, "+resolutions in %s is %d. (Must be 1 or greater)", filename, help_overlaylist[overlay_id].num_resolutions);
-		}
-
-		if (optional_string("+font")) {
-			int font;
-			for (i=0; i<help_overlaylist[overlay_id].num_resolutions; i++) {
-				stuff_int(&font);
-				help_overlaylist[overlay_id].fontlist.push_back(font);
-			}
-		} else {
-			for (i=0; i<help_overlaylist[overlay_id].num_resolutions; i++) {
-				help_overlaylist[overlay_id].fontlist.push_back(FONT1);
-			}
-		}
-
-		for (i=0; i<help_overlaylist[overlay_id].num_resolutions; i++) {
-			help_overlaylist[overlay_id].plinelist.push_back(pline_temp);
-			help_overlaylist[overlay_id].textlist.push_back(text_temp);
-			help_overlaylist[overlay_id].rbracketlist.push_back(rbracket_temp);
-			help_overlaylist[overlay_id].lbracketlist.push_back(lbracket_temp);
-		}
-		
-		int type;
-		// read in all elements for this overlay
-		while ((type = required_string_one_of(5, "+pline", "+text", "+right_bracket", "+left_bracket", "$end")) != 4) {	// Doing it this way means an error lists "$end" at the end, which seems appropriate. -MageKing17
-
-			switch (type) {
-			case 0:	// +pline
-				required_string("+pline");
-				currcount = help_overlaylist[overlay_id].plinecount;
-				int a, b;		// temp vars to read in int before cast to float;
-
-				// read number of pline vertices
-				stuff_int(&vtxcount);
-				// get vertex coordinates for each resolution
-				for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
-					help_overlaylist[overlay_id].plinelist.at(i).push_back(pline_temp2);
-					for (j = 0; j < vtxcount; j++) {
-						help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.push_back(vec3d_temp);
-						help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtxcount = vtxcount;
-						stuff_int(&a);
-						stuff_int(&b);
-						help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.at(j).xyz.x = (float)a;
-						help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.at(j).xyz.y = (float)b;
-						help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.at(j).xyz.z = 0.0f;
+					if (!skip_to_string("$end")) {
+						Error(LOCATION, "Couldn't find $end. Help.tbl or -hlp.tbm is invalid.\n");
 					}
+
+					continue;
 				}
-
-				help_overlaylist[overlay_id].plinecount++;
-				break;
-			case 1:	// +text
-				required_string("+text");
-				currcount = help_overlaylist[overlay_id].textcount;
-
-				// get coordinates for each resolution
-				for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
-					help_overlaylist[overlay_id].textlist.at(i).push_back(text_temp2);
-					stuff_int(&(help_overlaylist[overlay_id].textlist.at(i).at(currcount).x_coord));
-					stuff_int(&(help_overlaylist[overlay_id].textlist.at(i).at(currcount).y_coord));
+				else {
+					overlay_id = num_help_overlays;
+					strcpy_s(help_overlaylist[overlay_id].name, name);
+					num_help_overlays++;
 				}
-
-				// get string (always use the first resolution)
-				stuff_string(buf, F_MESSAGE, sizeof(buf));
-				help_overlaylist[overlay_id].textlist.at(0).at(currcount).string = vm_strdup(buf);
-
-				help_overlaylist[overlay_id].textcount++;
-				break;
-			case 2: // +right_bracket
-				required_string("+right_bracket");
-				currcount = help_overlaylist[overlay_id].rbracketcount;
-
-				// get coordinates for each resolution
-				for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
-					help_overlaylist[overlay_id].rbracketlist.at(i).push_back(rbracket_temp2);
-					stuff_int(&(help_overlaylist[overlay_id].rbracketlist.at(i).at(currcount).x_coord));
-					stuff_int(&(help_overlaylist[overlay_id].rbracketlist.at(i).at(currcount).y_coord));
-				}
-
-				help_overlaylist[overlay_id].rbracketcount++;
-				break;
-			case 3: // +left_bracket
-				required_string("+left_bracket");
-				currcount = help_overlaylist[overlay_id].lbracketcount;
-
-				// get coordinates for each resolution
-				for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
-					help_overlaylist[overlay_id].lbracketlist.at(i).push_back(lbracket_temp2);
-					stuff_int(&(help_overlaylist[overlay_id].lbracketlist.at(i).at(currcount).x_coord));
-					stuff_int(&(help_overlaylist[overlay_id].lbracketlist.at(i).at(currcount).y_coord));
-				}
-
-				help_overlaylist[overlay_id].lbracketcount++;
-				break;
-			case -1:
-				// -noparseerrors is set
-				break;
-			case 4: // $end
-			default:
-				Assertion(false, "This should never happen.\n");
-				break;
 			}
+
+			// clear out counters in the overlay struct
+			help_overlaylist[overlay_id].plinecount = 0;
+			help_overlaylist[overlay_id].textcount = 0;
+			help_overlaylist[overlay_id].rbracketcount = 0;
+			help_overlaylist[overlay_id].lbracketcount = 0;
+
+			help_overlaylist[overlay_id].fontlist.clear();
+			help_overlaylist[overlay_id].plinelist.clear();
+			help_overlaylist[overlay_id].textlist.clear();
+			help_overlaylist[overlay_id].rbracketlist.clear();
+			help_overlaylist[overlay_id].lbracketlist.clear();
+
+			if (optional_string("+resolutions")) {
+				stuff_int(&help_overlaylist[overlay_id].num_resolutions);
+			}
+			else {
+				help_overlaylist[overlay_id].num_resolutions = 2;
+			}
+
+			if (help_overlaylist[overlay_id].num_resolutions < 1) {
+				Error(LOCATION, "+resolutions in %s is %d. (Must be 1 or greater)", filename, help_overlaylist[overlay_id].num_resolutions);
+			}
+
+			if (optional_string("+font")) {
+				int font;
+				for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+					stuff_int(&font);
+					help_overlaylist[overlay_id].fontlist.push_back(font);
+				}
+			}
+			else {
+				for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+					help_overlaylist[overlay_id].fontlist.push_back(FONT1);
+				}
+			}
+
+			for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+				help_overlaylist[overlay_id].plinelist.push_back(pline_temp);
+				help_overlaylist[overlay_id].textlist.push_back(text_temp);
+				help_overlaylist[overlay_id].rbracketlist.push_back(rbracket_temp);
+				help_overlaylist[overlay_id].lbracketlist.push_back(lbracket_temp);
+			}
+
+			int type;
+			// read in all elements for this overlay
+			while ((type = required_string_one_of(5, "+pline", "+text", "+right_bracket", "+left_bracket", "$end")) != 4) {	// Doing it this way means an error lists "$end" at the end, which seems appropriate. -MageKing17
+
+				switch (type) {
+				case 0:	// +pline
+					required_string("+pline");
+					currcount = help_overlaylist[overlay_id].plinecount;
+					int a, b;		// temp vars to read in int before cast to float;
+
+					// read number of pline vertices
+					stuff_int(&vtxcount);
+					// get vertex coordinates for each resolution
+					for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+						help_overlaylist[overlay_id].plinelist.at(i).push_back(pline_temp2);
+						for (j = 0; j < vtxcount; j++) {
+							help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.push_back(vec3d_temp);
+							help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtxcount = vtxcount;
+							stuff_int(&a);
+							stuff_int(&b);
+							help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.at(j).xyz.x = (float)a;
+							help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.at(j).xyz.y = (float)b;
+							help_overlaylist[overlay_id].plinelist.at(i).at(currcount).vtx.at(j).xyz.z = 0.0f;
+						}
+					}
+
+					help_overlaylist[overlay_id].plinecount++;
+					break;
+				case 1:	// +text
+					required_string("+text");
+					currcount = help_overlaylist[overlay_id].textcount;
+
+					// get coordinates for each resolution
+					for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+						help_overlaylist[overlay_id].textlist.at(i).push_back(text_temp2);
+						stuff_int(&(help_overlaylist[overlay_id].textlist.at(i).at(currcount).x_coord));
+						stuff_int(&(help_overlaylist[overlay_id].textlist.at(i).at(currcount).y_coord));
+					}
+
+					// get string (always use the first resolution)
+					stuff_string(buf, F_MESSAGE, sizeof(buf));
+					help_overlaylist[overlay_id].textlist.at(0).at(currcount).string = vm_strdup(buf);
+
+					help_overlaylist[overlay_id].textcount++;
+					break;
+				case 2: // +right_bracket
+					required_string("+right_bracket");
+					currcount = help_overlaylist[overlay_id].rbracketcount;
+
+					// get coordinates for each resolution
+					for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+						help_overlaylist[overlay_id].rbracketlist.at(i).push_back(rbracket_temp2);
+						stuff_int(&(help_overlaylist[overlay_id].rbracketlist.at(i).at(currcount).x_coord));
+						stuff_int(&(help_overlaylist[overlay_id].rbracketlist.at(i).at(currcount).y_coord));
+					}
+
+					help_overlaylist[overlay_id].rbracketcount++;
+					break;
+				case 3: // +left_bracket
+					required_string("+left_bracket");
+					currcount = help_overlaylist[overlay_id].lbracketcount;
+
+					// get coordinates for each resolution
+					for (i = 0; i < help_overlaylist[overlay_id].num_resolutions; i++) {
+						help_overlaylist[overlay_id].lbracketlist.at(i).push_back(lbracket_temp2);
+						stuff_int(&(help_overlaylist[overlay_id].lbracketlist.at(i).at(currcount).x_coord));
+						stuff_int(&(help_overlaylist[overlay_id].lbracketlist.at(i).at(currcount).y_coord));
+					}
+
+					help_overlaylist[overlay_id].lbracketcount++;
+					break;
+				case -1:
+					// -noparseerrors is set
+					break;
+				case 4: // $end
+				default:
+					Assertion(false, "This should never happen.\n");
+					break;
+				}
+			}		// end while
+			required_string("$end");
 		}		// end while
-		required_string("$end");
-	}		// end while
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
+	}
 }
 
 

code/gamesnd/eventmusic.cpp

@@ -593,7 +593,7 @@ void event_music_level_init(int force_soundtrack)
 	{
 		if (!strnicmp(strack->pattern_fnames[i], NOX("none.wav"), 4))
 		{
-			Patterns[i].handle = -1;
+			Patterns[i].handle = -1;	
 			continue;
 		}
 
@@ -1373,14 +1373,10 @@ void parse_menumusic()
 //
 void event_music_parse_musictbl(const char *filename)
 {
-	int rval;
-
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-
-	} else {
+	try
+	{
 		read_file_text(filename, CF_TYPE_TABLES);
-		reset_parse();
+		reset_parse();		
 
 		while ( skip_to_start_of_string_either("#Soundtrack Start", "#Menu Music Start", NULL ) )
 		{
@@ -1398,6 +1394,10 @@ void event_music_parse_musictbl(const char *filename)
 			}
 		}
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+	}
 }
 
 // -------------------------------------------------------------------------------------------------

code/gamesnd/gamesnd.cpp

@@ -693,83 +693,83 @@ static SCP_vector<species_info> missingFlybySounds;
 
 void parse_sound_table(const char* filename)
 {
-	int	rval;
-
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
+
+		// Parse the gameplay sounds section
+		if (optional_string("#Game Sounds Start"))
+		{
+			while (!check_for_string("#Game Sounds End"))
+			{
+				game_snd tempSound;
+				if (gamesnd_parse_line(&tempSound, "$Name:", &Snds))
+				{
+					Snds.push_back(game_snd(tempSound));
+				}
+			}
+
+			required_string("#Game Sounds End");
+		}
+
+		// Parse the interface sounds section
+		if (optional_string("#Interface Sounds Start"))
+		{
+			while (!check_for_string("#Interface Sounds End"))
+			{
+				game_snd tempSound;
+				if (gamesnd_parse_line(&tempSound, "$Name:", &Snds_iface))
+				{
+					Snds_iface.push_back(game_snd(tempSound));
+					Snds_iface_handle.push_back(-1);
+				}
+			}
+
+			required_string("#Interface Sounds End");
+		}
+
+		// parse flyby sound section	
+		if (optional_string("#Flyby Sounds Start"))
+		{
+			char species_name_tag[NAME_LENGTH + 2];
+			int	sanity_check = 0;
+			size_t i;
+
+			while (!check_for_string("#Flyby Sounds End") && (sanity_check <= (int)Species_info.size()))
+			{
+				for (i = 0; i < Species_info.size(); i++)
+				{
+					species_info *species = &Species_info[i];
+
+					sprintf(species_name_tag, "$%s:", species->species_name);
+
+					if (check_for_string(species_name_tag))
+					{
+						gamesnd_parse_line(&species->snd_flyby_fighter, species_name_tag);
+						gamesnd_parse_line(&species->snd_flyby_bomber, species_name_tag);
+						sanity_check--;
+					}
+					else
+					{
+						sanity_check++;
+					}
+				}
+			}
+
+			required_string("#Flyby Sounds End");
+		}
+
+		if (optional_string("#Sound Environments Start"))
+		{
+			parse_sound_environments();
+		}
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	// Parse the gameplay sounds section
-	if (optional_string("#Game Sounds Start"))
-	{
-		while (!check_for_string("#Game Sounds End"))
-		{
-			game_snd tempSound;
-			if (gamesnd_parse_line(&tempSound, "$Name:", &Snds))
-			{
-				Snds.push_back(game_snd(tempSound));
-			}
-		}
-
-		required_string("#Game Sounds End");
-	}
-
-	// Parse the interface sounds section
-	if (optional_string("#Interface Sounds Start"))
-	{
-		while (!check_for_string("#Interface Sounds End"))
-		{
-			game_snd tempSound;
-			if (gamesnd_parse_line( &tempSound, "$Name:", &Snds_iface))
-			{
-				Snds_iface.push_back(game_snd(tempSound));
-				Snds_iface_handle.push_back(-1);
-			}
-		}
-
-		required_string("#Interface Sounds End");
-	}
-
-	// parse flyby sound section	
-	if (optional_string("#Flyby Sounds Start"))
-	{
-		char species_name_tag[NAME_LENGTH + 2];
-		int	sanity_check = 0;
-		size_t i;
-
-		while (!check_for_string("#Flyby Sounds End") && (sanity_check <= (int)Species_info.size()))
-		{
-			for (i = 0; i < Species_info.size(); i++)
-			{
-				species_info *species = &Species_info[i];
-
-				sprintf(species_name_tag, "$%s:", species->species_name);
-
-				if (check_for_string(species_name_tag))
-				{
-					gamesnd_parse_line(&species->snd_flyby_fighter, species_name_tag);
-					gamesnd_parse_line(&species->snd_flyby_bomber, species_name_tag);
-					sanity_check--;
-				}
-				else
-				{
-					sanity_check++;
-				}
-			}
-		}
-
-		required_string("#Flyby Sounds End");
-	}
-
-	if (optional_string("#Sound Environments Start"))
-	{
-		parse_sound_environments();
-	}
 }
 
 /**

code/globalincs/alphacolors.cpp

@@ -273,71 +273,74 @@ void parse_colors(const char *filename)
 {
 	Assertion(filename != NULL, "parse_colors() called on NULL; get a coder!\n");
 	read_file_text(filename, CF_TYPE_TABLES);
-
-	int err_code;
-	if ((err_code = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %d.\n", filename, err_code));
-		return;
-	}
-
-	reset_parse();
-
-	// we search for the colors based on their order of definition above
-	// if the color isn't found, we just use default values
-	if (optional_string("#Start Colors"))
+	
+	try
 	{
-		// vars for holding rgba values
-		int rgba[4] = {0,0,0,0};
-		int i, j;
+		reset_parse();
 
-		char* color_names[TOTAL_COLORS] = {
-			"$Blue:",
-			"$Bright Blue:",
-			"$Green:",
-			"$Bright Green:",
-			"$Black:",
-			"$Grey:",
-			"$Silver:",
-			"$White:",
-			"$Bright White:",
-			"$Violet Gray:",
-			"$Violet:",
-			"$Dim Red:",
-			"$Red:",
-			"$Bright Red:",
-			"$Pink:",
-			"$Light Pink:",
-			"$Yellow:",
-			"$Bright Yellow:",
-			"$UI Light Green:",
-			"$UI Green:",
-			"$UI Light Pink:",
-			"$UI Pink:"
-		};
+		// we search for the colors based on their order of definition above
+		// if the color isn't found, we just use default values
+		if (optional_string("#Start Colors"))
+		{
+			// vars for holding rgba values
+			int rgba[4] = { 0, 0, 0, 0 };
+			int i, j;
 
-		// now for each color, check if it's corresponding string is there
-		for (i = 0; i < TOTAL_COLORS; i++) {
-			if (optional_string(color_names[i])) {
-				// if so, get its rgba values and initialise it using them
-				mprintf(("'%s' has been redefined.\n", color_names[i]));
-				//if (check_for_string("(")) {
+			char* color_names[TOTAL_COLORS] = {
+				"$Blue:",
+				"$Bright Blue:",
+				"$Green:",
+				"$Bright Green:",
+				"$Black:",
+				"$Grey:",
+				"$Silver:",
+				"$White:",
+				"$Bright White:",
+				"$Violet Gray:",
+				"$Violet:",
+				"$Dim Red:",
+				"$Red:",
+				"$Bright Red:",
+				"$Pink:",
+				"$Light Pink:",
+				"$Yellow:",
+				"$Bright Yellow:",
+				"$UI Light Green:",
+				"$UI Green:",
+				"$UI Light Pink:",
+				"$UI Pink:"
+			};
+
+			// now for each color, check if it's corresponding string is there
+			for (i = 0; i < TOTAL_COLORS; i++) {
+				if (optional_string(color_names[i])) {
+					// if so, get its rgba values and initialise it using them
+					mprintf(("'%s' has been redefined.\n", color_names[i]));
+					//if (check_for_string("(")) {
 					stuff_int_list(rgba, 4, RAW_INTEGER_TYPE);
 					for (j = 0; j < 4; j++) {
 						if (rgba[j] < 0) {
 							Warning(LOCATION, "RGBA value for '%s' in %s too low (%d), capping to 0.\n", color_names[i], filename, rgba[j]);
 							rgba[j] = 0;
-						} else if (rgba[j] > 255) {
+						}
+						else if (rgba[j] > 255) {
 							Warning(LOCATION, "RGBA value for '%s' in %s too high (%d), capping to 255.\n", color_names[i], filename, rgba[j]);
 							rgba[j] = 255;
 						}
 					}
-				//} else {
-				//	stuff_hex_list(rgba, 4);
-				//}
-				gr_init_alphacolor(COLOR_LIST[i], rgba[0], rgba[1], rgba[2], rgba[3]);
+					//} else {
+					//	stuff_hex_list(rgba, 4);
+					//}
+					gr_init_alphacolor(COLOR_LIST[i], rgba[0], rgba[1], rgba[2], rgba[3]);
+				}
 			}
+			required_string("#End");
 		}
-		required_string("#End");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
 }
 
@@ -346,281 +349,290 @@ void parse_everything_else(const char *filename)
 	Assertion(filename != NULL, "parse_everything_else() called on NULL; get a coder!\n");
 	read_file_text(filename, CF_TYPE_TABLES);
 
-	int err_code;
-	if ((err_code = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %d.\n", filename, err_code));
-		return;
-	}
+	try
+	{
+		reset_parse();
 
-	reset_parse();
+		int rgba[4] = { 0, 0, 0, 0 };
 
-	int rgba[4] = {0,0,0,0};
+		// reusable temp vars
+		int i, j;
+		SCP_string temp;
 
-	// reusable temp vars
-	int i, j;
-	SCP_string temp;
-
-	if (optional_string("#Start Colors")) {
-		// Skip this section; we already parsed it in every file.
-		skip_to_string("#End", NULL);
-	}
-
-	//Team coloring
-	if (optional_string("#Team Colors")) {
-
-		while (required_string_either("#End", "$Team Name:")) {
-			required_string("$Team Name:"); // required to move the parse pointer forward
-			team_color temp_color;
-
-			char temp2[NAME_LENGTH];
-			stuff_string(temp2, F_NAME, NAME_LENGTH);
-			temp = temp2;
-
-			if (!stricmp(temp2, "none")) {
-				Warning(LOCATION, "Team color in '%s' defined with a name of '%s'; this won't be usable due to 'None' being used for a lack of a team color by the engine.\n", filename, temp2);
-			}
-
-			if (required_string("$Team Stripe Color:")) {
-				int rgb[3];
-				stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-				for (i = 0; i < 3; i++) {
-					CLAMP(rgb[i], 0, 255);
-				}
-				
-				temp_color.stripe.r = rgb[0] / 255.0f;
-				temp_color.stripe.g = rgb[1] / 255.0f;
-				temp_color.stripe.b = rgb[2] / 255.0f;
-			}
-
-			if (required_string("$Team Base Color:")) {
-				int rgb[3];
-				stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-				for (i = 0; i < 3; i++) {
-					CLAMP(rgb[i], 0, 255);
-				}
-
-				temp_color.base.r = rgb[0] / 255.0f;
-				temp_color.base.g = rgb[1] / 255.0f;
-				temp_color.base.b = rgb[2] / 255.0f;
-			}
-
-			if (Team_Colors.find(temp) == Team_Colors.end()) {	// Only push to the vector if the team isn't already defined.
-				Team_Names.push_back(temp);
-			}
-			Team_Colors[temp] = temp_color;
-		}
-		required_string("#End");
-	}
-
-	// Previously-hardcoded interface colors
-	if (optional_string("#Interface Colors")) {
-		char *color_names[INTERFACE_COLORS] = {
-			"$Text Normal:",
-			"$Text Subselected:",
-			"$Text Selected:",
-			"$Text Error:",
-			"$Text Error Highlighted:",
-			"$Text Active:",
-			"$Text Active Highlighted:",
-			"$Text Heading:",
-			"$More Indicator:",
-			"$Bright More Indicator:",
-			"$Bright:",
-			"$Normal:",
-			"$Briefing Grid:",
-		};
-
-		// now for each color, check if its corresponding string is there
-		for (i = 0; i < INTERFACE_COLORS; i++) {
-			if (optional_string(color_names[i])) {
-				// if so, get its rgba values and initialise it using them
-				mprintf(("'%s' has been redefined.\n", color_names[i]));
-				if ( check_for_string("(") ) {
-					// If we have a list of integers, use them.
-					stuff_int_list(rgba, 4, RAW_INTEGER_TYPE);
-					for (j = 0; j < 4; j++) {
-						if (rgba[j] < 0)
-						{
-							Warning(LOCATION, "RGBA value for '%s' in %s too low (%d), capping to 0.\n", color_names[i], filename, rgba[j]);
-							rgba[j] = 0;
-						}
-						else if (rgba[j] > 255)
-						{
-							Warning(LOCATION, "RGBA value for '%s' in %s too high (%d), capping to 255.\n", color_names[i], filename, rgba[j]);
-							rgba[j] = 255;
-						}
-					}
-					gr_init_alphacolor(interface_colors[i], rgba[0], rgba[1], rgba[2], rgba[3]);
-				//} else if (check_for_string("#")) {
-				//	stuff_hex_list(rgba, 4);
-				//	gr_init_alphacolor(interface_colors[i], rgba[0], rgba[1], rgba[2], rgba[3]);
-				} else {
-					// We have a string; it should be the name of a color to use.
-					stuff_string(temp, F_NAME);
-					for (j = 0; j < TOTAL_COLORS; j++) {
-						if ( !temp.compare(COLOR_NAMES[j]) ) {
-							break;
-						}
-					}
-					if ( j == TOTAL_COLORS ) {
-						Warning(LOCATION, "Unknown color '%s' in %s, for definition of '%s'; using default ('%s').\n", temp.c_str(), filename, color_names[i], COLOR_NAMES[interface_defaults[i]]);
-					} else {
-						Assertion(j >= 0 && j < TOTAL_COLORS, "Attempting to copy nonexistant color (%d out of 0-%d)!\n", j, TOTAL_COLORS-1);
-						memcpy(interface_colors[i], COLOR_LIST[j], sizeof(color));
-					}
-				}
-			}
-		}
-		required_string("#End");
-	}
-
-	// Text color tags; for briefings, command briefings, debriefings, and the fiction viewer
-	if (optional_string("#Color Tags")) {
-		while (required_string_either("$Tag:", "#End") < 1) {
-			required_string("$Tag:");
-			color temp_color;
-			char tag;
-
-			stuff_string(temp, F_RAW);
-			if (temp[0] == '$') {
-				if (temp[1] == '\0') {
-					Error(LOCATION, "%s - found a '$Tag:' entry with a solitary '$'.\n", filename);
-				}
-				tag = temp[1];
-				if (temp[2] != '\0') {
-					Warning(LOCATION, "%s - tag '$%c' has extra text in its definition.\n", filename, tag);
-				}
-			} else if (temp[0] == '\0') {
-				Error(LOCATION, "%s - found a '$Tag:' entry with no tag.\n", filename);
-			} else {
-				tag = temp[0];
-				if (temp[1] != '\0') {
-					Warning(LOCATION, "%s - tag '$%c' has extra text in its definition.\n", filename, tag);
-				}
-			}
-
-			if (Tagged_Colors.find(tag) == Tagged_Colors.end()) {	// Only push the tag to our list of tags if it's actually new, not just a redefinition.
-				Color_Tags.push_back(tag);
-			}
-
-			switch(required_string_one_of(4, "+Color:", "+Friendly", "+Hostile", "+Neutral")) {
-			case 0:	// +Color
-				required_string("+Color:");
-
-				rgba[0] = rgba[1] = rgba[2] = 0;
-				rgba[3] = 255;	// Odds are pretty high you want it to have full alpha...
-
-				if ( check_for_string("(") ) {
-					stuff_int_list(rgba, 4, RAW_INTEGER_TYPE);
-					for (j = 0; j < 4; j++) {
-						if (rgba[j] < 0)
-						{
-							Warning(LOCATION, "RGBA value for '$%c' in %s too low (%d), capping to 0.\n", tag, filename, rgba[j]);
-							rgba[j] = 0;
-						}
-						else if (rgba[j] > 255)
-						{
-							Warning(LOCATION, "RGBA value for '$%c' in %s too high (%d), capping to 255.\n", tag, filename, rgba[j]);
-							rgba[j] = 255;
-						}
-					}
-					gr_init_alphacolor(&temp_color, rgba[0], rgba[1], rgba[2], rgba[3]);
-					Custom_Colors[tag] = temp_color;
-					Tagged_Colors[tag] = &Custom_Colors[tag];
-				//} else if ( check_for_string ("#") ) {
-				//	stuff_hex_list(rgba, 4);
-				//	gr_init_alphacolor(&temp_color, rgba[0], rgba[1], rgba[2], rgba[3]);
-				//	Custom_Colors[tag] = temp_color;
-				//	Tagged_Colors[tag] = &Custom_Colors[tag];
-				} else {
-					// We have a string; it should be the name of a color to use.
-					stuff_string(temp, F_NAME);
-					for (j = 0; j < TOTAL_COLORS; j++) {
-						if ( !temp.compare(COLOR_NAMES[j]) ) {
-							break;
-						}
-					}
-					if ( j == TOTAL_COLORS ) {
-						Error(LOCATION, "Unknown color '%s' in %s, for definition of tag '$%c'.\n", temp.c_str(), filename, tag);
-					}
-					Tagged_Colors[tag] = COLOR_LIST[j];
-				}
-				break;
-			case 1:	// +Friendly
-				required_string("+Friendly");
-				Tagged_Colors[tag] = &Brief_color_green;
-				break;
-			case 2:	// +Hostile
-				required_string("+Hostile");
-				Tagged_Colors[tag] = &Brief_color_red;
-				break;
-			case 3:	// +Neutral
-				required_string("+Neutral");
-				Tagged_Colors[tag] = &Brief_color_legacy_neutral;
-				break;
-			case -1:
-				// -noparseerrors is set
-				if (Tagged_Colors.find(tag) == Tagged_Colors.end()) {	// It was a new color, but since we haven't actually defined it...
-					Color_Tags.pop_back();
-				}
-				break;
-			default:
-				Assertion(false, "MageKing17 made a coding error somewhere, and you should laugh at him (and report this error).\n");
-				break;
-			}
+		if (optional_string("#Start Colors")) {
+			// Skip this section; we already parsed it in every file.
+			skip_to_string("#End", NULL);
 		}
 
-		required_string("#End");
-	}
-	Assertion(Color_Tags.size() == Tagged_Colors.size(), "Color_Tags and Tagged_Colors size mismatch; get a coder!\n");
+		//Team coloring
+		if (optional_string("#Team Colors")) {
 
-	if (optional_string("#Default Text Colors")) {
+			while (required_string_either("#End", "$Team Name:")) {
+				required_string("$Team Name:"); // required to move the parse pointer forward
+				team_color temp_color;
 
-		char* color_names[MAX_DEFAULT_TEXT_COLORS] = {
-			"$Fiction Viewer:",
-			"$Command Briefing:",
-			"$Briefing:",
-			"$Redalert Briefing:",
-			"$Debriefing:",
-			"$Recommendation:",
-			"$Loop Briefing:",
-		};
+				char temp2[NAME_LENGTH];
+				stuff_string(temp2, F_NAME, NAME_LENGTH);
+				temp = temp2;
 
-		char *color_value[MAX_DEFAULT_TEXT_COLORS] = {
-			&default_fiction_viewer_color,
-			&default_command_briefing_color,
-			&default_briefing_color,
-			&default_redalert_briefing_color,
-			&default_debriefing_color,
-			&default_recommendation_color,
-			&default_loop_briefing_color,
-		};
+				if (!stricmp(temp2, "none")) {
+					Warning(LOCATION, "Team color in '%s' defined with a name of '%s'; this won't be usable due to 'None' being used for a lack of a team color by the engine.\n", filename, temp2);
+				}
+
+				if (required_string("$Team Stripe Color:")) {
+					int rgb[3];
+					stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+					for (i = 0; i < 3; i++) {
+						CLAMP(rgb[i], 0, 255);
+					}
+
+					temp_color.stripe.r = rgb[0] / 255.0f;
+					temp_color.stripe.g = rgb[1] / 255.0f;
+					temp_color.stripe.b = rgb[2] / 255.0f;
+				}
+
+				if (required_string("$Team Base Color:")) {
+					int rgb[3];
+					stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+					for (i = 0; i < 3; i++) {
+						CLAMP(rgb[i], 0, 255);
+					}
+
+					temp_color.base.r = rgb[0] / 255.0f;
+					temp_color.base.g = rgb[1] / 255.0f;
+					temp_color.base.b = rgb[2] / 255.0f;
+				}
+
+				if (Team_Colors.find(temp) == Team_Colors.end()) {	// Only push to the vector if the team isn't already defined.
+					Team_Names.push_back(temp);
+				}
+				Team_Colors[temp] = temp_color;
+			}
+			required_string("#End");
+		}
+
+		// Previously-hardcoded interface colors
+		if (optional_string("#Interface Colors")) {
+			char *color_names[INTERFACE_COLORS] = {
+				"$Text Normal:",
+				"$Text Subselected:",
+				"$Text Selected:",
+				"$Text Error:",
+				"$Text Error Highlighted:",
+				"$Text Active:",
+				"$Text Active Highlighted:",
+				"$Text Heading:",
+				"$More Indicator:",
+				"$Bright More Indicator:",
+				"$Bright:",
+				"$Normal:",
+				"$Briefing Grid:",
+			};
+
+			// now for each color, check if its corresponding string is there
+			for (i = 0; i < INTERFACE_COLORS; i++) {
+				if (optional_string(color_names[i])) {
+					// if so, get its rgba values and initialise it using them
+					mprintf(("'%s' has been redefined.\n", color_names[i]));
+					if (check_for_string("(")) {
+						// If we have a list of integers, use them.
+						stuff_int_list(rgba, 4, RAW_INTEGER_TYPE);
+						for (j = 0; j < 4; j++) {
+							if (rgba[j] < 0)
+							{
+								Warning(LOCATION, "RGBA value for '%s' in %s too low (%d), capping to 0.\n", color_names[i], filename, rgba[j]);
+								rgba[j] = 0;
+							}
+							else if (rgba[j] > 255)
+							{
+								Warning(LOCATION, "RGBA value for '%s' in %s too high (%d), capping to 255.\n", color_names[i], filename, rgba[j]);
+								rgba[j] = 255;
+							}
+						}
+						gr_init_alphacolor(interface_colors[i], rgba[0], rgba[1], rgba[2], rgba[3]);
+						//} else if (check_for_string("#")) {
+						//	stuff_hex_list(rgba, 4);
+						//	gr_init_alphacolor(interface_colors[i], rgba[0], rgba[1], rgba[2], rgba[3]);
+					}
+					else {
+						// We have a string; it should be the name of a color to use.
+						stuff_string(temp, F_NAME);
+						for (j = 0; j < TOTAL_COLORS; j++) {
+							if (!temp.compare(COLOR_NAMES[j])) {
+								break;
+							}
+						}
+						if (j == TOTAL_COLORS) {
+							Warning(LOCATION, "Unknown color '%s' in %s, for definition of '%s'; using default ('%s').\n", temp.c_str(), filename, color_names[i], COLOR_NAMES[interface_defaults[i]]);
+						}
+						else {
+							Assertion(j >= 0 && j < TOTAL_COLORS, "Attempting to copy nonexistant color (%d out of 0-%d)!\n", j, TOTAL_COLORS - 1);
+							memcpy(interface_colors[i], COLOR_LIST[j], sizeof(color));
+						}
+					}
+				}
+			}
+			required_string("#End");
+		}
+
+		// Text color tags; for briefings, command briefings, debriefings, and the fiction viewer
+		if (optional_string("#Color Tags")) {
+			while (required_string_either("$Tag:", "#End") < 1) {
+				required_string("$Tag:");
+				color temp_color;
+				char tag;
 
-		for (i = 0; i < MAX_DEFAULT_TEXT_COLORS; i++) {
-			if ( optional_string(color_names[i]) ) {
 				stuff_string(temp, F_RAW);
 				if (temp[0] == '$') {
 					if (temp[1] == '\0') {
-						Error(LOCATION, "%s - default text color '%s' entry with a solitary '$'.\n", filename, color_names[i]);
+						Error(LOCATION, "%s - found a '$Tag:' entry with a solitary '$'.\n", filename);
 					}
-					*color_value[i] = temp[1];
+					tag = temp[1];
 					if (temp[2] != '\0') {
-						Warning(LOCATION, "%s - default text color '%s' has extra text after the tag '$%c'.\n", filename, color_names[i], *color_value[i]);
-					}
-				} else if (temp[0] == '\0') {
-					Error(LOCATION, "%s - default text color '%s' entry with no tag.\n", filename, color_names[i]);
-				} else {
-					*color_value[i] = temp[0];
-					if (temp[1] != '\0') {
-						Warning(LOCATION, "%s - default text color '%s' has extra text after the tag '$%c'.\n", filename, color_names[i], *color_value[i]);
+						Warning(LOCATION, "%s - tag '$%c' has extra text in its definition.\n", filename, tag);
 					}
 				}
-				if (Tagged_Colors.find(*color_value[i]) == Tagged_Colors.end()) {
-					// Just mprintf() this information instead of complaining with a Warning(); the tag might be defined in a later-loading TBM, and if it isn't, nothing too terrible will happen.
-					mprintf(("%s - default text color '%s' set to non-existant tag '$%c'.\n", filename, color_names[i], *color_value[i]));
+				else if (temp[0] == '\0') {
+					Error(LOCATION, "%s - found a '$Tag:' entry with no tag.\n", filename);
+				}
+				else {
+					tag = temp[0];
+					if (temp[1] != '\0') {
+						Warning(LOCATION, "%s - tag '$%c' has extra text in its definition.\n", filename, tag);
+					}
+				}
+
+				if (Tagged_Colors.find(tag) == Tagged_Colors.end()) {	// Only push the tag to our list of tags if it's actually new, not just a redefinition.
+					Color_Tags.push_back(tag);
+				}
+
+				switch (required_string_one_of(4, "+Color:", "+Friendly", "+Hostile", "+Neutral")) {
+				case 0:	// +Color
+					required_string("+Color:");
+
+					rgba[0] = rgba[1] = rgba[2] = 0;
+					rgba[3] = 255;	// Odds are pretty high you want it to have full alpha...
+
+					if (check_for_string("(")) {
+						stuff_int_list(rgba, 4, RAW_INTEGER_TYPE);
+						for (j = 0; j < 4; j++) {
+							if (rgba[j] < 0)
+							{
+								Warning(LOCATION, "RGBA value for '$%c' in %s too low (%d), capping to 0.\n", tag, filename, rgba[j]);
+								rgba[j] = 0;
+							}
+							else if (rgba[j] > 255)
+							{
+								Warning(LOCATION, "RGBA value for '$%c' in %s too high (%d), capping to 255.\n", tag, filename, rgba[j]);
+								rgba[j] = 255;
+							}
+						}
+						gr_init_alphacolor(&temp_color, rgba[0], rgba[1], rgba[2], rgba[3]);
+						Custom_Colors[tag] = temp_color;
+						Tagged_Colors[tag] = &Custom_Colors[tag];
+						//} else if ( check_for_string ("#") ) {
+						//	stuff_hex_list(rgba, 4);
+						//	gr_init_alphacolor(&temp_color, rgba[0], rgba[1], rgba[2], rgba[3]);
+						//	Custom_Colors[tag] = temp_color;
+						//	Tagged_Colors[tag] = &Custom_Colors[tag];
+					}
+					else {
+						// We have a string; it should be the name of a color to use.
+						stuff_string(temp, F_NAME);
+						for (j = 0; j < TOTAL_COLORS; j++) {
+							if (!temp.compare(COLOR_NAMES[j])) {
+								break;
+							}
+						}
+						if (j == TOTAL_COLORS) {
+							Error(LOCATION, "Unknown color '%s' in %s, for definition of tag '$%c'.\n", temp.c_str(), filename, tag);
+						}
+						Tagged_Colors[tag] = COLOR_LIST[j];
+					}
+					break;
+				case 1:	// +Friendly
+					required_string("+Friendly");
+					Tagged_Colors[tag] = &Brief_color_green;
+					break;
+				case 2:	// +Hostile
+					required_string("+Hostile");
+					Tagged_Colors[tag] = &Brief_color_red;
+					break;
+				case 3:	// +Neutral
+					required_string("+Neutral");
+					Tagged_Colors[tag] = &Brief_color_legacy_neutral;
+					break;
+				case -1:
+					// -noparseerrors is set
+					if (Tagged_Colors.find(tag) == Tagged_Colors.end()) {	// It was a new color, but since we haven't actually defined it...
+						Color_Tags.pop_back();
+					}
+					break;
+				default:
+					Assertion(false, "MageKing17 made a coding error somewhere, and you should laugh at him (and report this error).\n");
+					break;
 				}
 			}
+
+			required_string("#End");
 		}
-		required_string("#End");
+		Assertion(Color_Tags.size() == Tagged_Colors.size(), "Color_Tags and Tagged_Colors size mismatch; get a coder!\n");
+
+		if (optional_string("#Default Text Colors")) {
+
+			char* color_names[MAX_DEFAULT_TEXT_COLORS] = {
+				"$Fiction Viewer:",
+				"$Command Briefing:",
+				"$Briefing:",
+				"$Redalert Briefing:",
+				"$Debriefing:",
+				"$Recommendation:",
+				"$Loop Briefing:",
+			};
+
+			char *color_value[MAX_DEFAULT_TEXT_COLORS] = {
+				&default_fiction_viewer_color,
+				&default_command_briefing_color,
+				&default_briefing_color,
+				&default_redalert_briefing_color,
+				&default_debriefing_color,
+				&default_recommendation_color,
+				&default_loop_briefing_color,
+			};
+
+			for (i = 0; i < MAX_DEFAULT_TEXT_COLORS; i++) {
+				if (optional_string(color_names[i])) {
+					stuff_string(temp, F_RAW);
+					if (temp[0] == '$') {
+						if (temp[1] == '\0') {
+							Error(LOCATION, "%s - default text color '%s' entry with a solitary '$'.\n", filename, color_names[i]);
+						}
+						*color_value[i] = temp[1];
+						if (temp[2] != '\0') {
+							Warning(LOCATION, "%s - default text color '%s' has extra text after the tag '$%c'.\n", filename, color_names[i], *color_value[i]);
+						}
+					}
+					else if (temp[0] == '\0') {
+						Error(LOCATION, "%s - default text color '%s' entry with no tag.\n", filename, color_names[i]);
+					}
+					else {
+						*color_value[i] = temp[0];
+						if (temp[1] != '\0') {
+							Warning(LOCATION, "%s - default text color '%s' has extra text after the tag '$%c'.\n", filename, color_names[i], *color_value[i]);
+						}
+					}
+					if (Tagged_Colors.find(*color_value[i]) == Tagged_Colors.end()) {
+						// Just mprintf() this information instead of complaining with a Warning(); the tag might be defined in a later-loading TBM, and if it isn't, nothing too terrible will happen.
+						mprintf(("%s - default text color '%s' set to non-existant tag '$%c'.\n", filename, color_names[i], *color_value[i]));
+					}
+				}
+			}
+			required_string("#End");
+		}
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
 }

code/globalincs/fsmemory.cpp

@@ -3,7 +3,11 @@
 
 
 // throw
+#ifdef HAVE_CXX11
+void * operator new (size_t size)
+#else
 void * operator new (size_t size) throw (std::bad_alloc)
+#endif // CPP11_STD
 {
 	void *p = vm_malloc_q(size);
 
@@ -19,7 +23,11 @@ void operator delete (void *p) throw()
 	vm_free(p);
 }
 
+#ifdef HAVE_CXX11
+void * operator new [] (size_t size)
+#else
 void * operator new [] (size_t size) throw (std::bad_alloc)
+#endif // CPP11_STD
 {
 	void *p = vm_malloc_q(size);
 

code/globalincs/fsmemory.h

@@ -4,6 +4,25 @@
 
 #include <new>
 
+#ifdef HAVE_CXX11
+// throw
+extern void * operator new (size_t size);
+
+extern void operator delete (void *p) throw();
+
+extern void * operator new [] (size_t size);
+
+extern void operator delete [] (void *p) throw();
+
+// no-throw
+extern void * operator new (size_t size, const std::nothrow_t&) throw();
+
+extern void operator delete (void *p, const std::nothrow_t&) throw();
+
+extern void * operator new [] (size_t size, const std::nothrow_t&) throw();
+
+extern void operator delete [] (void *p, const std::nothrow_t&) throw();
+#else
 // throw
 extern void * operator new (size_t size) throw (std::bad_alloc);
 
@@ -21,5 +40,6 @@ extern void operator delete (void *p, const std::nothrow_t&) throw();
 extern void * operator new [] (size_t size, const std::nothrow_t&) throw();
 
 extern void operator delete [] (void *p, const std::nothrow_t&) throw();
+#endif
 
 #endif	// _FSMEMORY_H

code/globalincs/pstypes.h

@@ -22,6 +22,7 @@
 #define IAM_64BIT 1
 #endif
 
+
 #include "windows_stub/config.h"
 
 // value to represent an uninitialized state in any int or uint
@@ -680,5 +681,113 @@ public:
 #include "globalincs/vmallocator.h"
 #include "globalincs/safe_strings.h"
 
+// c++11 standard detection
+// for GCC with autotools, see AX_CXX_COMPILE_STDCXX_11 macro in configure.ac
+// this sets HAVE_CXX11 & -std=c++0x or -std=c++11 appropriately
+
+// Use the visual studio version to detect C++11 support
+#if _MSC_VER >= 1600
+#	define HAVE_CXX11
+#endif
+// clang doesn't seem to have a feature check for is_trivial
+// oh well, assume it'll be covered by one of the other two checks...
+// http://clang.llvm.org/docs/LanguageExtensions.html#feature_check
+#if defined(__clang__)
+	#if __has_feature(cxx_static_assert)
+		#if __has_feature(cxx_auto_type)
+			#define HAVE_CXX11
+		#endif // __has_feature(cxx_auto_type)
+	#endif // __has_feature(cxx_static_assert)
+#endif // defined(__clang__)
+// TODO: sort out cmake/gcc
+
+// DEBUG compile time catch for dangerous uses of memset/memcpy/memmove
+// would prefer std::is_trivially_copyable but it's not supported by gcc yet
+// ref: http://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html
+#ifndef NDEBUG
+	#if defined(HAVE_CXX11)
+	// feature support seems to be: gcc   clang   msvc
+	// auto                         4.4   2.9     2010
+	// std::is_trivial              4.5   ?       2012 (2010 only duplicates std::is_pod)
+	// static_assert                4.3   2.9     2010
+	#include <type_traits>
+	#include <cstring>
+
+	// MEMSET!
+	const auto ptr_memset = std::memset;
+	#define memset memset_if_trivial_else_error
+
+	template<typename T>
+	void *memset_if_trivial_else_error(T *memset_data, int ch, size_t count)
+	{
+		static_assert(std::is_trivial<T>::value, "memset on non-trivial object");
+		return ptr_memset(memset_data, ch, count);
+	}
+
+	// assume memset on a void* is "safe"
+	// only used in cutscene/mveplayer.cpp:mve_video_createbuf()
+	inline void *memset_if_trivial_else_error(void *memset_data, int ch, size_t count)
+	{
+		return ptr_memset(memset_data, ch, count);
+	}
+
+	// MEMCPY!
+	const auto ptr_memcpy = std::memcpy;
+	#define memcpy memcpy_if_trivial_else_error
+
+	template<typename T, typename U>
+	void *memcpy_if_trivial_else_error(T *memcpy_dest, U *src, size_t count)
+	{
+		static_assert(std::is_trivial<T>::value, "memcpy on non-trivial object T");
+		static_assert(std::is_trivial<U>::value, "memcpy on non-trivial object U");
+		return ptr_memcpy(memcpy_dest, src, count);
+	}
+
+	// assume memcpy with void* is "safe"
+	// used in:
+	//   globalincs/systemvars.cpp:insertion_sort()
+	//   network/chat_api.cpp:AddChatCommandToQueue()
+	//   network/multi_obj.cpp:multi_oo_sort_func()
+	//   parse/lua.cpp:ade_get_args() && ade_set_args()
+	//
+	// probably should setup a static_assert on insertion_sort as well
+	template<typename U>
+	void *memcpy_if_trivial_else_error(void *memcpy_dest, U *memcpy_src, size_t count)
+	{
+		static_assert(std::is_trivial<U>::value, "memcpy on non-trivial object U");
+		return ptr_memcpy(memcpy_dest, memcpy_src, count);
+	}
+
+	template<typename T>
+	void *memcpy_if_trivial_else_error(T *memcpy_dest, void *memcpy_src, size_t count)
+	{
+		static_assert(std::is_trivial<T>::value, "memcpy on non-trivial object T");
+		return ptr_memcpy(memcpy_dest, memcpy_src, count);
+	}
+	template<typename T>
+	void *memcpy_if_trivial_else_error(T *memcpy_dest, const void *memcpy_src, size_t count)
+	{
+		static_assert(std::is_trivial<T>::value, "memcpy on non-trivial object T");
+		return ptr_memcpy(memcpy_dest, memcpy_src, count);
+	}
+
+	inline void *memcpy_if_trivial_else_error(void *memcpy_dest, void *memcpy_src, size_t count)
+	{
+		return ptr_memcpy(memcpy_dest, memcpy_src, count);
+	}
+
+	// MEMMOVE!
+	const auto ptr_memmove = std::memmove;
+	#define memmove memmove_if_trivial_else_error
+
+	template<typename T, typename U>
+	void *memmove_if_trivial_else_error(T *memmove_dest, U *memmove_src, size_t count)
+	{
+		static_assert(std::is_trivial<T>::value, "memmove on non-trivial object T");
+		static_assert(std::is_trivial<U>::value, "memmove on non-trivial object U");
+		return ptr_memmove(memmove_dest, memmove_src, count);
+	}
+	#endif // HAVE_CXX11
+#endif // NDEBUG
 
 #endif		// PS_TYPES_H

code/graphics/font.cpp

@@ -579,7 +579,7 @@ void gr_set_font(int fontnum)
 
 void parse_fonts_tbl(char *only_parse_first_font, size_t only_parse_first_font_size)
 {
-	int rval, i;
+	int i;
 	char *filename;
 	
 	// choose file name
@@ -591,99 +591,104 @@ void parse_fonts_tbl(char *only_parse_first_font, size_t only_parse_first_font_s
 		filename = NULL;
 	}
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", (filename) ? filename : NOX("<default fonts.tbl>"), rval));
+	try
+	{
+		if (filename != NULL) {
+			read_file_text(filename, CF_TYPE_TABLES);
+		}
+		else {
+			read_file_text_from_array(defaults_get_file("fonts.tbl"));
+		}
+
+		reset_parse();
+
+		// start parsing
+		required_string("#Fonts");
+
+		// read fonts
+		while (required_string_either("#End", "$Font:")) {
+			char font_filename[MAX_FILENAME_LEN];
+
+			// grab font
+			required_string("$Font:");
+			stuff_string(font_filename, F_NAME, MAX_FILENAME_LEN);
+
+			// if we only need the first font, copy it and bail
+			if (only_parse_first_font != NULL) {
+				strcpy_s(only_parse_first_font, only_parse_first_font_size, font_filename);
+				return;
+			}
+
+			// create font
+			int font_id = gr_create_font(font_filename);
+			if (font_id < 0) {
+				Warning(LOCATION, "Could not create font from typeface '%s'!", font_filename);
+				skip_to_start_of_string_either("#End", "$Font:");
+			}
+			else {
+				// max allowed special char index; i.e. 7 special chars in retail fonts 1 & 3
+				static const int MAX_SPECIAL_CHAR_IDX = UCHAR_MAX - 6;
+
+				// 'default' special char index for all languages using this font
+				int default_special_char_index = 0;
+				if (optional_string("+Default Special Character Index:")) {
+					stuff_int(&default_special_char_index);
+
+					if (default_special_char_index < 0 || default_special_char_index >= MAX_SPECIAL_CHAR_IDX) {
+						Error(LOCATION, "Default special character index (%d) for font (%s), must be 0 - %u", default_special_char_index, font_filename, MAX_SPECIAL_CHAR_IDX);
+					}
+
+					for (i = 0; i < (int)Lcl_languages.size(); ++i) {
+						Lcl_languages[i].special_char_indexes[font_id] = (ubyte)default_special_char_index;
+					}
+				}
+
+				while (optional_string("+Language:")) {
+					char lang_name[LCL_LANG_NAME_LEN + 1];
+					int special_char_index, lang_idx = -1;
+
+					stuff_string(lang_name, F_NAME, LCL_LANG_NAME_LEN + 1);
+
+					// find language and set the index, or if not found move to the next one
+					for (i = 0; i < (int)Lcl_languages.size(); ++i) {
+						if (!strcmp(Lcl_languages[i].lang_name, lang_name)) {
+							lang_idx = i;
+							break;
+						}
+					}
+
+					if (lang_idx == -1) {
+						Warning(LOCATION, "Ignoring invalid language (%s) specified by font (%s); not built-in or in strings.tbl", lang_name, font_filename);
+						skip_to_start_of_string_either("+Language:", "$Font:", "#End");
+						continue;
+					}
+
+					if (optional_string("+Special Character Index:")) {
+						stuff_int(&special_char_index);
+
+						if (special_char_index < 0 || special_char_index >= MAX_SPECIAL_CHAR_IDX) {
+							Error(LOCATION, "Special character index (%d) for font (%s), language (%s) is invalid, must be 0 - %u", special_char_index, font_filename, lang_name, MAX_SPECIAL_CHAR_IDX);
+						}
+
+						Lcl_languages[lang_idx].special_char_indexes[font_id] = (ubyte)special_char_index;
+					}
+				}
+			}
+		}
+
+		// done parsing
+		required_string("#End");
+
+		// double check
+		if (Num_fonts < 3) {
+			Error(LOCATION, "There must be at least three fonts in %s!", (filename) ? filename : NOX("<default fonts.tbl>"));
+		}
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", (filename) ? filename : NOX("<default fonts.tbl>"), e.what()));
 		return;
 	}
-
-	if (filename != NULL) {
-		read_file_text(filename, CF_TYPE_TABLES);
-	} else {
-		read_file_text_from_array(defaults_get_file("fonts.tbl"));
-	}
-
-	reset_parse();		
-
-	// start parsing
-	required_string("#Fonts");
-
-	// read fonts
-	while (required_string_either("#End","$Font:")) {
-		char font_filename[MAX_FILENAME_LEN];
-
-		// grab font
-		required_string("$Font:");
-		stuff_string(font_filename, F_NAME, MAX_FILENAME_LEN);
-
-		// if we only need the first font, copy it and bail
-		if (only_parse_first_font != NULL) {
-			strcpy_s(only_parse_first_font, only_parse_first_font_size, font_filename);
-			return;
-		}
-
-		// create font
-		int font_id = gr_create_font(font_filename);
-		if (font_id < 0) {
-			Warning(LOCATION, "Could not create font from typeface '%s'!", font_filename);
-			skip_to_start_of_string_either("#End","$Font:");
-		} else {
-			// max allowed special char index; i.e. 7 special chars in retail fonts 1 & 3
-			static const int MAX_SPECIAL_CHAR_IDX = UCHAR_MAX-6;
-
-			// 'default' special char index for all languages using this font
-			int default_special_char_index = 0;
-			if (optional_string("+Default Special Character Index:")) {
-				stuff_int(&default_special_char_index);
-
-				if (default_special_char_index < 0 || default_special_char_index >= MAX_SPECIAL_CHAR_IDX) {
-					Error(LOCATION, "Default special character index (%d) for font (%s), must be 0 - %u", default_special_char_index, font_filename, MAX_SPECIAL_CHAR_IDX);
-				}
-
-				for (i = 0; i < (int)Lcl_languages.size(); ++i) {
-					Lcl_languages[i].special_char_indexes[font_id] = (ubyte)default_special_char_index;
-				}
-			}
-
-			while (optional_string("+Language:")) {
-				char lang_name[LCL_LANG_NAME_LEN + 1];
-				int special_char_index, lang_idx = -1;
-
-				stuff_string(lang_name, F_NAME, LCL_LANG_NAME_LEN + 1);
-
-				// find language and set the index, or if not found move to the next one
-				for (i = 0; i < (int)Lcl_languages.size(); ++i) {
-					if (!strcmp(Lcl_languages[i].lang_name, lang_name)) {
-						lang_idx = i;
-						break;
-					}
-				}
-
-				if (lang_idx == -1) {
-					Warning(LOCATION, "Ignoring invalid language (%s) specified by font (%s); not built-in or in strings.tbl", lang_name, font_filename );
-					skip_to_start_of_string_either("+Language:","$Font:","#End");
-					continue;
-				}
-
-				if (optional_string("+Special Character Index:")) {
-					stuff_int(&special_char_index);
-
-					if (special_char_index < 0 || special_char_index >= MAX_SPECIAL_CHAR_IDX) {
-						Error(LOCATION, "Special character index (%d) for font (%s), language (%s) is invalid, must be 0 - %u", special_char_index, font_filename, lang_name, MAX_SPECIAL_CHAR_IDX);
-					}
-
-					Lcl_languages[lang_idx].special_char_indexes[font_id] = (ubyte)special_char_index;
-				}
-			}
-		}
-	}
-
-	// done parsing
-	required_string("#End");
-
-	// double check
-	if (Num_fonts < 3) {
-		Error(LOCATION, "There must be at least three fonts in %s!", (filename) ? filename : NOX("<default fonts.tbl>"));
-	}
 }
 
 void gr_stuff_first_font(char *first_font, size_t first_font_size )

code/graphics/gropenglpostprocessing.cpp

@@ -687,115 +687,118 @@ void gr_opengl_post_process_save_zbuffer()
 
 static bool opengl_post_init_table()
 {
-	int rval;
 	bool warned = false;
 
-	if ( (rval = setjmp(parse_abort)) != 0 ) {
-		mprintf(("Unable to parse 'post_processing.tbl'!  Error code = %d.\n", rval));
-		return false;
-	}
+	try
+	{
+		if (cf_exists_full("post_processing.tbl", CF_TYPE_TABLES))
+			read_file_text("post_processing.tbl", CF_TYPE_TABLES);
+		else
+			read_file_text_from_array(defaults_get_file("post_processing.tbl"));
 
-	if (cf_exists_full("post_processing.tbl", CF_TYPE_TABLES))
-		read_file_text("post_processing.tbl", CF_TYPE_TABLES);
-	else
-		read_file_text_from_array(defaults_get_file("post_processing.tbl"));
-
-	reset_parse();
+		reset_parse();
 
 
-	if (optional_string("#Effects")) {
-		while ( !required_string_one_of(3, "$Name:", "#Ship Effects", "#End") ) {
-			char tbuf[NAME_LENGTH+1] = { 0 };
-			post_effect_t eff;
+		if (optional_string("#Effects")) {
+			while (!required_string_one_of(3, "$Name:", "#Ship Effects", "#End")) {
+				char tbuf[NAME_LENGTH + 1] = { 0 };
+				post_effect_t eff;
 
-			required_string("$Name:");
-			stuff_string(tbuf, F_NAME, NAME_LENGTH);
-			eff.name = tbuf;
+				required_string("$Name:");
+				stuff_string(tbuf, F_NAME, NAME_LENGTH);
+				eff.name = tbuf;
 
-			required_string("$Uniform:");
-			stuff_string(tbuf, F_NAME, NAME_LENGTH);
-			eff.uniform_name = tbuf;
+				required_string("$Uniform:");
+				stuff_string(tbuf, F_NAME, NAME_LENGTH);
+				eff.uniform_name = tbuf;
 
-			required_string("$Define:");
-			stuff_string(tbuf, F_NAME, NAME_LENGTH);
-			eff.define_name = tbuf;
+				required_string("$Define:");
+				stuff_string(tbuf, F_NAME, NAME_LENGTH);
+				eff.define_name = tbuf;
 
-			required_string("$AlwaysOn:");
-			stuff_boolean(&eff.always_on);
+				required_string("$AlwaysOn:");
+				stuff_boolean(&eff.always_on);
 
-			required_string("$Default:");
-			stuff_float(&eff.default_intensity);
-			eff.intensity = eff.default_intensity;
+				required_string("$Default:");
+				stuff_float(&eff.default_intensity);
+				eff.intensity = eff.default_intensity;
 
-			required_string("$Div:");
-			stuff_float(&eff.div);
+				required_string("$Div:");
+				stuff_float(&eff.div);
 
-			required_string("$Add:");
-			stuff_float(&eff.add);
+				required_string("$Add:");
+				stuff_float(&eff.add);
 
-			// Post_effects index is used for flag checks, so we can't have more than 32
-			if (Post_effects.size() < 32) {
-				Post_effects.push_back( eff );
-			} else if ( !warned ) {
-				mprintf(("WARNING: post_processing.tbl can only have a max of 32 effects! Ignoring extra...\n"));
-				warned = true;
+				// Post_effects index is used for flag checks, so we can't have more than 32
+				if (Post_effects.size() < 32) {
+					Post_effects.push_back(eff);
+				}
+				else if (!warned) {
+					mprintf(("WARNING: post_processing.tbl can only have a max of 32 effects! Ignoring extra...\n"));
+					warned = true;
+				}
 			}
 		}
-	}
 
-	//Built-in per-ship effects
-	ship_effect se1;
-	strcpy_s(se1.name, "FS1 Ship select");
-	se1.shader_effect = 0;
-	se1.disables_rendering = false;
-	se1.invert_timer = false;
-	Ship_effects.push_back(se1);
+		//Built-in per-ship effects
+		ship_effect se1;
+		strcpy_s(se1.name, "FS1 Ship select");
+		se1.shader_effect = 0;
+		se1.disables_rendering = false;
+		se1.invert_timer = false;
+		Ship_effects.push_back(se1);
 
-	if (optional_string("#Ship Effects")) {
-		while ( !required_string_one_of(3, "$Name:", "#Light Shafts", "#End") ) {
-			ship_effect se;
-			char tbuf[NAME_LENGTH] = { 0 };
+		if (optional_string("#Ship Effects")) {
+			while (!required_string_one_of(3, "$Name:", "#Light Shafts", "#End")) {
+				ship_effect se;
+				char tbuf[NAME_LENGTH] = { 0 };
 
-			required_string("$Name:");
-			stuff_string(tbuf, F_NAME, NAME_LENGTH);
-			strcpy_s(se.name, tbuf);
+				required_string("$Name:");
+				stuff_string(tbuf, F_NAME, NAME_LENGTH);
+				strcpy_s(se.name, tbuf);
 
-			required_string("$Shader Effect:");
-			stuff_int(&se.shader_effect);
+				required_string("$Shader Effect:");
+				stuff_int(&se.shader_effect);
 
-			required_string("$Disables Rendering:");
-			stuff_boolean(&se.disables_rendering);
+				required_string("$Disables Rendering:");
+				stuff_boolean(&se.disables_rendering);
 
-			required_string("$Invert timer:");
-			stuff_boolean(&se.invert_timer);
+				required_string("$Invert timer:");
+				stuff_boolean(&se.invert_timer);
 
-			Ship_effects.push_back(se);
+				Ship_effects.push_back(se);
+			}
 		}
+
+		if (optional_string("#Light Shafts")) {
+			required_string("$AlwaysOn:");
+			stuff_boolean(&ls_on);
+			required_string("$Density:");
+			stuff_float(&ls_density);
+			required_string("$Falloff:");
+			stuff_float(&ls_falloff);
+			required_string("$Weight:");
+			stuff_float(&ls_weight);
+			required_string("$Intensity:");
+			stuff_float(&ls_intensity);
+			required_string("$Sample Number:");
+			stuff_int(&ls_samplenum);
+
+			ls_cpintensity = ls_weight;
+			for (int i = 1; i < ls_samplenum; i++)
+				ls_cpintensity += ls_weight * pow(ls_falloff, i);
+			ls_cpintensity *= ls_intensity;
+		}
+
+		required_string("#End");
+
+		return true;
 	}
-
-	if (optional_string("#Light Shafts")) {
-		required_string("$AlwaysOn:");
-		stuff_boolean(&ls_on);
-		required_string("$Density:");
-		stuff_float(&ls_density);
-		required_string("$Falloff:");
-		stuff_float(&ls_falloff);
-		required_string("$Weight:");
-		stuff_float(&ls_weight);
-		required_string("$Intensity:");
-		stuff_float(&ls_intensity);
-		required_string("$Sample Number:");
-		stuff_int(&ls_samplenum);
-
-		ls_cpintensity = ls_weight;
-		for(int i = 1; i < ls_samplenum; i++)
-			ls_cpintensity += ls_weight * pow(ls_falloff, i);
-		ls_cpintensity *= ls_intensity;
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("Unable to parse 'post_processing.tbl'!  Error message = %s.\n", e.what()));
+		return false;
 	}
-	
-	required_string("#End");
-
-	return true;
 }
 
 static char *opengl_post_load_shader(char *filename, int flags, int flags2)

code/hud/hudartillery.cpp

@@ -62,72 +62,75 @@ int ssm_info_lookup(char *name)
 // game init
 void ssm_init()
 {	
-	int rval;
 	ssm_info bogus, *s;
 	char weapon_name[NAME_LENGTH];
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "ssm.tbl", rval));
-		return;
-	}
+	try
+	{
+		read_file_text("ssm.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-	read_file_text("ssm.tbl", CF_TYPE_TABLES);
-	reset_parse();
+		// parse the table
+		Ssm_info_count = 0;
+		while (!optional_string("#end")){
+			// another ssm definition
+			if (optional_string("$SSM:")){
+				// pointer to info struct
+				if (Ssm_info_count >= MAX_SSM_TYPES){
+					s = &bogus;
+				}
+				else {
+					s = &Ssm_info[Ssm_info_count];
+				}
 
-	// parse the table
-	Ssm_info_count = 0;
-	while(!optional_string("#end")){
-		// another ssm definition
-		if(optional_string("$SSM:")){
-			// pointer to info struct
-			if(Ssm_info_count >= MAX_SSM_TYPES){
-				s = &bogus;
-			} else {
-				s = &Ssm_info[Ssm_info_count];
-			}
+				// name
+				stuff_string(s->name, F_NAME, NAME_LENGTH);
 
-			// name
-			stuff_string(s->name, F_NAME, NAME_LENGTH);
+				// stuff data
+				required_string("+Weapon:");
+				stuff_string(weapon_name, F_NAME, NAME_LENGTH);
+				required_string("+Count:");
+				stuff_int(&s->count);
+				required_string("+WarpRadius:");
+				stuff_float(&s->warp_radius);
+				required_string("+WarpTime:");
+				stuff_float(&s->warp_time);
+				// According to fireballs.cpp, "Warp lifetime must be at least 4 seconds!"
+				if ((s->warp_time) < 4.0f) {
+					// So let's warn them before they try to use it, shall we?
+					Warning(LOCATION, "Expected a '+WarpTime:' value equal or greater than 4.0, found '%f' in weapon '%s'.\n Setting to 4.0, please check and set to a number 4.0 or greater!\n", s->warp_time, weapon_name);
+					// And then make the Assert obsolete -- Zacam
+					s->warp_time = 4.0f;
+				}
+				required_string("+Radius:");
+				stuff_float(&s->radius);
+				required_string("+Offset:");
+				stuff_float(&s->offset);
+				if (optional_string("+HUD Message:"))
+					stuff_boolean(&s->send_message);
+				else
+					s->send_message = true;
+				if (optional_string("+Custom Message:")) {
+					stuff_string(s->message, F_NAME, NAME_LENGTH);
+					s->use_custom_message = true;
+				}
+				parse_sound("+Alarm Sound:", &s->sound_index, s->name);
 
-			// stuff data
-			required_string("+Weapon:");
-			stuff_string(weapon_name, F_NAME, NAME_LENGTH);
-			required_string("+Count:");
-			stuff_int(&s->count);
-			required_string("+WarpRadius:");
-			stuff_float(&s->warp_radius);
-			required_string("+WarpTime:");
-			stuff_float(&s->warp_time);
-			// According to fireballs.cpp, "Warp lifetime must be at least 4 seconds!"
-			if ( (s->warp_time) < 4.0f) {
-				// So let's warn them before they try to use it, shall we?
-				Warning(LOCATION, "Expected a '+WarpTime:' value equal or greater than 4.0, found '%f' in weapon '%s'.\n Setting to 4.0, please check and set to a number 4.0 or greater!\n", s->warp_time, weapon_name);
-				// And then make the Assert obsolete -- Zacam
-				s->warp_time = 4.0f;
-			}
-			required_string("+Radius:");
-			stuff_float(&s->radius);
-			required_string("+Offset:");
-			stuff_float(&s->offset);
-			if (optional_string("+HUD Message:")) 
-				stuff_boolean(&s->send_message);
-			else
-				s->send_message = true;
-			if (optional_string("+Custom Message:")) {
-				stuff_string(s->message, F_NAME, NAME_LENGTH);
-				s->use_custom_message = true;
-			}
-			parse_sound("+Alarm Sound:", &s->sound_index, s->name);
-
-			// see if we have a valid weapon
-			s->weapon_info_index = -1;
-			s->weapon_info_index = weapon_info_lookup(weapon_name);
-			if(s->weapon_info_index >= 0){
-				// valid
-				Ssm_info_count++;
+				// see if we have a valid weapon
+				s->weapon_info_index = -1;
+				s->weapon_info_index = weapon_info_lookup(weapon_name);
+				if (s->weapon_info_index >= 0){
+					// valid
+					Ssm_info_count++;
+				}
 			}
 		}
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "ssm.tbl", e.what()));
+		return;
+	}
 }
 
 void ssm_get_random_start_pos(vec3d *out, vec3d *start, matrix *orient, int ssm_index)

code/hud/hudconfig.cpp

@@ -1641,40 +1641,43 @@ void hud_config_color_save(char *name)
 
 void hud_config_color_load(char *name)
 {
-	int idx, rval;
+	int idx;
 	char str[1024];
 	char *fname;
 
 	fname = cf_add_ext(name, ".hcf");
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("HUDCONFIG: Unable to parse '%s'!  Error code = %i.\n", fname, rval));
-		return;
-	}
+	try
+	{
+		read_file_text(fname);
+		reset_parse();
 
-	read_file_text(fname);
-	reset_parse();
+		// First, set all gauges to the current main color
+		for (idx = 0; idx < NUM_HUD_GAUGES; idx++){
+			gr_init_alphacolor(&HUD_config.clr[idx], HUD_color_red, HUD_color_green, HUD_color_blue, (HUD_color_alpha + 1) * 16);
+		}
 
-	// First, set all gauges to the current main color
-	for (idx=0; idx<NUM_HUD_GAUGES; idx++){
-		gr_init_alphacolor(&HUD_config.clr[idx], HUD_color_red, HUD_color_green, HUD_color_blue, (HUD_color_alpha+1)*16);
-	}
+		// Now read in the color values for the gauges
+		while (optional_string("+Gauge:")) {
+			stuff_string(str, F_NAME, sizeof(str));
 
-	// Now read in the color values for the gauges
-	while (optional_string("+Gauge:")) {
-		stuff_string(str, F_NAME, sizeof(str));
-
-		for (idx=0; idx<NUM_HUD_GAUGES; idx++) {
-			if (!stricmp(str, Hud_Gauge_Names[idx])) {
-				required_string("+RGBA:");
-				stuff_ubyte(&HUD_config.clr[idx].red);
-				stuff_ubyte(&HUD_config.clr[idx].green);
-				stuff_ubyte(&HUD_config.clr[idx].blue);
-				stuff_ubyte(&HUD_config.clr[idx].alpha);
-				break;
+			for (idx = 0; idx < NUM_HUD_GAUGES; idx++) {
+				if (!stricmp(str, Hud_Gauge_Names[idx])) {
+					required_string("+RGBA:");
+					stuff_ubyte(&HUD_config.clr[idx].red);
+					stuff_ubyte(&HUD_config.clr[idx].green);
+					stuff_ubyte(&HUD_config.clr[idx].blue);
+					stuff_ubyte(&HUD_config.clr[idx].alpha);
+					break;
+				}
 			}
 		}
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("HUDCONFIG: Unable to parse '%s'!  Error message = %s.\n", fname, e.what()));
+		return;
+	}
 }
 
 void hud_config_alpha_slider_up()

code/hud/hudparse.cpp

@@ -165,7 +165,7 @@ int parse_ship_start()
 
 void parse_hud_gauges_tbl(const char *filename)
 {
-	int i, rval;
+	int i;
 	char *saved_Mp = NULL;
 
 	int colors[3] = {255, 255, 255};
@@ -175,114 +175,112 @@ void parse_hud_gauges_tbl(const char *filename)
 	color *ship_clr_p = NULL;
 	bool scale_gauge = true;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	}
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	if(optional_string("$Load Retail Configuration:")) {
-		stuff_boolean(&Hud_retail);
-	}
-
-	if ( optional_string("$Color:") ) {
-		stuff_int_list(colors, 3);
-
-		check_color(colors);
-		gr_init_alphacolor(&hud_color, colors[0], colors[1], colors[2], 255);
-		hud_clr_p = &hud_color;
-	}
-
-	if(optional_string("$Font:")) {
-		stuff_int(&Hud_font);
-	}
-	
-	if(optional_string("$Max Directives:")) {
-		stuff_int(&Max_directives);
-	}
-
-	if(optional_string("$Max Escort Ships:")) {
-		stuff_int(&Max_escort_ships);
-	}
-
-	if(optional_string("$Length Unit Multiplier:"))	{
-		stuff_float(&Hud_unit_multiplier);
-
-		if (Hud_unit_multiplier <= 0.0f) {
-			Warning(LOCATION, "\"$Length Unit Multiplier:\" value of \"%f\" is invalid!  Resetting to default.", Hud_unit_multiplier);
-			Hud_unit_multiplier = 1.0f;
+		if (optional_string("$Load Retail Configuration:")) {
+			stuff_boolean(&Hud_retail);
 		}
-	}
 
-	if(optional_string("$Speed Unit Multiplier:")) {
-		stuff_float(&Hud_speed_multiplier);
+		if (optional_string("$Color:")) {
+			stuff_int_list(colors, 3);
 
-		if (Hud_speed_multiplier <= 0.0f) {
-			Warning(LOCATION, "\"$Speed Unit Multiplier:\" value of \"%f\" is invalid!  Resetting to default.", Hud_speed_multiplier);
-			Hud_speed_multiplier = 1.0f;
+			check_color(colors);
+			gr_init_alphacolor(&hud_color, colors[0], colors[1], colors[2], 255);
+			hud_clr_p = &hud_color;
 		}
-	} else {
-		Hud_speed_multiplier = Hud_unit_multiplier;
-	} 
 
-	if (optional_string("$Wireframe Targetbox:")) {
-		stuff_int(&Targetbox_wire);
-		if ((Targetbox_wire < 0) || (Targetbox_wire > 3)) {
-			Targetbox_wire = 0;
+		if (optional_string("$Font:")) {
+			stuff_int(&Hud_font);
 		}
-	}
 
-	if (optional_string("$Targetbox Shader Effect:")) {
-		stuff_int(&Targetbox_shader_effect);
-		if (Targetbox_shader_effect < 0) {
-			Targetbox_shader_effect = 0;
+		if (optional_string("$Max Directives:")) {
+			stuff_int(&Max_directives);
 		}
-	}
 
-	if (optional_string("$Lock Wireframe Mode:")) {
-		stuff_boolean(&Lock_targetbox_mode);
-	}
+		if (optional_string("$Max Escort Ships:")) {
+			stuff_int(&Max_escort_ships);
+		}
 
-	if (optional_string("$Scale Gauges:")) {
-		stuff_boolean(&scale_gauge);
-		Scale_retail_gauges = scale_gauge;
-	}
+		if (optional_string("$Length Unit Multiplier:"))	{
+			stuff_float(&Hud_unit_multiplier);
 
-	if(optional_string("$Reticle Style:")) {
-		int temp = required_string_either("FS1", "FS2"); 
+			if (Hud_unit_multiplier <= 0.0f) {
+				Warning(LOCATION, "\"$Length Unit Multiplier:\" value of \"%f\" is invalid!  Resetting to default.", Hud_unit_multiplier);
+				Hud_unit_multiplier = 1.0f;
+			}
+		}
 
-		// using require_string_either won't advance the Mp pointer to the next token so force it instead
-		skip_to_start_of_string("#Gauge Config");
+		if (optional_string("$Speed Unit Multiplier:")) {
+			stuff_float(&Hud_speed_multiplier);
 
-		if (temp < 0)
-			Warning(LOCATION, "Undefined reticle style in hud_gauges.tbl!");
-		else
-			Hud_reticle_style = temp;
-	}
+			if (Hud_speed_multiplier <= 0.0f) {
+				Warning(LOCATION, "\"$Speed Unit Multiplier:\" value of \"%f\" is invalid!  Resetting to default.", Hud_speed_multiplier);
+				Hud_speed_multiplier = 1.0f;
+			}
+		}
+		else {
+			Hud_speed_multiplier = Hud_unit_multiplier;
+		}
 
-	if (optional_string("$Show disabled ETS gauges:")) {
-		stuff_boolean(&Show_disabled_ets_gauges);
-	}
+		if (optional_string("$Wireframe Targetbox:")) {
+			stuff_int(&Targetbox_wire);
+			if ((Targetbox_wire < 0) || (Targetbox_wire > 3)) {
+				Targetbox_wire = 0;
+			}
+		}
 
-	int base_res[2];
-	int ship_idx = -1;
-	int ship_font = -1;
-	int gauge_type = -1;
-	int use_font = -1;
-	color *use_clr_p = NULL;
-	SCP_vector<int> ship_classes;
-	bool retail_config = false;
-	int n_ships = 0;
+		if (optional_string("$Targetbox Shader Effect:")) {
+			stuff_int(&Targetbox_shader_effect);
+			if (Targetbox_shader_effect < 0) {
+				Targetbox_shader_effect = 0;
+			}
+		}
 
-	while(optional_string("#Gauge Config")) {
-		ship_classes.clear();
-		switch (optional_string_either("$Ship:", "$Ships:")) {
+		if (optional_string("$Lock Wireframe Mode:")) {
+			stuff_boolean(&Lock_targetbox_mode);
+		}
+
+		if (optional_string("$Scale Gauges:")) {
+			stuff_boolean(&scale_gauge);
+			Scale_retail_gauges = scale_gauge;
+		}
+
+		if (optional_string("$Reticle Style:")) {
+			int temp = required_string_either("FS1", "FS2");
+
+			// using require_string_either won't advance the Mp pointer to the next token so force it instead
+			skip_to_start_of_string("#Gauge Config");
+
+			if (temp < 0)
+				Warning(LOCATION, "Undefined reticle style in hud_gauges.tbl!");
+			else
+				Hud_reticle_style = temp;
+		}
+
+		if (optional_string("$Show disabled ETS gauges:")) {
+			stuff_boolean(&Show_disabled_ets_gauges);
+		}
+
+		int base_res[2];
+		int ship_idx = -1;
+		int ship_font = -1;
+		int gauge_type = -1;
+		int use_font = -1;
+		color *use_clr_p = NULL;
+		SCP_vector<int> ship_classes;
+		bool retail_config = false;
+		int n_ships = 0;
+
+		while (optional_string("#Gauge Config")) {
+			ship_classes.clear();
+			switch (optional_string_either("$Ship:", "$Ships:")) {
 			case 0:
 				mprintf(("$Ship in hud_gauges.tbl and -hdg.tbms is deprecated. Use \"$Ships: (\"Some ship class\") instead.\n"));
 
-				if(!ships_inited) {
+				if (!ships_inited) {
 					// just in case ship info has not been initialized.
 					skip_to_start_of_string("#Gauge Config");
 					continue;
@@ -292,15 +290,15 @@ void parse_hud_gauges_tbl(const char *filename)
 				ship_idx = parse_ship_start();
 				ship_classes.push_back(ship_idx);
 
-				if(ship_idx >= 0) {
+				if (ship_idx >= 0) {
 					Ship_info[ship_idx].hud_enabled = true;
 
 					// see if we need to load defaults for this configuration
-					if(optional_string("$Load Retail Configuration:")) {
+					if (optional_string("$Load Retail Configuration:")) {
 						stuff_boolean(&Ship_info[ship_idx].hud_retail);
 					}
 
-					if ( optional_string("$Color:") ) {
+					if (optional_string("$Color:")) {
 						stuff_int_list(colors, 3);
 
 						check_color(colors);
@@ -308,10 +306,11 @@ void parse_hud_gauges_tbl(const char *filename)
 						ship_clr_p = &ship_color;
 					}
 
-					if(optional_string("$Font:")) {
+					if (optional_string("$Font:")) {
 						stuff_int(&ship_font);
 					}
-				} else {
+				}
+				else {
 					// can't find ship class. move on.
 					ship_classes.push_back(-1);
 					skip_to_start_of_string("#Gauge Config");
@@ -324,7 +323,7 @@ void parse_hud_gauges_tbl(const char *filename)
 
 				n_ships = stuff_int_list(shiparray, 256, SHIP_INFO_TYPE);
 
-				if(optional_string("$Load Retail Configuration:")) {
+				if (optional_string("$Load Retail Configuration:")) {
 					stuff_boolean(&retail_config);
 				}
 
@@ -334,7 +333,7 @@ void parse_hud_gauges_tbl(const char *filename)
 					Ship_info[shiparray[i]].hud_retail = retail_config;
 				}
 
-				if ( optional_string("$Color:") ) {
+				if (optional_string("$Color:")) {
 					stuff_int_list(colors, 3);
 
 					check_color(colors);
@@ -342,119 +341,131 @@ void parse_hud_gauges_tbl(const char *filename)
 					ship_clr_p = &ship_color;
 				}
 
-				if(optional_string("$Font:")) {
+				if (optional_string("$Font:")) {
 					stuff_int(&ship_font);
 				}
 				break;
 			default:
-			// No particular ship. -1 for default HUD configuration.
-			ship_classes.push_back(-1);
-			ship_font = -1;
-			ship_clr_p = NULL;
-			break; 
-		}
+				// No particular ship. -1 for default HUD configuration.
+				ship_classes.push_back(-1);
+				ship_font = -1;
+				ship_clr_p = NULL;
+				break;
+			}
 
-		if ( ship_clr_p != NULL ) {
-			use_clr_p = ship_clr_p;
-		} else {
-			use_clr_p = hud_clr_p;
-		}
+			if (ship_clr_p != NULL) {
+				use_clr_p = ship_clr_p;
+			}
+			else {
+				use_clr_p = hud_clr_p;
+			}
 
-		if(ship_font >= 0) {
-			use_font = ship_font;
-		} else {
-			use_font = Hud_font;
-		}
+			if (ship_font >= 0) {
+				use_font = ship_font;
+			}
+			else {
+				use_font = Hud_font;
+			}
 
-		// Now start going through resolution info for this HUD layout
-		required_string("$Base:");
+			// Now start going through resolution info for this HUD layout
+			required_string("$Base:");
 
-		// get the base width and height describing this HUD
-		stuff_int_list(base_res, 2, RAW_INTEGER_TYPE);
+			// get the base width and height describing this HUD
+			stuff_int_list(base_res, 2, RAW_INTEGER_TYPE);
 
-		// gauge scaling for this base res?
-		if (optional_string("$Scale Gauges:")) {
-			stuff_boolean(&scale_gauge);
-		}
+			// gauge scaling for this base res?
+			if (optional_string("$Scale Gauges:")) {
+				stuff_boolean(&scale_gauge);
+			}
 
-		// Pruning time. Let's see if the current resolution defined by the user matches the conditions set by this entry
-		if(optional_string("$Required Aspect:")) {
-			// filter aspect ratio.
-			if(optional_string("Full Screen")) {
-				if( (float)gr_screen.max_w / (float)gr_screen.max_h > 1.5) {
-					skip_to_start_of_string("#Gauge Config");
-					//skip_to_start_of_string_either("#Gauge Config", "#End");
-					continue;
+			// Pruning time. Let's see if the current resolution defined by the user matches the conditions set by this entry
+			if (optional_string("$Required Aspect:")) {
+				// filter aspect ratio.
+				if (optional_string("Full Screen")) {
+					if ((float)gr_screen.max_w / (float)gr_screen.max_h > 1.5) {
+						skip_to_start_of_string("#Gauge Config");
+						//skip_to_start_of_string_either("#Gauge Config", "#End");
+						continue;
+					}
 				}
-			} else if(optional_string("Wide Screen")) {
-				if( (float)gr_screen.max_w / (float)gr_screen.max_h <= 1.5) {
-					skip_to_start_of_string("#Gauge Config");
-					//skip_to_start_of_string_either("#Gauge Config", "#End");
-					continue;
+				else if (optional_string("Wide Screen")) {
+					if ((float)gr_screen.max_w / (float)gr_screen.max_h <= 1.5) {
+						skip_to_start_of_string("#Gauge Config");
+						//skip_to_start_of_string_either("#Gauge Config", "#End");
+						continue;
+					}
 				}
-			} 
-		}
-		
-		// check minimum resolution
-		if(optional_string("$Min:")) {
-			int min_res[2];
-			stuff_int_list(min_res, 2, RAW_INTEGER_TYPE);
-			
-			if(min_res[0] > gr_screen.max_w) {
-				skip_to_start_of_string("#Gauge Config");
-				continue;
-			} else if (min_res[0] == gr_screen.max_w) {
-				if(min_res[1] > gr_screen.max_h) {
+			}
+
+			// check minimum resolution
+			if (optional_string("$Min:")) {
+				int min_res[2];
+				stuff_int_list(min_res, 2, RAW_INTEGER_TYPE);
+
+				if (min_res[0] > gr_screen.max_w) {
 					skip_to_start_of_string("#Gauge Config");
 					continue;
 				}
+				else if (min_res[0] == gr_screen.max_w) {
+					if (min_res[1] > gr_screen.max_h) {
+						skip_to_start_of_string("#Gauge Config");
+						continue;
+					}
+				}
 			}
-		}
 
-		// check maximum resolution
-		if(optional_string("$Max:")) {
-			int max_res[2];
-			stuff_int_list(max_res, 2, RAW_INTEGER_TYPE);
+			// check maximum resolution
+			if (optional_string("$Max:")) {
+				int max_res[2];
+				stuff_int_list(max_res, 2, RAW_INTEGER_TYPE);
 
-			if(max_res[0] < gr_screen.max_w) {
-				skip_to_start_of_string("#Gauge Config");
-				continue;
-			} else if (max_res[0] == gr_screen.max_w) {
-				if(max_res[1] < gr_screen.max_h) {
+				if (max_res[0] < gr_screen.max_w) {
 					skip_to_start_of_string("#Gauge Config");
 					continue;
 				}
+				else if (max_res[0] == gr_screen.max_w) {
+					if (max_res[1] < gr_screen.max_h) {
+						skip_to_start_of_string("#Gauge Config");
+						continue;
+					}
+				}
 			}
+
+			// let's start parsing for gauges.
+			required_string("$Gauges:");
+
+			while (!check_for_string("$Gauges:") && !check_for_string("$End Gauges")) {
+				// find out what type of gauge we're parsing.
+				gauge_type = parse_gauge_type();
+
+				// then call the specific gauge load handler function for this gauge type.
+				if (optional_string("default")) {
+					// sending -1 base width and height will indicate GR_640 or GR_1024 to the handlers
+					load_gauge(gauge_type, -1, -1, use_font, scale_gauge, &ship_classes, use_clr_p);
+				}
+				else {
+					load_gauge(gauge_type, base_res[0], base_res[1], use_font, scale_gauge, &ship_classes, use_clr_p);
+				}
+
+				if (saved_Mp && (saved_Mp == Mp)) {
+					Mp++;
+				}
+
+				skip_to_start_of_string_either("$", "+");
+				// stolened from AI_profiles
+				// if we've been through once already and are at the same place, force a move
+
+				saved_Mp = Mp;
+			}
+
+			required_string("$End Gauges");
+			required_string("#End");
 		}
-
-		// let's start parsing for gauges.
-		required_string("$Gauges:");
-
-		while (!check_for_string("$Gauges:") && !check_for_string("$End Gauges")) {
-			// find out what type of gauge we're parsing.
-			gauge_type = parse_gauge_type();
-
-			// then call the specific gauge load handler function for this gauge type.
-			if(optional_string("default")) {
-				// sending -1 base width and height will indicate GR_640 or GR_1024 to the handlers
-				load_gauge(gauge_type, -1, -1, use_font, scale_gauge, &ship_classes, use_clr_p);
-			} else {
-				load_gauge(gauge_type, base_res[0], base_res[1], use_font, scale_gauge, &ship_classes, use_clr_p);
-			}
-
-			if ( saved_Mp && (saved_Mp == Mp) ) {
-				Mp++;
-			}
-
-			skip_to_start_of_string_either("$", "+");
-			// stolened from AI_profiles
-			// if we've been through once already and are at the same place, force a move
-
-			saved_Mp = Mp;
-		}
-
-		required_string("$End Gauges");
-		required_string("#End");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
 }
 

code/hud/hudshield.cpp

@@ -545,6 +545,11 @@ void hud_shield_quadrant_hit(object *objp, int quadrant)
 	shield_hit_info	*shi;
 	int					num;
 
+	if (Game_mode & GM_STANDALONE_SERVER)
+		return;
+
+	Assertion(objp != NULL, "hud_shield_quadrant_hit() called with a NULL objp; get a coder!\n");
+
 	if ( objp->type != OBJ_SHIP )
 		return;
 
@@ -559,12 +564,16 @@ void hud_shield_quadrant_hit(object *objp, int quadrant)
 		return;
 	}
 
+	Assertion(shi->shield_hit_timers.size() > 0, "Shield hit info object for object '%s' has a size %d shield_hit_timers; get a coder!\n", Ships[objp->instance].ship_name, shi->shield_hit_timers.size());
+	Assertion(shi->hull_hit_index < shi->shield_hit_timers.size(), "Shield hit info object for object '%s' has a hull_hit_index of %d (should be between 0 and %d); get a coder!\n", Ships[objp->instance].ship_name, shi->hull_hit_index, shi->shield_hit_timers.size() - 1);
+
 	if ( quadrant >= 0 ) {
 		if ( !(Ship_info[Ships[objp->instance].ship_info_index].flags2 & SIF2_MODEL_POINT_SHIELDS) )
 			num = Quadrant_xlate[quadrant];
 		else
 			num = quadrant;
 
+		Assertion(num < shi->hull_hit_index, "Shield hit info object for object '%s' hit on quadrant #%d, despite having a hull_hit_index of %d; get a coder!\n", Ships[objp->instance].ship_name, num, shi->hull_hit_index);
 		shi->shield_hit_timers[num] = timestamp(SHIELD_HIT_DURATION_SHORT);
 	} else {
 		shi->shield_hit_timers[shi->hull_hit_index] = timestamp(SHIELD_HIT_DURATION_SHORT);

code/hud/hudsquadmsg.cpp

@@ -1373,11 +1373,10 @@ int hud_squadmsg_send_wing_command( int wingnum, int command, int send_message,
 
 		target_shipname = NULL;
 		target_team = -1;
-		if ( ainfo->target_objnum != -1) {
-			if ( Objects[ainfo->target_objnum].type == OBJ_SHIP ) {
-				target_shipname = Ships[Objects[ainfo->target_objnum].instance].ship_name;		// I think this is right
-				target_team = Ships[Objects[ainfo->target_objnum].instance].team;
-			}
+
+		if ( Objects[ainfo->target_objnum].type == OBJ_SHIP ) {
+			target_shipname = Ships[Objects[ainfo->target_objnum].instance].ship_name;		// I think this is right
+			target_team = Ships[Objects[ainfo->target_objnum].instance].team;
 		}
 
 		Assert ( ainfo->shipnum != -1 );

code/iff_defs/iff_defs.cpp

@@ -128,406 +128,407 @@ void iff_init()
 	int i, j, k;
 	int string_idx;
 
-	int rval;
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "iff_defs.tbl", rval));
+		// Goober5000 - if table doesn't exist, use the default table
+		if (cf_exists_full("iff_defs.tbl", CF_TYPE_TABLES))
+			read_file_text("iff_defs.tbl", CF_TYPE_TABLES);
+		else
+			read_file_text_from_array(defaults_get_file("iff_defs.tbl"));
+
+		reset_parse();
+
+		// parse the table --------------------------------------------------------
+
+		required_string("#IFFs");
+
+		// get the traitor
+		required_string("$Traitor IFF:");
+		stuff_string(traitor_name, F_NAME, NAME_LENGTH);
+
+		int rgb[3];
+
+		// check if alternate colours are wanted to be used for these
+		// Marks various stuff... like asteroids
+		if ((optional_string("$Selection Color:")) || (optional_string("$Selection Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			iff_init_color(rgb[0], rgb[1], rgb[2]);
+		}
+		else
+			iff_init_color(0xff, 0xff, 0xff);
+
+		// Marks the ship currently saying something
+		if ((optional_string("$Message Color:")) || (optional_string("$Message Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			iff_init_color(rgb[0], rgb[1], rgb[2]);
+		}
+		else
+			iff_init_color(0x7f, 0x7f, 0x7f);
+
+		// Marks the tagged ships
+		if ((optional_string("$Tagged Color:")) || (optional_string("$Tagged Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			iff_init_color(rgb[0], rgb[1], rgb[2]);
+		}
+		else
+			iff_init_color(0xff, 0xff, 0x00);
+
+		// init radar blips colour table
+		int a_bright, a_dim;
+		bool alternate_blip_color = false;
+		for (i = 0; i < 5; i++)
+		{
+			for (j = 0; j < 2; j++)
+			{
+				for (k = 0; k < 3; k++)
+				{
+					radar_iff_color[i][j][k] = -1;
+				}
+			}
+		}
+
+		// if the bright/dim scaling is wanted to be changed
+		if (optional_string("$Dimmed IFF brightness:"))
+		{
+			int dim_iff_brightness;
+			stuff_int(&dim_iff_brightness);
+			Assert(dim_iff_brightness >= 0 && dim_iff_brightness <= HUD_COLOR_ALPHA_MAX);
+			*iff_color_brightness = dim_iff_brightness;
+		}
+		else
+			*iff_color_brightness = 4;
+
+		// alternate = use same method as with ship blips
+		// retail = use 1/2 intensities
+		if (optional_string("$Use Alternate Blip Coloring:") || optional_string("$Use Alternate Blip Colouring:"))
+		{
+			stuff_boolean(&alternate_blip_color);
+		}
+
+		// Parse blip colours, their order is hardcoded.
+		if ((optional_string("$Missile Blip Color:")) || (optional_string("$Missile Blip Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			for (i = 0; i < 3; i++)
+			{
+				Assert(rgb[i] >= 0 && rgb[i] <= 255);
+				radar_iff_color[0][1][i] = rgb[i];
+				radar_iff_color[0][0][i] = rgb[i] / 2;
+			}
+		}
+
+		if ((optional_string("$Navbuoy Blip Color:")) || (optional_string("$Navbuoy Blip Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			for (i = 0; i < 3; i++)
+			{
+				Assert(rgb[i] >= 0 && rgb[i] <= 255);
+				radar_iff_color[1][1][i] = rgb[i];
+				radar_iff_color[1][0][i] = rgb[i] / 2;
+			}
+		}
+
+		if ((optional_string("$Warping Blip Color:")) || (optional_string("$Warping Blip Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			for (i = 0; i < 3; i++)
+			{
+				Assert(rgb[i] >= 0 && rgb[i] <= 255);
+				radar_iff_color[2][1][i] = rgb[i];
+				radar_iff_color[2][0][i] = rgb[i] / 2;
+			}
+		}
+
+		if ((optional_string("$Node Blip Color:")) || (optional_string("$Node Blip Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			for (i = 0; i < 3; i++)
+			{
+				Assert(rgb[i] >= 0 && rgb[i] <= 255);
+				radar_iff_color[3][1][i] = rgb[i];
+				radar_iff_color[3][0][i] = rgb[i] / 2;
+			}
+		}
+
+		if ((optional_string("$Tagged Blip Color:")) || (optional_string("$Tagged Blip Colour:")))
+		{
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			for (i = 0; i < 3; i++)
+			{
+				Assert(rgb[i] >= 0 && rgb[i] <= 255);
+				radar_iff_color[4][1][i] = rgb[i];
+				radar_iff_color[4][0][i] = rgb[i] / 2;
+			}
+		}
+
+		if (alternate_blip_color == true)
+		{
+			a_bright = iff_get_alpha_value(true);
+			a_dim = iff_get_alpha_value(false);
+			for (i = 0; i < 5; i++)
+			{
+				if (radar_iff_color[i][0][0] >= 0)
+				{
+					for (j = 0; j < 3; j++)
+					{
+						radar_iff_color[i][0][j] = radar_iff_color[i][1][j];
+					}
+
+					radar_iff_color[i][1][3] = a_bright;
+					radar_iff_color[i][0][3] = a_dim;
+				}
+			}
+		}
+		else
+		{
+			for (i = 0; i < 5; i++)
+			{
+				if (radar_iff_color[i][0][0] >= 0)
+				{
+					radar_iff_color[i][0][3] = 255;
+					radar_iff_color[i][1][3] = 255;
+				}
+			}
+		}
+
+		if (optional_string("$Radar Target ID Flags:")) {
+			parse_string_flag_list((int*)&radar_target_id_flags, rti_flags, Num_rti_flags);
+			if (optional_string("+reset"))
+				radar_target_id_flags = 0;
+		}
+
+		// begin reading data
+		Num_iffs = 0;
+		while (required_string_either("#End", "$IFF Name:"))
+		{
+			iff_info *iff;
+			int cur_iff;
+
+			// make sure we're under the limit
+			if (Num_iffs >= MAX_IFFS)
+			{
+				Warning(LOCATION, "Too many iffs in iffs_defs.tbl!  Max is %d.\n", MAX_IFFS);
+				skip_to_start_of_string("#End", NULL);
+				break;
+			}
+
+			// add new IFF
+			iff = &Iff_info[Num_iffs];
+			cur_iff = Num_iffs;
+			Num_iffs++;
+
+
+			// get required IFF info ----------------------------------------------
+
+			// get the iff name
+			required_string("$IFF Name:");
+			stuff_string(iff->iff_name, F_NAME, NAME_LENGTH);
+
+			// get the iff color
+			if (check_for_string("$Colour:"))
+				required_string("$Colour:");
+			else
+				required_string("$Color:");
+			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+			iff->color_index = iff_init_color(rgb[0], rgb[1], rgb[2]);
+
+
+			// get relationships between IFFs -------------------------------------
+
+			// get the list of iffs attacked
+			if (optional_string("$Attacks:"))
+				num_attack_names[cur_iff] = stuff_string_list(attack_names[cur_iff], MAX_IFFS);
+			else
+				num_attack_names[cur_iff] = 0;
+
+			// get the list of observed colors
+			num_observed_colors[cur_iff] = 0;
+			while (optional_string("+Sees"))
+			{
+				// get iff observed
+				stuff_string_until(observed_color_table[cur_iff][num_observed_colors[cur_iff]].iff_name, "As:", NAME_LENGTH);
+				required_string("As:");
+
+				// get color observed
+				stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
+				observed_color_table[cur_iff][num_observed_colors[cur_iff]].color_index = iff_init_color(rgb[0], rgb[1], rgb[2]);
+
+				// increment
+				num_observed_colors[cur_iff]++;
+			}
+
+
+			// get flags ----------------------------------------------------------
+
+			// get iff flags
+			iff->flags = 0;
+			if (optional_string("$Flags:"))
+			{
+				char flag_strings[MAX_IFF_FLAGS][NAME_LENGTH];
+
+				int num_strings = stuff_string_list(flag_strings, MAX_IFF_FLAGS);
+				for (string_idx = 0; string_idx < num_strings; string_idx++)
+				{
+					if (!stricmp(NOX("support allowed"), flag_strings[string_idx]))
+						iff->flags |= IFFF_SUPPORT_ALLOWED;
+					else if (!stricmp(NOX("exempt from all teams at war"), flag_strings[string_idx]))
+						iff->flags |= IFFF_EXEMPT_FROM_ALL_TEAMS_AT_WAR;
+					else if (!stricmp(NOX("orders hidden"), flag_strings[string_idx]))
+						iff->flags |= IFFF_ORDERS_HIDDEN;
+					else if (!stricmp(NOX("orders shown"), flag_strings[string_idx]))
+						iff->flags |= IFFF_ORDERS_SHOWN;
+					else if (!stricmp(NOX("wing name hidden"), flag_strings[string_idx]))
+						iff->flags |= IFFF_WING_NAME_HIDDEN;
+					else
+						Warning(LOCATION, "Bogus string in iff flags: %s\n", flag_strings[string_idx]);
+				}
+			}
+
+			// get default ship flags
+			iff->default_parse_flags = 0;
+			if (optional_string("$Default Ship Flags:"))
+			{
+				i = 0;
+				j = 0;
+				char flag_strings[MAX_PARSE_OBJECT_FLAGS][NAME_LENGTH];
+				int num_strings = stuff_string_list(flag_strings, MAX_PARSE_OBJECT_FLAGS);
+				for (i = 0; i < num_strings; i++)
+				{
+					for (j = 0; j < MAX_PARSE_OBJECT_FLAGS; j++)
+					{
+						if (!stricmp(flag_strings[i], Parse_object_flags[j]))
+						{
+							iff->default_parse_flags |= (1 << j);
+							break;
+						}
+					}
+				}
+
+				if (j == MAX_PARSE_OBJECT_FLAGS)
+					Warning(LOCATION, "Bogus string in iff default ship flags: %s\n", flag_strings[i]);
+			}
+
+			// again
+			iff->default_parse_flags2 = 0;
+			if (optional_string("$Default Ship Flags2:"))
+			{
+				i = 0;
+				j = 0;
+				char flag_strings[MAX_PARSE_OBJECT_FLAGS_2][NAME_LENGTH];
+				int num_strings = stuff_string_list(flag_strings, MAX_PARSE_OBJECT_FLAGS_2);
+				for (i = 0; i < num_strings; i++)
+				{
+					for (j = 0; j < MAX_PARSE_OBJECT_FLAGS_2; j++)
+					{
+						if (!stricmp(flag_strings[i], Parse_object_flags_2[j]))
+						{
+							iff->default_parse_flags2 |= (1 << j);
+							break;
+						}
+					}
+				}
+
+				if (j == MAX_PARSE_OBJECT_FLAGS_2)
+					Warning(LOCATION, "Bogus string in iff default ship flags2: %s\n", flag_strings[i]);
+			}
+
+			// this is cleared between each level but let's just set it here for thoroughness
+			iff->ai_rearm_timestamp = timestamp(-1);
+		}
+
+		required_string("#End");
+
+
+		// now resolve the relationships ------------------------------------------
+
+		// first get the traitor
+		Iff_traitor = iff_lookup(traitor_name);
+		if (Iff_traitor < 0)
+		{
+			Iff_traitor = 0;
+			Warning(LOCATION, "Traitor IFF %s not found in iff_defs.tbl!  Defaulting to %s.\n", traitor_name, Iff_info[Iff_traitor].iff_name);
+		}
+
+		// next get the attackees and colors
+		for (int cur_iff = 0; cur_iff < Num_iffs; cur_iff++)
+		{
+			iff_info *iff = &Iff_info[cur_iff];
+
+			// clear the iffs to be attacked
+			iff->attackee_bitmask = 0;
+			iff->attackee_bitmask_all_teams_at_war = 0;
+
+			// clear the observed colors
+			for (j = 0; j < MAX_IFFS; j++)
+				iff->observed_color_index[j] = -1;
+
+			// resolve the list names
+			for (int list_index = 0; list_index < MAX_IFFS; list_index++)
+			{
+				// are we within the number of attackees listed?
+				if (list_index < num_attack_names[cur_iff])
+				{
+					// find out who
+					int target_iff = iff_lookup(attack_names[cur_iff][list_index]);
+
+					// valid?
+					if (target_iff >= 0)
+						iff->attackee_bitmask |= iff_get_mask(target_iff);
+					else
+						Warning(LOCATION, "Attack target IFF %s not found for IFF %s in iff_defs.tbl!\n", attack_names[cur_iff][list_index], iff->iff_name);
+				}
+
+				// are we within the number of colors listed?
+				if (list_index < num_observed_colors[cur_iff])
+				{
+					// find out who
+					int target_iff = iff_lookup(observed_color_table[cur_iff][list_index].iff_name);
+
+					// valid?
+					if (target_iff >= 0)
+						iff->observed_color_index[target_iff] = observed_color_table[cur_iff][list_index].color_index;
+					else
+						Warning(LOCATION, "Observed color IFF %s not found for IFF %s in iff_defs.tbl!\n", observed_color_table[cur_iff][list_index].iff_name, iff->iff_name);
+				}
+			}
+
+			// resolve the all teams at war relationships
+			if (iff->flags & IFFF_EXEMPT_FROM_ALL_TEAMS_AT_WAR)
+			{
+				// exempt, so use standard attacks
+				iff->attackee_bitmask_all_teams_at_war = iff->attackee_bitmask;
+			}
+			else
+			{
+				// nonexempt, so build bitmask of all other nonexempt teams
+				for (int other_iff = 0; other_iff < Num_iffs; other_iff++)
+				{
+					// skip myself (unless I attack myself normally)
+					if ((other_iff == cur_iff) && !iff_x_attacks_y(cur_iff, cur_iff))
+						continue;
+
+					// skip anyone exempt
+					if (Iff_info[other_iff].flags & IFFF_EXEMPT_FROM_ALL_TEAMS_AT_WAR)
+						continue;
+
+					// add everyone else
+					iff->attackee_bitmask_all_teams_at_war |= iff_get_mask(other_iff);
+				}
+			}
+		}
+
+		// add tbl/tbm to multiplayer validation list
+		extern void fs2netd_add_table_validation(const char *tblname);
+		fs2netd_add_table_validation("iff_defs.tbl");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "iff_defs.tbl", e.what()));
 		return;
 	}
-
-	// Goober5000 - if table doesn't exist, use the default table
-	if (cf_exists_full("iff_defs.tbl", CF_TYPE_TABLES))
-		read_file_text("iff_defs.tbl", CF_TYPE_TABLES);
-	else
-		read_file_text_from_array(defaults_get_file("iff_defs.tbl"));
-
-	reset_parse();	
-
-	// parse the table --------------------------------------------------------
-
-	required_string("#IFFs");
-
-	// get the traitor
-	required_string("$Traitor IFF:");
-	stuff_string(traitor_name, F_NAME, NAME_LENGTH);
-
-	int rgb[3];
-
-	// check if alternate colours are wanted to be used for these
-	// Marks various stuff... like asteroids
-	if ((optional_string("$Selection Color:")) || (optional_string("$Selection Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		iff_init_color(rgb[0], rgb[1], rgb[2]);
-	}
-	else
-		iff_init_color(0xff, 0xff, 0xff);
-
-	// Marks the ship currently saying something
-	if ((optional_string("$Message Color:")) || (optional_string("$Message Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		iff_init_color(rgb[0], rgb[1], rgb[2]);
-	}
-	else
-		iff_init_color(0x7f, 0x7f, 0x7f);
-
-	// Marks the tagged ships
-	if ((optional_string("$Tagged Color:")) || (optional_string("$Tagged Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		iff_init_color(rgb[0], rgb[1], rgb[2]);
-	}
-	else
-		iff_init_color(0xff, 0xff, 0x00);
-
-	// init radar blips colour table
-	int a_bright,a_dim;
-	bool alternate_blip_color = false;
-	for (i=0;i<5;i++)
-	{
-		for (j=0;j<2;j++)
-		{
-			for (k=0;k<3;k++)
-			{
-				radar_iff_color[i][j][k] = -1;
-			}
-		}
-	}
-	
-	// if the bright/dim scaling is wanted to be changed
-	if (optional_string("$Dimmed IFF brightness:"))
-	{
-		int dim_iff_brightness;
-		stuff_int(&dim_iff_brightness);
-		Assert(dim_iff_brightness >= 0 && dim_iff_brightness <= HUD_COLOR_ALPHA_MAX);
-		*iff_color_brightness = dim_iff_brightness;
-	}
-	else
-		*iff_color_brightness = 4;
-
-	// alternate = use same method as with ship blips
-	// retail = use 1/2 intensities
-	if (optional_string("$Use Alternate Blip Coloring:") || optional_string("$Use Alternate Blip Colouring:"))
-	{
-		stuff_boolean(&alternate_blip_color);
-	}
-
-	// Parse blip colours, their order is hardcoded.
-	if ((optional_string("$Missile Blip Color:")) || (optional_string("$Missile Blip Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		for (i=0;i<3;i++)
-		{
-			Assert(rgb[i] >= 0 && rgb[i] <= 255);
-			radar_iff_color[0][1][i] = rgb[i];
-			radar_iff_color[0][0][i] = rgb[i]/2;
-		}
-	}		
-
-	if ((optional_string("$Navbuoy Blip Color:")) || (optional_string("$Navbuoy Blip Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		for (i=0;i<3;i++)
-		{
-			Assert(rgb[i] >= 0 && rgb[i] <= 255);
-			radar_iff_color[1][1][i] = rgb[i];
-			radar_iff_color[1][0][i] = rgb[i]/2;
-		}
-	}
-
-	if ((optional_string("$Warping Blip Color:")) || (optional_string("$Warping Blip Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		for (i=0;i<3;i++)
-		{
-			Assert(rgb[i] >= 0 && rgb[i] <= 255);
-			radar_iff_color[2][1][i] = rgb[i];
-			radar_iff_color[2][0][i] = rgb[i]/2;
-		}
-	}
-
-	if ((optional_string("$Node Blip Color:")) || (optional_string("$Node Blip Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		for (i=0;i<3;i++)
-		{
-			Assert(rgb[i] >= 0 && rgb[i] <= 255);
-			radar_iff_color[3][1][i] = rgb[i];
-			radar_iff_color[3][0][i] = rgb[i]/2;
-		}
-	}
-
-	if ((optional_string("$Tagged Blip Color:")) || (optional_string("$Tagged Blip Colour:")))
-	{
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		for (i=0;i<3;i++)
-		{
-			Assert(rgb[i] >= 0 && rgb[i] <= 255);
-			radar_iff_color[4][1][i] = rgb[i];
-			radar_iff_color[4][0][i] = rgb[i]/2;
-		}
-	}
-
-	if (alternate_blip_color == true)
-	{
-		a_bright = iff_get_alpha_value(true);
-		a_dim = iff_get_alpha_value(false);
-		for (i=0;i<5;i++)
-		{
-			if (radar_iff_color[i][0][0] >= 0)
-			{
-				for (j=0;j<3;j++)
-				{
-					radar_iff_color[i][0][j] = radar_iff_color[i][1][j];
-				}
-
-				radar_iff_color[i][1][3] = a_bright;
-				radar_iff_color[i][0][3] = a_dim;
-			}
-		}
-	}
-	else
-	{
-		for (i=0;i<5;i++)
-		{
-			if (radar_iff_color[i][0][0] >= 0)
-			{
-				radar_iff_color[i][0][3] = 255;
-				radar_iff_color[i][1][3] = 255;
-			}
-		}
-	}
-
-	if (optional_string("$Radar Target ID Flags:")) {
-		parse_string_flag_list((int*)&radar_target_id_flags, rti_flags, Num_rti_flags);
-		if (optional_string("+reset"))
-			radar_target_id_flags = 0;
-	}
-	
-	// begin reading data
-	Num_iffs = 0;
-	while (required_string_either("#End", "$IFF Name:"))
-	{
-		iff_info *iff;
-		int cur_iff;
-		
-		// make sure we're under the limit
-		if (Num_iffs >= MAX_IFFS)
-		{
-			Warning(LOCATION, "Too many iffs in iffs_defs.tbl!  Max is %d.\n", MAX_IFFS);
-			skip_to_start_of_string("#End", NULL);
-			break;
-		}
-
-		// add new IFF
-		iff = &Iff_info[Num_iffs];
-		cur_iff = Num_iffs;
-		Num_iffs++;
-
-
-		// get required IFF info ----------------------------------------------
-
-		// get the iff name
-		required_string("$IFF Name:");
-		stuff_string(iff->iff_name, F_NAME, NAME_LENGTH);
-
-		// get the iff color
-		if (check_for_string("$Colour:"))
-			required_string("$Colour:");
-		else
-			required_string("$Color:");
-		stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-		iff->color_index = iff_init_color(rgb[0], rgb[1], rgb[2]);
-
-
-		// get relationships between IFFs -------------------------------------
-
-		// get the list of iffs attacked
-		if (optional_string("$Attacks:"))
-			num_attack_names[cur_iff] = stuff_string_list(attack_names[cur_iff], MAX_IFFS);
-		else
-			num_attack_names[cur_iff] = 0;
-
-		// get the list of observed colors
-		num_observed_colors[cur_iff] = 0;
-		while (optional_string("+Sees"))
-		{
-			// get iff observed
-			stuff_string_until(observed_color_table[cur_iff][num_observed_colors[cur_iff]].iff_name, "As:", NAME_LENGTH);
-			required_string("As:");
-
-			// get color observed
-			stuff_int_list(rgb, 3, RAW_INTEGER_TYPE);
-			observed_color_table[cur_iff][num_observed_colors[cur_iff]].color_index = iff_init_color(rgb[0], rgb[1], rgb[2]);
-
-			// increment
-			num_observed_colors[cur_iff]++;
-		}
-
-
-		// get flags ----------------------------------------------------------
-
-		// get iff flags
-		iff->flags = 0;
-		if (optional_string("$Flags:"))
-		{
-			char flag_strings[MAX_IFF_FLAGS][NAME_LENGTH];
-
-			int num_strings = stuff_string_list(flag_strings, MAX_IFF_FLAGS);
-			for (string_idx = 0; string_idx < num_strings; string_idx++)
-			{
-				if (!stricmp(NOX("support allowed"), flag_strings[string_idx]))
-					iff->flags |= IFFF_SUPPORT_ALLOWED;
-				else if (!stricmp(NOX("exempt from all teams at war"), flag_strings[string_idx]))
-					iff->flags |= IFFF_EXEMPT_FROM_ALL_TEAMS_AT_WAR;
-				else if (!stricmp(NOX("orders hidden"), flag_strings[string_idx]))
-					iff->flags |= IFFF_ORDERS_HIDDEN;
-				else if (!stricmp(NOX("orders shown"), flag_strings[string_idx]))
-					iff->flags |= IFFF_ORDERS_SHOWN;
-				else if (!stricmp(NOX("wing name hidden"), flag_strings[string_idx]))
-					iff->flags |= IFFF_WING_NAME_HIDDEN;
-				else
-					Warning(LOCATION, "Bogus string in iff flags: %s\n", flag_strings[string_idx]);
-			}
-		}
-
-		// get default ship flags
-		iff->default_parse_flags = 0;
-		if (optional_string("$Default Ship Flags:"))
-		{
-			i = 0;
-			j = 0;
-			char flag_strings[MAX_PARSE_OBJECT_FLAGS][NAME_LENGTH];
-			int num_strings = stuff_string_list(flag_strings, MAX_PARSE_OBJECT_FLAGS);
-			for (i = 0; i < num_strings; i++)
-			{
-				for (j = 0; j < MAX_PARSE_OBJECT_FLAGS; j++)
-				{
-					if (!stricmp(flag_strings[i], Parse_object_flags[j]))
-					{
-						iff->default_parse_flags |= (1 << j);
-						break;
-					}
-				}
-			}
-
-			if (j == MAX_PARSE_OBJECT_FLAGS)
-				Warning(LOCATION, "Bogus string in iff default ship flags: %s\n", flag_strings[i]);
-		}
-
-		// again
-		iff->default_parse_flags2 = 0;
-		if (optional_string("$Default Ship Flags2:"))
-		{
-			i = 0;
-			j = 0;
-			char flag_strings[MAX_PARSE_OBJECT_FLAGS_2][NAME_LENGTH];
-			int num_strings = stuff_string_list(flag_strings, MAX_PARSE_OBJECT_FLAGS_2);
-			for (i = 0; i < num_strings; i++)
-			{
-				for (j = 0; j < MAX_PARSE_OBJECT_FLAGS_2; j++)
-				{
-					if (!stricmp(flag_strings[i], Parse_object_flags_2[j]))
-					{
-						iff->default_parse_flags2 |= (1 << j);
-						break;
-					}
-				}
-			}
-
-			if (j == MAX_PARSE_OBJECT_FLAGS_2)
-				Warning(LOCATION, "Bogus string in iff default ship flags2: %s\n", flag_strings[i]);
-		}
-
-		// this is cleared between each level but let's just set it here for thoroughness
-		iff->ai_rearm_timestamp = timestamp(-1);
-	}
-	
-	required_string("#End");
-
-
-	// now resolve the relationships ------------------------------------------
-
-	// first get the traitor
-	Iff_traitor = iff_lookup(traitor_name);
-	if (Iff_traitor < 0)
-	{
-		Iff_traitor = 0;
-		Warning(LOCATION, "Traitor IFF %s not found in iff_defs.tbl!  Defaulting to %s.\n", traitor_name, Iff_info[Iff_traitor].iff_name);
-	}
-
-	// next get the attackees and colors
-	for (int cur_iff = 0; cur_iff < Num_iffs; cur_iff++)
-	{
-		iff_info *iff = &Iff_info[cur_iff];
-
-		// clear the iffs to be attacked
-		iff->attackee_bitmask = 0;
-		iff->attackee_bitmask_all_teams_at_war = 0;
-
-		// clear the observed colors
-		for (j = 0; j < MAX_IFFS; j++)
-			iff->observed_color_index[j] = -1;
-
-		// resolve the list names
-		for (int list_index = 0; list_index < MAX_IFFS; list_index++)
-		{
-			// are we within the number of attackees listed?
-			if (list_index < num_attack_names[cur_iff])
-			{
-				// find out who
-				int target_iff = iff_lookup(attack_names[cur_iff][list_index]);
-
-				// valid?
-				if (target_iff >= 0)
-					iff->attackee_bitmask |= iff_get_mask(target_iff);
-				else
-					Warning(LOCATION, "Attack target IFF %s not found for IFF %s in iff_defs.tbl!\n", attack_names[cur_iff][list_index], iff->iff_name);
-			}
-
-			// are we within the number of colors listed?
-			if (list_index < num_observed_colors[cur_iff])
-			{
-				// find out who
-				int target_iff = iff_lookup(observed_color_table[cur_iff][list_index].iff_name);
-
-				// valid?
-				if (target_iff >= 0)
-					iff->observed_color_index[target_iff] = observed_color_table[cur_iff][list_index].color_index;
-				else
-					Warning(LOCATION, "Observed color IFF %s not found for IFF %s in iff_defs.tbl!\n", observed_color_table[cur_iff][list_index].iff_name, iff->iff_name);
-			}
-		}
-
-		// resolve the all teams at war relationships
-		if (iff->flags & IFFF_EXEMPT_FROM_ALL_TEAMS_AT_WAR)
-		{
-			// exempt, so use standard attacks
-			iff->attackee_bitmask_all_teams_at_war = iff->attackee_bitmask;
-		}
-		else
-		{
-			// nonexempt, so build bitmask of all other nonexempt teams
-			for (int other_iff = 0; other_iff < Num_iffs; other_iff++)
-			{
-				// skip myself (unless I attack myself normally)
-				if ((other_iff == cur_iff) && !iff_x_attacks_y(cur_iff, cur_iff))
-					continue;
-
-				// skip anyone exempt
-				if (Iff_info[other_iff].flags & IFFF_EXEMPT_FROM_ALL_TEAMS_AT_WAR)
-					continue;
-
-				// add everyone else
-				iff->attackee_bitmask_all_teams_at_war |= iff_get_mask(other_iff);
-			}
-		}
-	}
-
-	// add tbl/tbm to multiplayer validation list
-	extern void fs2netd_add_table_validation(const char *tblname);
-	fs2netd_add_table_validation("iff_defs.tbl");
 }
 
 /**

code/lab/lab.cpp

@@ -2243,6 +2243,7 @@ void labviewer_make_weap_window(Button* caller)
 			delete type_nodes[i];
 		}
 	}
+	delete[] type_nodes;
 
 	Lab_mode = LAB_MODE_WEAPON;
 

code/lab/wmcgui.cpp

@@ -142,32 +142,35 @@ bool ScreenClassInfoEntry::Parse()
 
 void GUISystem::ParseClassInfo(char* filename)
 {
-	int rval;
-
 	if (ClassInfoParsed) {
 		Warning(LOCATION, "Class info is being parsed twice");
 		DestroyClassInfo();
 	}
+	
+	try
+	{
+		read_file_text(filename);
+		reset_parse();
+		ScreenClassInfo.Parse();
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("WMCGUI: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+		bool flag;
+		do {
+			ScreenClassInfoEntry* sciep = new ScreenClassInfoEntry;
+			flag = sciep->Parse();
+			if (flag) {
+				list_append(&ScreenClassInfo, sciep);
+			} else {
+				delete sciep;
+			}
+		} while (flag);
+
+		ClassInfoParsed = true;
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("WMCGUI: Unable to parse '%s'!  Error code = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename);
-	reset_parse();
-	ScreenClassInfo.Parse();
-
-	bool flag;
-	do {
-		ScreenClassInfoEntry* sciep = new ScreenClassInfoEntry;
-		flag = sciep->Parse();
-		if (flag) {
-			list_append(&ScreenClassInfo, sciep);
-		}
-	} while(flag);
-
-	ClassInfoParsed = true;
 }
 
 void ClassInfoEntry::Parse(char* tag, int in_type)

code/localization/localize.cpp

@@ -112,7 +112,6 @@ void lcl_init(int lang_init)
 	char lang_string[128];
 	const char *ret;
 	int lang, idx, i;
-	int rval;
 
 	// initialize encryption
 	encrypt_init();
@@ -121,12 +120,14 @@ void lcl_init(int lang_init)
 	Lcl_languages.push_back(Lcl_builtin_languages[FS2_OPEN_DEFAULT_LANGUAGE]);
 
 	// check string.tbl to see which languages we support
-	if ( (rval = setjmp(parse_abort)) != 0 ) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "strings.tbl", rval));
-	}
-	else {
+	try
+	{
 		parse_stringstbl_quick("strings.tbl");
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "strings.tbl", e.what()));
+	}
 
 	parse_modular_table(NOX("*-lcl.tbm"), parse_stringstbl_quick);
 
@@ -147,7 +148,7 @@ void lcl_init(int lang_init)
 
 		if(ret == NULL){
 			Error(LOCATION, "Default language not found."); 
-		}		
+		}
 
 		strcpy_s(lang_string, ret);
 		
@@ -407,7 +408,7 @@ void parse_tstringstbl(const char *filename)
 // initialize the xstr table
 void lcl_xstr_init()
 {
-	int i, rval;
+	int i;
 
 
 	for (i = 0; i < XSTR_SIZE; i++)
@@ -417,18 +418,26 @@ void lcl_xstr_init()
 		Lcl_ext_str[i] = NULL;
 
 
-	if ( (rval = setjmp(parse_abort)) != 0 )
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "strings.tbl", rval));
-	else
+	try
+	{
 		parse_stringstbl("strings.tbl");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "strings.tbl", e.what()));
+	}
 
 	parse_modular_table(NOX("*-lcl.tbm"), parse_stringstbl);
 
 
-	if ( (rval = setjmp(parse_abort)) != 0 )
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "tstrings.tbl", rval));
-	else
+	try
+	{
 		parse_tstringstbl("tstrings.tbl");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "tstrings.tbl", e.what()));
+	}
 
 	parse_modular_table(NOX("*-tlc.tbm"), parse_tstringstbl);
 
@@ -1209,7 +1218,7 @@ void lcl_translate_brief_icon_name_gr(char *name)
 
 	} else if ((pos = strstr(name, "Transport")) != NULL) {
 		pos += 9;		// strlen of "transport"
-		strcpy_s(buf, "Transportowiec");
+		strcpy_s(buf, "Transporter");
 		strcat_s(buf, pos);
 		strcpy(name, buf);
 
@@ -1356,7 +1365,7 @@ char buf[128];
 
 	} else if ((pos = strstr(name, "Transport")) != NULL) {
 		pos += 9;		// strlen of "transport"
-		strcpy_s(buf, "Transporter");
+		strcpy_s(buf, "Transportowiec");
 		strcat_s(buf, pos);
 		strcpy(name, buf);
 

code/math/vecmat.cpp

@@ -225,7 +225,7 @@ vec3d *vm_vec_avg4(vec3d *dest,vec3d *src0,vec3d *src1,vec3d *src2,vec3d *src3)
 }
 
 
-//scales a vector in place.  returns ptr to vector
+//scales a vector in place.
 #ifndef _INLINE_VECMAT
 void vm_vec_scale(vec3d *dest,float s)
 {
@@ -236,7 +236,7 @@ void vm_vec_scale(vec3d *dest,float s)
 #endif
 
 
-//scales and copies a vector.  returns ptr to dest
+//scales and copies a vector.
 #ifndef _INLINE_VECMAT
 void vm_vec_copy_scale(vec3d *dest,vec3d *src,float s)
 {
@@ -288,7 +288,7 @@ void vm_vec_scale_sub2(vec3d *dest,vec3d *src,float k)
 }
 #endif
 
-//scales a vector in place, taking n/d for scale.  returns ptr to vector
+//scales a vector in place, taking n/d for scale.
 //dest *= n/d
 #ifndef _INLINE_VECMAT
 void vm_vec_scale2(vec3d *dest,float n,float d)

code/menuui/credits.cpp

@@ -279,133 +279,133 @@ int credits_screen_button_pressed(int n)
 }
 
 void credits_parse_table(const char* filename)
-{
-	int rval;
+{	
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	if ((rval = setjmp(parse_abort)) != 0)
-	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	}
-		
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	// any metadata?
-	if (optional_string("$Music:"))
-	{
-		stuff_string(Credits_music_name, F_NAME, NAME_LENGTH);
-	}
-	if (optional_string("$Number of Images:"))
-	{
-		int temp;
-		stuff_int(&temp);
-		if (temp > 0)
-			Credits_num_images = temp;
-	}
-	if (optional_string("$Start Image Index:"))
-	{
-		stuff_int(&Credits_artwork_index);
-
-		// bounds check
-		if (Credits_artwork_index < 0)
+		// any metadata?
+		if (optional_string("$Music:"))
 		{
-			Credits_artwork_index = 0;
+			stuff_string(Credits_music_name, F_NAME, NAME_LENGTH);
 		}
-		else if (Credits_artwork_index >= Credits_num_images)
+		if (optional_string("$Number of Images:"))
 		{
-			Credits_artwork_index = Credits_num_images - 1;
+			int temp;
+			stuff_int(&temp);
+			if (temp > 0)
+				Credits_num_images = temp;
 		}
-	}
-	if (optional_string("$Text scroll rate:"))
-	{
-		stuff_float(&Credits_scroll_rate);
-		if (Credits_scroll_rate < 0.01f)
-			Credits_scroll_rate = 0.01f;
-	}
-	if (optional_string("$Artworks display time:"))
-	{
-		stuff_float(&Credits_artwork_display_time);
-		if (Credits_artwork_display_time < 0.01f)
-			Credits_artwork_display_time = 0.01f;
-	}
-	if (optional_string("$Artworks fade time:"))
-	{
-		stuff_float(&Credits_artwork_fade_time);
-		if (Credits_artwork_fade_time < 0.01f)
-			Credits_artwork_fade_time = 0.01f;
-	}
-	if (optional_string("$SCP Credits position:"))
-	{
-		char mode[NAME_LENGTH];
-
-		stuff_string(mode, F_NAME, NAME_LENGTH);
-
-		if (!stricmp(mode, "Start"))
-			SCP_credits_position = START;
-		else if (!stricmp(mode, "End"))
-			SCP_credits_position = END;
-		else
-			Warning(LOCATION, "Unknown credits position mode \"%s\".", mode);
-	}
-
-	ignore_white_space();
-	
-	SCP_string credits_text;
-	SCP_string line;
-
-	SCP_vector<int> charNum;
-	SCP_vector<const char*> lines;
-	int numLines = -1;
-
-	bool first_run = true;
-	while(!check_for_string_raw("#end"))
-	{
-		// Read in a line of text			
-		stuff_string_line(line);
-
-		// This is a bit odd but it means if a total conversion uses different credits the 
-		// Volition credit won't happen
-		// Also don't append the default credits anymore when there was already a parsed table
-		if(first_run && !Credits_parsed && !line.compare(mod_check))
+		if (optional_string("$Start Image Index:"))
 		{
-			credits_text.append(unmodified_credits);
-		}
+			stuff_int(&Credits_artwork_index);
 
-		first_run = false;
-
-		if (line.empty())
-		{
-			// If the line is empty then just append a newline, don't bother with splitting it first
-			credits_text.append("\n");
-		}
-		else
-		{
-			// split_str doesn't take care of this.
-			charNum.clear();
-
-			// Split the string into multiple lines if it's too long
-			numLines = split_str(line.c_str(), Credits_text_coords[gr_screen.res][2], charNum, lines, -1);
-
-			// Make sure that we have valid data
-			Assertion(lines.size() == (size_t) numLines, "split_str reported %d lines but vector contains %d entries!", numLines, lines.size());
-
-			Assertion(lines.size() <= charNum.size(),
-				"Something has gone wrong while splitting strings. Got %d lines but only %d chacter lengths.",
-				lines.size(), charNum.size());
-
-			// Now add all splitted lines to the credit text and append a newline to the end
-			for (int i = 0; i < numLines; i++)
+			// bounds check
+			if (Credits_artwork_index < 0)
 			{
-				credits_text.append(SCP_string(lines[i], charNum[i]));
-				credits_text.append("\n");
+				Credits_artwork_index = 0;
+			}
+			else if (Credits_artwork_index >= Credits_num_images)
+			{
+				Credits_artwork_index = Credits_num_images - 1;
 			}
 		}
+		if (optional_string("$Text scroll rate:"))
+		{
+			stuff_float(&Credits_scroll_rate);
+			if (Credits_scroll_rate < 0.01f)
+				Credits_scroll_rate = 0.01f;
+		}
+		if (optional_string("$Artworks display time:"))
+		{
+			stuff_float(&Credits_artwork_display_time);
+			if (Credits_artwork_display_time < 0.01f)
+				Credits_artwork_display_time = 0.01f;
+		}
+		if (optional_string("$Artworks fade time:"))
+		{
+			stuff_float(&Credits_artwork_fade_time);
+			if (Credits_artwork_fade_time < 0.01f)
+				Credits_artwork_fade_time = 0.01f;
+		}
+		if (optional_string("$SCP Credits position:"))
+		{
+			char mode[NAME_LENGTH];
+
+			stuff_string(mode, F_NAME, NAME_LENGTH);
+
+			if (!stricmp(mode, "Start"))
+				SCP_credits_position = START;
+			else if (!stricmp(mode, "End"))
+				SCP_credits_position = END;
+			else
+				Warning(LOCATION, "Unknown credits position mode \"%s\".", mode);
+		}
+
+		ignore_white_space();
+
+		SCP_string credits_text;
+		SCP_string line;
+
+		SCP_vector<int> charNum;
+		SCP_vector<const char*> lines;
+		int numLines = -1;
+
+		bool first_run = true;
+		while (!check_for_string_raw("#end"))
+		{
+			// Read in a line of text			
+			stuff_string_line(line);
+
+			// This is a bit odd but it means if a total conversion uses different credits the 
+			// Volition credit won't happen
+			// Also don't append the default credits anymore when there was already a parsed table
+			if (first_run && !Credits_parsed && !line.compare(mod_check))
+			{
+				credits_text.append(unmodified_credits);
+			}
+
+			first_run = false;
+
+			if (line.empty())
+			{
+				// If the line is empty then just append a newline, don't bother with splitting it first
+				credits_text.append("\n");
+			}
+			else
+			{
+				// split_str doesn't take care of this.
+				charNum.clear();
+
+				// Split the string into multiple lines if it's too long
+				numLines = split_str(line.c_str(), Credits_text_coords[gr_screen.res][2], charNum, lines, -1);
+
+				// Make sure that we have valid data
+				Assertion(lines.size() == (size_t)numLines, "split_str reported %d lines but vector contains %d entries!", numLines, lines.size());
+
+				Assertion(lines.size() <= charNum.size(),
+					"Something has gone wrong while splitting strings. Got %d lines but only %d chacter lengths.",
+					lines.size(), charNum.size());
+
+				// Now add all splitted lines to the credit text and append a newline to the end
+				for (int i = 0; i < numLines; i++)
+				{
+					credits_text.append(SCP_string(lines[i], charNum[i]));
+					credits_text.append("\n");
+				}
+			}
+		}
+
+		Credit_text_parts.push_back(credits_text);
+
+		Credits_parsed = true;
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
-
-	Credit_text_parts.push_back(credits_text);
-
-	Credits_parsed = true;
 }
 
 void credits_parse()
@@ -645,10 +645,10 @@ void credits_close()
 	int i;
 
 	for (i=0; i<Credits_num_images; i++) {
-		if (Credits_bmps[i] >= 0) {
+		if (Credits_bmps[i] >= 0){
 			bm_release(Credits_bmps[i]);
 		}
-	}
+	}	
 	Credits_bmps.clear();
 
 	credits_stop_music(true);

code/menuui/mainhallmenu.cpp

@@ -2079,415 +2079,432 @@ void parse_main_hall_table(const char* filename)
 {
 	SCP_vector<main_hall_defines> temp_vector;
 	main_hall_defines *m, temp;
-	int idx, s_idx, m_idx, rval;
+	int idx, s_idx, m_idx;
 	int num_resolutions = 2;
 	unsigned int count;
 	char temp_string[MAX_FILENAME_LEN];
 	SCP_string temp_scp_string;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	}
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
 
-	read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	reset_parse();
-
-	if (optional_string("$Num Resolutions:")) {
-		stuff_int(&num_resolutions);
-	}
-
-	if (num_resolutions < 1) {
-		Error(LOCATION, "$Num Resolutions in %s is %d. (Must be 1 or greater)", filename, num_resolutions);
-	}
-
-	// go for it
-	count = Main_hall_defines.size();
-	while (!optional_string("#end")) {
-		Main_hall_defines.push_back(temp_vector);
-		// read in all resolutions
-		for (m_idx = 0; m_idx < num_resolutions; m_idx++) {
-			Main_hall_defines.at(count).push_back(temp);
-			m = &Main_hall_defines.at(count).at(m_idx);
-
-			// ready
-			required_string("$Main Hall");
-
-			// Parse the entry name for the first resolution, checking for duplicates and erroring if necessary
-			if (m_idx == 0) {
-				if (optional_string("+Name:")) {
-					stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
-
-					// we can't have two mainhalls with the same name
-					if (main_hall_get_pointer(temp_string) == NULL) {
-						m->name = temp_string;
-					} else {
-						Error(LOCATION, "A mainhall with the name '%s' already exists. All mainhalls must have unique names.", temp_string);
-					}
-				} else {
-					snprintf(temp_string, MAX_FILENAME_LEN, "%d", count);
-					m->name = temp_string;
-				}
-			} else {
-				if (optional_string("+Name:")) {
-					stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
-
-					/**
-					 * the reason that this is an error is that even if we were to change the names to match
-					 * it is very likely the user would get the wrong mainhall loaded since their campaign files 
-					 * may still refer to the entry with the incorrect name
-					 */
-					if (strcmp(temp_string, Main_hall_defines.at(count).at(0).name.c_str()) != 0) {
-						Error(LOCATION, "The mainhall '%s' has different names for different resolutions. All resolutions must have the same name. Either remove the hi-res entries' names entirely or set them to match the first resolution entry's name.", Main_hall_defines.at(0).at(count).name.c_str());
-					}
-				}
-
-				m->name = Main_hall_defines.at(count).at(0).name;
-			}
-
-			// add cheats
-			while (optional_string("+Cheat String:")) {
-				stuff_string(temp_scp_string, F_RAW);
-				m->cheat.push_back(temp_scp_string);
-
-				if(temp_scp_string.size() > MAIN_HALL_MAX_CHEAT_LEN) {
-					// Since the value is longer than the cheat buffer it will never match.
-
-					Warning(LOCATION, "The value '%s' for '+Cheat String:' is too long! It can be at most %d characters long.", temp_scp_string.size(), MAIN_HALL_MAX_CHEAT_LEN);
-				}
-
-				required_string("+Anim To Change:");
-				stuff_string(temp_scp_string, F_NAME);
-				m->cheat_anim_from.push_back(temp_scp_string);
-
-				required_string("+Anim To Change To:");
-				stuff_string(temp_scp_string, F_NAME);
-				m->cheat_anim_to.push_back(temp_scp_string);
-			}
-
-			// minimum resolution
-			if (optional_string("+Min Resolution:")) {
-				stuff_int(&m->min_width);
-				stuff_int(&m->min_height);
-			} else if (m_idx == 0) {
-				m->min_width = 0;
-				m->min_height = 0;
-			} else {
-				m->min_width = GR_1024_THRESHOLD_WIDTH;
-				m->min_height = GR_1024_THRESHOLD_HEIGHT;
-			}
-
-			// minimum aspect ratio
-			if (optional_string("+Min Aspect Ratio:")) {
-				stuff_float(&m->min_aspect_ratio);
-			} else {
-				m->min_aspect_ratio = 0.0f;
-			}
-
-			// bitmap and mask
-			required_string("+Bitmap:");
-			stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-			m->bitmap = temp_string;
-
-			required_string("+Mask:");
-			stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-			m->mask = temp_string;
-
-			required_string("+Music:");
-			stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-			m->music_name = temp_string;
-
-			// Goober5000
-			if (optional_string("+Substitute Music:")) {
-				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-				m->substitute_music_name = temp_string;
-			}
-
-			if (optional_string("+Help Overlay:")) {
-				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-				m->help_overlay_name = temp_string;
-			}
-
-			if (optional_string("+Help Overlay Resolution Index:")) {
-				stuff_int(&m->help_overlay_resolution_index);
-			} else {
-				m->help_overlay_resolution_index = m_idx;
-			}
-
-			// zoom area
-			if (optional_string("+Zoom To:")) {
-				stuff_int(&m->zoom_area_width);
-				stuff_int(&m->zoom_area_height);
-			} else {
-				m->zoom_area_width = -1;
-				m->zoom_area_height = -1;
-			}
-
-			// intercom sounds
-			required_string("+Num Intercom Sounds:");
-			stuff_int(&m->num_random_intercom_sounds);
-
-			// initialise intercom sounds vectors
-			intercom_sounds_init(*m);
-
-			for (idx = 0; idx < m->num_random_intercom_sounds; idx++) {
-				// intercom delay
-				required_string("+Intercom delay:");
-				stuff_int(&m->intercom_delay.at(idx).at(0));
-				stuff_int(&m->intercom_delay.at(idx).at(1));
-			}
-
-			for (idx = 0; idx < m->num_random_intercom_sounds; idx++) {
-				// intercom sound id
-				parse_sound("+Intercom sound:", &m->intercom_sounds.at(idx), "+Intercom sound:", PARSE_SOUND_INTERFACE_SOUND);
-			}
-
-			for (idx = 0; idx < m->num_random_intercom_sounds; idx++) {
-				// intercom pan
-				required_string("+Intercom pan:");
-				stuff_float(&m->intercom_sound_pan.at(idx));
-			}
-
-			// misc animations
-			required_string("+Num Misc Animations:");
-			stuff_int(&m->num_misc_animations);
-
-			// initialise the misc anim vectors
-			misc_anim_init(*m);
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim names
-				required_string("+Misc anim:");
-				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-				m->misc_anim_name.at(idx) = (SCP_string)temp_string;
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim groups, optionally
-				if (optional_string("+Misc anim group:")) {
-					stuff_int(&m->misc_anim_group.at(idx));
-				} else {
-					m->misc_anim_group.at(idx) = -1;
-				}
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim delay
-				required_string("+Misc anim delay:");
-				stuff_int(&m->misc_anim_delay.at(idx).at(0));
-				stuff_int(&m->misc_anim_delay.at(idx).at(1));
-				stuff_int(&m->misc_anim_delay.at(idx).at(2));
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim coords
-				required_string("+Misc anim coords:");
-				stuff_int(&m->misc_anim_coords.at(idx).at(0));
-				stuff_int(&m->misc_anim_coords.at(idx).at(1));
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim mode
-				required_string("+Misc anim mode:");
-				stuff_int(&m->misc_anim_modes.at(idx));
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim pan
-				required_string("+Misc anim pan:");
-				stuff_float(&m->misc_anim_sound_pan.at(idx));
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim sound id
-				parse_sound_list("+Misc anim sounds:", m->misc_anim_special_sounds.at(idx), "+Misc anim sounds:", PARSE_SOUND_INTERFACE_SOUND);
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim sound triggers
-				required_string("+Misc anim trigger:");
-				int temp_int = 0;
-				stuff_int(&temp_int);
-				for (s_idx = 0; s_idx < temp_int; s_idx++) {
-					m->misc_anim_special_trigger.at(idx).push_back(0);
-					stuff_int(&m->misc_anim_special_trigger.at(idx).at(s_idx));
-				}
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim sound handles - deprecated, but deal with it just in case
-				if (optional_string("+Misc anim handles:")) {
-					advance_to_eoln(NULL);
-				}
-			}
-
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// anim sound flags - table flag deprecated, so ignore user input
-				if (optional_string("+Misc anim flags:")) {
-					advance_to_eoln(NULL);
-				}
-
-				// we need one flag for each sound
-				Assert(m->misc_anim_special_sounds.at(idx).size() < INT_MAX);
-				for (s_idx = 0; s_idx < (int)m->misc_anim_special_sounds.at(idx).size(); s_idx++) {
-					m->misc_anim_sound_flag.at(idx).push_back(0);
-				}
-			}
-			
-			for (idx = 0; idx < m->num_misc_animations; idx++) {
-				// render over doors - default to false
-
-				if (optional_string("+Misc anim over doors:")) {
-					bool temp_b;
-					stuff_boolean(&temp_b);
-					m->misc_anim_over_doors.push_back(temp_b);
-				} else {
-					m->misc_anim_over_doors.push_back(0);
-				}
-			}
-
-			region_info_init(*m);
-			
-			// door animations
-			required_string("+Num Door Animations:");
-			stuff_int(&m->num_door_animations);
-
-			// initialise the door anim vectors
-			door_anim_init(*m);
-
-			for (idx = 0; idx < m->num_door_animations; idx++) {
-				// door name
-				required_string("+Door anim:");
-				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
-				m->door_anim_name.at(idx) = (SCP_string)temp_string;
-			}
-
-			for (idx = 0; idx < m->num_door_animations; idx++) {
-				// door coords
-				required_string("+Door coords:");
-				stuff_int(&m->door_anim_coords.at(idx).at(0));
-				stuff_int(&m->door_anim_coords.at(idx).at(1));
-				stuff_int(&m->door_anim_coords.at(idx).at(2));
-				stuff_int(&m->door_anim_coords.at(idx).at(3));
-			}
-
-			for (idx = 0; idx < m->num_door_animations; idx++) {
-				// door open and close sounds
-				parse_sound_list("+Door sounds:", m->door_sounds.at(idx), "+Door sounds:", (parse_sound_flags)(PARSE_SOUND_INTERFACE_SOUND | PARSE_SOUND_SCP_SOUND_LIST));
-			}
-
-			for (idx = 0; idx < m->num_door_animations; idx++) {
-				// door pan value
-				required_string("+Door pan:");
-				stuff_float(&m->door_sound_pan[idx]);
-			}
-
-			int mask;
-			for (idx = 0; optional_string("+Door mask value:"); idx++) {
-				// door mask
-				stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
-				
-				mask = (int) strtol(temp_string, NULL, 0);
-				mask = 255 - mask;
-				
-				if(idx >= (int) m->regions.size()) {
-					m->regions.resize(idx + 1);
-				}
-				m->regions[idx].mask = mask;
-			}
-			
-			for (idx = 0; optional_string("+Door action:"); idx++) {
-				// door action
-				
-				if(idx >= (int) m->regions.size()) {
-					m->regions.resize(idx + 1);
-				}
-				
-				if (optional_string("Script")) {
-					m->regions[idx].action = SCRIPT_REGION;
-					stuff_string(m->regions[idx].lua_action, F_RAW);
-				} else {
-					stuff_string(temp_scp_string, F_RAW);
-					
-					int action = -1;
-					for (int i = 0; Main_hall_region_map[i].name != NULL; i++) {
-						if (temp_scp_string == Main_hall_region_map[i].name) {
-							action = Main_hall_region_map[i].mask;
-							break;
-						}
-					}
-					
-					if (action == -1) {
-						SCP_string err_msg = "";
-						for (int i = 0; Main_hall_region_map[i].name != NULL; i++) {
-							if (i != 0) {
-								err_msg += ", ";
-							}
-							err_msg += Main_hall_region_map[i].name;
-						}
-						
-						Error(LOCATION, "Unkown Door Region '%s'! Expected one of: %s", temp_scp_string.c_str(), err_msg.c_str());
-					}
-					
-					m->regions[idx].action = action;
-				}
-			}
-
-			for (idx = 0; optional_string("+Door key:"); idx++) {
-				// door key
-				stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
-
-				if ((int) m->regions.size() <= idx) {
-					m->regions.resize(idx + 1);
-				}
-				m->regions[idx].key = temp_string[0];
-			}
-
-			for (idx = 0; optional_string("+Door description:"); idx++) {
-				// region description (tooltip)
-				stuff_string(temp_scp_string, F_MESSAGE);
-
-				if (temp_scp_string != "default") {
-					if(idx >= (int) m->regions.size()) {
-						m->regions.resize(idx + 1);
-					}
-					
-					m->regions[idx].description = temp_scp_string;
-					
-					if (idx == 2) {
-						m->default_readyroom = false;
-					}
-				}
-			}
-
-			// font for tooltips and other text
-			if (optional_string("+Font:")) {
-				stuff_int(&m->font);
-			} else {
-				m->font = FONT1;
-			}
-
-			// tooltip padding
-			if (optional_string("+Tooltip Padding:")) {
-				stuff_int(&m->tooltip_padding);
-			} else {
-				m->tooltip_padding = -1; // we'll get the default value later
-			}
-
-			// tooltip y location
-			if (optional_string("+Tooltip Y:")) {
-				stuff_int(&m->region_yval);
-			} else {
-				m->region_yval = -1;
-			}
+		if (optional_string("$Num Resolutions:")) {
+			stuff_int(&num_resolutions);
 		}
 
-		count++;
-	}
+		if (num_resolutions < 1) {
+			Error(LOCATION, "$Num Resolutions in %s is %d. (Must be 1 or greater)", filename, num_resolutions);
+		}
 
-	// free up memory from parsing the mainhall tbl
-	stop_parse();
+		// go for it
+		count = Main_hall_defines.size();
+		while (!optional_string("#end")) {
+			Main_hall_defines.push_back(temp_vector);
+			// read in all resolutions
+			for (m_idx = 0; m_idx < num_resolutions; m_idx++) {
+				Main_hall_defines.at(count).push_back(temp);
+				m = &Main_hall_defines.at(count).at(m_idx);
+
+				// ready
+				required_string("$Main Hall");
+
+				// Parse the entry name for the first resolution, checking for duplicates and erroring if necessary
+				if (m_idx == 0) {
+					if (optional_string("+Name:")) {
+						stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
+
+						// we can't have two mainhalls with the same name
+						if (main_hall_get_pointer(temp_string) == NULL) {
+							m->name = temp_string;
+						}
+						else {
+							Error(LOCATION, "A mainhall with the name '%s' already exists. All mainhalls must have unique names.", temp_string);
+						}
+					}
+					else {
+						snprintf(temp_string, MAX_FILENAME_LEN, "%d", count);
+						m->name = temp_string;
+					}
+				}
+				else {
+					if (optional_string("+Name:")) {
+						stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
+
+						/**
+						 * the reason that this is an error is that even if we were to change the names to match
+						 * it is very likely the user would get the wrong mainhall loaded since their campaign files
+						 * may still refer to the entry with the incorrect name
+						 */
+						if (strcmp(temp_string, Main_hall_defines.at(count).at(0).name.c_str()) != 0) {
+							Error(LOCATION, "The mainhall '%s' has different names for different resolutions. All resolutions must have the same name. Either remove the hi-res entries' names entirely or set them to match the first resolution entry's name.", Main_hall_defines.at(0).at(count).name.c_str());
+						}
+					}
+
+					m->name = Main_hall_defines.at(count).at(0).name;
+				}
+
+				// add cheats
+				while (optional_string("+Cheat String:")) {
+					stuff_string(temp_scp_string, F_RAW);
+					m->cheat.push_back(temp_scp_string);
+
+					if (temp_scp_string.size() > MAIN_HALL_MAX_CHEAT_LEN) {
+						// Since the value is longer than the cheat buffer it will never match.
+
+						Warning(LOCATION, "The value '%s' for '+Cheat String:' is too long! It can be at most %d characters long.", temp_scp_string.size(), MAIN_HALL_MAX_CHEAT_LEN);
+					}
+
+					required_string("+Anim To Change:");
+					stuff_string(temp_scp_string, F_NAME);
+					m->cheat_anim_from.push_back(temp_scp_string);
+
+					required_string("+Anim To Change To:");
+					stuff_string(temp_scp_string, F_NAME);
+					m->cheat_anim_to.push_back(temp_scp_string);
+				}
+
+				// minimum resolution
+				if (optional_string("+Min Resolution:")) {
+					stuff_int(&m->min_width);
+					stuff_int(&m->min_height);
+				}
+				else if (m_idx == 0) {
+					m->min_width = 0;
+					m->min_height = 0;
+				}
+				else {
+					m->min_width = GR_1024_THRESHOLD_WIDTH;
+					m->min_height = GR_1024_THRESHOLD_HEIGHT;
+				}
+
+				// minimum aspect ratio
+				if (optional_string("+Min Aspect Ratio:")) {
+					stuff_float(&m->min_aspect_ratio);
+				}
+				else {
+					m->min_aspect_ratio = 0.0f;
+				}
+
+				// bitmap and mask
+				required_string("+Bitmap:");
+				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+				m->bitmap = temp_string;
+
+				required_string("+Mask:");
+				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+				m->mask = temp_string;
+
+				required_string("+Music:");
+				stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+				m->music_name = temp_string;
+
+				// Goober5000
+				if (optional_string("+Substitute Music:")) {
+					stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+					m->substitute_music_name = temp_string;
+				}
+
+				if (optional_string("+Help Overlay:")) {
+					stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+					m->help_overlay_name = temp_string;
+				}
+
+				if (optional_string("+Help Overlay Resolution Index:")) {
+					stuff_int(&m->help_overlay_resolution_index);
+				}
+				else {
+					m->help_overlay_resolution_index = m_idx;
+				}
+
+				// zoom area
+				if (optional_string("+Zoom To:")) {
+					stuff_int(&m->zoom_area_width);
+					stuff_int(&m->zoom_area_height);
+				}
+				else {
+					m->zoom_area_width = -1;
+					m->zoom_area_height = -1;
+				}
+
+				// intercom sounds
+				required_string("+Num Intercom Sounds:");
+				stuff_int(&m->num_random_intercom_sounds);
+
+				// initialise intercom sounds vectors
+				intercom_sounds_init(*m);
+
+				for (idx = 0; idx < m->num_random_intercom_sounds; idx++) {
+					// intercom delay
+					required_string("+Intercom delay:");
+					stuff_int(&m->intercom_delay.at(idx).at(0));
+					stuff_int(&m->intercom_delay.at(idx).at(1));
+				}
+
+				for (idx = 0; idx < m->num_random_intercom_sounds; idx++) {
+					// intercom sound id
+					parse_sound("+Intercom sound:", &m->intercom_sounds.at(idx), "+Intercom sound:", PARSE_SOUND_INTERFACE_SOUND);
+				}
+
+				for (idx = 0; idx < m->num_random_intercom_sounds; idx++) {
+					// intercom pan
+					required_string("+Intercom pan:");
+					stuff_float(&m->intercom_sound_pan.at(idx));
+				}
+
+				// misc animations
+				required_string("+Num Misc Animations:");
+				stuff_int(&m->num_misc_animations);
+
+				// initialise the misc anim vectors
+				misc_anim_init(*m);
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim names
+					required_string("+Misc anim:");
+					stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+					m->misc_anim_name.at(idx) = (SCP_string)temp_string;
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim groups, optionally
+					if (optional_string("+Misc anim group:")) {
+						stuff_int(&m->misc_anim_group.at(idx));
+					}
+					else {
+						m->misc_anim_group.at(idx) = -1;
+					}
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim delay
+					required_string("+Misc anim delay:");
+					stuff_int(&m->misc_anim_delay.at(idx).at(0));
+					stuff_int(&m->misc_anim_delay.at(idx).at(1));
+					stuff_int(&m->misc_anim_delay.at(idx).at(2));
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim coords
+					required_string("+Misc anim coords:");
+					stuff_int(&m->misc_anim_coords.at(idx).at(0));
+					stuff_int(&m->misc_anim_coords.at(idx).at(1));
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim mode
+					required_string("+Misc anim mode:");
+					stuff_int(&m->misc_anim_modes.at(idx));
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim pan
+					required_string("+Misc anim pan:");
+					stuff_float(&m->misc_anim_sound_pan.at(idx));
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim sound id
+					parse_sound_list("+Misc anim sounds:", m->misc_anim_special_sounds.at(idx), "+Misc anim sounds:", PARSE_SOUND_INTERFACE_SOUND);
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim sound triggers
+					required_string("+Misc anim trigger:");
+					int temp_int = 0;
+					stuff_int(&temp_int);
+					for (s_idx = 0; s_idx < temp_int; s_idx++) {
+						m->misc_anim_special_trigger.at(idx).push_back(0);
+						stuff_int(&m->misc_anim_special_trigger.at(idx).at(s_idx));
+					}
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim sound handles - deprecated, but deal with it just in case
+					if (optional_string("+Misc anim handles:")) {
+						advance_to_eoln(NULL);
+					}
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// anim sound flags - table flag deprecated, so ignore user input
+					if (optional_string("+Misc anim flags:")) {
+						advance_to_eoln(NULL);
+					}
+
+					// we need one flag for each sound
+					Assert(m->misc_anim_special_sounds.at(idx).size() < INT_MAX);
+					for (s_idx = 0; s_idx < (int)m->misc_anim_special_sounds.at(idx).size(); s_idx++) {
+						m->misc_anim_sound_flag.at(idx).push_back(0);
+					}
+				}
+
+				for (idx = 0; idx < m->num_misc_animations; idx++) {
+					// render over doors - default to false
+
+					if (optional_string("+Misc anim over doors:")) {
+						bool temp_b;
+						stuff_boolean(&temp_b);
+						m->misc_anim_over_doors.push_back(temp_b);
+					}
+					else {
+						m->misc_anim_over_doors.push_back(0);
+					}
+				}
+
+				region_info_init(*m);
+
+				// door animations
+				required_string("+Num Door Animations:");
+				stuff_int(&m->num_door_animations);
+
+				// initialise the door anim vectors
+				door_anim_init(*m);
+
+				for (idx = 0; idx < m->num_door_animations; idx++) {
+					// door name
+					required_string("+Door anim:");
+					stuff_string(temp_string, F_NAME, MAX_FILENAME_LEN);
+					m->door_anim_name.at(idx) = (SCP_string)temp_string;
+				}
+
+				for (idx = 0; idx < m->num_door_animations; idx++) {
+					// door coords
+					required_string("+Door coords:");
+					stuff_int(&m->door_anim_coords.at(idx).at(0));
+					stuff_int(&m->door_anim_coords.at(idx).at(1));
+					stuff_int(&m->door_anim_coords.at(idx).at(2));
+					stuff_int(&m->door_anim_coords.at(idx).at(3));
+				}
+
+				for (idx = 0; idx < m->num_door_animations; idx++) {
+					// door open and close sounds
+					parse_sound_list("+Door sounds:", m->door_sounds.at(idx), "+Door sounds:", (parse_sound_flags)(PARSE_SOUND_INTERFACE_SOUND | PARSE_SOUND_SCP_SOUND_LIST));
+				}
+
+				for (idx = 0; idx < m->num_door_animations; idx++) {
+					// door pan value
+					required_string("+Door pan:");
+					stuff_float(&m->door_sound_pan[idx]);
+				}
+
+				int mask;
+				for (idx = 0; optional_string("+Door mask value:"); idx++) {
+					// door mask
+					stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
+
+					mask = (int)strtol(temp_string, NULL, 0);
+					mask = 255 - mask;
+
+					if (idx >= (int)m->regions.size()) {
+						m->regions.resize(idx + 1);
+					}
+					m->regions[idx].mask = mask;
+				}
+
+				for (idx = 0; optional_string("+Door action:"); idx++) {
+					// door action
+
+					if (idx >= (int)m->regions.size()) {
+						m->regions.resize(idx + 1);
+					}
+
+					if (optional_string("Script")) {
+						m->regions[idx].action = SCRIPT_REGION;
+						stuff_string(m->regions[idx].lua_action, F_RAW);
+					}
+					else {
+						stuff_string(temp_scp_string, F_RAW);
+
+						int action = -1;
+						for (int i = 0; Main_hall_region_map[i].name != NULL; i++) {
+							if (temp_scp_string == Main_hall_region_map[i].name) {
+								action = Main_hall_region_map[i].mask;
+								break;
+							}
+						}
+
+						if (action == -1) {
+							SCP_string err_msg = "";
+							for (int i = 0; Main_hall_region_map[i].name != NULL; i++) {
+								if (i != 0) {
+									err_msg += ", ";
+								}
+								err_msg += Main_hall_region_map[i].name;
+							}
+
+							Error(LOCATION, "Unkown Door Region '%s'! Expected one of: %s", temp_scp_string.c_str(), err_msg.c_str());
+						}
+
+						m->regions[idx].action = action;
+					}
+				}
+
+				for (idx = 0; optional_string("+Door key:"); idx++) {
+					// door key
+					stuff_string(temp_string, F_RAW, MAX_FILENAME_LEN);
+
+					if ((int)m->regions.size() <= idx) {
+						m->regions.resize(idx + 1);
+					}
+					m->regions[idx].key = temp_string[0];
+				}
+
+				for (idx = 0; optional_string("+Door description:"); idx++) {
+					// region description (tooltip)
+					stuff_string(temp_scp_string, F_MESSAGE);
+
+					if (temp_scp_string != "default") {
+						if (idx >= (int)m->regions.size()) {
+							m->regions.resize(idx + 1);
+						}
+
+						m->regions[idx].description = temp_scp_string;
+
+						if (idx == 2) {
+							m->default_readyroom = false;
+						}
+					}
+				}
+
+				// font for tooltips and other text
+				if (optional_string("+Font:")) {
+					stuff_int(&m->font);
+				}
+				else {
+					m->font = FONT1;
+				}
+
+				// tooltip padding
+				if (optional_string("+Tooltip Padding:")) {
+					stuff_int(&m->tooltip_padding);
+				}
+				else {
+					m->tooltip_padding = -1; // we'll get the default value later
+				}
+
+				// tooltip y location
+				if (optional_string("+Tooltip Y:")) {
+					stuff_int(&m->region_yval);
+				}
+				else {
+					m->region_yval = -1;
+				}
+			}
+
+			count++;
+		}
+
+		// free up memory from parsing the mainhall tbl
+		stop_parse();
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
+	}
 }
 
 /**

code/menuui/playermenu.cpp

@@ -1292,25 +1292,26 @@ int Player_tips_shown = 0;
 // tooltips
 void player_tips_init()
 {
-	int rval;
-
 	Num_player_tips = 0;
+	
+	try
+	{
+		read_file_text("tips.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "tips.tbl", rval));
-		return;
-	}
+		while (!optional_string("#end")) {
+			required_string("+Tip:");
 
-	read_file_text("tips.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	while(!optional_string("#end")) {
-		required_string("+Tip:");
-
-		if(Num_player_tips >= MAX_PLAYER_TIPS) {
-			break;
+			if (Num_player_tips >= MAX_PLAYER_TIPS) {
+				break;
+			}
+			Player_tips[Num_player_tips++] = stuff_and_malloc_string(F_NAME, NULL);
 		}
-		Player_tips[Num_player_tips++] = stuff_and_malloc_string(F_NAME, NULL);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "tips.tbl", e.what()));
+		return;
 	}
 }
 

code/menuui/techmenu.cpp

@@ -1026,51 +1026,54 @@ int techroom_load_ani(anim **animpp, char *name)
 
 void techroom_intel_init()
 {
-	int rval, temp;
+	int  temp;
 	static int inited = 0;
 
 	if (inited)
 		return;
+		
+	try
+	{
+		read_file_text("species.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "species.tbl", rval));
+		Intel_info_size = 0;
+		while (optional_string("$Entry:")) {
+			Assert(Intel_info_size < MAX_INTEL_ENTRIES);
+			if (Intel_info_size >= MAX_INTEL_ENTRIES) {
+				mprintf(("TECHMENU: Too many intel entries!\n"));
+				break;
+			}
+
+			Intel_info[Intel_info_size].flags = IIF_DEFAULT_VALUE;
+
+			required_string("$Name:");
+			stuff_string(Intel_info[Intel_info_size].name, F_NAME, NAME_LENGTH);
+
+			required_string("$Anim:");
+			stuff_string(Intel_info[Intel_info_size].anim_filename, F_NAME, NAME_LENGTH);
+
+			required_string("$AlwaysInTechRoom:");
+			stuff_int(&temp);
+			if (temp) {
+				// set default to align with what we read - Goober5000
+				Intel_info[Intel_info_size].flags |= IIF_IN_TECH_DATABASE;
+				Intel_info[Intel_info_size].flags |= IIF_DEFAULT_IN_TECH_DATABASE;
+			}
+
+			required_string("$Description:");
+			stuff_string(Intel_info[Intel_info_size].desc, F_MULTITEXT, TECH_INTEL_DESC_LEN);
+
+			Intel_info_size++;
+		}
+
+		inited = 1;
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "species.tbl", e.what()));
 		return;
 	}
-	
-	read_file_text("species.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	Intel_info_size = 0;
-	while (optional_string("$Entry:")) {
-		Assert(Intel_info_size < MAX_INTEL_ENTRIES);
-		if (Intel_info_size >= MAX_INTEL_ENTRIES) {
-			mprintf(("TECHMENU: Too many intel entries!\n"));
-			break;
-		}
-
-		Intel_info[Intel_info_size].flags = IIF_DEFAULT_VALUE;
-
-		required_string("$Name:");
-		stuff_string(Intel_info[Intel_info_size].name, F_NAME, NAME_LENGTH);
-
-		required_string("$Anim:");
-		stuff_string(Intel_info[Intel_info_size].anim_filename, F_NAME, NAME_LENGTH);
-
-		required_string("$AlwaysInTechRoom:");
-		stuff_int(&temp);
-		if (temp) {
-			// set default to align with what we read - Goober5000
-			Intel_info[Intel_info_size].flags |= IIF_IN_TECH_DATABASE;
-			Intel_info[Intel_info_size].flags |= IIF_DEFAULT_IN_TECH_DATABASE;
-		}
-
-		required_string("$Description:");
-		stuff_string(Intel_info[Intel_info_size].desc, F_MULTITEXT, TECH_INTEL_DESC_LEN);
-
-		Intel_info_size++;
-	}
-
-	inited = 1;
 }
 
 void techroom_init()

code/mission/missionbriefcommon.cpp

@@ -274,77 +274,78 @@ int brief_text_wipe_finished();
 //
 void brief_parse_icon_tbl()
 {
-	int rval, icon;
+	int icon;
 	size_t species;
 	char name[MAX_FILENAME_LEN];
 
 	Assert(!Species_info.empty());
 	const size_t max_icons = Species_info.size() * MIN_BRIEF_ICONS;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "icons.tbl", rval));
-
-		return;
-	}
-
-	read_file_text("icons.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	required_string("#Start");
-
-	Briefing_icon_info.clear();
-	while (required_string_either("#End","$Name:"))
+	try
 	{
-		if(Briefing_icon_info.size() >= max_icons) {
-			Warning(LOCATION, "Too many icons in icons.tbl; only the first %d will be used", max_icons);
-			skip_to_start_of_string("#End");
-			break;
-		}
+		read_file_text("icons.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-		briefing_icon_info bii;
+		required_string("#Start");
 
-		// parse regular frames
-		required_string("$Name:");
-		stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-		generic_anim_init(&bii.regular, name);
-	
-		// parse fade frames
-		required_string("$Name:");
-		stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-		hud_anim_init(&bii.fade, 0, 0, name);
-
-		// parse highlighting frames
-		required_string("$Name:");
-		stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-		hud_anim_init(&bii.highlight, 0, 0, name);
-
-		// add it to the collection
-		Briefing_icon_info.push_back(bii);
-	}
-	required_string("#End");
-
-
-	// now assign the icons to their species
-	const size_t num_species_covered = Briefing_icon_info.size() / MIN_BRIEF_ICONS;
-	size_t bii_index = 0;
-	for (icon = 0; icon < MIN_BRIEF_ICONS; icon++)
-	{
-		for (species = 0; species < num_species_covered; species++)
-			Species_info[species].bii_index[icon] = bii_index++;
-	}
-
-	// error check
-	if (num_species_covered < Species_info.size())
-	{
-		SCP_string errormsg = "The following species are missing icon info in icons.tbl:\n";
-
-		for (species = num_species_covered; species < Species_info.size(); species++)
+		Briefing_icon_info.clear();
+		while (required_string_either("#End", "$Name:"))
 		{
-			errormsg += Species_info[species].species_name;
-			errormsg += "\n";
+			if (Briefing_icon_info.size() >= max_icons) {
+				Warning(LOCATION, "Too many icons in icons.tbl; only the first %d will be used", max_icons);
+				skip_to_start_of_string("#End");
+				break;
+			}
+
+			briefing_icon_info bii;
+
+			// parse regular frames
+			required_string("$Name:");
+			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+			generic_anim_init(&bii.regular, name);
+
+			// parse fade frames
+			required_string("$Name:");
+			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+			hud_anim_init(&bii.fade, 0, 0, name);
+
+			// parse highlighting frames
+			required_string("$Name:");
+			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+			hud_anim_init(&bii.highlight, 0, 0, name);
+
+			// add it to the collection
+			Briefing_icon_info.push_back(bii);
+		}
+		required_string("#End");
+
+
+		// now assign the icons to their species
+		const size_t num_species_covered = Briefing_icon_info.size() / MIN_BRIEF_ICONS;
+		size_t bii_index = 0;
+		for (icon = 0; icon < MIN_BRIEF_ICONS; icon++)
+		{
+			for (species = 0; species < num_species_covered; species++)
+				Species_info[species].bii_index[icon] = bii_index++;
 		}
 
-		Error(LOCATION, errormsg.c_str());
+		// error check
+		if (num_species_covered < Species_info.size())
+		{
+			SCP_string errormsg = "The following species are missing icon info in icons.tbl:\n";
+
+			for (species = num_species_covered; species < Species_info.size(); species++)
+			{
+				errormsg += Species_info[species].species_name;
+				errormsg += "\n";
+			}
+
+			Error(LOCATION, errormsg.c_str());
+		}
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "icons.tbl", e.what()));
 	}
 }
 

code/mission/missioncampaign.cpp

@@ -100,7 +100,7 @@ bool campaign_is_ignored(const char *filename);
  */
 int mission_campaign_get_info(const char *filename, char *name, int *type, int *max_players, char **desc)
 {
-	int rval, i, success = 0;
+	int i, success = 0;
 	char campaign_type[NAME_LENGTH], fname[MAX_FILENAME_LEN];
 
 	Assert( name != NULL );
@@ -116,53 +116,57 @@ int mission_campaign_get_info(const char *filename, char *name, int *type, int *
 
 	*type = -1;
 	do {
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error code = %i.\n", fname, rval));
-			break;
-		}
+		try
+		{
+			read_file_text(fname);
+			reset_parse();
 
-		read_file_text(fname);
-		reset_parse();
+			required_string("$Name:");
+			stuff_string(name, F_NAME, NAME_LENGTH);
+			if (name == NULL) {
+				nprintf(("Warning", "No name found for campaign file %s\n", filename));
+				break;
+			}
 
-		required_string("$Name:");
-		stuff_string( name, F_NAME, NAME_LENGTH );
-		if (name == NULL) {
-			nprintf(("Warning", "No name found for campaign file %s\n", filename));
-			break;
-		}
+			required_string("$Type:");
+			stuff_string(campaign_type, F_NAME, NAME_LENGTH);
 
-		required_string("$Type:");
-		stuff_string( campaign_type, F_NAME, NAME_LENGTH );
+			for (i = 0; i < MAX_CAMPAIGN_TYPES; i++) {
+				if (!stricmp(campaign_type, campaign_types[i])) {
+					*type = i;
+				}
+			}
 
-		for (i=0; i<MAX_CAMPAIGN_TYPES; i++) {
-			if ( !stricmp(campaign_type, campaign_types[i]) ) {
-				*type = i;
+			if (name == NULL) {
+				Warning(LOCATION, "Invalid campaign type \"%s\"\n", campaign_type);
+				break;
+			}
+
+			if (desc) {
+				if (optional_string("+Description:")) {
+					*desc = stuff_and_malloc_string(F_MULTITEXT, NULL);
+				}
+				else {
+					*desc = NULL;
+				}
+			}
+
+			// if this is a multiplayer campaign, get the max players
+			if ((*type) != CAMPAIGN_TYPE_SINGLE) {
+				skip_to_string("+Num Players:");
+				stuff_int(max_players);
+			}
+
+			// if we found a valid campaign type
+			if ((*type) >= 0) {
+				success = 1;
 			}
 		}
-
-		if (name == NULL) {
-			Warning(LOCATION, "Invalid campaign type \"%s\"\n", campaign_type);
+		catch (const parse::ParseException& e)
+		{
+			mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error message = %s.\n", fname, e.what()));
 			break;
 		}
-
-		if (desc) {
-			if (optional_string("+Description:")) {
-				*desc = stuff_and_malloc_string(F_MULTITEXT, NULL);
-			} else {
-				*desc = NULL;
-			}
-		}
-
-		// if this is a multiplayer campaign, get the max players
-		if ((*type) != CAMPAIGN_TYPE_SINGLE) {
-			skip_to_string("+Num Players:");
-			stuff_int(max_players);
-		}
-
-		// if we found a valid campaign type
-		if ((*type) >= 0) {
-			success = 1;
-		}
 	} while (0);
 
 	Assert(success);
@@ -176,22 +180,14 @@ int mission_campaign_get_info(const char *filename, char *name, int *type, int *
  */
 int mission_campaign_get_mission_list(const char *filename, char **list, int max)
 {
-	int rval, i, num = 0;
+	int i, num = 0;
 	char name[MAX_FILENAME_LEN];
 
 	filename = cf_add_ext(filename, FS_CAMPAIGN_FILE_EXT);
 
 	// read the campaign file and get the list of mission filenames
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-
-		// since we can't return count of allocated elements, free them instead
-		for (i=0; i<num; i++)
-			vm_free(list[i]);
-
-		num = -1;
-
-	} else {
+	try
+	{
 		read_file_text(filename);
 		reset_parse();
 
@@ -203,6 +199,16 @@ int mission_campaign_get_mission_list(const char *filename, char **list, int max
 				Warning(LOCATION, "Maximum number of missions exceeded (%d)!", max);
 		}
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+
+		// since we can't return count of allocated elements, free them instead
+		for (i = 0; i<num; i++)
+			vm_free(list[i]);
+
+		num = -1;
+	}
 
 	return num;
 }
@@ -241,10 +247,10 @@ int mission_campaign_maybe_add(const char *filename)
 	char *desc = NULL;
 	int type, max_players;
 
-	// don't add ignored campaigns
-	if (campaign_is_ignored(filename)) {
-		return 0;
-	}
+		// don't add ignored campaigns
+		if (campaign_is_ignored(filename)) {
+			return 0;
+		}
 
 	if ( mission_campaign_get_info( filename, name, &type, &max_players, &desc) ) {
 		if ( !MC_multiplayer && (type == CAMPAIGN_TYPE_SINGLE) ) {
@@ -410,7 +416,7 @@ void mission_campaign_get_sw_info()
  */
 int mission_campaign_load( char *filename, player *pl, int load_savefile, bool reset_stats )
 {
-	int len, rval, i;
+	int len, i;
 	char name[NAME_LENGTH], type[NAME_LENGTH], temp[NAME_LENGTH];
 
 	if (campaign_is_ignored(filename)) {
@@ -429,21 +435,8 @@ int mission_campaign_load( char *filename, player *pl, int load_savefile, bool r
 	}
 
 	// read the mission file and get the list of mission filenames
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("Error parsing '%s'\r\nError code = %i.\r\n", filename, rval));
-
-		Campaign.filename[0] = 0;
-		Campaign.num_missions = 0;
-
-		if ( !Fred_running && !(Game_mode & GM_MULTIPLAYER) ) {
-			Campaign_file_missing = 1;
-			Campaign_load_failure = CAMPAIGN_ERROR_MISSING;
-			return CAMPAIGN_ERROR_MISSING;
-		}
-
-		return CAMPAIGN_ERROR_CORRUPT;
-
-	} else {
+	try
+	{
 		// be sure to remove all old malloced strings of Mission_names
 		// we must also free any goal stuff that was from a previous campaign
 		// this also frees sexpressions so the next call to init_sexp will be able to reclaim
@@ -643,6 +636,21 @@ int mission_campaign_load( char *filename, player *pl, int load_savefile, bool r
 			Campaign.num_missions++;
 		}
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("Error parsing '%s'\r\nError message = %s.\r\n", filename, e.what()));
+
+		Campaign.filename[0] = 0;
+		Campaign.num_missions = 0;
+
+		if (!Fred_running && !(Game_mode & GM_MULTIPLAYER)) {
+			Campaign_file_missing = 1;
+			Campaign_load_failure = CAMPAIGN_ERROR_MISSING;
+			return CAMPAIGN_ERROR_MISSING;
+		}
+
+		return CAMPAIGN_ERROR_CORRUPT;
+	}
 
 	// set up the other variables for the campaign stuff.  After initializing, we must try and load
 	// the campaign save file for this player.  Since all campaign loads go through this routine, I
@@ -1406,14 +1414,9 @@ void mission_campaign_clear()
  */
 int mission_campaign_get_filenames(char *filename, char dest[][NAME_LENGTH], int *num)
 {
-	int	rval;
-
 	// read the mission file and get the list of mission filenames
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return rval;
-
-	} else {
+	try
+	{
 		Assert( strlen(filename) < MAX_FILENAME_LEN );  // make sure no overflow
 		read_file_text(filename);
 		reset_parse();
@@ -1431,6 +1434,11 @@ int mission_campaign_get_filenames(char *filename, char dest[][NAME_LENGTH], int
 			(*num)++;
 		}
 	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return 1;
+	}
 
 	return 0;
 }
@@ -1443,110 +1451,115 @@ void read_mission_goal_list(int num)
 {
 	char *filename, notes[NOTES_LENGTH], goals[MAX_GOALS][NAME_LENGTH];
 	char events[MAX_MISSION_EVENTS][NAME_LENGTH];
-	int i, z, rval, event_count, count = 0;
+	int i, z, event_count, count = 0;
 
 	filename = Campaign.missions[num].name;
 	
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+	try
+	{
+		read_file_text(filename);
+		reset_parse();
+		init_sexp();
+
+		// first, read the mission notes for this mission.  Used in campaign editor
+		if (skip_to_string("#Mission Info")) {
+			if (skip_to_string("$Notes:")) {
+				stuff_string(notes, F_NOTES, NOTES_LENGTH);
+				if (Campaign.missions[num].notes){
+					vm_free(Campaign.missions[num].notes);
+				}
+
+				Campaign.missions[num].notes = (char *)vm_malloc(strlen(notes) + 1);
+				strcpy(Campaign.missions[num].notes, notes);
+			}
+		}
+
+		event_count = 0;
+		// skip to events section in the mission file.  Events come before goals, so we process them first
+		if (skip_to_string("#Events")) {
+			while (1) {
+				if (skip_to_string("$Formula:", "#Goals") != 1){
+					break;
+				}
+
+				z = skip_to_string("+Name:", "$Formula:");
+				if (!z){
+					break;
+				}
+
+				if (z == 1){
+					stuff_string(events[event_count], F_NAME, NAME_LENGTH);
+				}
+				else {
+					sprintf(events[event_count], NOX("Event #%d"), event_count + 1);
+				}
+
+				event_count++;
+				if (event_count > MAX_MISSION_EVENTS) {
+					Warning(LOCATION, "Maximum number of events exceeded (%d)!", MAX_MISSION_EVENTS);
+					event_count = MAX_MISSION_EVENTS;
+					break;
+				}
+			}
+		}
+
+		count = 0;
+		if (skip_to_string("#Goals")) {
+			while (1) {
+				if (skip_to_string("$Type:", "#End") != 1){
+					break;
+				}
+
+				z = skip_to_string("+Name:", "$Type:");
+				if (!z){
+					break;
+				}
+
+				if (z == 1){
+					stuff_string(goals[count], F_NAME, NAME_LENGTH);
+				}
+				else {
+					sprintf(goals[count], NOX("Goal #%d"), count + 1);
+				}
+
+				count++;
+				if (count > MAX_GOALS) {
+					Warning(LOCATION, "Maximum number of goals exceeded (%d)!", MAX_GOALS);
+					count = MAX_GOALS;
+					break;
+				}
+			}
+		}
+
+		Campaign.missions[num].num_goals = count;
+		if (count) {
+			Campaign.missions[num].goals = (mgoal *)vm_malloc(count * sizeof(mgoal));
+			Assert(Campaign.missions[num].goals);  // make sure we got the memory
+			memset(Campaign.missions[num].goals, 0, count * sizeof(mgoal));
+
+			for (i = 0; i < count; i++){
+				strcpy_s(Campaign.missions[num].goals[i].name, goals[i]);
+			}
+		}
+		// copy the events
+		Campaign.missions[num].num_events = event_count;
+		if (event_count) {
+			Campaign.missions[num].events = (mevent *)vm_malloc(event_count * sizeof(mevent));
+			Assert(Campaign.missions[num].events);
+			memset(Campaign.missions[num].events, 0, event_count * sizeof(mevent));
+
+			for (i = 0; i < event_count; i++){
+				strcpy_s(Campaign.missions[num].events[i].name, events[i]);
+			}
+		}
+
+		// Goober5000 - variables do not need to be read here
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename);
-	reset_parse();
-	init_sexp();
-
-	// first, read the mission notes for this mission.  Used in campaign editor
-	if (skip_to_string("#Mission Info")) {
-		if (skip_to_string("$Notes:")) {
-			stuff_string(notes, F_NOTES, NOTES_LENGTH);
-			if (Campaign.missions[num].notes){
-				vm_free(Campaign.missions[num].notes);
-			}
-
-			Campaign.missions[num].notes = (char *) vm_malloc(strlen(notes) + 1);
-			strcpy(Campaign.missions[num].notes, notes);
-		}
-	}
-
-	event_count = 0;
-	// skip to events section in the mission file.  Events come before goals, so we process them first
-	if ( skip_to_string("#Events") ) {
-		while (1) {
-			if (skip_to_string("$Formula:", "#Goals") != 1){
-				break;
-			}
-
-			z = skip_to_string("+Name:", "$Formula:");
-			if (!z){
-				break;
-			}
-
-			if (z == 1){
-				stuff_string(events[event_count], F_NAME, NAME_LENGTH);
-			} else {
-				sprintf(events[event_count], NOX("Event #%d"), event_count + 1);
-			}
-
-			event_count++;
-			if (event_count > MAX_MISSION_EVENTS) {
-				Warning(LOCATION, "Maximum number of events exceeded (%d)!", MAX_MISSION_EVENTS);
-				event_count = MAX_MISSION_EVENTS;
-				break;
-			}
-		}
-	}
-
-	count = 0;
-	if (skip_to_string("#Goals")) {
-		while (1) {
-			if (skip_to_string("$Type:", "#End") != 1){
-				break;
-			}
-
-			z = skip_to_string("+Name:", "$Type:");
-			if (!z){
-				break;
-			}
-
-			if (z == 1){
-				stuff_string(goals[count], F_NAME, NAME_LENGTH);
-			} else {
-				sprintf(goals[count], NOX("Goal #%d"), count + 1);
-			}
-
-			count++;
-			if (count > MAX_GOALS) {
-				Warning(LOCATION, "Maximum number of goals exceeded (%d)!", MAX_GOALS);
-				count = MAX_GOALS;
-				break;
-			}
-		}
-	}
-
-	Campaign.missions[num].num_goals = count;
-	if (count) {
-		Campaign.missions[num].goals = (mgoal *) vm_malloc(count * sizeof(mgoal));
-		Assert(Campaign.missions[num].goals);  // make sure we got the memory
-		memset(Campaign.missions[num].goals, 0, count * sizeof(mgoal));
-
-		for (i=0; i<count; i++){
-			strcpy_s(Campaign.missions[num].goals[i].name, goals[i]);
-		}
-	}
-		// copy the events
-	Campaign.missions[num].num_events = event_count;
-	if (event_count) {
-		Campaign.missions[num].events = (mevent *)vm_malloc(event_count * sizeof(mevent));
-		Assert ( Campaign.missions[num].events );
-		memset(Campaign.missions[num].events, 0, event_count * sizeof(mevent));
-
-		for (i = 0; i < event_count; i++ ){
-			strcpy_s(Campaign.missions[num].events[i].name, events[i]);
-		}
-	}
-
-	// Goober5000 - variables do not need to be read here
 }
 
 /**
@@ -1622,33 +1635,36 @@ void mission_campaign_maybe_play_movie(int type)
  */
 int mission_campaign_parse_is_multi(char *filename, char *name)
 {	
-	int i, rval;
+	int i;
 	char temp[NAME_LENGTH];
 	
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+	try
+	{
+		read_file_text(filename);
+		reset_parse();
+
+		required_string("$Name:");
+		stuff_string(temp, F_NAME, NAME_LENGTH);
+		if (name)
+			strcpy(name, temp);
+
+		required_string("$Type:");
+		stuff_string(temp, F_NAME, NAME_LENGTH);
+
+		for (i = 0; i < MAX_CAMPAIGN_TYPES; i++) {
+			if (!stricmp(temp, campaign_types[i])) {
+				return i;
+			}
+		}
+
+		Error(LOCATION, "Unknown campaign type %s", temp);
 		return -1;
 	}
-
-	read_file_text( filename );
-	reset_parse();
-	
-	required_string("$Name:");
-	stuff_string( temp, F_NAME, NAME_LENGTH );	
-	if ( name )
-		strcpy( name, temp );
-
-	required_string( "$Type:" );
-	stuff_string( temp, F_NAME, NAME_LENGTH );
-
-	for (i = 0; i < MAX_CAMPAIGN_TYPES; i++ ) {
-		if ( !stricmp(temp, campaign_types[i]) ) {
-			return i;
-		}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("MISSIONCAMPAIGN: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return -1;
 	}
-
-	Error(LOCATION, "Unknown campaign type %s", temp );
-	return -1;
 }
 
 /** 

code/mission/missiongoals.h

@@ -93,7 +93,7 @@ extern int	Num_goals;									// number of goals for this mission
 #define MLF_FIRST_REPEAT_ONLY		(1 << 4)
 #define MLF_LAST_REPEAT_ONLY		(1 << 5)
 #define MLF_FIRST_TRIGGER_ONLY		(1 << 6)
-#define MLF_LAST_TRIGGER_ONLY		(1 << 7)
+#define MLF_LAST_TRIGGER_ONLY		(1 << 7)	
 #define MLF_STATE_CHANGE			(1 << 8)	
 
 #define MLF_ALL_REPETITION_FLAGS (MLF_FIRST_REPEAT_ONLY | MLF_LAST_REPEAT_ONLY | MLF_FIRST_TRIGGER_ONLY | MLF_LAST_TRIGGER_ONLY) 

code/mission/missionmessage.cpp

@@ -648,19 +648,22 @@ void parse_msgtbl()
 // this is called at the start of each level
 void messages_init()
 {
-	int rval, i;
+	int i;
 	static int table_read = 0;
 
 	if ( !table_read ) {
 		Default_command_persona = -1;
-
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "messages.tbl", rval));
+		
+		try
+		{
+			parse_msgtbl();
+			table_read = 1;
+		}
+		catch (const parse::ParseException& e)
+		{
+			mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "messages.tbl", e.what()));
 			return;
 		}
-
-		parse_msgtbl();
-		table_read = 1;
 	}
 
 	Current_mission_mood = 0;
@@ -1531,6 +1534,9 @@ void message_queue_process()
 
 	//	Don't play death scream unless a small ship.
 	if ( q->builtin_type == MESSAGE_WINGMAN_SCREAM ) {
+		if (Message_shipnum < 0) {
+			goto all_done;
+		}
 		if (!((Ship_info[Ships[Message_shipnum].ship_info_index].flags & SIF_SMALL_SHIP) || (Ships[Message_shipnum].flags2 & SF2_ALWAYS_DEATH_SCREAM)) ) {
 			goto all_done;
 		}
@@ -1914,7 +1920,7 @@ void message_send_builtin_to_player( int type, ship *shipp, int priority, int ti
 	char *who_from;
 	int best_match = -1;
 
-	matching_builtin *current_builtin = new matching_builtin(); 
+	matching_builtin current_builtin;
 	SCP_vector <matching_builtin> matching_builtins; 
 
 
@@ -1976,52 +1982,52 @@ void message_send_builtin_to_player( int type, ship *shipp, int priority, int ti
 		// check the type of message
 		if ( !stricmp(Messages[i].name, name) ) {
 			// condition 1: we have a type match
-			current_builtin->message_index = i;
-			current_builtin->type_of_match =  BUILTIN_MATCHES_TYPE; 
+			current_builtin.message_index = i;
+			current_builtin.type_of_match =  BUILTIN_MATCHES_TYPE; 
 
 			// check the species of this persona (if required)
 			if ( (persona_species >= 0) && (Personas[Messages[i].persona_index].species == persona_species) ) {
 				// condition 2: we have a type + species match
-				current_builtin->type_of_match =  BUILTIN_MATCHES_SPECIES; 
+				current_builtin.type_of_match =  BUILTIN_MATCHES_SPECIES; 
 			}
 
 			// check the exact persona (if required)
 			// NOTE: doesn't need to be nested under the species condition above
 			if ( (persona_index >= 0) && (Messages[i].persona_index == persona_index) ) {
 				// condition 3: type + species + persona index match	
-				current_builtin->type_of_match =  BUILTIN_MATCHES_PERSONA_CHECK_MOOD; 
+				current_builtin.type_of_match =  BUILTIN_MATCHES_PERSONA_CHECK_MOOD; 
 			}
 
 			// check if the personas mood suits this particular message, first check if it is excluded
-			if (!Messages[i].excluded_moods.empty() && (current_builtin->type_of_match ==  BUILTIN_MATCHES_PERSONA_CHECK_MOOD)) {
+			if (!Messages[i].excluded_moods.empty() && (current_builtin.type_of_match ==  BUILTIN_MATCHES_PERSONA_CHECK_MOOD)) {
 				for (SCP_vector<int>::iterator iter = Messages[i].excluded_moods.begin(); iter != Messages[i].excluded_moods.end(); ++iter) {
 					if (*iter == Current_mission_mood) {
-						current_builtin->type_of_match =  BUILTIN_MATCHES_PERSONA_EXCLUDED; 
+						current_builtin.type_of_match =  BUILTIN_MATCHES_PERSONA_EXCLUDED; 
 						break; 
 					}
 				}
 			}
 
-			if (current_builtin->type_of_match ==  BUILTIN_MATCHES_PERSONA_CHECK_MOOD) {
+			if (current_builtin.type_of_match ==  BUILTIN_MATCHES_PERSONA_CHECK_MOOD) {
 				if (Current_mission_mood == Messages[i].mood) {
-					current_builtin->type_of_match =  BUILTIN_MATCHES_PERSONA_MOOD; 
+					current_builtin.type_of_match =  BUILTIN_MATCHES_PERSONA_MOOD; 
 				}
 				else {
-					current_builtin->type_of_match =  BUILTIN_MATCHES_PERSONA; 
+					current_builtin.type_of_match =  BUILTIN_MATCHES_PERSONA; 
 				}
 			}			
 
-			if (current_builtin->type_of_match == best_match) {
+			if (current_builtin.type_of_match == best_match) {
 				num_matching_builtins++;
 			}
 			// otherwise check to see if the this is the best kind of match we've found so far
-			else if (current_builtin->type_of_match > best_match) {
-				best_match = current_builtin->type_of_match; 
+			else if (current_builtin.type_of_match > best_match) {
+				best_match = current_builtin.type_of_match; 
 				num_matching_builtins = 1;
 			}
 
 			// add the match to our list
-			matching_builtins.push_back(*current_builtin); 
+			matching_builtins.push_back(current_builtin); 
 		}
 	}
 

code/mission/missionparse.cpp

@@ -5832,39 +5832,38 @@ int get_mission_info(const char *filename, mission *mission_p, bool basic)
 	if (p) *p = 0; // remove any extension
 	strcat_s(real_fname, FS_MISSION_FILE_EXT);  // append mission extension
 
-	int rval, filelength;
+	int filelength;
 
 	// if mission_p is NULL, make it point to The_mission
 	if ( mission_p == NULL )
 		mission_p = &The_mission;
 
-	do {
-		CFILE *ftemp = cfopen(real_fname, "rt");
-		if (!ftemp) {
-			rval = -1;
-			break;
-		}
+	CFILE *ftemp = cfopen(real_fname, "rt");
+	if (!ftemp) {
+		return -1;
+	}
 
-		// 7/9/98 -- MWA -- check for 0 length file.
-		filelength = cfilelength(ftemp);
-		cfclose(ftemp);
-		if (filelength == 0) {
-			rval = -1;
-			break;
-		}
-
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("MISSIONS: Unable to parse '%s'!  Error code = %i.\n", real_fname, rval));
-			break;
-		}
+	// 7/9/98 -- MWA -- check for 0 length file.
+	filelength = cfilelength(ftemp);
+	cfclose(ftemp);
+	if (filelength == 0) {
+		return -1;
+	}
 
+	try
+	{
 		read_file_text(real_fname, CF_TYPE_MISSIONS);
-		mission_p->Reset( );
+		mission_p->Reset();
 		parse_init(basic);
 		parse_mission_info(mission_p, basic);
-	} while (0);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("MISSIONS: Unable to parse '%s'!  Error message = %s.\n", real_fname, e.what()));
+		return -1;
+	}
 
-	return rval;
+	return 0;
 }
 
 /**
@@ -5926,22 +5925,27 @@ int parse_main(const char *mission_name, int flags)
 			cfclose(ftemp);
 		}
 
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("MISSIONS: Unable to parse '%s'!  Error code = %i.\n", mission_name, rval));
+		try
+		{
+			// import?
+			if (flags & MPF_IMPORT_FSM) {
+				read_file_text(mission_name, CF_TYPE_ANY);
+				convertFSMtoFS2();
+			}
+			else {
+				read_file_text(mission_name, CF_TYPE_MISSIONS);
+			}
+
+			The_mission.Reset();
+			rval = parse_mission(&The_mission, flags);
+			display_parse_diagnostics();
+		}
+		catch (const parse::ParseException& e)
+		{
+			mprintf(("MISSIONS: Unable to parse '%s'!  Error message = %s.\n", mission_name, e.what()));
+			rval = 1;
 			break;
 		}
-
-		// import?
-		if (flags & MPF_IMPORT_FSM) {
-			read_file_text(mission_name, CF_TYPE_ANY);
-			convertFSMtoFS2();
-		} else {
-			read_file_text(mission_name, CF_TYPE_MISSIONS);
-		}
-
-		The_mission.Reset( );
-		rval = parse_mission(&The_mission, flags);
-		display_parse_diagnostics();
 	} while (0);
 
 	if (!Fred_running)
@@ -6283,7 +6287,7 @@ void mission_parse_set_up_initial_docks()
  */
 int mission_parse_is_multi(const char *filename, char *mission_name)
 {
-	int rval, game_type;
+	int game_type;
 	int filelength;
 	CFILE *ftemp;
 
@@ -6302,25 +6306,28 @@ int mission_parse_is_multi(const char *filename, char *mission_name)
 
 	game_type = 0;
 	do {
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("MISSIONS: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+		try
+		{
+			read_file_text(filename, CF_TYPE_MISSIONS);
+			reset_parse();
+
+			if (skip_to_string("$Name:") != 1) {
+				nprintf(("Network", "Unable to process %s because we couldn't find $Name:", filename));
+				break;
+			}
+			stuff_string(mission_name, F_NAME, NAME_LENGTH);
+
+			if (skip_to_string("+Game Type Flags:") != 1) {
+				nprintf(("Network", "Unable to process %s because we couldn't find +Game Type Flags:\n", filename));
+				break;
+			}
+			stuff_int(&game_type);
+		}
+		catch (const parse::ParseException& e)
+		{
+			mprintf(("MISSIONS: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 			break;
 		}
-
-		read_file_text(filename, CF_TYPE_MISSIONS);
-		reset_parse();
-
-		if ( skip_to_string("$Name:") != 1 ) {
-			nprintf(("Network", "Unable to process %s because we couldn't find $Name:", filename));
-			break;
-		}
-		stuff_string( mission_name, F_NAME, NAME_LENGTH );
-
-		if ( skip_to_string("+Game Type Flags:") != 1 ) {
-			nprintf(("Network", "Unable to process %s because we couldn't find +Game Type Flags:\n", filename));
-			break;
-		}
-		stuff_int(&game_type);
 	} while (0);
 
 	return (game_type & MISSION_TYPE_MULTI) ? game_type : 0;

code/missionui/missiondebrief.cpp

@@ -1058,49 +1058,51 @@ void debrief_traitor_init()
 	if ( !inited ) {
 		debriefing		*debrief;
 		debrief_stage	*stagep;
-		int rval;
 		int stage_num;
+		
+		try
+		{
+			read_file_text("traitor.tbl", CF_TYPE_TABLES);
+			reset_parse();
 
-		if ((rval = setjmp(parse_abort)) != 0) {
-			mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "traitor.tbl", rval));
+			// simplied form of the debriefing stuff.
+			debrief = &Traitor_debriefing;
+			required_string("#Debriefing_info");
+
+			required_string("$Num stages:");
+			stuff_int(&debrief->num_stages);
+			Assert(debrief->num_stages == 1);
+
+			stage_num = 0;
+			stagep = &debrief->stages[stage_num++];
+			required_string("$Formula:");
+			stagep->formula = get_sexp_main();
+			required_string("$multi text");
+			stuff_string(stagep->text, F_MULTITEXT, NULL);
+			required_string("$Voice:");
+			char traitor_voice_file[MAX_FILENAME_LEN];
+			stuff_string(traitor_voice_file, F_FILESPEC, MAX_FILENAME_LEN);
+
+			// DKA 9/13/99	Only 1 traitor msg for FS2
+			//		if ( Player->main_hall ) {
+			//			strcpy_s(stagep->voice, NOX("3_"));
+			//		} else {
+			//			strcpy_s(stagep->voice, NOX("1_"));
+			//		}
+
+			// Goober5000
+			debrief_choose_voice(stagep->voice, traitor_voice_file, debrief_find_persona_index(), 1);
+
+			required_string("$Recommendation text:");
+			stuff_string(stagep->recommendation_text, F_MULTITEXT, NULL);
+
+			inited = 1;
+		}
+		catch (const parse::ParseException& e)
+		{
+			mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "traitor.tbl", e.what()));
 			return;
 		}
-
-		read_file_text("traitor.tbl", CF_TYPE_TABLES);
-		reset_parse();		
-
-		// simplied form of the debriefing stuff.
-		debrief = &Traitor_debriefing;
-		required_string("#Debriefing_info");
-
-		required_string("$Num stages:");
-		stuff_int(&debrief->num_stages);
-		Assert(debrief->num_stages == 1);
-
-		stage_num = 0;
-		stagep = &debrief->stages[stage_num++];
-		required_string("$Formula:");
-		stagep->formula = get_sexp_main();
-		required_string("$multi text");
-		stuff_string( stagep->text, F_MULTITEXT, NULL);
-		required_string("$Voice:");
-		char traitor_voice_file[MAX_FILENAME_LEN];
-		stuff_string(traitor_voice_file, F_FILESPEC, MAX_FILENAME_LEN);
-
-// DKA 9/13/99	Only 1 traitor msg for FS2
-//		if ( Player->main_hall ) {
-//			strcpy_s(stagep->voice, NOX("3_"));
-//		} else {
-//			strcpy_s(stagep->voice, NOX("1_"));
-//		}
-
-		// Goober5000
-		debrief_choose_voice(stagep->voice, traitor_voice_file, debrief_find_persona_index(), 1);
-
-		required_string("$Recommendation text:");
-		stuff_string( stagep->recommendation_text, F_MULTITEXT, NULL);
-
-		inited = 1;
 	}
 
 	// disable the accept button if in single player and I am a traitor

code/mod_table/mod_table.cpp

@@ -36,240 +36,247 @@ bool Beams_use_damage_factors = false;
 
 void parse_mod_table(const char *filename)
 {
-	int rval;
 	// SCP_vector<SCP_string> lines;
 
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", (filename) ? filename : "<default game_settings.tbl>", rval));
-		return;
-	}
+		if (filename == NULL)
+			read_file_text_from_array(defaults_get_file("game_settings.tbl"));
+		else
+			read_file_text(filename, CF_TYPE_TABLES);
 
-	if (filename == NULL)
-		read_file_text_from_array(defaults_get_file("game_settings.tbl"));
-	else
-		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	reset_parse();	
+		// start parsing
+		optional_string("#CAMPAIGN SETTINGS");
 
-	// start parsing
-	optional_string("#CAMPAIGN SETTINGS");
-
-	if (optional_string("$Default Campaign File Name:")) {
-		char temp[MAX_FILENAME_LEN];
-		stuff_string(temp, F_NAME, MAX_FILENAME_LEN);
-
-		// remove extension?
-		if (drop_extension(temp)) {
-			mprintf(("Game Settings Table: Removed extension on default campaign file name %s\n", temp));
-		}
-
-		// check length
-		int maxlen = (MAX_FILENAME_LEN - 4);
-		int len = strlen(temp);
-		if (len > maxlen) {
-			Warning(LOCATION, "Token too long: [%s].  Length = %i.  Max is %i.\n", temp, len, maxlen);
-			temp[maxlen] = 0;
-		}
-
-		strcpy_s(Default_campaign_file_name, temp);
-	}
-
-	if (optional_string("#Ignored Campaign File Names")) {
-		SCP_string campaign_name; 
-
-		while (optional_string("$Campaign File Name:")) {
-			stuff_string(campaign_name, F_NAME);
+		if (optional_string("$Default Campaign File Name:")) {
+			char temp[MAX_FILENAME_LEN];
+			stuff_string(temp, F_NAME, MAX_FILENAME_LEN);
 
 			// remove extension?
-			if (drop_extension(campaign_name)) {
-				mprintf(("Game Settings Table: Removed extension on ignored campaign file name %s\n", campaign_name.c_str()));
+			if (drop_extension(temp)) {
+				mprintf(("Game Settings Table: Removed extension on default campaign file name %s\n", temp));
 			}
 
-			Ignored_campaigns.push_back(campaign_name);
+			// check length
+			int maxlen = (MAX_FILENAME_LEN - 4);
+			int len = strlen(temp);
+			if (len > maxlen) {
+				Warning(LOCATION, "Token too long: [%s].  Length = %i.  Max is %i.\n", temp, len, maxlen);
+				temp[maxlen] = 0;
+			}
+
+			strcpy_s(Default_campaign_file_name, temp);
 		}
-	}
 
-	if (optional_string("$Red-alert applies to delayed ships:")) {
-		stuff_boolean(&Red_alert_applies_to_delayed_ships);
-		if (Red_alert_applies_to_delayed_ships) {
-			mprintf(("Game Settings Table: Red-alert stats will be loaded for ships that arrive later in missions\n"));
-		} else {
-			mprintf(("Game Settings Table: Red-alert stats will NOT be loaded for ships that arrive later in missions (this is retail behavior)\n"));
+		if (optional_string("#Ignored Campaign File Names")) {
+			SCP_string campaign_name;
+
+			while (optional_string("$Campaign File Name:")) {
+				stuff_string(campaign_name, F_NAME);
+
+				// remove extension?
+				if (drop_extension(campaign_name)) {
+					mprintf(("Game Settings Table: Removed extension on ignored campaign file name %s\n", campaign_name.c_str()));
+				}
+
+				Ignored_campaigns.push_back(campaign_name);
+			}
 		}
-	}
 
-	optional_string("#HUD SETTINGS");
-
-	// how long should the game wait before displaying a directive?
-	if (optional_string("$Directive Wait Time:")) {
-		stuff_int(&Directive_wait_time);
-	}
-
-	if (optional_string("$Cutscene camera displays HUD:")) {
-		stuff_boolean(&Cutscene_camera_displays_hud);
-	}
-	// compatibility
-	if (optional_string("$Cutscene camera disables HUD:")) {
-		mprintf(("Game Settings Table: \"$$Cutscene camera disables HUD\" is deprecated in favor of \"$Cutscene camera displays HUD\"\n"));
-		bool temp;
-		stuff_boolean(&temp);
-		Cutscene_camera_displays_hud = !temp;
-	}
-	
-	if (optional_string("$Full color head animations:")) {
-		stuff_boolean(&Full_color_head_anis);
-	}
-	// compatibility
-	if (optional_string("$Color head animations with hud colors:")) {
-		mprintf(("Game Settings Table: \"$Color head animations with hud colors\" is deprecated in favor of \"$Full color head animations\"\n"));
-		bool temp;
-		stuff_boolean(&temp);
-		Full_color_head_anis = !temp;
-	}
-
-	optional_string("#SEXP SETTINGS"); 
-
-	if (optional_string("$Loop SEXPs Then Arguments:")) { 
-		stuff_boolean(&True_loop_argument_sexps);
-		if (True_loop_argument_sexps) {
-			mprintf(("Game Settings Table: Using Reversed Loops For SEXP Arguments\n"));
-		} else {
-			mprintf(("Game Settings Table: Using Standard Loops For SEXP Arguments\n"));
+		if (optional_string("$Red-alert applies to delayed ships:")) {
+			stuff_boolean(&Red_alert_applies_to_delayed_ships);
+			if (Red_alert_applies_to_delayed_ships) {
+				mprintf(("Game Settings Table: Red-alert stats will be loaded for ships that arrive later in missions\n"));
+			}
+			else {
+				mprintf(("Game Settings Table: Red-alert stats will NOT be loaded for ships that arrive later in missions (this is retail behavior)\n"));
+			}
 		}
-	}
 
-	if (optional_string("$Use Alternate Chaining Behavior:")) {
-		stuff_boolean(&Alternate_chaining_behavior);
-		if (Alternate_chaining_behavior) {
-			mprintf(("Game Settings Table: Using alternate event chaining behavior\n"));
-		} else {
-			mprintf(("Game Settings Table: Using standard event chaining behavior\n"));
+		optional_string("#HUD SETTINGS");
+
+		// how long should the game wait before displaying a directive?
+		if (optional_string("$Directive Wait Time:")) {
+			stuff_int(&Directive_wait_time);
 		}
-	}
 
-	optional_string("#GRAPHICS SETTINGS");
-
-	if (optional_string("$Enable External Shaders:")) {
-		stuff_boolean(&Enable_external_shaders);
-		if (Enable_external_shaders)
-			mprintf(("Game Settings Table: External shaders are enabled\n"));
-		else
-			mprintf(("Game Settings Table: External shaders are DISABLED\n"));
-	}
-
-	if (optional_string("$Default Detail Level:")) {
-		int detail_level;
-
-		stuff_int(&detail_level);
-
-		mprintf(("Game Settings Table: Setting default detail level to %i of %i-%i\n", detail_level, 0, NUM_DEFAULT_DETAIL_LEVELS-1));
-
-		if (detail_level < 0 || detail_level > NUM_DEFAULT_DETAIL_LEVELS-1) {
-			Warning(LOCATION, "Invalid detail level: %i, setting to %i\n", detail_level, Default_detail_level);
-		} else {
-			Default_detail_level = detail_level;
+		if (optional_string("$Cutscene camera displays HUD:")) {
+			stuff_boolean(&Cutscene_camera_displays_hud);
 		}
-	}
-
-	if (optional_string("$Briefing Window FOV:")) {
-		float fov;
-
-		stuff_float(&fov);
-
-		mprintf(("Game Settings Table: Setting briefing window FOV from %f to %f\n", Briefing_window_FOV, fov));
-
-		Briefing_window_FOV = fov;
-	}
-	
-	optional_string("#NETWORK SETTINGS"); 
-
-	if (optional_string("$FS2NetD port:")) {
-		stuff_int(&FS2NetD_port);
-		if (FS2NetD_port)
-			mprintf(("Game Settings Table: FS2NetD connecting to port %i\n", FS2NetD_port));
-	}
-
-	optional_string("#SOUND SETTINGS"); 
-
-	if (optional_string("$Default Sound Volume:")) {
-		stuff_float(&Default_sound_volume);
-	}
-
-	if (optional_string("$Default Music Volume:")) {
-		stuff_float(&Default_music_volume);
-	}
-
-	if (optional_string("$Default Voice Volume:")) {
-		stuff_float(&Default_voice_volume);
-	}
-
-	optional_string("#FRED SETTINGS");
-	
-	if (optional_string("$Disable Hard Coded Message Head Ani Files:")) {
-		stuff_boolean(&Disable_hc_message_ani);
-		if (Disable_hc_message_ani) {
-			mprintf(("Game Settings Table: FRED - Disabling Hard Coded Message Ani Files\n"));
-		} else {
-			mprintf(("Game Settings Table: FRED - Using Hard Coded Message Ani Files\n"));
-			
+		// compatibility
+		if (optional_string("$Cutscene camera disables HUD:")) {
+			mprintf(("Game Settings Table: \"$$Cutscene camera disables HUD\" is deprecated in favor of \"$Cutscene camera displays HUD\"\n"));
+			bool temp;
+			stuff_boolean(&temp);
+			Cutscene_camera_displays_hud = !temp;
 		}
-	}
 
-	optional_string("#OTHER SETTINGS"); 
-
-	if (optional_string("$Fixed Turret Collisions:")) { 
-		stuff_boolean(&Fixed_turret_collisions);
-	}
-
-	if (optional_string("$Damage Impacted Subsystem First:")) { 
-		stuff_boolean(&Damage_impacted_subsystem_first);
-	}
-
-	if (optional_string("$Default ship select effect:")) {
-		char effect[NAME_LENGTH];
-		stuff_string(effect, F_NAME, NAME_LENGTH);
-		if (!stricmp(effect, "FS2"))
-			Default_ship_select_effect = 2;
-		else if (!stricmp(effect, "FS1"))
-			Default_ship_select_effect = 1;
-		else if (!stricmp(effect, "off"))
-			Default_ship_select_effect = 0;
-	}
-
-	if (optional_string("$Default weapon select effect:")) {
-		char effect[NAME_LENGTH];
-		stuff_string(effect, F_NAME, NAME_LENGTH);
-		if (!stricmp(effect, "FS2"))
-			Default_weapon_select_effect = 2;
-		else if (!stricmp(effect, "FS1"))
-			Default_weapon_select_effect = 1;
-		else if (!stricmp(effect, "off"))
-			Default_weapon_select_effect = 0;
-	}
-
-	if (optional_string("$Weapons inherit parent collision group:")) {
-		stuff_boolean(&Weapons_inherit_parent_collision_group);
-		if (Weapons_inherit_parent_collision_group)
-			mprintf(("Game Settings Table: Weapons inherit parent collision group\n"));
-	}
-
-	if (optional_string("$Flight controls follow eyepoint orientation:")) {
-		stuff_boolean(&Flight_controls_follow_eyepoint_orientation);
-		if (Flight_controls_follow_eyepoint_orientation)
-			mprintf(("Game Settings Table: Flight controls follow eyepoint orientation\n"));
-	}
-
-	if (optional_string("$Beams Use Damage Factors:")) {
-		stuff_boolean(&Beams_use_damage_factors);
-		if (Beams_use_damage_factors) {
-			mprintf(("Game Settings Table: Beams will use Damage Factors\n"));
-		} else {
-			mprintf(("Game Settings Table: Beams will ignore Damage Factors (retail behavior)\n"));
+		if (optional_string("$Full color head animations:")) {
+			stuff_boolean(&Full_color_head_anis);
+		}
+		// compatibility
+		if (optional_string("$Color head animations with hud colors:")) {
+			mprintf(("Game Settings Table: \"$Color head animations with hud colors\" is deprecated in favor of \"$Full color head animations\"\n"));
+			bool temp;
+			stuff_boolean(&temp);
+			Full_color_head_anis = !temp;
 		}
-	}
 
-	required_string("#END");
+		optional_string("#SEXP SETTINGS");
+
+		if (optional_string("$Loop SEXPs Then Arguments:")) {
+			stuff_boolean(&True_loop_argument_sexps);
+			if (True_loop_argument_sexps) {
+				mprintf(("Game Settings Table: Using Reversed Loops For SEXP Arguments\n"));
+			}
+			else {
+				mprintf(("Game Settings Table: Using Standard Loops For SEXP Arguments\n"));
+			}
+		}
+
+		if (optional_string("$Use Alternate Chaining Behavior:")) {
+			stuff_boolean(&Alternate_chaining_behavior);
+			if (Alternate_chaining_behavior) {
+				mprintf(("Game Settings Table: Using alternate event chaining behavior\n"));
+			}
+			else {
+				mprintf(("Game Settings Table: Using standard event chaining behavior\n"));
+			}
+		}
+
+		optional_string("#GRAPHICS SETTINGS");
+
+		if (optional_string("$Enable External Shaders:")) {
+			stuff_boolean(&Enable_external_shaders);
+			if (Enable_external_shaders)
+				mprintf(("Game Settings Table: External shaders are enabled\n"));
+			else
+				mprintf(("Game Settings Table: External shaders are DISABLED\n"));
+		}
+
+		if (optional_string("$Default Detail Level:")) {
+			int detail_level;
+
+			stuff_int(&detail_level);
+
+			mprintf(("Game Settings Table: Setting default detail level to %i of %i-%i\n", detail_level, 0, NUM_DEFAULT_DETAIL_LEVELS - 1));
+
+			if (detail_level < 0 || detail_level > NUM_DEFAULT_DETAIL_LEVELS - 1) {
+				Warning(LOCATION, "Invalid detail level: %i, setting to %i\n", detail_level, Default_detail_level);
+			}
+			else {
+				Default_detail_level = detail_level;
+			}
+		}
+
+		if (optional_string("$Briefing Window FOV:")) {
+			float fov;
+
+			stuff_float(&fov);
+
+			mprintf(("Game Settings Table: Setting briefing window FOV from %f to %f\n", Briefing_window_FOV, fov));
+
+			Briefing_window_FOV = fov;
+		}
+
+		optional_string("#NETWORK SETTINGS");
+
+		if (optional_string("$FS2NetD port:")) {
+			stuff_int(&FS2NetD_port);
+			if (FS2NetD_port)
+				mprintf(("Game Settings Table: FS2NetD connecting to port %i\n", FS2NetD_port));
+		}
+
+		optional_string("#SOUND SETTINGS");
+
+		if (optional_string("$Default Sound Volume:")) {
+			stuff_float(&Master_sound_volume);
+		}
+
+		if (optional_string("$Default Music Volume:")) {
+			stuff_float(&Master_event_music_volume);
+		}
+
+		if (optional_string("$Default Voice Volume:")) {
+			stuff_float(&Master_voice_volume);
+		}
+
+		optional_string("#FRED SETTINGS");
+
+		if (optional_string("$Disable Hard Coded Message Head Ani Files:")) {
+			stuff_boolean(&Disable_hc_message_ani);
+			if (Disable_hc_message_ani) {
+				mprintf(("Game Settings Table: FRED - Disabling Hard Coded Message Ani Files\n"));
+			}
+			else {
+				mprintf(("Game Settings Table: FRED - Using Hard Coded Message Ani Files\n"));
+
+			}
+		}
+
+		optional_string("#OTHER SETTINGS");
+
+		if (optional_string("$Fixed Turret Collisions:")) {
+			stuff_boolean(&Fixed_turret_collisions);
+		}
+
+		if (optional_string("$Damage Impacted Subsystem First:")) {
+			stuff_boolean(&Damage_impacted_subsystem_first);
+		}
+
+		if (optional_string("$Default ship select effect:")) {
+			char effect[NAME_LENGTH];
+			stuff_string(effect, F_NAME, NAME_LENGTH);
+			if (!stricmp(effect, "FS2"))
+				Default_ship_select_effect = 2;
+			else if (!stricmp(effect, "FS1"))
+				Default_ship_select_effect = 1;
+			else if (!stricmp(effect, "off"))
+				Default_ship_select_effect = 0;
+		}
+
+		if (optional_string("$Default weapon select effect:")) {
+			char effect[NAME_LENGTH];
+			stuff_string(effect, F_NAME, NAME_LENGTH);
+			if (!stricmp(effect, "FS2"))
+				Default_weapon_select_effect = 2;
+			else if (!stricmp(effect, "FS1"))
+				Default_weapon_select_effect = 1;
+			else if (!stricmp(effect, "off"))
+				Default_weapon_select_effect = 0;
+		}
+
+		if (optional_string("$Weapons inherit parent collision group:")) {
+			stuff_boolean(&Weapons_inherit_parent_collision_group);
+			if (Weapons_inherit_parent_collision_group)
+				mprintf(("Game Settings Table: Weapons inherit parent collision group\n"));
+		}
+
+		if (optional_string("$Flight controls follow eyepoint orientation:")) {
+			stuff_boolean(&Flight_controls_follow_eyepoint_orientation);
+			if (Flight_controls_follow_eyepoint_orientation)
+				mprintf(("Game Settings Table: Flight controls follow eyepoint orientation\n"));
+		}
+
+		if (optional_string("$Beams Use Damage Factors:")) {
+			stuff_boolean(&Beams_use_damage_factors);
+			if (Beams_use_damage_factors) {
+				mprintf(("Game Settings Table: Beams will use Damage Factors\n"));
+			}
+			else {
+				mprintf(("Game Settings Table: Beams will ignore Damage Factors (retail behavior)\n"));
+			}
+		}
+
+		required_string("#END");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", (filename) ? filename : "<default game_settings.tbl>", e.what()));
+		return;
+	}
 }
 
 void mod_table_init()

code/model/modelread.cpp

@@ -2480,7 +2480,7 @@ int model_load(char *filename, int n_subsystems, model_subsystem *subsystems, in
 
 	pm = new polymodel;	
 	Polygon_models[num] = pm;
-	
+
 	pm->n_paths = 0;
 	pm->paths = NULL;
 

code/nebula/neb.cpp

@@ -249,48 +249,52 @@ void neb2_regen();
 // initialize neb2 stuff at game startup
 void neb2_init()
 {
-	int rval;
 	char name[MAX_FILENAME_LEN];
 
-	if ( ( rval = setjmp(parse_abort) ) != 0 ) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "nebula.tbl", rval));
+	try
+	{
+		// read in the nebula.tbl
+		read_file_text("nebula.tbl", CF_TYPE_TABLES);
+		reset_parse();
+
+		// background bitmaps
+		Neb2_bitmap_count = 0;
+		while (!optional_string("#end")) {
+			// nebula
+			required_string("+Nebula:");
+			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+
+			if (Neb2_bitmap_count < MAX_NEB2_BITMAPS) {
+				strcpy_s(Neb2_bitmap_filenames[Neb2_bitmap_count++], name);
+			}
+			else {
+				WarningEx(LOCATION, "nebula.tbl\nExceeded maximum number of nebulas (%d)!\nSkipping %s.", MAX_NEB2_BITMAPS, name);
+			}
+		}
+
+		// poofs
+		Neb2_poof_count = 0;
+		while (!optional_string("#end")) {
+			// nebula
+			required_string("+Poof:");
+			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+
+			if (Neb2_poof_count < MAX_NEB2_POOFS) {
+				strcpy_s(Neb2_poof_filenames[Neb2_poof_count++], name);
+			}
+			else {
+				WarningEx(LOCATION, "nebula.tbl\nExceeded maximum number of nebula poofs (%d)!\nSkipping %s.", MAX_NEB2_POOFS, name);
+			}
+		}
+
+		// should always have 6 neb poofs
+		Assert(Neb2_poof_count == 6);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "nebula.tbl", e.what()));
 		return;
 	}
-
-	// read in the nebula.tbl
-	read_file_text("nebula.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	// background bitmaps
-	Neb2_bitmap_count = 0;
-	while ( !optional_string("#end") ) {
-		// nebula
-		required_string("+Nebula:");
-		stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-
-		if ( Neb2_bitmap_count < MAX_NEB2_BITMAPS ) {
-			strcpy_s(Neb2_bitmap_filenames[Neb2_bitmap_count++], name);
-		} else {
-			WarningEx(LOCATION, "nebula.tbl\nExceeded maximum number of nebulas (%d)!\nSkipping %s.", MAX_NEB2_BITMAPS, name);
-		}
-	}
-
-	// poofs
-	Neb2_poof_count = 0;
-	while ( !optional_string("#end") ) {
-		// nebula
-		required_string("+Poof:");
-		stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-
-		if ( Neb2_poof_count < MAX_NEB2_POOFS ) {
-			strcpy_s(Neb2_poof_filenames[Neb2_poof_count++], name);
-		} else {
-			WarningEx(LOCATION, "nebula.tbl\nExceeded maximum number of nebula poofs (%d)!\nSkipping %s.", MAX_NEB2_POOFS, name);
-		}
-	}
-
-	// should always have 6 neb poofs
-	Assert(Neb2_poof_count == 6);
 }
 
 // set detail level

code/nebula/neblightning.cpp

@@ -155,123 +155,125 @@ DCF(lightning_intensity, "Sets lightning intensity between 0.0 and 1.0 (Default
 void nebl_init()
 {
 	char name[MAX_FILENAME_LEN];
-	int rval;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "lightning.tbl", rval));
+	try
+	{
+		// parse the lightning table
+		read_file_text("lightning.tbl", CF_TYPE_TABLES);
+		reset_parse();
+
+		// parse the individual lightning bolt types
+		required_string("#Bolts begin");
+		while (!optional_string("#Bolts end")){
+			bolt_type new_bolt_type;
+
+			// bolt title
+			required_string("$Bolt:");
+			stuff_string(new_bolt_type.name, F_NAME, NAME_LENGTH);
+
+			// b_scale
+			required_string("+b_scale:");
+			stuff_float(&new_bolt_type.b_scale);
+
+			// b_shrink
+			required_string("+b_shrink:");
+			stuff_float(&new_bolt_type.b_shrink);
+
+			// b_poly_pct
+			required_string("+b_poly_pct:");
+			stuff_float(&new_bolt_type.b_poly_pct);
+
+			// child rand
+			required_string("+b_rand:");
+			stuff_float(&new_bolt_type.b_rand);
+
+			// z add
+			required_string("+b_add:");
+			stuff_float(&new_bolt_type.b_add);
+
+			// # strikes
+			required_string("+b_strikes:");
+			stuff_int(&new_bolt_type.num_strikes);
+
+			// lifetime
+			required_string("+b_lifetime:");
+			stuff_int(&new_bolt_type.lifetime);
+
+			// noise
+			required_string("+b_noise:");
+			stuff_float(&new_bolt_type.noise);
+
+			// emp effect
+			required_string("+b_emp:");
+			stuff_float(&new_bolt_type.emp_intensity);
+			stuff_float(&new_bolt_type.emp_time);
+
+			// texture
+			required_string("+b_texture:");
+			stuff_string(name, F_NAME, sizeof(name));
+			if (!Fred_running){
+				new_bolt_type.texture = bm_load(name);
+			}
+
+			// glow
+			required_string("+b_glow:");
+			stuff_string(name, F_NAME, sizeof(name));
+			if (!Fred_running){
+				new_bolt_type.glow = bm_load(name);
+			}
+
+			// brightness
+			required_string("+b_bright:");
+			stuff_float(&new_bolt_type.b_bright);
+
+			Bolt_types.push_back(new_bolt_type);
+		}
+
+		// parse lightning storm types
+		required_string("#Storms begin");
+		while (!optional_string("#Storms end")){
+			storm_type new_storm_type;
+
+			// bolt title
+			required_string("$Storm:");
+			stuff_string(new_storm_type.name, F_NAME, NAME_LENGTH);
+
+			// bolt types
+			while (optional_string("+bolt:")){
+				if (new_storm_type.num_bolt_types < MAX_BOLT_TYPES_PER_STORM){
+					stuff_string(name, F_NAME, sizeof(name));
+
+					new_storm_type.bolt_types[new_storm_type.num_bolt_types] = nebl_get_bolt_index(name);
+					Assert(new_storm_type.bolt_types[new_storm_type.num_bolt_types] != (size_t)-1);
+
+					new_storm_type.num_bolt_types++;
+				}
+			}
+
+			// flavor
+			required_string("+flavor:");
+			stuff_float(&new_storm_type.flavor.xyz.x);
+			stuff_float(&new_storm_type.flavor.xyz.y);
+			stuff_float(&new_storm_type.flavor.xyz.z);
+
+			// frequencies
+			required_string("+random_freq:");
+			stuff_int(&new_storm_type.min);
+			stuff_int(&new_storm_type.max);
+
+			// counts
+			required_string("+random_count:");
+			stuff_int(&new_storm_type.min_count);
+			stuff_int(&new_storm_type.max_count);
+
+			Storm_types.push_back(new_storm_type);
+		}
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "lightning.tbl", e.what()));
 		return;
 	}
-
-	// parse the lightning table
-	read_file_text("lightning.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	// parse the individual lightning bolt types
-	required_string("#Bolts begin");
-	while(!optional_string("#Bolts end")){
-		bolt_type new_bolt_type;
-
-		// bolt title
-		required_string("$Bolt:");
-		stuff_string(new_bolt_type.name, F_NAME, NAME_LENGTH);
-
-		// b_scale
-		required_string("+b_scale:");
-		stuff_float(&new_bolt_type.b_scale);
-
-		// b_shrink
-		required_string("+b_shrink:");
-		stuff_float(&new_bolt_type.b_shrink);
-
-		// b_poly_pct
-		required_string("+b_poly_pct:");
-		stuff_float(&new_bolt_type.b_poly_pct);		
-
-		// child rand
-		required_string("+b_rand:");
-		stuff_float(&new_bolt_type.b_rand);
-
-		// z add
-		required_string("+b_add:");
-		stuff_float(&new_bolt_type.b_add);
-
-		// # strikes
-		required_string("+b_strikes:");
-		stuff_int(&new_bolt_type.num_strikes);
-
-		// lifetime
-		required_string("+b_lifetime:");
-		stuff_int(&new_bolt_type.lifetime);
-
-		// noise
-		required_string("+b_noise:");
-		stuff_float(&new_bolt_type.noise);
-
-		// emp effect
-		required_string("+b_emp:");
-		stuff_float(&new_bolt_type.emp_intensity);
-		stuff_float(&new_bolt_type.emp_time);
-
-		// texture
-		required_string("+b_texture:");
-		stuff_string(name, F_NAME, sizeof(name));
-		if(!Fred_running){
-			new_bolt_type.texture = bm_load(name);
-		}
-
-		// glow
-		required_string("+b_glow:");
-		stuff_string(name, F_NAME, sizeof(name));
-		if(!Fred_running){
-			new_bolt_type.glow = bm_load(name);
-		}
-
-		// brightness
-		required_string("+b_bright:");
-		stuff_float(&new_bolt_type.b_bright);
-
-		Bolt_types.push_back(new_bolt_type);
-	}
-
-	// parse lightning storm types
-	required_string("#Storms begin");
-	while(!optional_string("#Storms end")){
-		storm_type new_storm_type;
-
-		// bolt title
-		required_string("$Storm:");
-		stuff_string(new_storm_type.name, F_NAME, NAME_LENGTH);
-
-		// bolt types
-		while(optional_string("+bolt:")){			
-			if(new_storm_type.num_bolt_types < MAX_BOLT_TYPES_PER_STORM){
-				stuff_string(name, F_NAME, sizeof(name));	
-				
-				new_storm_type.bolt_types[new_storm_type.num_bolt_types] = nebl_get_bolt_index(name);
-				Assert(new_storm_type.bolt_types[new_storm_type.num_bolt_types] != (size_t)-1);								
-
-				new_storm_type.num_bolt_types++;
-			} 			
-		}
-
-		// flavor
-		required_string("+flavor:");
-		stuff_float(&new_storm_type.flavor.xyz.x);
-		stuff_float(&new_storm_type.flavor.xyz.y);
-		stuff_float(&new_storm_type.flavor.xyz.z);
-
-		// frequencies
-		required_string("+random_freq:");
-		stuff_int(&new_storm_type.min);
-		stuff_int(&new_storm_type.max);
-
-		// counts
-		required_string("+random_count:");
-		stuff_int(&new_storm_type.min_count);
-		stuff_int(&new_storm_type.max_count);
-
-		Storm_types.push_back(new_storm_type);
-	}
 }
 
 // initialize lightning before entering a level

code/network/multi_options.cpp

@@ -585,6 +585,11 @@ void multi_options_process_packet(unsigned char *data, header *hinfo)
 	// find out who is sending this data	
 	player_index = find_player_id(hinfo->id);
 
+	if (player_index < 0) {
+		nprintf(("Network", "Received packet from unknown player!\n"));
+		return;
+	}
+
 	// get the packet code
 	GET_DATA(code);
 	switch(code){

code/network/multi_pxo.cpp

@@ -4511,7 +4511,8 @@ void multi_pxo_pinfo_build_vals()
 	if (fs->stats.last_flown == 0) {		
 		strcpy_s(Multi_pxo_pinfo_vals[7], XSTR("No missions flown", 970) );
 	} else {
-		tm *tmr = gmtime( (time_t*)&fs->stats.last_flown );
+		time_t tmp_lf = fs->stats.last_flown; // don't cast a pointer to a type that can be either 32 or 64bit
+		tm *tmr = gmtime( &tmp_lf );
 
 		if (tmr != NULL)
 			strftime(Multi_pxo_pinfo_vals[7], 30, "%m/%d/%y %H:%M", tmr);	

code/network/multiutil.cpp

@@ -1599,6 +1599,12 @@ void multi_create_standalone_object()
 
 	vm_vec_zero(&v);
 	objnum = observer_create(&m,&v);
+
+	if (objnum < 0) {
+		Error(LOCATION, "Failed to create standalone observer object! Please investigate!");
+		return;
+	}
+
 	Player_obj = &Objects[objnum];
 	obj_set_flags(Player_obj, Player_obj->flags & (~OF_COLLIDES) );
 	//obj_set_flags(Player_obj, Player_obj->flags | OF_SHOULD_BE_DEAD);

code/object/object.cpp

@@ -51,7 +51,7 @@
 
 object obj_free_list;
 object obj_used_list;
-object obj_create_list;
+object obj_create_list;	
 
 object *Player_obj = NULL;
 object *Viewer_obj = NULL;
@@ -716,7 +716,7 @@ void obj_move_one_docked_object(object *objp, object *parent_objp)
  * Deals with firing player things like lasers, missiles, etc.
  *
  * Separated out because of multiplayer issues.
- */
+*/
 void obj_player_fire_stuff( object *objp, control_info ci )
 {
 	ship *shipp;
@@ -888,7 +888,7 @@ void obj_move_call_physics(object *objp, float frametime)
 				goto obj_maybe_fire;
 			}
 
-			physics_sim(&objp->pos, &objp->orient, &objp->phys_info, frametime );		// simulate the physics
+				physics_sim(&objp->pos, &objp->orient, &objp->phys_info, frametime );		// simulate the physics
 
 			// if the object is the player object, do things that need to be done after the ship
 			// is moved (like firing weapons, etc).  This routine will get called either single
@@ -906,7 +906,7 @@ obj_maybe_fire:
 			// do stream weapon firing for all ships themselves. 
 			if(objp->type == OBJ_SHIP){
 				ship_fire_primary(objp, 1, 0);
-				has_fired = 1;
+					has_fired = 1;
 			}
 		}
 	}
@@ -1411,7 +1411,7 @@ void obj_move_all(float frametime)
 		vec3d cur_pos = objp->pos;			// Save the current position
 
 #ifdef OBJECT_CHECK 
-		obj_check_object( objp );
+			obj_check_object( objp );
 #endif
 
 		// pre-move
@@ -1708,7 +1708,7 @@ void obj_get_average_ship_pos( vec3d *pos )
 
 	vm_vec_zero( pos );
 
-	// average up all ship positions
+   // average up all ship positions
 	count = 0;
 	for ( objp = GET_FIRST(&obj_used_list); objp != END_OF_LIST(&obj_used_list); objp = GET_NEXT(objp) ) {
 		if ( objp->type != OBJ_SHIP )

code/osapi/outwnd_unix.cpp

@@ -35,7 +35,8 @@ void outwnd_print(const char *id = NULL, const char *temp = NULL);
 bool outwnd_inited = false;
 ubyte Outwnd_no_filter_file = 0;		// 0 = .cfg file found, 1 = not found and warning not printed yet, 2 = not found and warning printed
 
-struct outwnd_filter_struct {
+class outwnd_filter_struct {
+public:
 	char name[NAME_LENGTH];
 	bool enabled;
 
@@ -75,22 +76,16 @@ void load_filter_info(void)
 	if (!fp) {
 		Outwnd_no_filter_file = 1;
 
-		memset( &new_filter, 0, sizeof(outwnd_filter_struct) );
 		strcpy_s( new_filter.name, "error" );
 		new_filter.enabled = true;
-
 		OutwndFilter.push_back( new_filter );
 
-		memset( &new_filter, 0, sizeof(outwnd_filter_struct) );
 		strcpy_s( new_filter.name, "general" );
 		new_filter.enabled = true;
-
 		OutwndFilter.push_back( new_filter );
 
-		memset( &new_filter, 0, sizeof(outwnd_filter_struct) );
 		strcpy_s( new_filter.name, "warning" );
 		new_filter.enabled = true;
-
 		OutwndFilter.push_back( new_filter );
 
 		return;
@@ -99,7 +94,6 @@ void load_filter_info(void)
 	Outwnd_no_filter_file = 0;
 
 	while ( fgets(inbuf, NAME_LENGTH+3, fp) ) {
-		memset( &new_filter, 0, sizeof(outwnd_filter_struct) );
 
 		if (*inbuf == '+')
 			new_filter.enabled = true;

code/palman/palman.cpp

@@ -64,28 +64,30 @@ int palman_is_nondarkening(int r,int g, int b)
 
 void palman_load_pixels()
 {
-	int rval;
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "pixels.tbl", rval));
+	try
+	{
+		// open pixels.tbl
+		read_file_text("pixels.tbl", CF_TYPE_TABLES);
+		reset_parse();
+
+		// parse pixels	
+		while (!optional_string("#END")){
+			// nondarkening pixel
+			if (required_string("+ND")){
+				stuff_ubyte(&Palman_non_darkening_default[Palman_num_nondarkening_default][0]);
+				stuff_ubyte(&Palman_non_darkening_default[Palman_num_nondarkening_default][1]);
+				stuff_ubyte(&Palman_non_darkening_default[Palman_num_nondarkening_default++][2]);
+			}
+		}
+
+		// set this to be the active table
+		palman_set_nondarkening(Palman_non_darkening_default, Palman_num_nondarkening_default);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "pixels.tbl", e.what()));
 		return;
 	}
-
-	// open pixels.tbl
-	read_file_text("pixels.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	// parse pixels	
-	while(!optional_string("#END")){
-		// nondarkening pixel
-		if(required_string("+ND")){
-			stuff_ubyte(&Palman_non_darkening_default[Palman_num_nondarkening_default][0]);
-			stuff_ubyte(&Palman_non_darkening_default[Palman_num_nondarkening_default][1]);
-			stuff_ubyte(&Palman_non_darkening_default[Palman_num_nondarkening_default++][2]);
-		}
-	}
-
-	// set this to be the active table
-	palman_set_nondarkening(Palman_non_darkening_default, Palman_num_nondarkening_default);
 }
 
 void palman_set_nondarkening(ubyte colors[MAX_NONDARK_COLORS][3], int size)
@@ -526,84 +528,6 @@ void palette_update(const char *name_with_extension, int restrict_font_to_128)
 	}
 }
 
-ubyte *palette_get_fade_table()
-{
-	int i,l;
-
-	if ( palman_screen_signature != gr_screen.signature )	{
-		palman_screen_signature = gr_screen.signature;
-		palette_fade_table_calculated = 0;
-	}
-
-
-	if ( !palette_fade_table_calculated )	{
-		//mprintf(( "Creating fading table..." ));	
-
-		for (i=0; i<256; i++ )	{
-			int r, g, b;
-			int ur, ug, ub;
-			r = gr_palette[i*3+0];
-			g = gr_palette[i*3+1];
-			b = gr_palette[i*3+2];
-
-			if ( palman_is_nondarkening(r,g,b))		{
-				// Make pure white not fade
-				for (l=0; l<32; l++ )	{
-					gr_fade_table[((l+1)*256)+i] = (unsigned char)i;
-				}
-			} else {
-				for (l=0; l<32; l++ )	{
-
-					if ( l < 24 )	{
-						float f = (float)pow(i2fl(l)/23.0f, 1.0f/Gr_gamma);
-						ur = fl2i(i2fl(r)*f); if ( ur > 255 ) ur = 255;
-						ug = fl2i(i2fl(g)*f); if ( ug > 255 ) ug = 255;
-						ub = fl2i(i2fl(b)*f); if ( ub > 255 ) ub = 255;
-					} else {
-						int x,y;
-						int gi, gr, gg, gb;
-			
-						gi = (r+g+b)/3;
-
-						#ifdef RGB_LIGHTING
-							gr = r;
-							gg = g;
-							gb = gi*2;
-						#else
-							gr = r*2;
-							gg = g*2;
-							gb = b*2;
-						#endif
-				
-						x = l-24;			// x goes from 0 to 7
-						y = 31-l;			// y goes from 7 to 0
-
-						ur = ((gr*x)+(r*y))/7; if ( ur > 255 ) ur = 255;
-						ug = ((gg*x)+(g*y))/7; if ( ug > 255 ) ug = 255;
-						ub = ((gb*x)+(b*y))/7; if ( ub > 255 ) ub = 255;
-					}
-					gr_fade_table[((l+1)*256)+i] = (unsigned char)palette_find( ur, ug, ub );
-
-				}
-			}
-			gr_fade_table[ (0*256)+i ] = gr_fade_table[ (1*256)+i ];
-			gr_fade_table[ (33*256)+i ] = gr_fade_table[ (32*256)+i ];
-		}
-
-		// Mirror the fade table
-		for (i=0; i<34; i++ )	{
-			for ( l = 0; l < 256; l++ )	{
-				gr_fade_table[ ((67-i)*256)+l ] = gr_fade_table[ (i*256)+l ];
-			}
-		}
-
-//		mprintf(( "done\n" ));	
-		palette_fade_table_calculated = 1;
-	}
-
-	return &gr_fade_table[0];
-}
-
 
 ubyte *palette_get_blend_table(float alpha)
 {

code/palman/palman.h

@@ -24,7 +24,6 @@ extern void palette_flush();
 // Functions to query a palette
 extern uint palette_compute_checksum( ubyte *pal );		// computes checksum of palette
 extern ubyte *palette_get_blend_table(float alpha);
-extern ubyte *palette_get_fade_table();
 
 extern uint palette_find( int r, int g, int b );
 

code/parse/lua.cpp

@@ -2632,7 +2632,7 @@ ADE_VIRTVAR(RotationalVelocityDamping, l_Physics, "number", "Rotational damping,
 	return ade_set_args(L, "f", pih->pi->rotdamp);
 }
 
-ADE_VIRTVAR(RotationalVelocityDesired, l_Physics, "lvector", "Desired rotational velocity", "number", "Desired rotational velocity, or 0 if handle is invalid")
+ADE_VIRTVAR(RotationalVelocityDesired, l_Physics, "vector", "Desired rotational velocity", "vector", "Desired rotational velocity, or null vector if handle is invalid")
 {
 	physics_info_h *pih;
 	vec3d *v3=NULL;
@@ -6580,9 +6580,9 @@ ADE_VIRTVAR(AmmoMax, l_WeaponBank, "number", "Maximum ammo for the current bank<
 	{
 		case SWH_PRIMARY:
 			{
-				if(ADE_SETTING_VAR && ammomax > -1) {
+			if(ADE_SETTING_VAR && ammomax > -1) {
 					bh->sw->primary_bank_capacity[bh->bank] = ammomax;
-				}
+			}
 
 				int weapon_class = bh->sw->primary_bank_weapons[bh->bank];
 
@@ -6592,9 +6592,9 @@ ADE_VIRTVAR(AmmoMax, l_WeaponBank, "number", "Maximum ammo for the current bank<
 			}
 		case SWH_SECONDARY:
 			{
-				if(ADE_SETTING_VAR && ammomax > -1) {
+			if(ADE_SETTING_VAR && ammomax > -1) {
 					bh->sw->secondary_bank_capacity[bh->bank] = ammomax;
-				}
+			}
 
 				int weapon_class = bh->sw->secondary_bank_weapons[bh->bank];
 

code/parse/parselo.cpp

@@ -43,7 +43,6 @@ int		Warning_count, Error_count;
 int		Warning_count_save = 0, Error_count_save = 0;
 int		fred_parse_flag = 0;
 int		Token_found_flag;
-jmp_buf	parse_abort;
 
 char 	*Mission_text = NULL;
 char	*Mission_text_raw = NULL;
@@ -483,7 +482,7 @@ int required_string(char *pstr)
 	if (count == RS_MAX_TRIES) {
 		nprintf(("Error", "Error: Unable to find required token [%s]\n", pstr));
 		Warning(LOCATION, "Error: Unable to find required token [%s]\n", pstr);
-		longjmp(parse_abort, 1);
+        throw parse::ParseException("Required string not found");
 	}
 
 	Mp += strlen(pstr);
@@ -691,8 +690,8 @@ int required_string_either(char *str1, char *str2)
 
 	if (count == RS_MAX_TRIES) {
 		nprintf(("Error", "Error: Unable to find either required token [%s] or [%s]\n", str1, str2));
-		Warning(LOCATION, "Error: Unable to find either required token [%s] or [%s]\n", str1, str2);
-		longjmp(parse_abort, 2);
+        Warning(LOCATION, "Error: Unable to find either required token [%s] or [%s]\n", str1, str2);
+        throw parse::ParseException("Required string not found");
 	}
 
 	return -1;
@@ -887,8 +886,8 @@ char* alloc_text_until(char* instr, char* endstr)
 
 	if(foundstr == NULL)
 	{
-		Error(LOCATION, "Missing [%s] in file");
-		longjmp(parse_abort, 3);
+        Error(LOCATION, "Missing [%s] in file", endstr);
+        throw parse::ParseException("End string not found");
 	}
 	else
 	{
@@ -922,8 +921,8 @@ void copy_text_until(char *outstr, char *instr, char *endstr, int max_chars)
 	foundstr = stristr(instr, endstr);
 
 	if (foundstr == NULL) {
-		nprintf(("Error", "Error.  Looking for [%s], but never found it.\n", endstr));
-		longjmp(parse_abort, 3);
+        nprintf(("Error", "Error.  Looking for [%s], but never found it.\n", endstr));
+        throw parse::ParseException("End string not found");
 	}
 
 	if (foundstr - instr + strlen(endstr) < (uint) max_chars) {
@@ -934,7 +933,7 @@ void copy_text_until(char *outstr, char *instr, char *endstr, int max_chars)
 		nprintf(("Error", "Error.  Too much text (%i chars, %i allowed) before %s\n",
 			foundstr - instr - strlen(endstr), max_chars, endstr));
 
-		longjmp(parse_abort, 4);
+        throw parse::ParseException("Too much text found");
 	}
 
 	diag_printf("Here's the partial wad of text:\n%.30s\n", outstr);
@@ -949,8 +948,8 @@ void copy_text_until(SCP_string &outstr, char *instr, char *endstr)
 	foundstr = stristr(instr, endstr);
 
 	if (foundstr == NULL) {
-		nprintf(("Error", "Error.  Looking for [%s], but never found it.\n", endstr));
-		longjmp(parse_abort, 3);
+        nprintf(("Error", "Error.  Looking for [%s], but never found it.\n", endstr));
+        throw parse::ParseException("End string not found");
 	}
 
 	outstr.assign(instr, foundstr - instr);
@@ -1046,8 +1045,8 @@ char* alloc_block(char* startstr, char* endstr, int extra_chars)
 	//Check that we left the file
 	if(level > 0)
 	{
-		Error(LOCATION, "Unclosed pair of \"%s\" and \"%s\" on line %d in file", startstr, endstr, get_line_num());
-		longjmp(parse_abort, 3);
+        Error(LOCATION, "Unclosed pair of \"%s\" and \"%s\" on line %d in file", startstr, endstr, get_line_num());
+        throw parse::ParseException("End string not found");
 	}
 	else
 	{
@@ -1967,8 +1966,9 @@ int parse_get_line(char *lineout, int max_line_len, char *start, int max_size, c
 void read_file_text(const char *filename, int mode, char *processed_text, char *raw_text)
 {
 	// copy the filename
-	if (!filename)
-		longjmp(parse_abort, 10);
+    if (!filename)
+        throw parse::ParseException("Invalid filename");
+
 	strcpy_s(Current_filename_sub, filename);
 
 	// if we are paused then processed_text and raw_text must not be NULL!!
@@ -2106,16 +2106,16 @@ void read_raw_file_text(const char *filename, int mode, char *raw_text)
 	mf = cfopen(filename, "rb", CFILE_NORMAL, mode);
 	if (mf == NULL)
 	{
-		nprintf(("Error", "Wokka!  Error opening file (%s)!\n", filename));
-		longjmp(parse_abort, 5);
+        nprintf(("Error", "Wokka!  Error opening file (%s)!\n", filename));
+        throw parse::ParseException("Failed to open file");
 	}
 
 	// read the entire file in
 	int file_len = cfilelength(mf);
 
 	if(!file_len) {
-		nprintf(("Error", "Oh noes!!  File is empty! (%s)!\n", filename));
-		longjmp(parse_abort, 5);
+        nprintf(("Error", "Oh noes!!  File is empty! (%s)!\n", filename));
+        throw parse::ParseException("Failed to open file");
 	}
 
 	// allocate, or reallocate, memory for Mission_text and Mission_text_raw based on size we need now
@@ -2567,8 +2567,8 @@ int stuff_bool_list(bool *blp, int max_bools)
 	ignore_white_space();
 	
 	if (*Mp != '(') {
-		error_display(1, "Reading boolean list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading boolean list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -2665,8 +2665,8 @@ int stuff_string_list(SCP_vector<SCP_string>& slp)
 	ignore_white_space();
 
 	if ( *Mp != '(' ) {
-		error_display(1, "Reading string list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 100);
+        error_display(1, "Reading string list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -2699,8 +2699,8 @@ int stuff_string_list(char slp[][NAME_LENGTH], int max_strings)
 	ignore_white_space();
 
 	if ( *Mp != '(' ) {
-		error_display(1, "Reading string list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 100);
+        error_display(1, "Reading string list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -2756,8 +2756,8 @@ int stuff_int_list(int *ilp, int max_ints, int lookup_type)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Reading integer list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading integer list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -2858,8 +2858,8 @@ int stuff_loadout_list (int *ilp, int max_ints, int lookup_type)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Reading loadout list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading loadout list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -2962,8 +2962,8 @@ int stuff_float_list(float* flp, int max_floats)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Reading float list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading float list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -2995,8 +2995,8 @@ void mark_int_list(int *ilp, int max_ints, int lookup_type)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Marking integer list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Marking integer list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -3062,15 +3062,15 @@ void stuff_parenthesized_vec3d(vec3d *vp)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Reading parenthesized vec3d.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 11);
+        error_display(1, "Reading parenthesized vec3d.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	} else {
 		Mp++;
 		stuff_vec3d(vp);
 		ignore_white_space();
 		if (*Mp != ')') {
-			error_display(1, "Reading parenthesized vec3d.  Found [%c].  Expecting ')'.\n", *Mp);
-			longjmp(parse_abort, 12);
+            error_display(1, "Reading parenthesized vec3d.  Found [%c].  Expecting ')'.\n", *Mp);
+            throw parse::ParseException("Syntax error");
 		}
 		Mp++;
 	}
@@ -3089,8 +3089,8 @@ int stuff_vec3d_list(vec3d *vlp, int max_vecs)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Reading vec3d list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading vec3d list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -3120,8 +3120,8 @@ int stuff_vec3d_list(SCP_vector<vec3d> &vec_list)
 	ignore_white_space();
 
 	if (*Mp != '(') {
-		error_display(1, "Reading vec3d list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading vec3d list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;

code/parse/parselo.h

@@ -14,9 +14,7 @@
 #include "cfile/cfile.h"
 #include "globalincs/pstypes.h"
 
-#include <csetjmp>
-#include <cstdio>
-#include <string>
+#include <exception>
 
 // NOTE: although the main game doesn't need this anymore, FRED2 still does
 #define	MISSION_TEXT_SIZE	1000000
@@ -27,7 +25,6 @@ extern char	*Mp;
 extern char	*token_found;
 extern int fred_parse_flag;
 extern int Token_found_flag;
-extern jmp_buf parse_abort;
 
 
 #define	COMMENT_CHAR	(char)';'
@@ -257,4 +254,14 @@ int get_string_or_variable (SCP_string &str);
 #define PARSING_FOUND_STRING		0
 #define PARSING_FOUND_VARIABLE		1
 
+namespace parse
+{
+	class ParseException : public std::runtime_error
+	{
+	public:
+		ParseException(const std::string& msg) : std::runtime_error(msg) {}
+		~ParseException() throw() {}
+	};
+}
+
 #endif

code/parse/scripting.cpp

@@ -109,46 +109,42 @@ bool script_hook_valid(script_hook *hook)
 void script_parse_table(const char *filename)
 {
 	script_state *st = &Script_system;
-	int rval;
-	if ((rval = setjmp(parse_abort)) != 0)
+	
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	}
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
+		if (optional_string("#Global Hooks"))
+		{
+			//int num = 42;
+			//Script_system.SetHookVar("Version", 'i', &num);
+			if (optional_string("$Global:")) {
+				st->ParseChunk(&Script_globalhook, "Global");
+			}
 
-	if(optional_string("#Global Hooks"))
-	{
-		//int num = 42;
-		//Script_system.SetHookVar("Version", 'i', &num);
-		if(optional_string("$Global:")) {
-			st->ParseChunk(&Script_globalhook, "Global");
+			if (optional_string("$Splash:")) {
+				st->ParseChunk(&Script_splashhook, "Splash");
+			}
+
+			if (optional_string("$GameInit:")) {
+				st->ParseChunk(&Script_gameinithook, "GameInit");
+			}
+
+			if (optional_string("$Simulation:")) {
+				st->ParseChunk(&Script_simulationhook, "Simulation");
+			}
+
+			if (optional_string("$HUD:")) {
+				st->ParseChunk(&Script_hudhook, "HUD");
+			}
+
+			required_string("#End");
 		}
-
-		if(optional_string("$Splash:")) {
-			st->ParseChunk(&Script_splashhook, "Splash");
-		}
-
-		if(optional_string("$GameInit:")) {
-			st->ParseChunk(&Script_gameinithook, "GameInit");
-		}
-
-		if(optional_string("$Simulation:")) {
-			st->ParseChunk(&Script_simulationhook, "Simulation");
-		}
-
-		if(optional_string("$HUD:")) {
-			st->ParseChunk(&Script_hudhook, "HUD");
-		}
-
-		required_string("#End");
-	}
-/*
-	if(optional_string("#State Hooks"))
-	{
-		while(optional_string("$State:")) {
+		/*
+			if(optional_string("#State Hooks"))
+			{
+			while(optional_string("$State:")) {
 			char buf[NAME_LENGTH];
 			int idx;
 			stuff_string(buf, F_NAME, sizeof(buf));
@@ -157,25 +153,31 @@ void script_parse_table(const char *filename)
 
 			if(optional_string("$Hook:"))
 			{
-				if(idx > -1) {
-					GS_state_hooks[idx] = st->ParseChunk(buf);
-				} else {
-					st->ParseChunk(buf);
-				}
+			if(idx > -1) {
+			GS_state_hooks[idx] = st->ParseChunk(buf);
+			} else {
+			st->ParseChunk(buf);
 			}
+			}
+			}
+			required_string("#End");
+			}
+			*/
+		if (optional_string("#Conditional Hooks"))
+		{
+			while (st->ParseCondition(filename));
+			required_string("#End");
 		}
-		required_string("#End");
-	}
-*/
-	if(optional_string("#Conditional Hooks"))
-	{
-		while(st->ParseCondition(filename));
-		required_string("#End");
-	}
 
-	// add tbl/tbm to multiplayer validation list
-	extern void fs2netd_add_table_validation(const char *tblname);
-	fs2netd_add_table_validation(filename);
+		// add tbl/tbm to multiplayer validation list
+		extern void fs2netd_add_table_validation(const char *tblname);
+		fs2netd_add_table_validation(filename);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
+	}
 }
 
 //Initializes the (global) scripting system, as well as any subsystems.

code/parse/sexp.cpp

@@ -3576,8 +3576,8 @@ int stuff_sexp_variable_list()
 
 	// check for start of list
 	if (*Mp != '(') {
-		error_display(1, "Reading sexp variable list.  Found [%c].  Expecting '('.\n", *Mp);
-		longjmp(parse_abort, 6);
+        error_display(1, "Reading sexp variable list.  Found [%c].  Expecting '('.\n", *Mp);
+        throw parse::ParseException("Syntax error");
 	}
 
 	Mp++;
@@ -4392,7 +4392,7 @@ int sexp_and(int n)
 		if (CAR(n) != -1)
 		{
 			result &= is_sexp_true(CAR(n));
-			if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_FALSE )
+			if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_FALSE || Sexp_nodes[CAR(n)].value == SEXP_NAN_FOREVER )
 				return SEXP_KNOWN_FALSE;							// if one of the AND clauses is FALSE, whole clause is false
 			if ( Sexp_nodes[CAR(n)].value != SEXP_KNOWN_TRUE )		// if the value is still unknown, they all can't be true
 				all_true = 0;
@@ -4406,7 +4406,7 @@ int sexp_and(int n)
 
 			new_result = is_sexp_true(CDR(n));
 			result &= new_result;
-			if ( Sexp_nodes[CDR(n)].value == SEXP_KNOWN_FALSE )
+			if ( Sexp_nodes[CDR(n)].value == SEXP_KNOWN_FALSE || Sexp_nodes[CDR(n)].value == SEXP_NAN_FOREVER )
 				return SEXP_KNOWN_FALSE;							// if one of the AND clauses is FALSE, whole clause is false
 			if ( Sexp_nodes[CDR(n)].value != SEXP_KNOWN_TRUE )		// if the value is still unknown, they all can't be true
 				all_true = 0;
@@ -4435,7 +4435,7 @@ int sexp_and_in_sequence(int n)
 		if (CAR(n) != -1)
 		{
 			result &= is_sexp_true(CAR(n));
-			if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_FALSE )
+			if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_FALSE || Sexp_nodes[CAR(n)].value == SEXP_NAN_FOREVER )
 				return SEXP_KNOWN_FALSE;														// if one of the AND clauses is FALSE, whole clause is false
 			if ( Sexp_nodes[CAR(n)].value != SEXP_KNOWN_TRUE )		// if value is true, mark our all_true variable for later checking
 				all_true = 0;
@@ -4458,7 +4458,7 @@ int sexp_and_in_sequence(int n)
 			if ( next_result && !result )				// if current result is true, and our running result is false, thngs didn't become true in order
 				return SEXP_KNOWN_FALSE;
 			result &= next_result;
-			if ( Sexp_nodes[CDR(n)].value == SEXP_KNOWN_FALSE )
+			if ( Sexp_nodes[CDR(n)].value == SEXP_KNOWN_FALSE || Sexp_nodes[CDR(n)].value == SEXP_NAN_FOREVER )
 				return SEXP_KNOWN_FALSE;															// if one of the OR clauses is TRUE, whole clause is true
 			if ( Sexp_nodes[CDR(n)].value != SEXP_KNOWN_TRUE )				// if the value is still unknown, they all can't be false
 				all_true = 0;
@@ -4490,14 +4490,12 @@ int sexp_not(int n)
 		if (CAR(n) != -1)
 		{
 			result = is_sexp_true(CAR(n));
-			if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_FALSE )
+			if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_FALSE || Sexp_nodes[CDR(n)].value == SEXP_NAN_FOREVER )
 				return SEXP_KNOWN_TRUE;												// not KNOWN_FALSE == KNOWN_TRUE;
 			else if ( Sexp_nodes[CAR(n)].value == SEXP_KNOWN_TRUE )		// not KNOWN_TRUE == KNOWN_FALSE
 				return SEXP_KNOWN_FALSE;
 			else if ( Sexp_nodes[CAR(n)].value == SEXP_NAN )				// not NAN == TRUE (I think)
 				return SEXP_TRUE;
-			else if ( Sexp_nodes[CAR(n)].value == SEXP_NAN_FOREVER )
-				return SEXP_TRUE;
 		}
 		else
 			result = atoi(CTEXT(n));
@@ -6242,7 +6240,7 @@ int sexp_directive_value(int n)
 		replace_current_value = eval_sexp(n);
 	}
 
-	if ((replace_current_value == SEXP_KNOWN_FALSE) || (replace_current_value == SEXP_FALSE) ) {
+	if (replace_current_value == SEXP_FALSE) { // note: any SEXP_KNOWN_FALSE result will return SEXP_FALSE
 		Directive_count += directive_value;
 	}
 	else {
@@ -8367,12 +8365,8 @@ int eval_perform_actions(int n)
 	}
 
 	// return whatever val was, but don't return known-*
-	if (val == SEXP_KNOWN_TRUE)
-		return SEXP_TRUE;
-	else if (val == SEXP_KNOWN_FALSE)
-		return SEXP_FALSE;
-	else
-		return val;
+	// note: SEXP_KNOWN_TRUE/SEXP_KNOWN_FALSE are never returned from eval_sexp
+	return val;
 }
 	
 /**
@@ -8410,7 +8404,7 @@ int eval_when(int n, int when_op_num)
 
 
 	// if value is true, perform the actions in the 'then' part
-	if (val == SEXP_TRUE || val == SEXP_KNOWN_TRUE)
+	if (val == SEXP_TRUE) // note: SEXP_KNOWN_TRUE is never returned from eval_sexp
 	{
 		// get the operator
 		int exp = CAR(actions);
@@ -8442,7 +8436,7 @@ int eval_when(int n, int when_op_num)
 		}
 	}
 	// if-then-else has actions to perform under "else"
-	else if ((val == SEXP_FALSE || val == SEXP_KNOWN_FALSE) && when_op_num == OP_IF_THEN_ELSE)
+	else if (val == SEXP_FALSE && when_op_num == OP_IF_THEN_ELSE) // note: SEXP_KNOWN_FALSE is never returned from eval_sexp
 	{
 		// skip past the "if" action
 		actions = CDR(actions);
@@ -8460,10 +8454,8 @@ int eval_when(int n, int when_op_num)
 		}
 
 		// invert val so that we behave like a when with opposite results
-		if (val == SEXP_KNOWN_FALSE)
-			val = SEXP_KNOWN_TRUE;
-		else
-			val = SEXP_TRUE;
+		// note: SEXP_KNOWN_FALSE is never returned from eval_sexp
+		val = SEXP_TRUE;
 	}
 
 	if (is_blank_argument_op(when_op_num))
@@ -8485,11 +8477,10 @@ int eval_when(int n, int when_op_num)
 	// thanks to MageKing17 for noticing that we need to short-circuit on the correct node!
 	int short_circuit_node = (arg_handler >= 0) ? arg_handler : cond;
 
-	if (Sexp_nodes[short_circuit_node].value == SEXP_KNOWN_FALSE)
+	if (Sexp_nodes[short_circuit_node].value == SEXP_KNOWN_FALSE || Sexp_nodes[short_circuit_node].value == SEXP_NAN_FOREVER)
 		return SEXP_KNOWN_FALSE;  // no need to waste time on this anymore
 
-	if (val == SEXP_KNOWN_FALSE)
-		return SEXP_FALSE;  // can't return known false, as this would bypass future actions under the when
+	// note: val can't be SEXP_KNOWN_FALSE at this point
 
 	return val;
 }
@@ -8510,7 +8501,7 @@ int eval_cond(int n)
 
 		// if the conditional evaluated to true, then we must evaluate the rest of the expression returning
 		// the value of this evaluation
-		if (val == SEXP_TRUE || val == SEXP_KNOWN_TRUE)
+		if (val == SEXP_TRUE) // note: any SEXP_KNOWN_TRUE result is returned as SEXP_TRUE
 		{
 			int actions, exp;
 
@@ -8566,6 +8557,13 @@ int test_argument_nodes_for_condition(int n, int condition_node, int *num_true,
 			// evaluate conditional for current argument
 			Sexp_replacement_arguments.push_back(Sexp_nodes[n].text);
 			val = eval_sexp(condition_node);
+			if ( Sexp_nodes[condition_node].value == SEXP_KNOWN_TRUE ||
+					Sexp_nodes[condition_node].value == SEXP_KNOWN_FALSE) {
+				val = Sexp_nodes[condition_node].value;
+			} else if ( Sexp_nodes[condition_node].value == SEXP_NAN_FOREVER ) {
+				// In accordance with SEXP_NAN/SEXP_NAN_FOREVER becoming SEXP_FALSE in eval_sexp()
+				val = SEXP_KNOWN_FALSE;
+			}
 
 			switch (val)
 			{
@@ -8640,6 +8638,13 @@ int test_argument_vector_for_condition(SCP_vector<char*> argument_vector, bool a
 			// evaluate conditional for current argument
 			Sexp_replacement_arguments.push_back(argument_vector[i]);
 			val = eval_sexp(condition_node);
+			if ( Sexp_nodes[condition_node].value == SEXP_KNOWN_TRUE ||
+					Sexp_nodes[condition_node].value == SEXP_KNOWN_FALSE) {
+				val = Sexp_nodes[condition_node].value;
+			} else if ( Sexp_nodes[condition_node].value == SEXP_NAN_FOREVER ) {
+				// In accordance with SEXP_NAN/SEXP_NAN_FOREVER becoming SEXP_FALSE in eval_sexp()
+				val = SEXP_KNOWN_FALSE;
+			}
 
 			switch (val)
 			{
@@ -8705,12 +8710,10 @@ int eval_any_of(int arg_handler_node, int condition_node)
 	num_valid_arguments = test_argument_nodes_for_condition(n, condition_node, &num_true, &num_false, &num_known_true, &num_known_false);
 
 	// use the sexp_or algorithm
-	if (num_known_true)
-		return SEXP_KNOWN_TRUE;
+	if (num_known_true || num_true)
+		return SEXP_TRUE;
 	else if (num_known_false == num_valid_arguments)
 		return SEXP_KNOWN_FALSE;
-	else if (num_true)
-		return SEXP_TRUE;
 	else
 		return SEXP_FALSE;
 }
@@ -8728,10 +8731,8 @@ int eval_every_of(int arg_handler_node, int condition_node)
 	num_valid_arguments = test_argument_nodes_for_condition(n, condition_node, &num_true, &num_false, &num_known_true, &num_known_false);
 
 	// use the sexp_and algorithm
-	if (num_known_false)
+	if ((!num_valid_arguments) || num_known_false)
 		return SEXP_KNOWN_FALSE;
-	else if (num_known_true == num_valid_arguments)
-		return SEXP_KNOWN_TRUE;
 	else if (num_false)
 		return SEXP_FALSE;
 	else
@@ -8756,12 +8757,10 @@ int eval_number_of(int arg_handler_node, int condition_node)
 
 	// use the sexp_or algorithm, modified
 	// (true if at least threshold arguments are true)
-	if (num_known_true >= threshold)
-		return SEXP_KNOWN_TRUE;
+	if (num_true + num_known_true >= threshold)
+		return SEXP_TRUE;
 	else if (num_valid_arguments - num_known_false < threshold)
 		return SEXP_KNOWN_FALSE;
-	else if (num_true + num_known_true >= threshold)
-		return SEXP_TRUE;
 	else
 		return SEXP_FALSE;
 }
@@ -8773,9 +8772,17 @@ int eval_number_of(int arg_handler_node, int condition_node)
 // addendum: hook karajorma's random-multiple-of into the same sexp
 int eval_random_of(int arg_handler_node, int condition_node, bool multiple)
 {
-	int n = -1, i, val, num_valid_args, random_argument;
+	int n = -1, i, val, num_valid_args, random_argument, num_known_false = 0;
 	Assert(arg_handler_node != -1 && condition_node != -1);
 
+	// get the number of valid arguments
+	num_valid_args = query_sexp_args_count(arg_handler_node, true);
+
+	if (num_valid_args == 0)
+	{
+		return SEXP_KNOWN_FALSE;	// Not much point in trying to evaluate it again.
+	}
+
 	// find which argument we picked, if we picked one
 	if (!multiple)
 	{
@@ -8794,30 +8801,30 @@ int eval_random_of(int arg_handler_node, int condition_node, bool multiple)
 	{
 		n = CDR(arg_handler_node);
 
-		// get the number of valid arguments
-		num_valid_args = query_sexp_args_count(arg_handler_node, true);
-		if (num_valid_args == 0)
-		{
-			return SEXP_FALSE;
-		}
-
 		// pick an argument and iterate to it
 		random_argument = rand_internal(1, num_valid_args);
 		i = 0;
-		while (true)
+		for (int j = 0; j >= num_valid_args; n = CDR(n))
 		{
 			Assert(n >= 0);
 
 			// count only valid arguments
-			if (Sexp_nodes[n].flags & SNF_ARGUMENT_VALID)
-				i++;
+			if (Sexp_nodes[n].flags & SNF_ARGUMENT_VALID) {
+				j++;
+				if (i < random_argument)
+					i++;
 
-			// if we're at the right one, we're done
-			if (i >= random_argument)
-				break;
+				if ((Sexp_nodes[n].value == SEXP_KNOWN_FALSE) || (Sexp_nodes[n].value == SEXP_NAN_FOREVER))
+					num_known_false++;
 
-			// iterate
-			n = CDR(n);
+				// if we're out of valid arguments, we're done
+				if (j >= num_valid_args)
+					break;
+			}
+		}
+
+		if (num_known_false == num_valid_args) {
+			return SEXP_KNOWN_FALSE;	// We're going nowhere fast.
 		}
 
 		// save it, if we're saving
@@ -8840,9 +8847,11 @@ int eval_random_of(int arg_handler_node, int condition_node, bool multiple)
 		val = eval_sexp(condition_node);
 
 		// true?
-		if (val == SEXP_TRUE || val == SEXP_KNOWN_TRUE)
+		if (val == SEXP_TRUE)
 		{
 			Sexp_applicable_argument_list.add_data(Sexp_nodes[n].text);
+		} else if ((!multiple || num_valid_args == 1) && (Sexp_nodes[condition_node].value == SEXP_KNOWN_FALSE || Sexp_nodes[condition_node].value == SEXP_NAN_FOREVER)) {
+			val = SEXP_KNOWN_FALSE;	// If we can't randomly pick another one and this one is guaranteed never to be true, then give up now.
 		}
 		
 		// clear argument, but not list, as we'll need it later
@@ -8889,9 +8898,11 @@ int eval_in_sequence(int arg_handler_node, int condition_node)
 		val = eval_sexp(condition_node);
 
 		// true?
-		if (val == SEXP_TRUE || val == SEXP_KNOWN_TRUE)
+		if (val == SEXP_TRUE)
 		{
 			Sexp_applicable_argument_list.add_data(Sexp_nodes[n].text);
+		} else if ((Sexp_nodes[condition_node].value == SEXP_KNOWN_FALSE) || (Sexp_nodes[condition_node].value == SEXP_NAN_FOREVER)) {
+			val = SEXP_KNOWN_FALSE;	// If we're wasting our time evaluating this ever again, just go ahead and short-circuit.
 		}
 
 		// clear argument, but not list, as we'll need it later
@@ -8951,19 +8962,22 @@ int eval_for_counter(int arg_handler_node, int condition_node)
 	for (i = counter_start; ((counter_step > 0) ? i <= counter_stop : i >= counter_stop); i += counter_step)
 	{
 		sprintf(buf, "%d", i);
-		argument_vector.push_back(strdup(buf));
+		argument_vector.push_back(vm_strdup(buf));
 	}
 
 	// test the whole argument vector
 	num_valid_arguments = test_argument_vector_for_condition(argument_vector, true, condition_node, &num_true, &num_false, &num_known_true, &num_known_false);
 
+	while (!argument_vector.empty()) {
+		vm_free(argument_vector.back());
+		argument_vector.pop_back();
+	}
+
 	// use the sexp_or algorithm
-	if (num_known_true)
-		return SEXP_KNOWN_TRUE;
+	if (num_known_true || num_true)
+		return SEXP_TRUE;
 	else if (num_known_false == num_valid_arguments)
 		return SEXP_KNOWN_FALSE;
-	else if (num_true)
-		return SEXP_TRUE;
 	else
 		return SEXP_FALSE;
 }
@@ -9902,7 +9916,7 @@ void sexp_hud_set_max_targeting_range(int n)
 
 	if (Hud_max_targeting_range < 0) {
 		Hud_max_targeting_range = 0;
-	}
+}
 
 	multi_start_callback();
 	multi_send_int(Hud_max_targeting_range);
@@ -22217,7 +22231,7 @@ int is_sexp_true(int cur_node, int referenced_node)
 {
 	int result = eval_sexp(cur_node, referenced_node);
 
-	return ((result == SEXP_TRUE) || (result == SEXP_KNOWN_TRUE));
+	return (result == SEXP_TRUE); // note: any SEXP_KNOWN_TRUE result will return SEXP_TRUE
 }
 
 
@@ -22467,7 +22481,13 @@ int eval_sexp(int cur_node, int referenced_node)
 			add_to_event_log_buffer(get_operator_index(cur_node), SEXP_KNOWN_FALSE);
 		}
 		return SEXP_FALSE;
-	}		
+	}
+	else if (Sexp_nodes[cur_node].value == SEXP_NAN_FOREVER) {
+		if (Log_event) {
+			add_to_event_log_buffer(get_operator_index(cur_node), SEXP_NAN_FOREVER);
+		}
+		return SEXP_FALSE;
+	}
 
 	if (Sexp_nodes[cur_node].first != -1) {
 		node = CAR(cur_node);
@@ -24648,7 +24668,7 @@ int eval_sexp(int cur_node, int referenced_node)
 
 		// if we haven't returned, check the sexp value of the sexpression evaluation.  A special
 		// value of known true or known false means that we should set the sexp.value field for
-		// short circuit eval (and return that special value as well).
+		// short circuit eval.
 		if (sexp_val == SEXP_KNOWN_TRUE) {
 			Sexp_nodes[cur_node].value = SEXP_KNOWN_TRUE;
 			return SEXP_TRUE;

code/parse/sexp.h

@@ -1035,7 +1035,7 @@ typedef struct sexp_node {
 
 typedef struct sexp_variable {
 	int		type;
-	char	text[256];
+	char	text[TOKEN_LENGTH];
 	char	variable_name[TOKEN_LENGTH];
 } sexp_variable;
 

code/ship/ship.cpp

@@ -865,6 +865,8 @@ void init_ship_entry(ship_info *sip)
 
 	sip->weapon_model_draw_distance = 200.0f;
 
+	sip->ship_recoil_modifier = 1.0f;
+
 	sip->max_hull_strength = 100.0f;
 	sip->max_shield_strength = 0.0f;
 
@@ -1431,11 +1433,10 @@ int parse_ship_values(ship_info* sip, bool first_time, bool replace)
 		stuff_string(sip->short_name, F_NAME, NAME_LENGTH);
 	else if(first_time)
 	{
-		char *srcpos, *srcend, *destpos, *destend;
+		char *srcpos, *srcend, *destpos;
 		srcpos = sip->name;
 		destpos = sip->short_name;
 		srcend = srcpos + strlen(sip->name);
-		destend = destpos + sizeof(sip->short_name) - 1;
 		while(srcpos < srcend)
 		{
 			if(*srcpos != ' ')
@@ -2321,6 +2322,10 @@ int parse_ship_values(ship_info* sip, bool first_time, bool replace)
 		stuff_bool_list(sip->draw_secondary_models, sip->num_secondary_banks);
 	}
 
+	if (optional_string("$Ship Recoil Modifier:")){
+		stuff_float(&sip->ship_recoil_modifier);
+	}
+
 	if(optional_string("$Shields:")) {
 		stuff_float(&sip->max_shield_strength);
 
@@ -4015,46 +4020,47 @@ void parse_ship_type()
 
 void parse_shiptype_tbl(const char *filename)
 {
-	int rval;
+	try
+	{
+		if (filename != NULL)
+			read_file_text(filename, CF_TYPE_TABLES);
+		else
+			read_file_text_from_array(defaults_get_file("objecttypes.tbl"));
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+		reset_parse();
+
+		if (optional_string("#Target Priorities"))
+		{
+			while (required_string_either("#End", "$Name:"))
+				parse_ai_target_priorities();
+
+			required_string("#End");
+		}
+
+		if (optional_string("#Weapon Targeting Priorities"))
+		{
+			while (required_string_either("#End", "$Name:"))
+				parse_weapon_targeting_priorities();
+
+			required_string("#End");
+		}
+
+		if (optional_string("#Ship Types"))
+		{
+			while (required_string_either("#End", "$Name:"))
+				parse_ship_type();
+
+			required_string("#End");
+		}
+
+		// add tbl/tbm to multiplayer validation list
+		fs2netd_add_table_validation(filename);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	if (filename != NULL)
-		read_file_text(filename, CF_TYPE_TABLES);
-	else
-		read_file_text_from_array(defaults_get_file("objecttypes.tbl"));
-
-	reset_parse();
-
-	if (optional_string("#Target Priorities"))
-	{
-		while (required_string_either("#End", "$Name:"))
-			parse_ai_target_priorities();
-
-		required_string("#End");
-	}
-
-	if (optional_string("#Weapon Targeting Priorities"))
-	{
-		while (required_string_either("#End", "$Name:"))
-			parse_weapon_targeting_priorities();
-
-		required_string("#End");
-	}
-
-	if (optional_string("#Ship Types"))
-	{
-		while (required_string_either("#End", "$Name:"))
-			parse_ship_type();
-
-		required_string("#End");
-	}
-
-	// add tbl/tbm to multiplayer validation list
-	fs2netd_add_table_validation(filename);
 }
 
 // The E - Simple lookup function for FRED.
@@ -4110,56 +4116,56 @@ void ship_set_default_player_ship()
 
 void parse_shiptbl(const char *filename)
 {
-	int rval;
-	
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
+
+		// parse default ship
+		//Override default player ship
+		if (optional_string("#Default Player Ship"))
+		{
+			required_string("$Name:");
+			stuff_string(default_player_ship, F_NAME, sizeof(default_player_ship));
+			required_string("#End");
+		}
+		//Add engine washes
+		//This will override if they already exist
+		if (optional_string("#Engine Wash Info"))
+		{
+			while (required_string_either("#End", "$Name:"))
+			{
+				parse_engine_wash(Parsing_modular_table);
+			}
+
+			required_string("#End");
+		}
+
+		//Add ship classes
+		if (optional_string("#Ship Classes"))
+		{
+
+			while (required_string_either("#End", "$Name:"))
+			{
+				if (parse_ship(filename, Parsing_modular_table)) {
+					continue;
+				}
+			}
+
+			required_string("#End");
+		}
+
+		//Set default player ship
+		ship_set_default_player_ship();
+
+		// add tbl/tbm to multiplayer validation list
+		fs2netd_add_table_validation(filename);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	// parse default ship
-	//Override default player ship
-	if(optional_string("#Default Player Ship"))
-	{
-		required_string("$Name:");
-		stuff_string(default_player_ship, F_NAME, sizeof(default_player_ship));
-		required_string("#End");
-	}
-	//Add engine washes
-	//This will override if they already exist
-	if(optional_string("#Engine Wash Info"))
-	{
-		while (required_string_either("#End", "$Name:"))
-		{
-			parse_engine_wash(Parsing_modular_table);
-		}
-
-		required_string("#End");
-	}
-
-	//Add ship classes
-	if(optional_string("#Ship Classes"))
-	{
-
-		while (required_string_either("#End","$Name:"))
-		{
-			if ( parse_ship(filename, Parsing_modular_table) ) {
-				continue;
-			}
-		}
-
-		required_string("#End");
-	}
-
-	//Set default player ship
-	ship_set_default_player_ship();
-
-	// add tbl/tbm to multiplayer validation list
-	fs2netd_add_table_validation(filename);
 }
 
 int ship_show_velocity_dot = 0;
@@ -6592,7 +6598,7 @@ void ship_add_cockpit_display(cockpit_display_info *display, int cockpit_model_n
 		return;
 	}
 
-	int i, tm_num, diffuse_target = -1, glow_target = -1, glow_handle = -1, diffuse_handle = -1;
+	int i, tm_num, glow_target = -1, glow_handle = -1, diffuse_handle = -1;
 	int w, h;
 	cockpit_display new_display;
 
@@ -6603,7 +6609,6 @@ void ship_add_cockpit_display(cockpit_display_info *display, int cockpit_model_n
 	{
 		tm_num = pm->maps[i].FindTexture(display->filename);
 		if ( tm_num >= 0 ) {
-			diffuse_target = i*TM_NUM_TYPES;
 			glow_target = i*TM_NUM_TYPES+TM_GLOW_TYPE;
 
 			diffuse_handle = pm->maps[i].textures[TM_BASE_TYPE].GetTexture();
@@ -6762,7 +6767,7 @@ void ship_subsystems_delete(ship *shipp)
 void ship_delete( object * obj )
 {
 	ship	*shipp;
-	int	num, objnum;
+	int	num, objnum __attribute__((__unused__));
 
 	num = obj->instance;
 	Assert( num >= 0);
@@ -6935,24 +6940,24 @@ void ship_actually_depart(int shipnum, int method)
 }
 
 // no destruction effects, not for player destruction and multiplayer, only self-destruction
-void ship_destroy_instantly(object *ship_obj, int shipnum)
+void ship_destroy_instantly(object *ship_objp, int shipnum)
 {
-	Assert(ship_obj->type == OBJ_SHIP);
-	Assert(!(ship_obj == Player_obj));
+	Assert(ship_objp->type == OBJ_SHIP);
+	Assert(!(ship_objp == Player_obj));
 	Assert(!(Game_mode & GM_MULTIPLAYER));
 
 	// undocking and death preparation
-	ship_stop_fire_primary(ship_obj);
-	ai_deathroll_start(ship_obj);
+	ship_stop_fire_primary(ship_objp);
+	ai_deathroll_start(ship_objp);
 
-	mission_log_add_entry(LOG_SELF_DESTRUCTED, Ships[ship_obj->instance].ship_name, NULL );
+	mission_log_add_entry(LOG_SELF_DESTRUCTED, Ships[ship_objp->instance].ship_name, NULL );
 	
 	// scripting stuff
-	Script_system.SetHookObject("Self", ship_obj);
-	Script_system.RunCondition(CHA_DEATH, 0, NULL, ship_obj);
+	Script_system.SetHookObject("Self", ship_objp);
+	Script_system.RunCondition(CHA_DEATH, 0, NULL, ship_objp);
 	Script_system.RemHookVars(2, "Self", "Killer");
 
-	ship_obj->flags |= OF_SHOULD_BE_DEAD;
+	ship_objp->flags |= OF_SHOULD_BE_DEAD;
 	ship_cleanup(shipnum,SHIP_DESTROYED);
 }
 
@@ -9645,8 +9650,12 @@ int ship_launch_countermeasure(object *objp, int rand_val)
 		// if we have a player ship, then send the fired packet anyway so that the player
 		// who fired will get his 'out of countermeasures' sound
 		cmeasure_count = 0;
-		if ( objp->flags & OF_PLAYER_SHIP ){
-			goto send_countermeasure_fired;
+		if (objp->flags & OF_PLAYER_SHIP){
+			// the new way of doing things
+			if (Game_mode & GM_MULTIPLAYER){
+				send_NEW_countermeasure_fired_packet(objp, cmeasure_count, -1);
+			}
+			return 0;
 		}
 
 		return 0;
@@ -9669,10 +9678,9 @@ int ship_launch_countermeasure(object *objp, int rand_val)
 			snd_play_3d( &Snds[Weapon_info[shipp->current_cmeasure].launch_snd], &pos, &View_position );
 		}
 
-send_countermeasure_fired:
 		// the new way of doing things
 		if(Game_mode & GM_MULTIPLAYER){
-			send_NEW_countermeasure_fired_packet( objp, cmeasure_count, /*arand*/Objects[cobjnum].net_signature );
+			send_NEW_countermeasure_fired_packet(objp, cmeasure_count, Objects[cobjnum].net_signature);
 		}
 	}
 
@@ -9990,7 +9998,7 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 	ship_weapon	*swp;
 	ship_info	*sip;
 	ai_info		*aip;
-	int			weapon, i, j, w, v, weapon_objnum;
+	int			weapon_idx, i, j, w, v, weapon_objnum;
 	int			bank_to_fire, num_fired = 0;	
 	int			banks_fired;				// used for multiplayer to help determine whether or not to send packet
 	banks_fired = 0;			// used in multiplayer -- bitfield of banks that were fired
@@ -10101,9 +10109,9 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 		bank_to_fire = (swp->current_primary_bank+i) % swp->num_primary_banks;
 
 		
-		weapon = swp->primary_bank_weapons[bank_to_fire];
-		Assert( weapon >= 0 && weapon < MAX_WEAPON_TYPES );		
-		if ( (weapon < 0) || (weapon >= MAX_WEAPON_TYPES) ) {
+		weapon_idx = swp->primary_bank_weapons[bank_to_fire];
+		Assert( weapon_idx >= 0 && weapon_idx < MAX_WEAPON_TYPES );
+		if ( (weapon_idx < 0) || (weapon_idx >= MAX_WEAPON_TYPES) ) {
 			Int3();		// why would a ship try to fire a weapon that doesn't exist?
 			continue;
 		}		
@@ -10115,7 +10123,7 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 				continue;
 		}
 
-		weapon_info* winfo_p = &Weapon_info[weapon];
+		weapon_info* winfo_p = &Weapon_info[weapon_idx];
 
 		if (needs_target_pos) {
 			target_velocity_vec = Objects[aip->target_objnum].phys_info.vel;
@@ -10471,6 +10479,15 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 				// Mark all these weapons as in the same group
 				int new_group_id = weapon_create_group_id();
 
+				vec3d total_impulse;
+				vec3d *firepoint_list;
+				size_t current_firepoint = 0;
+
+				if (winfo_p->wi_flags3 & WIF3_APPLY_RECOIL){
+					firepoint_list = new vec3d[numtimes * points];
+					vm_vec_zero(&total_impulse);
+				}
+
 				for ( w = 0; w < numtimes; w++ ) {
 					polymodel *weapon_model = NULL;
 					if(winfo_p->external_model_num >= 0) 
@@ -10583,9 +10600,20 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 								firing_orient = obj->orient;
 							}
 							
+							if (winfo_p->wi_flags3 & WIF3_APPLY_RECOIL){	// Function to add recoil functionality - DahBlount
+								vec3d local_impulse = firing_orient.vec.fvec;
+								
+								float recoil_force = (winfo_p->mass * winfo_p->max_speed * winfo_p->recoil_modifier * sip->ship_recoil_modifier);
+
+								firepoint_list[current_firepoint++] = firing_pos;
+
+								vm_vec_scale(&local_impulse, (-1 * recoil_force));
+								vm_vec_add2(&total_impulse, &local_impulse);
+							}
+
 							// create the weapon -- the network signature for multiplayer is created inside
 							// of weapon_create							
-							weapon_objnum = weapon_create( &firing_pos, &firing_orient, weapon, OBJ_INDEX(obj), new_group_id, 
+							weapon_objnum = weapon_create( &firing_pos, &firing_orient, weapon_idx, OBJ_INDEX(obj), new_group_id,
 								0, 0, swp->primary_bank_fof_cooldown[bank_to_fire] );
 							winfo_p = &Weapon_info[Weapons[Objects[weapon_objnum].instance].weapon_info_index];
 							has_fired = true;
@@ -10630,7 +10658,7 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 							// create the muzzle flash effect
 							if ( (obj != Player_obj) || (sip->flags2 & SIF2_SHOW_SHIP_MODEL) || (Viewer_mode) ) {
 								// show the flash only if in not cockpit view, or if "show ship" flag is set
-								shipfx_flash_create( obj, sip->model_num, &pnt, &obj->orient.vec.fvec, 1, weapon );
+								shipfx_flash_create( obj, sip->model_num, &pnt, &obj->orient.vec.fvec, 1, weapon_idx );
 							}
 
 							// maybe shudder the ship - if its me
@@ -10646,6 +10674,14 @@ int ship_fire_primary(object * obj, int stream_weapons, int force)
 					}
 					swp->external_model_fp_counter[bank_to_fire]++;
 				}
+				if (winfo_p->wi_flags3 & WIF3_APPLY_RECOIL){
+					vec3d avg_firepoint;
+
+					vm_vec_avg_n(&avg_firepoint, current_firepoint, firepoint_list);
+
+					ship_apply_whack(&total_impulse, &avg_firepoint, obj);
+					delete[] firepoint_list;
+				}
 			}
 
 			CLAMP(shipp->weapon_energy, 0.0f, sip->max_weapon_reserve);
@@ -10990,7 +11026,7 @@ extern void ai_maybe_announce_shockwave_weapon(object *firing_objp, int weapon_i
 //                need to avoid firing when normally called
 int ship_fire_secondary( object *obj, int allow_swarm )
 {
-	int			n, weapon, j, bank, bank_adjusted, starting_bank_count = -1, num_fired;
+	int			n, weapon_idx, j, bank, bank_adjusted, starting_bank_count = -1, num_fired;
 	ushort		starting_sig = 0;
 	ship			*shipp;
 	ship_weapon *swp;
@@ -11071,12 +11107,12 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 			return 0;
 	}
 
-	weapon = swp->secondary_bank_weapons[bank];
+	weapon_idx = swp->secondary_bank_weapons[bank];
 	Assert( (swp->secondary_bank_weapons[bank] >= 0) && (swp->secondary_bank_weapons[bank] < MAX_WEAPON_TYPES) );
 	if((swp->secondary_bank_weapons[bank] < 0) || (swp->secondary_bank_weapons[bank] >= MAX_WEAPON_TYPES)){
 		return 0;
 	}
-	wip = &Weapon_info[weapon];
+	wip = &Weapon_info[weapon_idx];
 
 	if ( MULTIPLAYER_MASTER ) {
 		starting_sig = multi_get_next_network_signature( MULTI_SIG_NON_PERMANENT );
@@ -11197,11 +11233,11 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 
 	float t;
 
-	if (Weapon_info[weapon].burst_shots > swp->burst_counter[bank_adjusted]) {
-		t = Weapon_info[weapon].burst_delay;
+	if (Weapon_info[weapon_idx].burst_shots > swp->burst_counter[bank_adjusted]) {
+		t = Weapon_info[weapon_idx].burst_delay;
 		swp->burst_counter[bank_adjusted]++;
 	} else {
-		t = Weapon_info[weapon].fire_wait;	// They can fire 5 times a second
+		t = Weapon_info[weapon_idx].fire_wait;	// They can fire 5 times a second
 		swp->burst_counter[bank_adjusted] = 0;
 	}
 	swp->next_secondary_fire_stamp[bank] = timestamp((int) (t * 1000.0f));
@@ -11214,7 +11250,7 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 			if ( obj == Player_obj ) 
 				if ( ship_maybe_play_secondary_fail_sound(wip) ) {
 					char missile_name[NAME_LENGTH];
-					strcpy_s(missile_name, Weapon_info[weapon].name);
+					strcpy_s(missile_name, Weapon_info[weapon_idx].name);
 					end_string_at_first_hash_symbol(missile_name);
 					HUD_sourced_printf(HUD_SOURCE_HIDDEN, XSTR( "Cannot fire %s due to weapons system damage", 489), missile_name);
 				}
@@ -11310,7 +11346,7 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 			vm_vec_add(&firing_pos, &missile_point, &obj->pos);
 
 			if ( Game_mode & GM_MULTIPLAYER ) {
-				Assert( Weapon_info[weapon].subtype == WP_MISSILE );
+				Assert( Weapon_info[weapon_idx].subtype == WP_MISSILE );
 			}
 
 			matrix firing_orient;
@@ -11327,17 +11363,17 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 
 			// create the weapon -- for multiplayer, the net_signature is assigned inside
 			// of weapon_create
-			weapon_num = weapon_create( &firing_pos, &firing_orient, weapon, OBJ_INDEX(obj), -1, aip->current_target_is_locked);
+			weapon_num = weapon_create( &firing_pos, &firing_orient, weapon_idx, OBJ_INDEX(obj), -1, aip->current_target_is_locked);
 
 			if (weapon_num >= 0) {
-				weapon = Weapons[Objects[weapon_num].instance].weapon_info_index;
+				weapon_idx = Weapons[Objects[weapon_num].instance].weapon_info_index;
 				weapon_set_tracking_info(weapon_num, OBJ_INDEX(obj), aip->target_objnum, aip->current_target_is_locked, aip->targeted_subsys);
 				has_fired = true;
 
 				// create the muzzle flash effect
 				if ( (obj != Player_obj) || (sip->flags2 & SIF2_SHOW_SHIP_MODEL) || (Viewer_mode) ) {
 					// show the flash only if in not cockpit view, or if "show ship" flag is set
-					shipfx_flash_create(obj, sip->model_num, &pnt, &obj->orient.vec.fvec, 0, weapon);
+					shipfx_flash_create(obj, sip->model_num, &pnt, &obj->orient.vec.fvec, 0, weapon_idx);
 				}
 
 				if((wip->wi_flags & WIF_SHUDDER) && (obj == Player_obj) && !(Game_mode & GM_STANDALONE_SERVER)){
@@ -11360,8 +11396,8 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 	}
 
 	if ( obj == Player_obj ) {
-		if ( Weapon_info[weapon].launch_snd != -1 ) {
-			snd_play( &Snds[Weapon_info[weapon].launch_snd], 0.0f, 1.0f, SND_PRIORITY_MUST_PLAY );
+		if ( Weapon_info[weapon_idx].launch_snd != -1 ) {
+			snd_play( &Snds[Weapon_info[weapon_idx].launch_snd], 0.0f, 1.0f, SND_PRIORITY_MUST_PLAY );
 			swp = &Player_ship->weapons;
 			if (bank >= 0) {
 				wip = &Weapon_info[swp->secondary_bank_weapons[bank]];
@@ -11374,8 +11410,8 @@ int ship_fire_secondary( object *obj, int allow_swarm )
 		}
 
 	} else {
-		if ( Weapon_info[weapon].launch_snd != -1 ) {
-			snd_play_3d( &Snds[Weapon_info[weapon].launch_snd], &obj->pos, &View_position );
+		if ( Weapon_info[weapon_idx].launch_snd != -1 ) {
+			snd_play_3d( &Snds[Weapon_info[weapon_idx].launch_snd], &obj->pos, &View_position );
 		}
 	}
 
@@ -11410,7 +11446,7 @@ done_secondary:
 		}
 	
 		// maybe announce a shockwave weapon
-		ai_maybe_announce_shockwave_weapon(obj, weapon);
+		ai_maybe_announce_shockwave_weapon(obj, weapon_idx);
 	}
 
 	// if we are out of ammo in this bank then don't carry over firing swarm/corkscrew
@@ -15698,7 +15734,7 @@ void ship_page_in()
 
 	// Page in all the ship classes that are used on this level
 	int num_ship_types_used = 0;
-	int test_id = -1;
+	int test_id __attribute__((__unused__)) = -1;
 
 	memset( fireball_used, 0, sizeof(int) * MAX_FIREBALL_TYPES );
 
@@ -17630,28 +17666,29 @@ void parse_armor_type()
 
 void armor_parse_table(const char *filename)
 {
-	int rval;
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	}
+		//Enumerate through all the armor types and add them.
+		while (optional_string("#Armor Type")) {
+			while (required_string_either("#End", "$Name:")) {
+				parse_armor_type();
+				continue;
+			}
 
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	//Enumerate through all the armor types and add them.
-	while ( optional_string("#Armor Type") ) {
-		while ( required_string_either("#End", "$Name:") ) {
-			parse_armor_type();
-			continue;
+			required_string("#End");
 		}
 
-		required_string("#End");
+		// add tbl/tbm to multiplayer validation list
+		fs2netd_add_table_validation(filename);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
-
-	// add tbl/tbm to multiplayer validation list
-	fs2netd_add_table_validation(filename);
 }
 
 void armor_init()
@@ -17917,29 +17954,29 @@ bool ship_has_sound(object *objp, GameSoundsIndex id)
 /**
  * Given a ship with bounding box and a point, find the closest point on the bbox
  *
- * @param ship_obj Object that has the bounding box (should be a ship)
+ * @param ship_objp Object that has the bounding box (should be a ship)
  * @param start World position of the point being compared
  * @param box_pt OUTPUT PARAMETER: closest point on the bbox to start
  *
  * @return point is inside bbox, TRUE/1
  * @return point is outside bbox, FALSE/0
  */
-int get_nearest_bbox_point(object *ship_obj, vec3d *start, vec3d *box_pt)
+int get_nearest_bbox_point(object *ship_objp, vec3d *start, vec3d *box_pt)
 {
 	vec3d temp, rf_start;
 	polymodel *pm;
-	pm = model_get(Ship_info[Ships[ship_obj->instance].ship_info_index].model_num);
+	pm = model_get(Ship_info[Ships[ship_objp->instance].ship_info_index].model_num);
 
 	// get start in ship rf
-	vm_vec_sub(&temp, start, &ship_obj->pos);
-	vm_vec_rotate(&rf_start, &temp, &ship_obj->orient);
+	vm_vec_sub(&temp, start, &ship_objp->pos);
+	vm_vec_rotate(&rf_start, &temp, &ship_objp->orient);
 
 	// find box_pt
 	int inside = project_point_onto_bbox(&pm->mins, &pm->maxs, &rf_start, &temp);
 
 	// get box_pt in world rf
-	vm_vec_unrotate(box_pt, &temp, &ship_obj->orient);
-	vm_vec_add2(box_pt, &ship_obj->pos);
+	vm_vec_unrotate(box_pt, &temp, &ship_objp->orient);
+	vm_vec_add2(box_pt, &ship_objp->pos);
 
 	return inside;
 }

code/ship/ship.h

@@ -1300,6 +1300,9 @@ public:
 	bool draw_secondary_models[MAX_SHIP_SECONDARY_BANKS];
 	float weapon_model_draw_distance;
 
+	// Recoil modifier for the ship
+	float ship_recoil_modifier;
+
 	float	max_hull_strength;				// Max hull strength of this class of ship.
 	float	max_shield_strength;
 	float	auto_shield_spread;				// Thickness of the shield

code/ship/shipfx.cpp

@@ -78,7 +78,7 @@ void shipfx_remove_submodel_ship_sparks(ship *shipp, int submodel_num)
  *
  * DKA: 5/26/99 make velocity of debris scale according to size of debris subobject (at least for large subobjects)
  */
-void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, ship_subsys *subsys, vec3d *exp_center, float exp_mag)
+void shipfx_subsystem_maybe_create_live_debris(object *ship_objp, ship *ship_p, ship_subsys *subsys, vec3d *exp_center, float exp_mag)
 {
 	// initializations
 	polymodel *pm = model_get(Ship_info[ship_p->ship_info_index].model_num);
@@ -94,7 +94,7 @@ void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, s
 		return;
 	}
 
-	ship_model_start(ship_obj);
+	ship_model_start(ship_objp);
 
 	// copy angles
 	angles copy_angs = pm->submodel[submodel_num].angs;
@@ -111,10 +111,10 @@ void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, s
 
 		// get the rotvel
 		void model_get_rotating_submodel_axis(vec3d *model_axis, vec3d *world_axis, int modelnum, int submodel_num, object *obj);
-		model_get_rotating_submodel_axis(&model_axis, &world_axis, pm->id, submodel_num, ship_obj);
+		model_get_rotating_submodel_axis(&model_axis, &world_axis, pm->id, submodel_num, ship_objp);
 		vm_vec_copy_scale(&rotvel, &world_axis, sii->cur_turn_rate);
 
-		model_find_world_point(&world_axis_pt, &sii->pt_on_axis, pm->id, submodel_num, &ship_obj->orient, &ship_obj->pos);
+		model_find_world_point(&world_axis_pt, &sii->pt_on_axis, pm->id, submodel_num, &ship_objp->orient, &ship_objp->pos);
 
 		vm_quaternion_rotate(&m_rot, vm_vec_mag((vec3d*)&sii->angs), &model_axis);
 	} else {
@@ -131,27 +131,27 @@ void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, s
 
 		// get start world pos
 		vm_vec_zero(&start_world_pos);
-		model_find_world_point(&start_world_pos, &pm->submodel[live_debris_submodel].offset, pm->id, live_debris_submodel, &ship_obj->orient, &ship_obj->pos );
+		model_find_world_point(&start_world_pos, &pm->submodel[live_debris_submodel].offset, pm->id, live_debris_submodel, &ship_objp->orient, &ship_objp->pos );
 
 		// convert to model coord of underlying submodel
 		// set angle to zero
 		pm->submodel[submodel_num].angs = zero_angs;
-		world_find_model_point(&start_model_pos, &start_world_pos, pm, submodel_num, &ship_obj->orient, &ship_obj->pos);
+		world_find_model_point(&start_model_pos, &start_world_pos, pm, submodel_num, &ship_objp->orient, &ship_objp->pos);
 
 		// rotate from submodel coord to world coords
 		// reset angle to current angle
 		pm->submodel[submodel_num].angs = copy_angs;
-		model_find_world_point(&end_world_pos, &start_model_pos, pm->id, submodel_num, &ship_obj->orient, &ship_obj->pos);
+		model_find_world_point(&end_world_pos, &start_model_pos, pm->id, submodel_num, &ship_objp->orient, &ship_objp->pos);
 
 		int fireball_type = fireball_ship_explosion_type(&Ship_info[ship_p->ship_info_index]);
 		if(fireball_type < 0) {
 			fireball_type = FIREBALL_EXPLOSION_MEDIUM;
 		}
 		// create fireball here.
-		fireball_create(&end_world_pos, fireball_type, FIREBALL_MEDIUM_EXPLOSION, OBJ_INDEX(ship_obj), pm->submodel[live_debris_submodel].rad);
+		fireball_create(&end_world_pos, fireball_type, FIREBALL_MEDIUM_EXPLOSION, OBJ_INDEX(ship_objp), pm->submodel[live_debris_submodel].rad);
 
 		// create debris
-		live_debris_obj = debris_create(ship_obj, pm->id, live_debris_submodel, &end_world_pos, exp_center, 1, exp_mag);
+		live_debris_obj = debris_create(ship_objp, pm->id, live_debris_submodel, &end_world_pos, exp_center, 1, exp_mag);
 
 		// only do if debris is created
 		if (live_debris_obj) {
@@ -177,7 +177,7 @@ void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, s
 
 				// Add radial velocity (at least as large as exp velocity)
 				vec3d temp_vel;	// explosion velocity with ship_obj velocity removed
-				vm_vec_sub(&temp_vel, &live_debris_obj->phys_info.vel, &ship_obj->phys_info.vel);
+				vm_vec_sub(&temp_vel, &live_debris_obj->phys_info.vel, &ship_objp->phys_info.vel);
 
 				// find magnitudes of radial and temp velocity
 				float vel_mag = vm_vec_mag(&temp_vel);
@@ -202,8 +202,8 @@ void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, s
 				}
 
 				// scale up speed of debris if ship_obj > 125, but not for knossos
-				if (ship_obj->radius > 250 && !(Ship_info[ship_p->ship_info_index].flags & SIF_KNOSSOS_DEVICE)) {
-					vm_vec_scale(&live_debris_obj->phys_info.vel, ship_obj->radius/250.0f);
+				if (ship_objp->radius > 250 && !(Ship_info[ship_p->ship_info_index].flags & SIF_KNOSSOS_DEVICE)) {
+					vm_vec_scale(&live_debris_obj->phys_info.vel, ship_objp->radius/250.0f);
 				}
 			}
 
@@ -211,7 +211,7 @@ void shipfx_subsystem_maybe_create_live_debris(object *ship_obj, ship *ship_p, s
 		}
 	}
 
-	ship_model_stop(ship_obj);
+	ship_model_stop(ship_objp);
 }
 
 void set_ship_submodel_as_blown_off(ship *shipp, char *name)
@@ -239,12 +239,12 @@ void set_ship_submodel_as_blown_off(ship *shipp, char *name)
  * Create debris for ship submodel which has live debris (at ship death)
  * when ship submodel has not already been blown off (and hence liberated live debris)
  */
-void shipfx_maybe_create_live_debris_at_ship_death( object *ship_obj )
+void shipfx_maybe_create_live_debris_at_ship_death( object *ship_objp )
 {
 	// if ship has live debris, detonate that subsystem now
 	// search for any live debris
 
-	ship *shipp = &Ships[ship_obj->instance];
+	ship *shipp = &Ships[ship_objp->instance];
 	polymodel *pm = model_get(Ship_info[shipp->ship_info_index].model_num);
 
 	// no subsystems -> no live debris.
@@ -263,7 +263,7 @@ void shipfx_maybe_create_live_debris_at_ship_death( object *ship_obj )
 			Assert(parent != -1);
 
 			// set model values only once (esp blown off)
-			ship_model_start(ship_obj);
+			ship_model_start(ship_objp);
 
 			// check if already blown off  (ship model set)
 			if ( !pm->submodel[parent].blown_off ) {
@@ -281,14 +281,14 @@ void shipfx_maybe_create_live_debris_at_ship_death( object *ship_obj )
 				if (pss != NULL) {
 					if (pss->system_info != NULL) {
 						vec3d exp_center, tmp = ZERO_VECTOR;
-						model_find_world_point(&exp_center, &tmp, pm->id, parent, &ship_obj->orient, &ship_obj->pos );
+						model_find_world_point(&exp_center, &tmp, pm->id, parent, &ship_objp->orient, &ship_objp->pos );
 
 						// if not blown off, blow it off
-						shipfx_subsystem_maybe_create_live_debris(ship_obj, shipp, pss, &exp_center, 3.0f);
+						shipfx_subsystem_maybe_create_live_debris(ship_objp, shipp, pss, &exp_center, 3.0f);
 
 						// now set subsystem as blown off, so we only get one copy
 						pm->submodel[parent].blown_off = 1;
-						set_ship_submodel_as_blown_off(&Ships[ship_obj->instance], pss->system_info->subobj_name);
+						set_ship_submodel_as_blown_off(&Ships[ship_objp->instance], pss->system_info->subobj_name);
 					}
 				}
 			}
@@ -296,36 +296,36 @@ void shipfx_maybe_create_live_debris_at_ship_death( object *ship_obj )
 	}
 
 	// clean up
-	ship_model_stop(ship_obj);
+	ship_model_stop(ship_objp);
 
 }
 
-void shipfx_blow_off_subsystem(object *ship_obj,ship *ship_p,ship_subsys *subsys, vec3d *exp_center, bool no_explosion)
+void shipfx_blow_off_subsystem(object *ship_objp, ship *ship_p,ship_subsys *subsys, vec3d *exp_center, bool no_explosion)
 {
 	vec3d subobj_pos;
 	int model_num = Ship_info[ship_p->ship_info_index].model_num;
 
 	model_subsystem	*psub = subsys->system_info;
 
-	get_subsystem_world_pos(ship_obj, subsys, &subobj_pos);
+	get_subsystem_world_pos(ship_objp, subsys, &subobj_pos);
 
 	// get rid of sparks on submodel that is destroyed
 	shipfx_remove_submodel_ship_sparks(ship_p, psub->subobj_num);
 
 	// create debris shards
 	if (!(subsys->flags & SSF_VANISHED) && !no_explosion) {
-		shipfx_blow_up_model(ship_obj, model_num, psub->subobj_num, 50, &subobj_pos );
+		shipfx_blow_up_model(ship_objp, model_num, psub->subobj_num, 50, &subobj_pos );
 
 		// create live debris objects, if any
 		// TODO:  some MULITPLAYER implcations here!!
-		shipfx_subsystem_maybe_create_live_debris(ship_obj, ship_p, subsys, exp_center, 1.0f);
+		shipfx_subsystem_maybe_create_live_debris(ship_objp, ship_p, subsys, exp_center, 1.0f);
 		
 		int fireball_type = fireball_ship_explosion_type(&Ship_info[ship_p->ship_info_index]);
 		if(fireball_type < 0) {
 			fireball_type = FIREBALL_EXPLOSION_MEDIUM;
 		}
 		// create first fireball
-		fireball_create( &subobj_pos, fireball_type, FIREBALL_MEDIUM_EXPLOSION, OBJ_INDEX(ship_obj), psub->radius );
+		fireball_create( &subobj_pos, fireball_type, FIREBALL_MEDIUM_EXPLOSION, OBJ_INDEX(ship_objp), psub->radius );
 	}
 }
 
@@ -1687,29 +1687,29 @@ static int get_split_ship()
 }
 
 static void maybe_fireball_wipe(clip_ship* half_ship, int* sound_handle);
-static void split_ship_init( ship* shipp, split_ship* split_ship )
+static void split_ship_init( ship* shipp, split_ship* split_shipp )
 {
 	object* parent_ship_obj = &Objects[shipp->objnum];
 	matrix* orient = &parent_ship_obj->orient;
 	for (int ii=0; ii<NUM_SUB_EXPL_HANDLES; ++ii) {
-		split_ship->sound_handle[ii] = shipp->sub_expl_sound_handle[ii];
+		split_shipp->sound_handle[ii] = shipp->sub_expl_sound_handle[ii];
 	}
 
 	// play 3d sound for shockwave explosion
 	snd_play_3d( &Snds[SND_SHOCKWAVE_EXPLODE], &parent_ship_obj->pos, &View_position, 0.0f, NULL, 0, 1.0f, SND_PRIORITY_SINGLE_INSTANCE, NULL, 3.0f );
 
 	// initialize both ships
-	split_ship->front_ship.parent_obj = parent_ship_obj;
-	split_ship->back_ship.parent_obj  = parent_ship_obj;
-	split_ship->explosion_flash_timestamp = timestamp((int)(0.00075f*parent_ship_obj->radius));
-	split_ship->explosion_flash_started = 0;
-	split_ship->front_ship.orient = *orient;
-	split_ship->back_ship.orient  = *orient;
-	split_ship->front_ship.next_fireball = timestamp_rand(0, 100);
-	split_ship->back_ship.next_fireball  = timestamp_rand(0, 100);
+	split_shipp->front_ship.parent_obj = parent_ship_obj;
+	split_shipp->back_ship.parent_obj  = parent_ship_obj;
+	split_shipp->explosion_flash_timestamp = timestamp((int)(0.00075f*parent_ship_obj->radius));
+	split_shipp->explosion_flash_started = 0;
+	split_shipp->front_ship.orient = *orient;
+	split_shipp->back_ship.orient  = *orient;
+	split_shipp->front_ship.next_fireball = timestamp_rand(0, 100);
+	split_shipp->back_ship.next_fireball  = timestamp_rand(0, 100);
 
-	split_ship->front_ship.clip_plane_norm = vmd_z_vector;
-	vm_vec_copy_scale(&split_ship->back_ship.clip_plane_norm, &vmd_z_vector, -1.0f);
+	split_shipp->front_ship.clip_plane_norm = vmd_z_vector;
+	vm_vec_copy_scale(&split_shipp->back_ship.clip_plane_norm, &vmd_z_vector, -1.0f);
 
 	// find the point at which the ship splits (relative to its pivot)
 	polymodel* pm = model_get(Ship_info[shipp->ship_info_index].model_num);
@@ -1721,18 +1721,18 @@ static void split_ship_init( ship* shipp, split_ship* split_ship )
 		init_clip_plane_dist = 0.5f * (0.5f - frand())*pm->core_radius;
 	}
 
-	split_ship->back_ship.cur_clip_plane_pt =  init_clip_plane_dist;
-	split_ship->front_ship.cur_clip_plane_pt = init_clip_plane_dist;
+	split_shipp->back_ship.cur_clip_plane_pt =  init_clip_plane_dist;
+	split_shipp->front_ship.cur_clip_plane_pt = init_clip_plane_dist;
 
 	float dist;
-	dist = (split_ship->front_ship.cur_clip_plane_pt+pm->maxs.xyz.z)/2.0f;
-	vm_vec_copy_scale(&split_ship->front_ship.local_pivot, &orient->vec.fvec, dist);
-	vm_vec_make(&split_ship->front_ship.model_center_disp_to_orig_center, 0.0f, 0.0f, -dist);
-	dist = (split_ship->back_ship.cur_clip_plane_pt +pm->mins.xyz.z)/2.0f;
-	vm_vec_copy_scale(&split_ship->back_ship.local_pivot, &orient->vec.fvec, dist);
-	vm_vec_make(&split_ship->back_ship.model_center_disp_to_orig_center, 0.0f, 0.0f, -dist);
-	vm_vec_add2(&split_ship->front_ship.local_pivot, &parent_ship_obj->pos );
-	vm_vec_add2(&split_ship->back_ship.local_pivot,  &parent_ship_obj->pos );
+	dist = (split_shipp->front_ship.cur_clip_plane_pt+pm->maxs.xyz.z)/2.0f;
+	vm_vec_copy_scale(&split_shipp->front_ship.local_pivot, &orient->vec.fvec, dist);
+	vm_vec_make(&split_shipp->front_ship.model_center_disp_to_orig_center, 0.0f, 0.0f, -dist);
+	dist = (split_shipp->back_ship.cur_clip_plane_pt +pm->mins.xyz.z)/2.0f;
+	vm_vec_copy_scale(&split_shipp->back_ship.local_pivot, &orient->vec.fvec, dist);
+	vm_vec_make(&split_shipp->back_ship.model_center_disp_to_orig_center, 0.0f, 0.0f, -dist);
+	vm_vec_add2(&split_shipp->front_ship.local_pivot, &parent_ship_obj->pos );
+	vm_vec_add2(&split_shipp->back_ship.local_pivot,  &parent_ship_obj->pos );
 	
 	// find which debris pieces are in the front and back split ships
 	for (int i=0; i<pm->num_debris_objects; i++ )	{
@@ -1742,30 +1742,30 @@ static void split_ship_init( ship* shipp, split_ship* split_ship )
 		// tmp is world position,  temp_pos is world_pivot,  tmp1 is offset from world_pivot (in ship local coord)
 		model_find_world_point(&tmp, &tmp1, pm->id, -1, &vmd_identity_matrix, &temp_pos );
 		if (tmp.xyz.z > init_clip_plane_dist) {
-			split_ship->front_ship.draw_debris[i] = DEBRIS_DRAW;
-			split_ship->back_ship.draw_debris[i]  = DEBRIS_NONE;
+			split_shipp->front_ship.draw_debris[i] = DEBRIS_DRAW;
+			split_shipp->back_ship.draw_debris[i]  = DEBRIS_NONE;
 		} else {
-			split_ship->front_ship.draw_debris[i] = DEBRIS_NONE;
-			split_ship->back_ship.draw_debris[i]  = DEBRIS_DRAW;
+			split_shipp->front_ship.draw_debris[i] = DEBRIS_NONE;
+			split_shipp->back_ship.draw_debris[i]  = DEBRIS_DRAW;
 		}
 	}
 
 	// set up physics 
-	physics_init( &split_ship->front_ship.phys_info );
-	physics_init( &split_ship->back_ship.phys_info );
-	split_ship->front_ship.phys_info.flags  |= (PF_ACCELERATES | PF_DEAD_DAMP);
-	split_ship->back_ship.phys_info.flags |= (PF_ACCELERATES | PF_DEAD_DAMP);
-	split_ship->front_ship.phys_info.side_slip_time_const = 10000.0f;
-	split_ship->back_ship.phys_info.side_slip_time_const =  10000.0f;
-	split_ship->front_ship.phys_info.rotdamp = 10000.0f;
-	split_ship->back_ship.phys_info.rotdamp =  10000.0f;
+	physics_init( &split_shipp->front_ship.phys_info );
+	physics_init( &split_shipp->back_ship.phys_info );
+	split_shipp->front_ship.phys_info.flags  |= (PF_ACCELERATES | PF_DEAD_DAMP);
+	split_shipp->back_ship.phys_info.flags |= (PF_ACCELERATES | PF_DEAD_DAMP);
+	split_shipp->front_ship.phys_info.side_slip_time_const = 10000.0f;
+	split_shipp->back_ship.phys_info.side_slip_time_const =  10000.0f;
+	split_shipp->front_ship.phys_info.rotdamp = 10000.0f;
+	split_shipp->back_ship.phys_info.rotdamp =  10000.0f;
 
 	// set up explosion vel and relative velocities (assuming mass depends on length)
-	float front_length = pm->maxs.xyz.z - split_ship->front_ship.cur_clip_plane_pt;
-	float back_length  = split_ship->back_ship.cur_clip_plane_pt - pm->mins.xyz.z;
+	float front_length = pm->maxs.xyz.z - split_shipp->front_ship.cur_clip_plane_pt;
+	float back_length  = split_shipp->back_ship.cur_clip_plane_pt - pm->mins.xyz.z;
 	float ship_length = front_length + back_length;
-	split_ship->front_ship.length_left = front_length;
-	split_ship->back_ship.length_left  = back_length;
+	split_shipp->front_ship.length_left = front_length;
+	split_shipp->back_ship.length_left  = back_length;
 
 	float expl_length_scale = (ship_length - 200.0f) / 2000.0f;
 	// s_r_f effects speed of "wipe" and rotvel
@@ -1773,8 +1773,8 @@ static void split_ship_init( ship* shipp, split_ship* split_ship )
 	float explosion_time = (3.0f + expl_length_scale + (frand()-0.5f)) * speed_reduction_factor;
 	float long_length = MAX(front_length, back_length);
 	float expl_vel = long_length / explosion_time;
-	split_ship->front_ship.explosion_vel = expl_vel;
-	split_ship->back_ship.explosion_vel  = -expl_vel;
+	split_shipp->front_ship.explosion_vel = expl_vel;
+	split_shipp->back_ship.explosion_vel  = -expl_vel;
 
 	float rel_vel = (0.6f + 0.2f*frand()) * expl_vel * speed_reduction_factor;
 	float front_vel = rel_vel * back_length / ship_length;
@@ -1786,26 +1786,26 @@ static void split_ship_init( ship* shipp, split_ship* split_ship )
 	rotvel.xyz.z = 0.0f;
 	vm_vec_normalize(&rotvel);
 	vm_vec_scale(&rotvel, 0.15f / speed_reduction_factor);
-	split_ship->front_ship.phys_info.rotvel = rotvel;
-	vm_vec_copy_scale(&split_ship->back_ship.phys_info.rotvel, &rotvel, -(front_length*front_length)/(back_length*back_length));
-	split_ship->front_ship.phys_info.rotvel.xyz.z = parent_ship_obj->phys_info.rotvel.xyz.z;
-	split_ship->back_ship.phys_info.rotvel.xyz.z  = parent_ship_obj->phys_info.rotvel.xyz.z;
+	split_shipp->front_ship.phys_info.rotvel = rotvel;
+	vm_vec_copy_scale(&split_shipp->back_ship.phys_info.rotvel, &rotvel, -(front_length*front_length)/(back_length*back_length));
+	split_shipp->front_ship.phys_info.rotvel.xyz.z = parent_ship_obj->phys_info.rotvel.xyz.z;
+	split_shipp->back_ship.phys_info.rotvel.xyz.z  = parent_ship_obj->phys_info.rotvel.xyz.z;
 
 
 	// modify vel of each split ship based on rotvel of parent ship obj
 	vec3d temp_rotvel = parent_ship_obj->phys_info.rotvel;
 	temp_rotvel.xyz.z = 0.0f;
 	vec3d vel_from_rotvel;
-	vm_vec_crossprod(&vel_from_rotvel, &temp_rotvel, &split_ship->front_ship.local_pivot);
-	vm_vec_crossprod(&vel_from_rotvel, &temp_rotvel, &split_ship->back_ship.local_pivot);
+	vm_vec_crossprod(&vel_from_rotvel, &temp_rotvel, &split_shipp->front_ship.local_pivot);
+	vm_vec_crossprod(&vel_from_rotvel, &temp_rotvel, &split_shipp->back_ship.local_pivot);
 
 	// set up velocity and make initial fireballs and particles
-	split_ship->front_ship.phys_info.vel = parent_ship_obj->phys_info.vel;
-	split_ship->back_ship.phys_info.vel  = parent_ship_obj->phys_info.vel;
-	maybe_fireball_wipe(&split_ship->front_ship, (int*)&split_ship->sound_handle);
-	maybe_fireball_wipe(&split_ship->back_ship,  (int*)&split_ship->sound_handle);
-	vm_vec_scale_add2(&split_ship->front_ship.phys_info.vel, &orient->vec.fvec, front_vel);
-	vm_vec_scale_add2(&split_ship->back_ship.phys_info.vel,  &orient->vec.fvec, back_vel);
+	split_shipp->front_ship.phys_info.vel = parent_ship_obj->phys_info.vel;
+	split_shipp->back_ship.phys_info.vel  = parent_ship_obj->phys_info.vel;
+	maybe_fireball_wipe(&split_shipp->front_ship, (int*)&split_shipp->sound_handle);
+	maybe_fireball_wipe(&split_shipp->back_ship,  (int*)&split_shipp->sound_handle);
+	vm_vec_scale_add2(&split_shipp->front_ship.phys_info.vel, &orient->vec.fvec, front_vel);
+	vm_vec_scale_add2(&split_shipp->back_ship.phys_info.vel,  &orient->vec.fvec, back_vel);
 
 	// HANDLE LIVE DEBRIS - blow off if not already gone
 	shipfx_maybe_create_live_debris_at_ship_death( parent_ship_obj );
@@ -1930,7 +1930,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 	if(db == NULL || shipp == NULL)
 		return;
 
-	object *ship_obj = &Objects[shipp->objnum];
+	object *ship_objp = &Objects[shipp->objnum];
 	physics_info *pi = &Objects[db->objnum].phys_info;
 	ship_info *sip = &Ship_info[shipp->ship_info_index];
 
@@ -1945,7 +1945,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 		}
 		else
 		{
-			vm_vec_copy_scale(&pi->vel, &ship_obj->orient.vec.fvec, debris_speed);
+			vm_vec_copy_scale(&pi->vel, &ship_objp->orient.vec.fvec, debris_speed);
 		}
 	}
 	else if(sip->debris_min_speed >= 0.0f)
@@ -1959,7 +1959,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 			}
 			else
 			{
-				vm_vec_copy_scale(&pi->vel, &ship_obj->orient.vec.fvec, sip->debris_min_speed);
+				vm_vec_copy_scale(&pi->vel, &ship_objp->orient.vec.fvec, sip->debris_min_speed);
 			}
 		}
 	}
@@ -1974,7 +1974,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 			}
 			else
 			{
-				vm_vec_copy_scale(&pi->vel, &ship_obj->orient.vec.fvec, sip->debris_max_speed);
+				vm_vec_copy_scale(&pi->vel, &ship_objp->orient.vec.fvec, sip->debris_max_speed);
 			}
 		}
 	}
@@ -1991,7 +1991,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 		}
 		else
 		{
-			vm_vec_copy_scale(&pi->rotvel, &ship_obj->orient.vec.uvec, debris_rotspeed);
+			vm_vec_copy_scale(&pi->rotvel, &ship_objp->orient.vec.uvec, debris_rotspeed);
 		}
 	}
 	else if(sip->debris_min_rotspeed >= 0.0f)
@@ -2005,7 +2005,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 			}
 			else
 			{
-				vm_vec_copy_scale(&pi->rotvel, &ship_obj->orient.vec.uvec, sip->debris_min_rotspeed);
+				vm_vec_copy_scale(&pi->rotvel, &ship_objp->orient.vec.uvec, sip->debris_min_rotspeed);
 			}
 		}
 	}
@@ -2021,7 +2021,7 @@ void shipfx_debris_limit_speed(debris *db, ship *shipp)
 			}
 			else
 			{
-				vm_vec_copy_scale(&pi->rotvel, &ship_obj->orient.vec.uvec, sip->debris_max_rotspeed);
+				vm_vec_copy_scale(&pi->rotvel, &ship_objp->orient.vec.uvec, sip->debris_max_rotspeed);
 			}
 		}
 	}

code/sound/ds.cpp

@@ -1660,12 +1660,12 @@ int ds_get_channel(int sig)
 /**
  * @todo Documentation
  */
-int ds_is_channel_playing(int channel)
+int ds_is_channel_playing(int channel_id)
 {
-	if ( Channels[channel].source_id != 0 ) {
+	if ( Channels[channel_id].source_id != 0 ) {
 		ALint status;
 
-		OpenAL_ErrorPrint( alGetSourcei(Channels[channel].source_id, AL_SOURCE_STATE, &status) );
+		OpenAL_ErrorPrint( alGetSourcei(Channels[channel_id].source_id, AL_SOURCE_STATE, &status) );
 
 		return (status == AL_PLAYING);
 	}
@@ -1676,10 +1676,10 @@ int ds_is_channel_playing(int channel)
 /**
  * @todo Documentation
  */
-void ds_stop_channel(int channel)
+void ds_stop_channel(int channel_id)
 {
-	if ( Channels[channel].source_id != 0 ) {
-		OpenAL_ErrorPrint( alSourceStop(Channels[channel].source_id) );
+	if ( Channels[channel_id].source_id != 0 ) {
+		OpenAL_ErrorPrint( alSourceStop(Channels[channel_id].source_id) );
 	}
 }
 
@@ -1701,13 +1701,13 @@ void ds_stop_channel_all()
  * @brief Set the volume for a channel.  The volume is expected to be in linear scale
  * @details If the sound is a 3D sound buffer, this is like re-establishing the maximum volume.
  */
-void ds_set_volume( int channel, float vol )
+void ds_set_volume( int channel_id, float vol )
 {
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return;
 	}
 
-	ALuint source_id = Channels[channel].source_id;
+	ALuint source_id = Channels[channel_id].source_id;
 
 	if (source_id != 0) {
 		CAP(vol, 0.0f, 1.0f);
@@ -1718,39 +1718,39 @@ void ds_set_volume( int channel, float vol )
 /**
  * Set the pan for a channel.  The pan is expected to be in DirectSound units
  */
-void ds_set_pan( int channel, float pan )
+void ds_set_pan( int channel_id, float pan )
 {
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return;
 	}
 
 	ALint state;
 
-	OpenAL_ErrorCheck( alGetSourcei(Channels[channel].source_id, AL_SOURCE_STATE, &state), return );
+	OpenAL_ErrorCheck( alGetSourcei(Channels[channel_id].source_id, AL_SOURCE_STATE, &state), return );
 
 	if (state == AL_PLAYING) {
-		//OpenAL_ErrorPrint( alSourcei(Channels[channel].source_id, AL_SOURCE_RELATIVE, AL_TRUE) );
-		OpenAL_ErrorPrint( alSource3f(Channels[channel].source_id, AL_POSITION, pan, 0.0f, 1.0f) );
+		//OpenAL_ErrorPrint( alSourcei(Channels[channel_id].source_id, AL_SOURCE_RELATIVE, AL_TRUE) );
+		OpenAL_ErrorPrint( alSource3f(Channels[channel_id].source_id, AL_POSITION, pan, 0.0f, 1.0f) );
 	}
 }
 
 /**
  * Get the pitch of a channel
  */
-int ds_get_pitch(int channel)
+int ds_get_pitch(int channel_id)
 {
 	ALint status;
 	ALfloat alpitch = 0;
 	int pitch;
 
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return -1;
 	}
 
-	OpenAL_ErrorCheck( alGetSourcei(Channels[channel].source_id, AL_SOURCE_STATE, &status), return -1 );
+	OpenAL_ErrorCheck( alGetSourcei(Channels[channel_id].source_id, AL_SOURCE_STATE, &status), return -1 );
 
 	if (status == AL_PLAYING) {
-		OpenAL_ErrorPrint( alGetSourcef(Channels[channel].source_id, AL_PITCH, &alpitch) );
+		OpenAL_ErrorPrint( alGetSourcef(Channels[channel_id].source_id, AL_PITCH, &alpitch) );
 	}
 
 	// convert OpenAL values to DirectSound values and return
@@ -1762,11 +1762,11 @@ int ds_get_pitch(int channel)
 /**
  * Set the pitch of a channel
  */
-void ds_set_pitch(int channel, int pitch)
+void ds_set_pitch(int channel_id, int pitch)
 {
 	ALint status;
 
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return;
 	}
 
@@ -1778,24 +1778,24 @@ void ds_set_pitch(int channel, int pitch)
 		pitch = MAX_PITCH;
 	}
 
-	OpenAL_ErrorCheck( alGetSourcei(Channels[channel].source_id, AL_SOURCE_STATE, &status), return );
+	OpenAL_ErrorCheck( alGetSourcei(Channels[channel_id].source_id, AL_SOURCE_STATE, &status), return );
 
 	if (status == AL_PLAYING) {
 		ALfloat alpitch = log10f((float)pitch) - 2.0f;
-		OpenAL_ErrorPrint( alSourcef(Channels[channel].source_id, AL_PITCH, alpitch) );
+		OpenAL_ErrorPrint( alSourcef(Channels[channel_id].source_id, AL_PITCH, alpitch) );
 	}
 }
 
 /**
  * @todo Documentation
  */
-void ds_chg_loop_status(int channel, int loop)
+void ds_chg_loop_status(int channel_id, int loop)
 {
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return;
 	}
 
-	ALuint source_id = Channels[channel].source_id;
+	ALuint source_id = Channels[channel_id].source_id;
 
 	OpenAL_ErrorPrint( alSourcei(source_id, AL_LOOPING, loop ? AL_TRUE : AL_FALSE) );
 }
@@ -1818,99 +1818,99 @@ void ds_chg_loop_status(int channel, int loop)
  */
 int ds3d_play(int sid, int snd_id, vec3d *pos, vec3d *vel, float min, float max, int looping, float max_volume, float estimated_vol, int priority )
 {
-	int channel;
+	int channel_id;
 
 	if (!ds_initialized) {
 		return -1;
 	}
 
-	channel = ds_get_free_channel(estimated_vol, snd_id, priority);
+	channel_id = ds_get_free_channel(estimated_vol, snd_id, priority);
 
-	if (channel < 0) {
+	if (channel_id < 0) {
 		return -1;
 	}
 
-	if ( Channels[channel].source_id == 0 ) {
+	if ( Channels[channel_id].source_id == 0 ) {
 		return -1;
 	}
 
 	// set up 3D sound data here
-	ds3d_update_buffer(channel, min, max, pos, vel);
+	ds3d_update_buffer(channel_id, min, max, pos, vel);
 
 
-	OpenAL_ErrorPrint( alSourcef(Channels[channel].source_id, AL_PITCH, 1.0f) );
+	OpenAL_ErrorPrint( alSourcef(Channels[channel_id].source_id, AL_PITCH, 1.0f) );
 
-	OpenAL_ErrorPrint( alSourcef(Channels[channel].source_id, AL_GAIN, max_volume) );
+	OpenAL_ErrorPrint( alSourcef(Channels[channel_id].source_id, AL_GAIN, max_volume) );
 
 	ALint status;
-	OpenAL_ErrorCheck( alGetSourcei(Channels[channel].source_id, AL_SOURCE_STATE, &status), return -1 );
+	OpenAL_ErrorCheck( alGetSourcei(Channels[channel_id].source_id, AL_SOURCE_STATE, &status), return -1 );
 	
 	if (status == AL_PLAYING) {
-		OpenAL_ErrorPrint( alSourceStop(Channels[channel].source_id) );
+		OpenAL_ErrorPrint( alSourceStop(Channels[channel_id].source_id) );
 	}
 
 
-	OpenAL_ErrorCheck( alSourcei(Channels[channel].source_id, AL_BUFFER, sound_buffers[sid].buf_id), return -1 );
+	OpenAL_ErrorCheck( alSourcei(Channels[channel_id].source_id, AL_BUFFER, sound_buffers[sid].buf_id), return -1 );
 
 	if (Ds_eax_inited) {
-		OpenAL_ErrorPrint( alSource3i(Channels[channel].source_id, AL_AUXILIARY_SEND_FILTER, AL_EFX_aux_id, 0, AL_FILTER_NULL) );
+		OpenAL_ErrorPrint( alSource3i(Channels[channel_id].source_id, AL_AUXILIARY_SEND_FILTER, AL_EFX_aux_id, 0, AL_FILTER_NULL) );
 	}
 
-	OpenAL_ErrorPrint( alSourcei(Channels[channel].source_id, AL_SOURCE_RELATIVE, AL_FALSE) );
+	OpenAL_ErrorPrint( alSourcei(Channels[channel_id].source_id, AL_SOURCE_RELATIVE, AL_FALSE) );
 
-	OpenAL_ErrorPrint( alSourcei(Channels[channel].source_id, AL_LOOPING, (looping) ? AL_TRUE : AL_FALSE) );
+	OpenAL_ErrorPrint( alSourcei(Channels[channel_id].source_id, AL_LOOPING, (looping) ? AL_TRUE : AL_FALSE) );
 
-	OpenAL_ErrorPrint( alSourcePlay(Channels[channel].source_id) );
+	OpenAL_ErrorPrint( alSourcePlay(Channels[channel_id].source_id) );
 
 
-	sound_buffers[sid].channel_id = channel;
+	sound_buffers[sid].channel_id = channel_id;
 
-	Channels[channel].sid = sid;
-	Channels[channel].snd_id = snd_id;
-	Channels[channel].sig = channel_next_sig++;
-	Channels[channel].last_position = 0;
-	Channels[channel].is_voice_msg = false;
-	Channels[channel].vol = max_volume;
-	Channels[channel].looping = looping;
-	Channels[channel].priority = priority;
+	Channels[channel_id].sid = sid;
+	Channels[channel_id].snd_id = snd_id;
+	Channels[channel_id].sig = channel_next_sig++;
+	Channels[channel_id].last_position = 0;
+	Channels[channel_id].is_voice_msg = false;
+	Channels[channel_id].vol = max_volume;
+	Channels[channel_id].looping = looping;
+	Channels[channel_id].priority = priority;
 
 	if (channel_next_sig < 0 ) {
 		channel_next_sig = 1;
 	}
 
-	return Channels[channel].sig;
+	return Channels[channel_id].sig;
 }
 
 /**
  * @todo Documentation
  */
-void ds_set_position(int channel, unsigned int offset)
+void ds_set_position(int channel_id, unsigned int offset)
 {
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return;
 	}
 
-	OpenAL_ErrorPrint( alSourcei(Channels[channel].source_id, AL_BYTE_OFFSET, offset) );
+	OpenAL_ErrorPrint( alSourcei(Channels[channel_id].source_id, AL_BYTE_OFFSET, offset) );
 }
 
 /**
  * @todo Documentation
  */
-unsigned int ds_get_play_position(int channel)
+unsigned int ds_get_play_position(int channel_id)
 {
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return 0;
 	}
 
 	ALint pos = -1;
-	int	sid = Channels[channel].sid;
+	int	sid = Channels[channel_id].sid;
 
 	if ( (sid < 0) || ((size_t)sid >= sound_buffers.size()) ) {
 		return 0;
 	}
 
 	if (AL_play_position) {
-		OpenAL_ErrorPrint( alGetSourcei(Channels[channel].source_id, AL_BYTE_LOKI, &pos) );
+		OpenAL_ErrorPrint( alGetSourcei(Channels[channel_id].source_id, AL_BYTE_LOKI, &pos) );
 
 		if ( pos < 0 ) {
 			pos = 0;
@@ -1925,7 +1925,7 @@ unsigned int ds_get_play_position(int channel)
 			pos = (ALint)(pos * ((float)sound_buffers[sid].nbytes / size));
 		}
 	} else {
-		OpenAL_ErrorPrint( alGetSourcei(Channels[channel].source_id, AL_BYTE_OFFSET, &pos) );
+		OpenAL_ErrorPrint( alGetSourcei(Channels[channel_id].source_id, AL_BYTE_OFFSET, &pos) );
 
 		if (pos < 0) {
 			pos = 0;
@@ -1938,7 +1938,7 @@ unsigned int ds_get_play_position(int channel)
 /**
  * @todo Documentation
  */
-unsigned int ds_get_write_position(int channel)
+unsigned int ds_get_write_position(int channel_id)
 {
 	return 0;
 }
@@ -1946,13 +1946,13 @@ unsigned int ds_get_write_position(int channel)
 /**
  * @todo Documentation
  */
-int ds_get_channel_size(int channel)
+int ds_get_channel_size(int channel_id)
 {
-	if ( (channel < 0) || (channel >= MAX_CHANNELS) ) {
+	if ( (channel_id < 0) || (channel_id >= MAX_CHANNELS) ) {
 		return 0;
 	}
 
-	int sid = Channels[channel].sid;
+	int sid = Channels[channel_id].sid;
 
 	if ( (sid < 0) || ((size_t)sid >= sound_buffers.size()) ) {
 		return 0;
@@ -2408,10 +2408,10 @@ void ds_do_frame()
 /**
  * Given a valid channel return the sound id
  */
-int ds_get_sound_id(int channel)
+int ds_get_sound_id(int channel_id)
 {
-	Assert( channel >= 0 );
+	Assert( channel_id >= 0 );
 
-	return Channels[channel].snd_id;
+	return Channels[channel_id].snd_id;
 }
 

code/sound/ds3d.cpp

@@ -32,18 +32,18 @@
 //					-1		=>		failure
 //
 //
-int ds3d_update_buffer(int channel, float min, float max, vec3d *pos, vec3d *vel)
+int ds3d_update_buffer(int channel_id, float min, float max, vec3d *pos, vec3d *vel)
 {
 	if (Cmdline_no_3d_sound) {
 		nprintf(("Sound", "Aborting ds3d_update_buffer due to Cmdline_no_3d_sound..."));
 		return -1;
 	}
 
-	if (channel < 0) {
+	if (channel_id < 0) {
 		return 0;
 	}
 
-	ALuint source_id = Channels[channel].source_id;
+	ALuint source_id = Channels[channel_id].source_id;
 	ALfloat rolloff = 1.0f;
 
 	if (pos) {

code/sound/phrases.xml

@@ -1,6 +1,6 @@
 <GRAMMAR>
 	<DEFINE>
-		<ID NAME="VID_Counter"			VAL="80"/> 
+		<ID NAME="VID_Counter"			VAL="80"/>
 		<ID NAME="VID_DestroyTarget"	VAL="10"/>
 		<ID NAME="VID_DisableTarget"	VAL="11"/>
 		<ID NAME="VID_DisarmTarget"		VAL="12"/>
@@ -35,30 +35,30 @@
 
 	<RULE ID="VID_WingName" TOPLEVEL="ACTIVE">
 		<L PROPID="VID_WingName">
-			<P VAL="0">Alpha</P>
-			<P VAL="1">Beta</P>	
-			<P VAL="2">Gamma</P>	
-			<P VAL="3">Delta</P>
-			<P VAL="4">Epsilon</P>
-			<P VAL="5">Zeta</P>
-			<P VAL="6">Eta</P>
-			<P VAL="7">Theta</P>
-			<P VAL="8">Iota</P>
-			<P VAL="9">Kappa</P>
-			<P VAL="10">Lambda</P>
-			<P VAL="11">Mu</P>
-			<P VAL="12">Nu</P>
-			<P VAL="13">Xi</P>
-			<P VAL="14">Omicron</P>
-			<P VAL="15">Pi</P>
-			<P VAL="16">Rho</P>
-			<P VAL="17">Sigma</P>
-			<P VAL="18">Tau</P>
-			<P VAL="19">Upsilon</P>
-			<P VAL="20">Phi</P>
-			<P VAL="21">Chi</P>
-			<P VAL="22">Psi</P>
-			<P VAL="23">Omega</P>		
+			<P VALSTR="Alpha">Alpha</P>
+			<P VALSTR="Beta">Beta</P>
+			<P VALSTR="Gamma">Gamma</P>
+			<P VALSTR="Delta">Delta</P>
+			<P VALSTR="Epsilon">Epsilon</P>
+			<P VALSTR="Zeta">Zeta</P>
+			<P VALSTR="Eta">Eta</P>
+			<P VALSTR="Theta">Theta</P>
+			<P VALSTR="Iota">Iota</P>
+			<P VALSTR="Kappa">Kappa</P>
+			<P VALSTR="Lambda">Lambda</P>
+			<P VALSTR="Mu">Mu</P>
+			<P VALSTR="Nu">Nu</P>
+			<P VALSTR="Xi">Xi</P>
+			<P VALSTR="Omicron">Omicron</P>
+			<P VALSTR="Pi">Pi</P>
+			<P VALSTR="Rho">Rho</P>
+			<P VALSTR="Sigma">Sigma</P>
+			<P VALSTR="Tau">Tau</P>
+			<P VALSTR="Upsilon">Upsilon</P>
+			<P VALSTR="Phi">Phi</P>
+			<P VALSTR="Chi">Chi</P>
+			<P VALSTR="Psi">Psi</P>
+			<P VALSTR="Omega">Omega</P>
 		</L>
 		<L PROPID="VID_ShipName">
 			<P VAl="0">Wing</P>
@@ -87,26 +87,26 @@
 			<P VAL="VID_IgnoreTarget">Ignore my target</P>
 			<P VAL="VID_FormWing">Form on my wing</P>
 			<P VAL="VID_CoverMe">Cover me</P>
-			<P VAL="VID_EngageEnemy">Engage Enemy</P>
+			<P VAL="VID_EngageEnemy">Engage the Enemy</P>
 			<P VAL="VID_EngageEnemy">Attack</P>
 			<P VAL="VID_Depart">Depart</P>
 		</L>
 	</RULE>
 
 	<RULE ID="VID_TopMenu" TOPLEVEL="ACTIVE">
-        	<L PROPID="VID_TopMenu">
+		<L PROPID="VID_TopMenu">
 			<P VAL="VID_Ships">Ships</P>
 			<P VAL="VID_Wings">Wings</P>
 			<P VAL="VID_AllFighters">All Fighters<O><RULEREF REFID="VID_Action"/></O></P>
 			<P VAL="VID_AllWings">All Wings<O><RULEREF REFID="VID_Action"/></O></P>
 			<P VAL="VID_Reinforcements">Reinforcements</P>
 			<P VAL="VID_SupportShip">Support ship</P>
-			<P VAL="VID_SupportShip">Rearm</P>
-			<P VAL="VID_SupportShip">Repair</P>
-			<P VAL="VID_AbortSupport">Abort</P>
+			<P VAL="VID_SupportShip">Rearm <O>and repair</O></P>
+			<P VAL="VID_SupportShip">Repair <O>and rearm</O></P>
+			<P VAL="VID_AbortSupport">Abort <L><P>support <O>ship</O></P><P>rearm <O>and repair</O></P><P>repair <O>and rearm</O></P></L></P>
 			<P VAL="VID_Cancel">Cancel</P>
 			<P VAL="VID_Command">Command</P>
-			<P VAL="VID_More">More</P>        
+			<P VAL="VID_More">More</P>
 		</L>
 	</RULE>
 
@@ -144,9 +144,9 @@
 			<P VAL="91">Target previous uninspected</P>
 			<P VAL="92">Target newest</P>
 			<P VAL="93">Target next turret</P>
-			<P VAL="94">Target previous turrent</P>
+			<P VAL="94">Target previous turret</P>
 			<P VAL="95">Target next bomb</P>
-			<P VAL="96">Target previous bomb</P>				
+			<P VAL="96">Target previous bomb</P>
 		</L>
 	</RULE>
 

code/sound/voicerec.cpp

@@ -112,104 +112,118 @@ void doVid_Action(int action)
 
 bool VOICEREC_init(HWND hWnd, int event_id, int grammar_id, int command_resource)
 {
-    HRESULT hr = S_OK;
-    CComPtr<ISpAudio> cpAudio;
+	HRESULT hr = S_OK;
+	CComPtr<ISpAudio> cpAudio;
 
-    while (true)
-    {
-        // create a recognition engine
-        hr = p_recogEngine.CoCreateInstance(CLSID_SpSharedRecognizer);
-        if (FAILED(hr))
-        {
+	while (true)
+	{
+		// create a recognition engine
+		hr = p_recogEngine.CoCreateInstance(CLSID_SpInprocRecognizer);
+		if (FAILED(hr))
+		{
 			MessageBox(hWnd,"Failed to create a recognition engine\n","Error",MB_OK);
 			printf("Failed to create a recognition engine\n");
-            break;
-        }
-       
-        // create the command recognition context
-        hr = p_recogEngine->CreateRecoContext( &p_recogContext );
-        if (FAILED(hr))
-        {
+			break;
+		}
+
+		// create the command recognition context
+		hr = p_recogEngine->CreateRecoContext( &p_recogContext );
+		if (FAILED(hr))
+		{
 			MessageBox(hWnd,"Failed to create the command recognition context\n","Error",MB_OK);
 			printf("Failed to create the command recognition context\n");
-            break;
-        }
+			break;
+		}
 
-        // Let SR know that window we want it to send event information to, and using
-        // what message
-        hr = p_recogContext->SetNotifyWindowMessage( hWnd, event_id, 0, 0 );
-        if (FAILED(hr))
-        {
+		// Let SR know that window we want it to send event information to, and using
+		// what message
+		hr = p_recogContext->SetNotifyWindowMessage( hWnd, event_id, 0, 0 );
+		if (FAILED(hr))
+		{
 			MessageBox(hWnd,"Failed to SetNotifyWindowMessage\n","Error",MB_OK);
-            break;
-        }
+			break;
+		}
 
-	    // Tell SR what types of events interest us.  Here we only care about command
-        // recognition.
-        hr = p_recogContext->SetInterest( SPFEI(SPEI_RECOGNITION), SPFEI(SPEI_RECOGNITION) );
-        if (FAILED(hr))
-        {
+		// Tell SR what types of events interest us.  Here we only care about command
+		// recognition.
+		hr = p_recogContext->SetInterest( SPFEI(SPEI_RECOGNITION), SPFEI(SPEI_RECOGNITION) );
+		if (FAILED(hr))
+		{
 			MessageBox(hWnd,"Failed to set events\n","Error",MB_OK);
-            break;
-        }
+			break;
+		}
 
 		// Create a grammar
-        hr = p_recogContext->CreateGrammar(grammar_id, &p_grammarObject);
-        if (FAILED(hr))
-        {
+		hr = p_recogContext->CreateGrammar(grammar_id, &p_grammarObject);
+		if (FAILED(hr))
+		{
 			MessageBox(hWnd,"Failed to create grammar\n","Error",MB_OK);
-            break;
-        }
+			break;
+		}
 
-        // Load our grammar from data\phrases.xml, or if that doesn't exist, from the compiled in 
-        // user defined ("SRGRAMMAR") resource type.
+		// Load our grammar from data\phrases.xml, or if that doesn't exist, from the compiled in 
+		// user defined ("SRGRAMMAR") resource type.
 		hr = p_grammarObject->LoadCmdFromFile(L"data\\phrases.xml", SPLO_STATIC);
-        if (FAILED(hr))
-        {
+		if (FAILED(hr))
+		{
 			hr = p_grammarObject->LoadCmdFromResource(NULL, MAKEINTRESOURCEW(command_resource),
-                                                 L"SRGRAMMAR", MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL),
-                                                 SPLO_DYNAMIC);
+												L"SRGRAMMAR", MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL),
+												SPLO_STATIC);
 			if (FAILED(hr))
 			{
 				MessageBox(hWnd,"Failed to load resource\n","Error",MB_OK);
-		        break;
+				break;
 			}
-        }
+		}
 
-        // Set rules to active, we are now listening for commands
-        hr = p_grammarObject->SetRuleState(NULL, NULL, SPRS_ACTIVE );
-        if (FAILED(hr))
-        {
+		hr = SpCreateDefaultObjectFromCategoryId(SPCAT_AUDIOIN, &cpAudio);
+		if (FAILED(hr))
+		{
+			MessageBox(hWnd,"Failed to get default audio input\n", "Error", MB_OK);
+			break;
+		}
+
+		// Set the audio input to our token.
+		hr = p_recogEngine->SetInput(cpAudio, TRUE);
+		if (FAILED(hr))
+		{
+			MessageBox(hWnd,"Failed to set audio input\n", "Error", MB_OK);
+		}
+
+		// Set rules to active, we are now listening for commands
+		hr = p_grammarObject->SetRuleState(NULL, NULL, SPRS_ACTIVE );
+		if (FAILED(hr))
+		{
 			MessageBox(hWnd,"Failed to set listening for commands\n","Error",MB_OK);
-            break;
-        }
+			break;
+		}
 
-        break;
-    }
+		break;
+	}
 
-    // if we failed and have a partially setup SAPI, close it all down
-    if (FAILED(hr))
-    {
-        VOICEREC_deinit();
-    }
+	// if we failed and have a partially setup SAPI, close it all down
+	if (FAILED(hr))
+	{
+		VOICEREC_deinit();
+	}
 
-    return ( hr == S_OK);
+	return ( hr == S_OK);
 }
 
 void VOICEREC_deinit()
 {
-    // Release grammar, if loaded
-    if ( p_grammarObject )
-    {
-        p_grammarObject.Release();
-    }
-    // Release recognition context, if created
-    if ( p_recogContext )
-    {
-        p_recogContext->SetNotifySink(NULL);
-        p_recogContext.Release();
-    }
-    // Release recognition engine instance, if created
+	// Release grammar, if loaded
+	if ( p_grammarObject )
+	{
+		p_grammarObject.Release();
+	}
+	// Release recognition context, if created
+	if ( p_recogContext )
+	{
+		p_recogContext->SetNotifySink(NULL);
+		p_recogContext.Release();
+	}
+	// Release recognition engine instance, if created
 	if ( p_recogEngine )
 	{
 		p_recogEngine.Release();
@@ -219,51 +233,22 @@ void VOICEREC_deinit()
 void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd);
 void VOICEREC_process_event(HWND hWnd)
 {
-    CSpEvent event;  // Event helper class
+	CSpEvent event;  // Event helper class
 
-    // Loop processing events while there are any in the queue
-    while (event.GetFrom(p_recogContext) == S_OK)
-    {
-        // Look at recognition event only
-        switch (event.eEventId)
-        {
-            case SPEI_RECOGNITION:
-					VOICEREC_execute_command(event.RecoResult(), hWnd);
-                break;
+	// Loop processing events while there are any in the queue
+	while (event.GetFrom(p_recogContext) == S_OK)
+	{
+		// Look at recognition event only
+		switch (event.eEventId)
+		{
+			case SPEI_RECOGNITION:
+				VOICEREC_execute_command(event.RecoResult(), hWnd);
+				break;
 
-        }
-    }
+		}
+	}
 }
 
-// Its not enough to update this, phrases.xml must have this info as well
-char *wing_names[] = 
-{
-		"Alpha",
-		"Beta",	
-		"Gamma",	
-		"Delta",
-		"Epsilon",
-		"Zeta",
-		"Eta",
-		"Theta",
-		"Iota",
-		"Kappa",
-		"Lambda",
-		"Mu",
-		"Nu",
-		"Xi",
-		"Omicron",
-		"Pi",
-		"Rho",
-		"Sigma",
-		"Tau",
-		"Upsilon",
-		"Phi",
-		"Chi",
-		"Psi",
-		"Omega",
-};
-
 /******************************************************************************
 * ExecuteCommand *
 *----------------*
@@ -276,12 +261,12 @@ char VOICEREC_lastCommand[30];
 
 void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 {
-    SPPHRASE *pElements;
+	SPPHRASE *pElements;
 
-    // Get the phrase elements, one of which is the rule id we specified in
-    // the grammar.  Switch on it to figure out which command was recognized.
-    if (SUCCEEDED(pPhrase->GetPhrase(&pElements)))
-    {     
+	// Get the phrase elements, one of which is the rule id we specified in
+	// the grammar.  Switch on it to figure out which command was recognized.
+	if (SUCCEEDED(pPhrase->GetPhrase(&pElements)))
+	{
 #ifndef NDEBUG
 		if(DEBUG_ON)
 		{
@@ -304,13 +289,15 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 
 			mprintf(( "recognized speech : %s \n", szText ));
 			mprintf(( "speech Rule.ulId : %d \n", pElements->Rule.ulId ));
-			//MessageBoxW(NULL,pwszText,NULL,MB_OK);	
+			//MessageBoxW(NULL,pwszText,NULL,MB_OK);
+
+			::CoTaskMemFree(pwszText);
 		}
-#endif		
+#endif
 		int part1, part2, part3;
 		part1 = part2 = part3 = -1;
-        switch ( pElements->Rule.ulId )
-        {
+		switch ( pElements->Rule.ulId )
+		{
 
 			case VID_WingName: 
 			{
@@ -327,9 +314,24 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 				if (part2 == -1) 
 					break; // no ship number or wing
 
+				const wchar_t* valstr = pElements->pProperties->pszValue;
+				char* wing_name = new char[wcslen(valstr)+1];
+
+				size_t j = 0;
+
+				for (size_t i = 0; i < wcslen(valstr); i++) {
+					int c = wctob(valstr[i]);
+					if (c != EOF) {
+						wing_name[j++] = static_cast<char>(c);
+					}
+				}
+				wing_name[j] = '\0';
+
 				if (part2 == 0) 
 				{
-					Msg_instance = wing_lookup(wing_names[part1]);
+					Msg_instance = wing_lookup(wing_name);
+					delete[] wing_name;
+
 					if (Msg_instance < 0)
 						break;
 
@@ -338,13 +340,14 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 						hud_squadmsg_toggle();
 					}
 
-					hud_squadmsg_do_mode(SM_MODE_WING_COMMAND);				
+					hud_squadmsg_do_mode(SM_MODE_WING_COMMAND);
 				}
-				else 
+				else
 				{
 					char shipName[NAME_LENGTH];
-					wing_bash_ship_name(shipName, wing_names[part1], part2);
-					
+					wing_bash_ship_name(shipName, wing_name, part2);
+					delete[] wing_name;
+
 					Msg_instance = ship_name_lookup(shipName);
 
 					// Can't issue commands to yourself or to nobody
@@ -358,20 +361,20 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 						hud_squadmsg_toggle();
 					}
 
-					hud_squadmsg_do_mode(SM_MODE_SHIP_COMMAND);				
+					hud_squadmsg_do_mode(SM_MODE_SHIP_COMMAND);
 
 				}
 
-				if (part3 == -1) 
+				if (part3 == -1)
 					break;
 			}
 
 			case VID_Action:
 			{
 				int action;
-				if (part3 == -1) 
+				if (part3 == -1)
 				{
-					action = pElements->pProperties->vValue.ulVal;					
+					action = pElements->pProperties->vValue.ulVal;
 				}
 				else
 				{
@@ -401,7 +404,7 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 				
 				switch(action)
 				{
-					case VID_Ships: 
+					case VID_Ships:
 						hud_squadmsg_do_mode( SM_MODE_SHIP_SELECT );
 						break;
 
@@ -409,22 +412,22 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 						hud_squadmsg_do_mode( SM_MODE_WING_SELECT );
 						break;
 
-					case VID_AllFighters: 
+					case VID_AllFighters:
 					case VID_AllWings:
 					//	Msg_instance = MESSAGE_ALL_FIGHTERS;
 					//	Squad_msg_mode == SM_MODE_ALL_FIGHTERS
 						hud_squadmsg_msg_all_fighters();
-						if (pElements->pProperties->pNextSibling) {
-							doVid_Action(pElements->pProperties->pNextSibling->vValue.ulVal);
+						if (pElements->pProperties->pFirstChild) {
+							doVid_Action(pElements->pProperties->pFirstChild->vValue.ulVal);
 						}
 
 					//	if(Msg_shortcut_command == -1)
 					//	{
-					//		hud_squadmsg_do_mode( SM_MODE_ALL_FIGHTERS ); 
+					//		hud_squadmsg_do_mode( SM_MODE_ALL_FIGHTERS );
 					//	}
 						break;
 
-					case VID_Reinforcements: 
+					case VID_Reinforcements:
 						hud_squadmsg_do_mode( SM_MODE_REINFORCEMENTS );
 						break;
 
@@ -466,7 +469,7 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 				int action = pElements->pProperties->vValue.ulVal;
 				mprintf(("Targeting/speed %d \n", action));
 
-				if (action > -1) 
+				if (action > -1)
 				{
 					button_function( action );
 				}
@@ -500,19 +503,19 @@ void VOICEREC_execute_command(ISpPhrase *pPhrase, HWND hWnd)
 			}
 	
 	
-	/*	
-		
-		
+	/*
+
+
 	hud_squadmsg_do_mode( SM_MODE_SHIP_COMMAND );				// and move to a new mode
 	hud_squadmsg_do_mode( SM_MODE_WING_COMMAND );				// and move to a new mode
 hud_squadmsg_do_mode( SM_MODE_SHIP_COMMAND );
 
 */
 
-        }
-        // Free the pElements memory which was allocated for us
-        ::CoTaskMemFree(pElements);
-    }
+		}
+		// Free the pElements memory which was allocated for us
+		::CoTaskMemFree(pElements);
+	}
 
 }
 

code/species_defs/species_defs.cpp

@@ -153,203 +153,205 @@ void parse_thrust_glows(species_info *species, bool no_create)
 
 void parse_species_tbl(const char *filename)
 {
-	int i, rval;
+	int i;
 	char species_name[NAME_LENGTH];
 
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", (filename) ? filename : NOX("<default species_defs.tbl>"), rval));
+		if (filename == NULL)
+			read_file_text_from_array(defaults_get_file("species_defs.tbl"));
+		else
+			read_file_text(filename, CF_TYPE_TABLES);
+
+		reset_parse();
+
+
+		// start parsing
+		required_string("#SPECIES DEFS");
+
+		// no longer required: counted automatically
+		if (optional_string("$NumSpecies:"))
+		{
+			int temp;
+			stuff_int(&temp);
+		}
+
+		// begin reading data
+		while (required_string_either("#END", "$Species_Name:"))
+		{
+			bool no_create = false;
+			species_info *species, new_species;
+
+			species = &new_species;
+
+			// Start Species - Get its name
+			required_string("$Species_Name:");
+			stuff_string(species_name, F_NAME, NAME_LENGTH);
+
+			if (optional_string("+nocreate"))
+			{
+				no_create = true;
+
+				for (i = 0; i < (int)Species_info.size(); i++)
+				{
+					if (!stricmp(Species_info[i].species_name, species_name))
+					{
+						species = &Species_info[i];
+						break;
+					}
+				}
+			}
+			else
+			{
+				strcpy_s(species->species_name, species_name);
+			}
+
+			// Goober5000 - IFF
+			if (optional_string("$Default IFF:"))
+			{
+				bool iff_found = false;
+				char temp_name[NAME_LENGTH];
+				stuff_string(temp_name, F_NAME, NAME_LENGTH);
+
+				// search for it in iffs
+				for (int iLoop = 0; iLoop < Num_iffs; iLoop++)
+				{
+					if (!stricmp(Iff_info[iLoop].iff_name, temp_name))
+					{
+						species->default_iff = iLoop;
+						iff_found = true;
+					}
+				}
+
+				if (!iff_found)
+				{
+					species->default_iff = 0;
+					Warning(LOCATION, "Species %s default IFF %s not found in iff_defs.tbl!  Defaulting to %s.\n", species->species_name, temp_name, Iff_info[species->default_iff].iff_name);
+				}
+			}
+			else if (!no_create)
+			{
+				// we have no idea which it could be, so default to 0
+				species->default_iff = 0;
+
+				// let them know
+				Warning(LOCATION, "$Default IFF not specified for species %s in species_defs.tbl!  Defaulting to %s.\n", species->species_name, Iff_info[species->default_iff].iff_name);
+			}
+
+			// Goober5000 - FRED color
+			if (optional_string("$FRED Color:") || optional_string("$FRED Colour:"))
+			{
+				stuff_int_list(species->fred_color.a1d, 3, RAW_INTEGER_TYPE);
+			}
+			else if (!no_create)
+			{
+				// set defaults to Volition's originals
+				if (!stricmp(species->species_name, "Terran"))
+				{
+					species->fred_color.rgb.r = 0;
+					species->fred_color.rgb.g = 0;
+					species->fred_color.rgb.b = 192;
+				}
+				else if (!stricmp(species->species_name, "Vasudan"))
+				{
+					species->fred_color.rgb.r = 0;
+					species->fred_color.rgb.g = 128;
+					species->fred_color.rgb.b = 0;
+				}
+				else if (!stricmp(species->species_name, "Shivan"))
+				{
+					species->fred_color.rgb.r = 192;
+					species->fred_color.rgb.g = 0;
+					species->fred_color.rgb.b = 0;
+				}
+				else if (!stricmp(species->species_name, "Ancients") || !stricmp(species->species_name, "Ancient"))
+				{
+					species->fred_color.rgb.r = 192;
+					species->fred_color.rgb.g = 0;
+					species->fred_color.rgb.b = 192;
+				}
+				else
+				{
+					species->fred_color.rgb.r = 0;
+					species->fred_color.rgb.g = 0;
+					species->fred_color.rgb.b = 0;
+				}
+
+				// let them know
+				Warning(LOCATION, "$FRED Color not specified for species %s in species_defs.tbl!  Defaulting to (%d, %d, %d).\n", species->species_name, species->fred_color.rgb.r, species->fred_color.rgb.g, species->fred_color.rgb.b);
+			}
+
+			// stuff
+			optional_string("$MiscAnims:");
+
+			// Get its Debris Texture
+			if ((!no_create && required_string("+Debris_Texture:")) || optional_string("+Debris_Texture:"))
+			{
+				generic_bitmap_init(&species->debris_texture, NULL);
+				stuff_string(species->debris_texture.filename, F_NAME, MAX_FILENAME_LEN);
+			}
+
+
+			// Shield Hit Animation
+			if (optional_string("+Shield_Hit_ani:")) // Shouldn't be required -- LPine
+			{
+				generic_anim_init(&species->shield_anim, NULL);
+				stuff_string(species->shield_anim.filename, F_NAME, MAX_FILENAME_LEN);
+			}
+			else if (!no_create)
+			{
+				species->shield_anim.filename[0] = '\0';
+				species->shield_anim.first_frame = -1; // Landmine to trip up anyone who does end up using this
+			}
+
+
+			// Thruster Anims
+			parse_thrust_anims(species, no_create);
+
+			// Thruster Glow Anims
+			parse_thrust_glows(species, no_create);
+
+
+			// Goober5000 - AWACS multiplier
+			if (optional_string("$AwacsMultiplier:"))
+			{
+				stuff_float(&species->awacs_multiplier);
+			}
+			else if (!no_create)
+			{
+				// set defaults to Volition's originals
+				if (!stricmp(species->species_name, "Vasudan"))
+					species->awacs_multiplier = 1.25f;
+				else if (!stricmp(species->species_name, "Shivan"))
+					species->awacs_multiplier = 1.50f;
+				else
+					species->awacs_multiplier = 1.0f;
+
+				// let them know
+				Warning(LOCATION, "$AwacsMultiplier not specified for species %s in species_defs.tbl!  Defaulting to %.2d.\n", species->species_name, species->awacs_multiplier);
+			}
+
+			// Goober5000 - countermeasure type
+			// (we won't be able to resolve it until after we've parsed the weapons table)
+			if (optional_string("$Countermeasure type:"))
+				stuff_string(species->cmeasure_name, F_NAME, NAME_LENGTH);
+
+			// don't add new entry if this is just a modified one
+			if (!no_create)
+				Species_info.push_back(new_species);
+		}
+
+		required_string("#END");
+
+		// add tbl/tbm to multiplayer validation list
+		extern void fs2netd_add_table_validation(const char *tblname);
+		fs2netd_add_table_validation(filename);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", (filename) ? filename : NOX("<default species_defs.tbl>"), e.what()));
 		return;
 	}
-
-	if (filename == NULL)
-		read_file_text_from_array(defaults_get_file("species_defs.tbl"));
-	else
-		read_file_text(filename, CF_TYPE_TABLES);
-
-	reset_parse();		
-
-
-	// start parsing
-	required_string("#SPECIES DEFS");
-
-	// no longer required: counted automatically
-	if (optional_string("$NumSpecies:"))
-	{
-		int temp;
-		stuff_int(&temp);
-	}
-
-	// begin reading data
-	while (required_string_either("#END","$Species_Name:"))
-	{
-		bool no_create = false;
-		species_info *species, new_species;
-
-		species = &new_species;
-
-		// Start Species - Get its name
-		required_string("$Species_Name:");
-		stuff_string(species_name, F_NAME, NAME_LENGTH);
-
-		if (optional_string("+nocreate"))
-		{
-			no_create = true;
-
-			for (i = 0; i < (int)Species_info.size(); i++)
-			{
-				if (!stricmp(Species_info[i].species_name, species_name))
-				{
-					species = &Species_info[i];
-					break;
-				}
-			}
-		}
-		else
-		{
-			strcpy_s(species->species_name, species_name);
-		}
-
-		// Goober5000 - IFF
-		if (optional_string("$Default IFF:"))
-		{
-			bool iff_found = false;
-			char temp_name[NAME_LENGTH];
-			stuff_string(temp_name, F_NAME, NAME_LENGTH);
-
-			// search for it in iffs
-			for (int iLoop = 0; iLoop < Num_iffs; iLoop++)
-			{
-				if (!stricmp(Iff_info[iLoop].iff_name, temp_name))
-				{
-					species->default_iff = iLoop;
-					iff_found = true;
-				}
-			}
-
-			if (!iff_found)
-			{
-				species->default_iff = 0;
-				Warning(LOCATION, "Species %s default IFF %s not found in iff_defs.tbl!  Defaulting to %s.\n", species->species_name, temp_name, Iff_info[species->default_iff].iff_name);
-			}
-		}
-		else if (!no_create)
-		{
-			// we have no idea which it could be, so default to 0
-			species->default_iff = 0;
-
-			// let them know
-			Warning(LOCATION, "$Default IFF not specified for species %s in species_defs.tbl!  Defaulting to %s.\n", species->species_name, Iff_info[species->default_iff].iff_name);
-		}
-
-		// Goober5000 - FRED color
-		if (optional_string("$FRED Color:") || optional_string("$FRED Colour:"))
-		{
-			stuff_int_list(species->fred_color.a1d, 3, RAW_INTEGER_TYPE);
-		}
-		else if (!no_create)
-		{
-			// set defaults to Volition's originals
-			if (!stricmp(species->species_name, "Terran"))
-			{
-				species->fred_color.rgb.r = 0;
-				species->fred_color.rgb.g = 0;
-				species->fred_color.rgb.b = 192;
-			}
-			else if (!stricmp(species->species_name, "Vasudan"))
-			{
-				species->fred_color.rgb.r = 0;
-				species->fred_color.rgb.g = 128;
-				species->fred_color.rgb.b = 0;
-			}
-			else if (!stricmp(species->species_name, "Shivan"))
-			{
-				species->fred_color.rgb.r = 192;
-				species->fred_color.rgb.g = 0;
-				species->fred_color.rgb.b = 0;
-			}
-			else if (!stricmp(species->species_name, "Ancients") || !stricmp(species->species_name, "Ancient"))
-			{
-				species->fred_color.rgb.r = 192;
-				species->fred_color.rgb.g = 0;
-				species->fred_color.rgb.b = 192;
-			}
-			else
-			{
-				species->fred_color.rgb.r = 0;
-				species->fred_color.rgb.g = 0;
-				species->fred_color.rgb.b = 0;
-			}
-
-			// let them know
-			Warning(LOCATION, "$FRED Color not specified for species %s in species_defs.tbl!  Defaulting to (%d, %d, %d).\n", species->species_name, species->fred_color.rgb.r, species->fred_color.rgb.g, species->fred_color.rgb.b);
-		}
-
-		// stuff
-		optional_string("$MiscAnims:");
-
-		// Get its Debris Texture
-		if ((!no_create && required_string("+Debris_Texture:")) || optional_string("+Debris_Texture:"))
-		{
-			generic_bitmap_init(&species->debris_texture, NULL);
-			stuff_string(species->debris_texture.filename, F_NAME, MAX_FILENAME_LEN);
-		}
-
-
-		// Shield Hit Animation
-        if (optional_string("+Shield_Hit_ani:")) // Shouldn't be required -- LPine
-		{
-			generic_anim_init(&species->shield_anim, NULL);
-			stuff_string(species->shield_anim.filename, F_NAME, MAX_FILENAME_LEN);
-		}
-        else if (!no_create)
-        {
-            species->shield_anim.filename[0] = '\0';
-            species->shield_anim.first_frame = -1; // Landmine to trip up anyone who does end up using this
-        }
-
-
-		// Thruster Anims
-		parse_thrust_anims(species, no_create);
-
-		// Thruster Glow Anims
-		parse_thrust_glows(species, no_create);
-
-
-		// Goober5000 - AWACS multiplier
-		if (optional_string("$AwacsMultiplier:"))
-		{
-			stuff_float(&species->awacs_multiplier);
-		}
-		else if (!no_create)
-		{
-			// set defaults to Volition's originals
-			if (!stricmp(species->species_name, "Vasudan"))
-				species->awacs_multiplier = 1.25f;
-			else if (!stricmp(species->species_name, "Shivan"))
-				species->awacs_multiplier = 1.50f;
-			else
-				species->awacs_multiplier = 1.0f;
-
-			// let them know
-			Warning(LOCATION, "$AwacsMultiplier not specified for species %s in species_defs.tbl!  Defaulting to %.2d.\n", species->species_name, species->awacs_multiplier);
-		}
-
-		// Goober5000 - countermeasure type
-		// (we won't be able to resolve it until after we've parsed the weapons table)
-		if (optional_string("$Countermeasure type:"))
-			stuff_string(species->cmeasure_name, F_NAME, NAME_LENGTH);
-
-		// don't add new entry if this is just a modified one
-		if ( !no_create )
-			Species_info.push_back( new_species );
-	}
-	
-	required_string("#END");
-
-	// add tbl/tbm to multiplayer validation list
-	extern void fs2netd_add_table_validation(const char *tblname);
-	fs2netd_add_table_validation(filename);
 }
 
 int Species_initted = 0;

code/starfield/starfield.cpp

@@ -404,183 +404,192 @@ void parse_startbl(const char *filename)
 {
 	char name[MAX_FILENAME_LEN], tempf[16];
 	starfield_bitmap sbm;
-	int idx, rval;
+	int idx;
 	bool in_check = false;
 	int rc = -1;
 	int run_count = 0;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
+
+		// freaky! ;)
+		while (!check_for_eof()) {
+			while ((rc = optional_string_either("$Bitmap:", "$BitmapX:")) != -1) {
+				in_check = true;
+
+				starfield_bitmap_entry_init(&sbm);
+
+				stuff_string(sbm.filename, F_NAME, MAX_FILENAME_LEN);
+				sbm.xparent = rc;  // 0 == intensity alpha bitmap,  1 == green xparency bitmap
+
+				if ((idx = stars_find_bitmap(sbm.filename)) >= 0) {
+					if (sbm.xparent == Starfield_bitmaps[idx].xparent) {
+						if (!Parsing_modular_table)
+							Warning(LOCATION, "Starfield bitmap '%s' listed more than once!!  Only using the first entry!", sbm.filename);
+					}
+					else {
+						Warning(LOCATION, "Starfield bitmap '%s' already listed as a %sxparent bitmap!!  Only using the xparent version!",
+							(rc) ? "xparent" : "non-xparent", (rc) ? "xparent" : "non-xparent", sbm.filename);
+					}
+				}
+				else {
+					Starfield_bitmaps.push_back(sbm);
+				}
+			}
+
+			CHECK_END();
+
+			while (optional_string("$Sun:")) {
+				in_check = true;
+
+				starfield_bitmap_entry_init(&sbm);
+
+				stuff_string(sbm.filename, F_NAME, MAX_FILENAME_LEN);
+
+				// associated glow
+				required_string("$Sunglow:");
+				stuff_string(sbm.glow_filename, F_NAME, MAX_FILENAME_LEN);
+
+				// associated lighting values
+				required_string("$SunRGBI:");
+				stuff_float(&sbm.r);
+				stuff_float(&sbm.g);
+				stuff_float(&sbm.b);
+				stuff_float(&sbm.i);
+
+				if (optional_string("$SunSpecularRGB:")) {
+					stuff_float(&sbm.spec_r);
+					stuff_float(&sbm.spec_g);
+					stuff_float(&sbm.spec_b);
+				}
+				else {
+					sbm.spec_r = sbm.r;
+					sbm.spec_g = sbm.g;
+					sbm.spec_b = sbm.b;
+				}
+
+				// lens flare stuff
+				if (optional_string("$Flare:")) {
+					sbm.flare = 1;
+
+					required_string("+FlareCount:");
+					stuff_int(&sbm.n_flares);
+
+					// if there's a flare, it has to have at least one texture
+					required_string("$FlareTexture1:");
+					stuff_string(sbm.flare_bitmaps[0].filename, F_NAME, MAX_FILENAME_LEN);
+
+					sbm.n_flare_bitmaps = 1;
+
+					for (idx = 1; idx < MAX_FLARE_BMP; idx++) {
+						// allow 9999 textures (theoretically speaking, that is)
+						sprintf(tempf, "$FlareTexture%d:", idx + 1);
+
+						if (optional_string(tempf)) {
+							sbm.n_flare_bitmaps++;
+							stuff_string(sbm.flare_bitmaps[idx].filename, F_NAME, MAX_FILENAME_LEN);
+						}
+						//	else break; //don't allow flaretexture1 and then 3, etc.
+					}
+
+					required_string("$FlareGlow1:");
+
+					required_string("+FlareTexture:");
+					stuff_int(&sbm.flare_infos[0].tex_num);
+
+					required_string("+FlarePos:");
+					stuff_float(&sbm.flare_infos[0].pos);
+
+					required_string("+FlareScale:");
+					stuff_float(&sbm.flare_infos[0].scale);
+
+					sbm.n_flares = 1;
+
+					for (idx = 1; idx < MAX_FLARE_COUNT; idx++) {
+						// allow a lot of glows
+						sprintf(tempf, "$FlareGlow%d:", idx + 1);
+
+						if (optional_string(tempf)) {
+							sbm.n_flares++;
+
+							required_string("+FlareTexture:");
+							stuff_int(&sbm.flare_infos[idx].tex_num);
+
+							required_string("+FlarePos:");
+							stuff_float(&sbm.flare_infos[idx].pos);
+
+							required_string("+FlareScale:");
+							stuff_float(&sbm.flare_infos[idx].scale);
+						}
+						//	else break; //don't allow "flare 1" and then "flare 3"
+					}
+				}
+
+				sbm.glare = !optional_string("$NoGlare:");
+
+				sbm.xparent = 1;
+
+				if ((idx = stars_find_sun(sbm.filename)) >= 0) {
+					if (Parsing_modular_table)
+						Sun_bitmaps[idx] = sbm;
+					else
+						Warning(LOCATION, "Sun bitmap '%s' listed more than once!!  Only using the first entry!", sbm.filename);
+				}
+				else {
+					Sun_bitmaps.push_back(sbm);
+				}
+			}
+
+			CHECK_END();
+
+			// normal debris pieces
+			while (optional_string("$Debris:")) {
+				in_check = true;
+
+				stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+
+				if (Num_debris_normal < MAX_DEBRIS_VCLIPS) {
+					strcpy_s(Debris_vclips_normal[Num_debris_normal++].name, name);
+				}
+				else {
+					Warning(LOCATION, "Could not load normal motion debris '%s'; maximum of %d exceeded.", name, MAX_DEBRIS_VCLIPS);
+				}
+			}
+
+			CHECK_END();
+
+			// nebula debris pieces
+			while (optional_string("$DebrisNeb:")) {
+				in_check = true;
+
+				stuff_string(name, F_NAME, MAX_FILENAME_LEN);
+
+				if (Num_debris_nebula < MAX_DEBRIS_VCLIPS) {
+					strcpy_s(Debris_vclips_nebula[Num_debris_nebula++].name, name);
+				}
+				else {
+					Warning(LOCATION, "Could not load nebula motion debris '%s'; maximum of %d exceeded.", name, MAX_DEBRIS_VCLIPS);
+				}
+			}
+
+			CHECK_END();
+
+			// since it's possible for some idiot to have a tbl screwed up enough
+			// that this ends up in an endless loop, give an opportunity to advance
+			// through the file no matter what, because even the retail tbl has an
+			// extra "#end" line in it.
+			if (optional_string("#end") || (run_count++ > 5)) {
+				run_count = 0;
+				advance_to_eoln(NULL);
+			}
+		}
 	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	// freaky! ;)
-	while ( !check_for_eof() ) {
-		while ( (rc = optional_string_either("$Bitmap:", "$BitmapX:")) != -1 ) {
-			in_check = true;
-
-			starfield_bitmap_entry_init( &sbm );
-
-			stuff_string(sbm.filename, F_NAME, MAX_FILENAME_LEN);
-			sbm.xparent = rc;  // 0 == intensity alpha bitmap,  1 == green xparency bitmap
-
-			if ( (idx = stars_find_bitmap(sbm.filename)) >= 0 ) {
-				if (sbm.xparent == Starfield_bitmaps[idx].xparent) {
-					if ( !Parsing_modular_table )
-						Warning(LOCATION, "Starfield bitmap '%s' listed more than once!!  Only using the first entry!", sbm.filename);
-				} else {
-					Warning(LOCATION, "Starfield bitmap '%s' already listed as a %sxparent bitmap!!  Only using the xparent version!",
-										(rc) ? "xparent" : "non-xparent", (rc) ? "xparent" : "non-xparent", sbm.filename);
-				}
-			} else {
-				Starfield_bitmaps.push_back(sbm);
-			}
-		}
-
-		CHECK_END();
-
-		while ( optional_string("$Sun:") ) {
-			in_check = true;
-
-			starfield_bitmap_entry_init( &sbm );
-
-			stuff_string(sbm.filename, F_NAME, MAX_FILENAME_LEN);
-
-			// associated glow
-			required_string("$Sunglow:");
-			stuff_string(sbm.glow_filename, F_NAME, MAX_FILENAME_LEN);
-
-			// associated lighting values
-			required_string("$SunRGBI:");
-			stuff_float(&sbm.r);
-			stuff_float(&sbm.g);
-			stuff_float(&sbm.b);
-			stuff_float(&sbm.i);
-
-			if ( optional_string("$SunSpecularRGB:") ) {
-				stuff_float(&sbm.spec_r);
-				stuff_float(&sbm.spec_g);
-				stuff_float(&sbm.spec_b);
-			} else {
-				sbm.spec_r = sbm.r;
-				sbm.spec_g = sbm.g;
-				sbm.spec_b = sbm.b;
-			}
-
-			// lens flare stuff
-			if ( optional_string("$Flare:") ) {
-				sbm.flare = 1;
-
-				required_string("+FlareCount:");
-				stuff_int(&sbm.n_flares);
-
-				// if there's a flare, it has to have at least one texture
-				required_string("$FlareTexture1:");
-				stuff_string(sbm.flare_bitmaps[0].filename, F_NAME, MAX_FILENAME_LEN);
-
-				sbm.n_flare_bitmaps = 1;
-
-				for (idx = 1; idx < MAX_FLARE_BMP; idx++) {
-					// allow 9999 textures (theoretically speaking, that is)
-					sprintf(tempf, "$FlareTexture%d:", idx+1);
-
-					if (optional_string(tempf)) {
-						sbm.n_flare_bitmaps++;
-						stuff_string(sbm.flare_bitmaps[idx].filename, F_NAME, MAX_FILENAME_LEN);
-					}
-				//	else break; //don't allow flaretexture1 and then 3, etc.
-				}
-
-				required_string("$FlareGlow1:");
-
-				required_string("+FlareTexture:");
-				stuff_int(&sbm.flare_infos[0].tex_num);
-
-				required_string("+FlarePos:");
-				stuff_float(&sbm.flare_infos[0].pos);
-
-				required_string("+FlareScale:");
-				stuff_float(&sbm.flare_infos[0].scale);
-				
-				sbm.n_flares = 1;
-
-				for (idx = 1; idx < MAX_FLARE_COUNT; idx++) {
-					// allow a lot of glows
-					sprintf(tempf, "$FlareGlow%d:", idx+1);
-
-					if (optional_string(tempf)) {
-						sbm.n_flares++;
-
-						required_string("+FlareTexture:");
-						stuff_int(&sbm.flare_infos[idx].tex_num);
-
-						required_string("+FlarePos:");
-						stuff_float(&sbm.flare_infos[idx].pos);
-
-						required_string("+FlareScale:");
-						stuff_float(&sbm.flare_infos[idx].scale);
-					}
-				//	else break; //don't allow "flare 1" and then "flare 3"
-				}
-			}
-
-			sbm.glare = !optional_string("$NoGlare:");
-
-			sbm.xparent = 1;
-
-			if ( (idx = stars_find_sun(sbm.filename)) >= 0 ) {
-				if (Parsing_modular_table)
-					Sun_bitmaps[idx] = sbm;
-				else
-					Warning(LOCATION, "Sun bitmap '%s' listed more than once!!  Only using the first entry!", sbm.filename);
-			} else {
-				Sun_bitmaps.push_back(sbm);
-			}
-		}
-
-		CHECK_END();
-
-		// normal debris pieces
-		while ( optional_string("$Debris:") ) {
-			in_check = true;
-
-			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-
-			if (Num_debris_normal < MAX_DEBRIS_VCLIPS) {
-				strcpy_s(Debris_vclips_normal[Num_debris_normal++].name, name);
-			} else {
-				Warning(LOCATION, "Could not load normal motion debris '%s'; maximum of %d exceeded.", name, MAX_DEBRIS_VCLIPS);
-			}
-		}
-
-		CHECK_END();
-
-		// nebula debris pieces
-		while ( optional_string("$DebrisNeb:") ) {
-			in_check = true;
-
-			stuff_string(name, F_NAME, MAX_FILENAME_LEN);
-
-			if (Num_debris_nebula < MAX_DEBRIS_VCLIPS) {
-				strcpy_s(Debris_vclips_nebula[Num_debris_nebula++].name, name);
-			} else {
-				Warning(LOCATION, "Could not load nebula motion debris '%s'; maximum of %d exceeded.", name, MAX_DEBRIS_VCLIPS);
-			}
-		}
-
-		CHECK_END();
-
-		// since it's possible for some idiot to have a tbl screwed up enough
-		// that this ends up in an endless loop, give an opportunity to advance
-		// through the file no matter what, because even the retail tbl has an
-		// extra "#end" line in it.
-		if ( optional_string("#end") || (run_count++ > 5) ) {
-			run_count = 0;
-			advance_to_eoln(NULL);
-		}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
 }
 

code/stats/medals.cpp

@@ -245,190 +245,205 @@ const medal_stuff &medal_stuff::operator=(const medal_stuff &m)
 
 void parse_medal_tbl()
 {
-	int rval, i;
+	int i;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "medals.tbl", rval));
-		return;
-	}
-
-	read_file_text("medals.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	required_string("#Medals");
-
-	// special background information
-	if (optional_string("+Background Bitmap:")) {
-		stuff_string(Medals_background_filename, F_NAME, NAME_LENGTH);
-	} else {
-		strcpy_s(Medals_background_filename, Default_medals_background_filename);
-	}
-
-	// special mask information
-	if (optional_string("+Mask Bitmap:")) {
-		stuff_string(Medals_mask_filename, F_NAME, NAME_LENGTH);
-	} else {
-		strcpy_s(Medals_mask_filename, Default_medals_mask_filename);
-	}
-
-	// special positioning for player callsign
-	if (optional_string("+Callsign Position 640:")) {
-		stuff_int(&Medals_callsign_coords[GR_640].x);
-		stuff_int(&Medals_callsign_coords[GR_640].y);
-	} else {
-		Medals_callsign_coords[GR_640].x = Default_medals_callsign_coords[GR_640][0];
-		Medals_callsign_coords[GR_640].y = Default_medals_callsign_coords[GR_640][1];
-	}
-	if (optional_string("+Callsign Position 1024:")) {
-		stuff_int(&Medals_callsign_coords[GR_1024].x);
-		stuff_int(&Medals_callsign_coords[GR_1024].y);
-	} else {
-		Medals_callsign_coords[GR_1024].x = Default_medals_callsign_coords[GR_1024][0];
-		Medals_callsign_coords[GR_1024].y = Default_medals_callsign_coords[GR_1024][1];
-	}
-
-	// special positioning for medal label
-	if (optional_string("+Label Position 640:")) {
-		stuff_int(&Medals_label_coords[GR_640].x);
-		stuff_int(&Medals_label_coords[GR_640].y);
-		stuff_int(&Medals_label_coords[GR_640].w);
-	} else {
-		Medals_label_coords[GR_640].x = Default_medals_label_coords[GR_640][0];
-		Medals_label_coords[GR_640].y = Default_medals_label_coords[GR_640][1];
-		Medals_label_coords[GR_640].w = Default_medals_label_coords[GR_640][2];
-	}
-	if (optional_string("+Label Position 1024:")) {
-		stuff_int(&Medals_label_coords[GR_1024].x);
-		stuff_int(&Medals_label_coords[GR_1024].y);
-		stuff_int(&Medals_label_coords[GR_1024].w);
-	} else {
-		Medals_label_coords[GR_1024].x = Default_medals_label_coords[GR_1024][0];
-		Medals_label_coords[GR_1024].y = Default_medals_label_coords[GR_1024][1];
-		Medals_label_coords[GR_1024].w = Default_medals_label_coords[GR_1024][2];
-	}
-
-	// parse in all the medal names
-	Num_medals = 0;
-	while ( required_string_either("#End", "$Name:") )
+	try
 	{
-		medal_stuff temp_medal;
-		medal_display_info temp_display;
+		read_file_text("medals.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-		required_string("$Name:");
-		stuff_string( temp_medal.name, F_NAME, NAME_LENGTH );
+		required_string("#Medals");
 
-		// is this rank?  if so, save it
-		if (!stricmp(temp_medal.name, "Rank"))
-			Rank_medal_index = Num_medals;
-
-		required_string("$Bitmap:");
-		stuff_string( temp_medal.bitmap, F_NAME, MAX_FILENAME_LEN );
-
-		if (optional_string("+Position 640:")) {
-			stuff_int(&temp_display.coords[GR_640].x);
-			stuff_int(&temp_display.coords[GR_640].y);
-		} else if (Num_medals < NUM_MEDALS_FS2) {
-			temp_display.coords[GR_640].x = Default_medal_coords[GR_640][Num_medals][0];
-			temp_display.coords[GR_640].y = Default_medal_coords[GR_640][Num_medals][1];
-		} else {
-			Warning(LOCATION, "No default GR_640 position for medal '%s'!", temp_medal.name);
-			temp_display.coords[GR_640].x = 0;
-			temp_display.coords[GR_640].y = 0;
+		// special background information
+		if (optional_string("+Background Bitmap:")) {
+			stuff_string(Medals_background_filename, F_NAME, NAME_LENGTH);
 		}
-		if (optional_string("+Position 1024:")) {
-			stuff_int(&temp_display.coords[GR_1024].x);
-			stuff_int(&temp_display.coords[GR_1024].y);
-		} else if (Num_medals < NUM_MEDALS_FS2) {
-			temp_display.coords[GR_1024].x = Default_medal_coords[GR_1024][Num_medals][0];
-			temp_display.coords[GR_1024].y = Default_medal_coords[GR_1024][Num_medals][1];
-		} else {
-			Warning(LOCATION, "No default GR_1024 position for medal '%s'!", temp_medal.name);
-			temp_display.coords[GR_1024].x = 0;
-			temp_display.coords[GR_1024].y = 0;
+		else {
+			strcpy_s(Medals_background_filename, Default_medals_background_filename);
 		}
 
-		if (optional_string("+Debriefing Bitmap:")) {
-			stuff_string( temp_medal.debrief_bitmap, F_NAME, MAX_FILENAME_LEN );
-		} else if (Num_medals < NUM_MEDALS_FS2) {
-			strcpy_s(temp_medal.debrief_bitmap, Default_debriefing_bitmaps[Num_medals]);
-		} else {
-			Warning(LOCATION, "No default debriefing bitmap for medal '%s'!", temp_medal.name);
-			strcpy_s(temp_medal.debrief_bitmap, "");
+		// special mask information
+		if (optional_string("+Mask Bitmap:")) {
+			stuff_string(Medals_mask_filename, F_NAME, NAME_LENGTH);
+		}
+		else {
+			strcpy_s(Medals_mask_filename, Default_medals_mask_filename);
 		}
 
-		required_string("$Num mods:");
-		stuff_int( &temp_medal.num_versions );
-
-		// this is dumb
-		temp_medal.version_starts_at_1 = (Num_medals == Rank_medal_index);
-		if (optional_string("+Version starts at 1:")) {
-			stuff_boolean( &temp_medal.version_starts_at_1 );
+		// special positioning for player callsign
+		if (optional_string("+Callsign Position 640:")) {
+			stuff_int(&Medals_callsign_coords[GR_640].x);
+			stuff_int(&Medals_callsign_coords[GR_640].y);
+		}
+		else {
+			Medals_callsign_coords[GR_640].x = Default_medals_callsign_coords[GR_640][0];
+			Medals_callsign_coords[GR_640].y = Default_medals_callsign_coords[GR_640][1];
+		}
+		if (optional_string("+Callsign Position 1024:")) {
+			stuff_int(&Medals_callsign_coords[GR_1024].x);
+			stuff_int(&Medals_callsign_coords[GR_1024].y);
+		}
+		else {
+			Medals_callsign_coords[GR_1024].x = Default_medals_callsign_coords[GR_1024][0];
+			Medals_callsign_coords[GR_1024].y = Default_medals_callsign_coords[GR_1024][1];
 		}
 
-		if (optional_string("+Available From Start:")) {
-			stuff_boolean( &temp_medal.available_from_start );
+		// special positioning for medal label
+		if (optional_string("+Label Position 640:")) {
+			stuff_int(&Medals_label_coords[GR_640].x);
+			stuff_int(&Medals_label_coords[GR_640].y);
+			stuff_int(&Medals_label_coords[GR_640].w);
+		}
+		else {
+			Medals_label_coords[GR_640].x = Default_medals_label_coords[GR_640][0];
+			Medals_label_coords[GR_640].y = Default_medals_label_coords[GR_640][1];
+			Medals_label_coords[GR_640].w = Default_medals_label_coords[GR_640][2];
+		}
+		if (optional_string("+Label Position 1024:")) {
+			stuff_int(&Medals_label_coords[GR_1024].x);
+			stuff_int(&Medals_label_coords[GR_1024].y);
+			stuff_int(&Medals_label_coords[GR_1024].w);
+		}
+		else {
+			Medals_label_coords[GR_1024].x = Default_medals_label_coords[GR_1024][0];
+			Medals_label_coords[GR_1024].y = Default_medals_label_coords[GR_1024][1];
+			Medals_label_coords[GR_1024].w = Default_medals_label_coords[GR_1024][2];
 		}
 
-		// some medals are based on kill counts.  When string +Num Kills: is present, we know that
-		// this medal is a badge and should be treated specially
-		if ( optional_string("+Num Kills:") ) {
-			char buf[MULTITEXT_LENGTH];
-			int persona;
-			stuff_int( &temp_medal.kills_needed );
+		// parse in all the medal names
+		Num_medals = 0;
+		while (required_string_either("#End", "$Name:"))
+		{
+			medal_stuff temp_medal;
+			medal_display_info temp_display;
 
-			if (optional_string("$Wavefile 1:"))
-				stuff_string(temp_medal.voice_base, F_NAME, MAX_FILENAME_LEN);
+			required_string("$Name:");
+			stuff_string(temp_medal.name, F_NAME, NAME_LENGTH);
 
-			if (optional_string("$Wavefile 2:"))
-				stuff_string(temp_medal.voice_base, F_NAME, MAX_FILENAME_LEN);
+			// is this rank?  if so, save it
+			if (!stricmp(temp_medal.name, "Rank"))
+				Rank_medal_index = Num_medals;
 
-			if (optional_string("$Wavefile Base:"))
-				stuff_string(temp_medal.voice_base, F_NAME, MAX_FILENAME_LEN);
+			required_string("$Bitmap:");
+			stuff_string(temp_medal.bitmap, F_NAME, MAX_FILENAME_LEN);
 
-			while (check_for_string("$Promotion Text:")) {
-				required_string("$Promotion Text:");
-				stuff_string(buf, F_MULTITEXT, sizeof(buf));
-				persona = -1;
-				if (optional_string("+Persona:")) {
-					stuff_int(&persona);
-					if (persona < 0) {
-						Warning(LOCATION, "Debriefing text for %s is assigned to an invalid persona: %i (must be 0 or greater).\n", temp_medal.name, persona);
-						continue;
+			if (optional_string("+Position 640:")) {
+				stuff_int(&temp_display.coords[GR_640].x);
+				stuff_int(&temp_display.coords[GR_640].y);
+			}
+			else if (Num_medals < NUM_MEDALS_FS2) {
+				temp_display.coords[GR_640].x = Default_medal_coords[GR_640][Num_medals][0];
+				temp_display.coords[GR_640].y = Default_medal_coords[GR_640][Num_medals][1];
+			}
+			else {
+				Warning(LOCATION, "No default GR_640 position for medal '%s'!", temp_medal.name);
+				temp_display.coords[GR_640].x = 0;
+				temp_display.coords[GR_640].y = 0;
+			}
+			if (optional_string("+Position 1024:")) {
+				stuff_int(&temp_display.coords[GR_1024].x);
+				stuff_int(&temp_display.coords[GR_1024].y);
+			}
+			else if (Num_medals < NUM_MEDALS_FS2) {
+				temp_display.coords[GR_1024].x = Default_medal_coords[GR_1024][Num_medals][0];
+				temp_display.coords[GR_1024].y = Default_medal_coords[GR_1024][Num_medals][1];
+			}
+			else {
+				Warning(LOCATION, "No default GR_1024 position for medal '%s'!", temp_medal.name);
+				temp_display.coords[GR_1024].x = 0;
+				temp_display.coords[GR_1024].y = 0;
+			}
+
+			if (optional_string("+Debriefing Bitmap:")) {
+				stuff_string(temp_medal.debrief_bitmap, F_NAME, MAX_FILENAME_LEN);
+			}
+			else if (Num_medals < NUM_MEDALS_FS2) {
+				strcpy_s(temp_medal.debrief_bitmap, Default_debriefing_bitmaps[Num_medals]);
+			}
+			else {
+				Warning(LOCATION, "No default debriefing bitmap for medal '%s'!", temp_medal.name);
+				strcpy_s(temp_medal.debrief_bitmap, "");
+			}
+
+			required_string("$Num mods:");
+			stuff_int(&temp_medal.num_versions);
+
+			// this is dumb
+			temp_medal.version_starts_at_1 = (Num_medals == Rank_medal_index);
+			if (optional_string("+Version starts at 1:")) {
+				stuff_boolean(&temp_medal.version_starts_at_1);
+			}
+
+			if (optional_string("+Available From Start:")) {
+				stuff_boolean(&temp_medal.available_from_start);
+			}
+
+			// some medals are based on kill counts.  When string +Num Kills: is present, we know that
+			// this medal is a badge and should be treated specially
+			if (optional_string("+Num Kills:")) {
+				char buf[MULTITEXT_LENGTH];
+				int persona;
+				stuff_int(&temp_medal.kills_needed);
+
+				if (optional_string("$Wavefile 1:"))
+					stuff_string(temp_medal.voice_base, F_NAME, MAX_FILENAME_LEN);
+
+				if (optional_string("$Wavefile 2:"))
+					stuff_string(temp_medal.voice_base, F_NAME, MAX_FILENAME_LEN);
+
+				if (optional_string("$Wavefile Base:"))
+					stuff_string(temp_medal.voice_base, F_NAME, MAX_FILENAME_LEN);
+
+				while (check_for_string("$Promotion Text:")) {
+					required_string("$Promotion Text:");
+					stuff_string(buf, F_MULTITEXT, sizeof(buf));
+					persona = -1;
+					if (optional_string("+Persona:")) {
+						stuff_int(&persona);
+						if (persona < 0) {
+							Warning(LOCATION, "Debriefing text for %s is assigned to an invalid persona: %i (must be 0 or greater).\n", temp_medal.name, persona);
+							continue;
+						}
 					}
+					temp_medal.promotion_text[persona] = vm_strdup(buf);
+				}
+				if (temp_medal.promotion_text.find(-1) == temp_medal.promotion_text.end()) {
+					Warning(LOCATION, "%s medal is missing default debriefing text.\n", temp_medal.name);
+					temp_medal.promotion_text[-1] = "";
 				}
-				temp_medal.promotion_text[persona] = vm_strdup(buf);
-			}
-			if (temp_medal.promotion_text.find(-1) == temp_medal.promotion_text.end()) {
-				Warning(LOCATION, "%s medal is missing default debriefing text.\n", temp_medal.name);
-				temp_medal.promotion_text[-1] = "";
 			}
+
+			Medals.push_back(temp_medal);
+			Medal_display_info.push_back(temp_display);
+			Num_medals++;
 		}
 
-		Medals.push_back(temp_medal);
-		Medal_display_info.push_back(temp_display);
-		Num_medals++;
+		required_string("#End");
+
+		// be sure that we know where the rank is
+		if (Rank_medal_index < 0)
+		{
+			Warning(LOCATION, "Could not find the 'Rank' medal!");
+			Rank_medal_index = 0;
+		}
+
+		// be sure that the badges kill numbers show up in order
+		//WMC - I don't think this is needed anymore due to my changes to post-mission functions
+		//but I'm keeping it here to be sure.
+		int prev_badge_kills = 0;
+		for (i = 0; i < Num_medals; i++)
+		{
+			if (Medals[i].kills_needed < prev_badge_kills && Medals[i].kills_needed != 0)
+				Error(LOCATION, "Badges must appear sorted by lowest kill # first in medals.tbl\nFind Allender for most information.");
+
+			if (Medals[i].kills_needed > 0)
+				prev_badge_kills = Medals[i].kills_needed;
+		}
 	}
-
-	required_string("#End");
-
-	// be sure that we know where the rank is
-	if (Rank_medal_index < 0)
+	catch (const parse::ParseException& e)
 	{
-		Warning(LOCATION, "Could not find the 'Rank' medal!");
-		Rank_medal_index = 0;
-	}
-
-	// be sure that the badges kill numbers show up in order
-	//WMC - I don't think this is needed anymore due to my changes to post-mission functions
-	//but I'm keeping it here to be sure.
-	int prev_badge_kills = 0;
-	for (i = 0; i < Num_medals; i++ )
-	{
-		if ( Medals[i].kills_needed < prev_badge_kills && Medals[i].kills_needed != 0)
-			Error(LOCATION, "Badges must appear sorted by lowest kill # first in medals.tbl\nFind Allender for most information.");
-
-		if (Medals[i].kills_needed > 0)
-			prev_badge_kills = Medals[i].kills_needed;
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "medals.tbl", e.what()));
+		return;
 	}
 }
 

code/stats/medals.h

@@ -59,7 +59,7 @@ extern void parse_medal_tbl();
 #define MM_POPUP				1		// called from within some other tight loop (don't use gameseq_ functions)
 
 // main medals screen
-void medal_main_init(player *pl, int mode = MM_NORMAL);
+void medal_main_init(player *pl,int mode = MM_NORMAL);
 
 // return 0 if the screen should close (used for MM_POPUP mode)
 int medal_main_do();

code/stats/scoring.cpp

@@ -59,61 +59,64 @@ void parse_rank_tbl()
 {
 	atexit(scoreing_close);
 	char buf[MULTITEXT_LENGTH];
-	int rval, idx, persona;
+	int idx, persona;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", "rank.tbl", rval));
-		return;
-	} 
+	try
+	{
+		read_file_text("rank.tbl", CF_TYPE_TABLES);
+		reset_parse();
 
-	read_file_text("rank.tbl", CF_TYPE_TABLES);
-	reset_parse();
-
-	// parse in all the rank names
-	idx = 0;
-	skip_to_string("[RANK NAMES]");
-	ignore_white_space();
-	while ( required_string_either("#End", "$Name:") ) {
-		Assert ( idx < NUM_RANKS );
-		required_string("$Name:");
-		stuff_string( Ranks[idx].name, F_NAME, NAME_LENGTH );
-		required_string("$Points:");
-		stuff_int( &Ranks[idx].points );
-		required_string("$Bitmap:");
-		stuff_string( Ranks[idx].bitmap, F_NAME, MAX_FILENAME_LEN );
-		required_string("$Promotion Voice Base:");
-		stuff_string( Ranks[idx].promotion_voice_base, F_NAME, MAX_FILENAME_LEN );
-		while (check_for_string("$Promotion Text:")) {
-			required_string("$Promotion Text:");
-			stuff_string(buf, F_MULTITEXT, sizeof(buf));
-			drop_white_space(buf);
-			compact_multitext_string(buf);
-			persona = -1;
-			if (optional_string("+Persona:")) {
-				stuff_int(&persona);
-				if (persona < 0) {
-					Warning(LOCATION, "Debriefing text for %s rank is assigned to an invalid persona: %i (must be 0 or greater).\n", Ranks[idx].name, persona);
-					continue;
+		// parse in all the rank names
+		idx = 0;
+		skip_to_string("[RANK NAMES]");
+		ignore_white_space();
+		while (required_string_either("#End", "$Name:")) {
+			Assert(idx < NUM_RANKS);
+			required_string("$Name:");
+			stuff_string(Ranks[idx].name, F_NAME, NAME_LENGTH);
+			required_string("$Points:");
+			stuff_int(&Ranks[idx].points);
+			required_string("$Bitmap:");
+			stuff_string(Ranks[idx].bitmap, F_NAME, MAX_FILENAME_LEN);
+			required_string("$Promotion Voice Base:");
+			stuff_string(Ranks[idx].promotion_voice_base, F_NAME, MAX_FILENAME_LEN);
+			while (check_for_string("$Promotion Text:")) {
+				required_string("$Promotion Text:");
+				stuff_string(buf, F_MULTITEXT, sizeof(buf));
+				drop_white_space(buf);
+				compact_multitext_string(buf);
+				persona = -1;
+				if (optional_string("+Persona:")) {
+					stuff_int(&persona);
+					if (persona < 0) {
+						Warning(LOCATION, "Debriefing text for %s rank is assigned to an invalid persona: %i (must be 0 or greater).\n", Ranks[idx].name, persona);
+						continue;
+					}
 				}
+				Ranks[idx].promotion_text[persona] = vm_strdup(buf);
 			}
-			Ranks[idx].promotion_text[persona] = vm_strdup(buf);
+			if (Ranks[idx].promotion_text.find(-1) == Ranks[idx].promotion_text.end()) {
+				Warning(LOCATION, "%s rank is missing default debriefing text.\n", Ranks[idx].name);
+				Ranks[idx].promotion_text[-1] = "";
+			}
+			idx++;
 		}
-		if (Ranks[idx].promotion_text.find(-1) == Ranks[idx].promotion_text.end()) {
-			Warning(LOCATION, "%s rank is missing default debriefing text.\n", Ranks[idx].name);
-			Ranks[idx].promotion_text[-1] = "";
-		}
-		idx++;
-	}
 
-	required_string("#End");
+		required_string("#End");
 
-	// be sure that all rank points are in order
+		// be sure that all rank points are in order
 #ifndef NDEBUG
-	for ( idx = 0; idx < NUM_RANKS-1; idx++ ) {
-		if ( Ranks[idx].points >= Ranks[idx+1].points )
-			Int3();
-	}
+		for (idx = 0; idx < NUM_RANKS - 1; idx++) {
+			if (Ranks[idx].points >= Ranks[idx + 1].points)
+				Int3();
+		}
 #endif
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", "rank.tbl", e.what()));
+		return;
+	}
 }
 
 // initialize a nice blank scoring element

code/weapon/muzzleflash.cpp

@@ -87,68 +87,70 @@ SCP_vector<mflash_info> Mflash_info;
 
 void parse_mflash_tbl(const char *filename)
 {
-	int rval;
 	uint i;
 
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+	try
+	{
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
+
+		// header
+		required_string("#Muzzle flash types");
+
+		while (optional_string("$Mflash:")) {
+			mflash_info mflash;
+			bool override_mflash = false;
+
+			required_string("+name:");
+			stuff_string(mflash.name, F_NAME, MAX_FILENAME_LEN);
+
+			if (optional_string("+override"))
+				override_mflash = true;
+
+			// read in all blobs
+			while (optional_string("+blob_name:")) {
+				mflash_blob_info mblob;
+
+				stuff_string(mblob.name, F_NAME, MAX_FILENAME_LEN);
+
+				required_string("+blob_offset:");
+				stuff_float(&mblob.offset);
+
+				required_string("+blob_radius:");
+				stuff_float(&mblob.radius);
+
+				mflash.blobs.push_back(mblob);
+			}
+
+			for (i = 0; i < Mflash_info.size(); i++) {
+				if (!stricmp(mflash.name, Mflash_info[i].name)) {
+					if (override_mflash) {
+						Mflash_info[i] = mflash;
+					}
+					break;
+				}
+			}
+
+			// no matching name exists so add as new
+			if (i == Mflash_info.size()) {
+				Mflash_info.push_back(mflash);
+			}
+			// a mflash of the same name exists, don't add it again
+			else {
+				if (!override_mflash) {
+					Warning(LOCATION, "Muzzle flash \"%s\" already exists!  Using existing entry instead.", mflash.name);
+				}
+			}
+		}
+
+		// close
+		required_string("#end");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();		
-
-	// header
-	required_string("#Muzzle flash types");
-
-	while ( optional_string("$Mflash:") ) {
-		mflash_info mflash;
-		bool override_mflash = false;
-
-		required_string("+name:");
-		stuff_string(mflash.name, F_NAME, MAX_FILENAME_LEN);
-
-		if (optional_string("+override"))
-			override_mflash = true;
-
-		// read in all blobs
-		while ( optional_string("+blob_name:") ) {
-			mflash_blob_info mblob;
-
-			stuff_string(mblob.name, F_NAME, MAX_FILENAME_LEN);
-
-			required_string("+blob_offset:");
-			stuff_float(&mblob.offset);
-
-			required_string("+blob_radius:");
-			stuff_float(&mblob.radius);
-
-			mflash.blobs.push_back(mblob);
-		}
-
-		for (i = 0; i < Mflash_info.size(); i++) {
-			if ( !stricmp(mflash.name, Mflash_info[i].name) ) {
-				if (override_mflash) {
-					Mflash_info[i] = mflash;
-				}
-				break;
-			}
-		}
-
-		// no matching name exists so add as new
-		if (i == Mflash_info.size()) {
-			Mflash_info.push_back(mflash);
-		}
-		// a mflash of the same name exists, don't add it again
-		else {
-			if (!override_mflash) {
-				Warning(LOCATION, "Muzzle flash \"%s\" already exists!  Using existing entry instead.", mflash.name);
-			}
-		}
-	}
-
-	// close
-	required_string("#end");
 }
 
 // initialize muzzle flash stuff for the whole game

code/weapon/shockwave.cpp

@@ -729,7 +729,7 @@ void shockwave_page_in()
 		} else if (Shockwave_info[i].model_id >= 0) {
 			// for a model we have to run model_load() on it again to make sure
 			// that it's ref_count is sane for this mission
-			int idx = model_load( Shockwave_info[i].filename, 0, NULL );
+			int idx __attribute__((__unused__)) = model_load( Shockwave_info[i].filename, 0, NULL );
 			Assert( idx == Shockwave_info[i].model_id );
 
 			model_page_in_textures( Shockwave_info[i].model_id );

code/weapon/weapon.h

@@ -122,7 +122,7 @@ extern int Num_weapon_subtypes;
 #define WIF3_TURRET_INTERCEPTABLE		(1 << 5)	// These two flags mark a weapon as being interceptable by the AI
 #define WIF3_FIGHTER_INTERCEPTABLE		(1 << 6)	// (like WIF_BOMB), without forcing it to be tagetable -MageKing17
 #define WIF3_AOE_ELECTRONICS			(1 << 7)	// Apply electronics effect across the weapon's entire area of effect instead of just on the impacted ship -MageKing17
-
+#define WIF3_APPLY_RECOIL				(1 << 8)	// Apply recoil using weapon and ship info
 
 #define	WIF_HOMING					(WIF_HOMING_HEAT | WIF_HOMING_ASPECT | WIF_HOMING_JAVELIN)
 #define WIF_LOCKED_HOMING           (WIF_HOMING_ASPECT | WIF_HOMING_JAVELIN)
@@ -437,6 +437,9 @@ typedef struct weapon_info {
 	float emp_intensity;					// intensity of the EMP effect
 	float emp_time;						// time of the EMP effect
 
+	// Recoil effect
+	float recoil_modifier;
+
 	// Energy suck effect
 	float weapon_reduce;					// how much energy removed from weapons systems
 	float afterburner_reduce;			// how much energy removed from weapons systems

code/weapon/weapons.cpp

@@ -320,50 +320,52 @@ int weapon_explosions::GetAnim(int weapon_expl_index, vec3d *pos, float size)
 
 void parse_weapon_expl_tbl(const char *filename)
 {
-	int rval;
 	uint i;
 	lod_checker lod_check;
-
-	if ((rval = setjmp(parse_abort)) != 0) {
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
-		return;
-	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();		
-
-	required_string("#Start");
-	while (required_string_either("#End","$Name:"))
+	
+	try
 	{
-		memset( &lod_check, 0, sizeof(lod_checker) );
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
 
-		// base filename
-		required_string("$Name:");
-		stuff_string(lod_check.filename, F_NAME, MAX_FILENAME_LEN);
-
-		//Do we have an LOD num
-		if (optional_string("$LOD:"))
+		required_string("#Start");
+		while (required_string_either("#End", "$Name:"))
 		{
-			stuff_int(&lod_check.num_lods);
-		}
+			memset(&lod_check, 0, sizeof(lod_checker));
 
-		// only bother with this if we have 1 or more lods and less than max lods,
-		// otherwise the stardard level loading will take care of the different effects
-		if ( (lod_check.num_lods > 0) || (lod_check.num_lods < MAX_WEAPON_EXPL_LOD) ) {
-			// name check, update lod count if it already exists
-			for (i = 0; i < LOD_checker.size(); i++) {
-				if ( !stricmp(LOD_checker[i].filename, lod_check.filename) ) {
-					LOD_checker[i].num_lods = lod_check.num_lods;
+			// base filename
+			required_string("$Name:");
+			stuff_string(lod_check.filename, F_NAME, MAX_FILENAME_LEN);
+
+			//Do we have an LOD num
+			if (optional_string("$LOD:"))
+			{
+				stuff_int(&lod_check.num_lods);
+			}
+
+			// only bother with this if we have 1 or more lods and less than max lods,
+			// otherwise the stardard level loading will take care of the different effects
+			if ((lod_check.num_lods > 0) || (lod_check.num_lods < MAX_WEAPON_EXPL_LOD)) {
+				// name check, update lod count if it already exists
+				for (i = 0; i < LOD_checker.size(); i++) {
+					if (!stricmp(LOD_checker[i].filename, lod_check.filename)) {
+						LOD_checker[i].num_lods = lod_check.num_lods;
+					}
+				}
+
+				// old entry not found, add new entry
+				if (i == LOD_checker.size()) {
+					LOD_checker.push_back(lod_check);
 				}
 			}
-
-			// old entry not found, add new entry
-			if ( i == LOD_checker.size() ) {
-				LOD_checker.push_back(lod_check);
-			}
 		}
+		required_string("#End");
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
+		return;
 	}
-	required_string("#End");
 }
 
 /**
@@ -663,6 +665,8 @@ void parse_wi_flags(weapon_info *weaponp, int wi_flags, int wi_flags2, int wi_fl
 			weaponp->wi_flags3 |= WIF3_TURRET_INTERCEPTABLE;
 		else if (!stricmp(NOX("fighter interceptable"), weapon_strings[i]))
 			weaponp->wi_flags3 |= WIF3_FIGHTER_INTERCEPTABLE;
+		else if (!stricmp(NOX("apply recoil"), weapon_strings[i]))
+			weaponp->wi_flags3 |= WIF3_APPLY_RECOIL;
 		else
 			Warning(LOCATION, "Bogus string in weapon flags: %s\n", weapon_strings[i]);
 	}
@@ -958,6 +962,7 @@ void init_weapon_entry(int weap_info_index)
 
 	wip->emp_intensity = EMP_DEFAULT_INTENSITY;
 	wip->emp_time = EMP_DEFAULT_TIME;	// Goober5000: <-- Look!  I fixed a Volition bug!  Gimme $5, Dave!
+	wip->recoil_modifier = 1.0f;
 	wip->weapon_reduce = ESUCK_DEFAULT_WEAPON_REDUCE;
 	wip->afterburner_reduce = ESUCK_DEFAULT_AFTERBURNER_REDUCE;
 
@@ -1065,7 +1070,6 @@ void init_weapon_entry(int weap_info_index)
 
 	wip->burst_delay = 1.0f; // 1 second, just incase its not defined
 	wip->burst_shots = 0;
-
 	wip->burst_flags = 0;
 
 	generic_anim_init( &wip->thruster_flame );
@@ -1974,6 +1978,15 @@ int parse_weapon(int subtype, bool replace)
 		stuff_float(&wip->emp_time);
 	}
 
+	// This is an optional modifier for a weapon that uses the "apply recoil" flag. recoil_force in ship.cpp line 10445 is multiplied by this if defined.
+	if (optional_string("$Recoil Modifier:")){
+		if (!(wip->wi_flags3 & WIF3_APPLY_RECOIL)){
+			Warning(LOCATION, "$Recoil Modifier specified for weapon %s but this weapon does not have the \"apply recoil\" weapon flag set. Automatically setting the flag", wip->name);
+			wip->wi_flags3 |= WIF3_APPLY_RECOIL;
+		}
+		stuff_float(&wip->recoil_modifier);
+	}
+
 	// Energy suck optional stuff (if WIF_ENERGY_SUCK is not set, none of this matters anyway)
 	if( optional_string("$Leech Weapon:") ){
 		stuff_float(&wip->weapon_reduce);
@@ -2803,83 +2816,83 @@ static char Default_cmeasure_name[NAME_LENGTH] = "";
 
 void parse_weaponstbl(const char *filename)
 {
-	int rval;
-
-	if ((rval = setjmp(parse_abort)) != 0)
+	try
 	{
-		mprintf(("TABLES: Unable to parse '%s'!  Error code = %i.\n", filename, rval));
+		read_file_text(filename, CF_TYPE_TABLES);
+		reset_parse();
+
+		if (optional_string("#Primary Weapons"))
+		{
+			while (required_string_either("#End", "$Name:")) {
+				// AL 28-3-98: If parse_weapon() fails, try next .tbl weapon
+				if (parse_weapon(WP_LASER, Parsing_modular_table) < 0) {
+					continue;
+				}
+			}
+			required_string("#End");
+		}
+
+		if (optional_string("#Secondary Weapons"))
+		{
+			while (required_string_either("#End", "$Name:")) {
+				// AL 28-3-98: If parse_weapon() fails, try next .tbl weapon
+				if (parse_weapon(WP_MISSILE, Parsing_modular_table) < 0) {
+					continue;
+				}
+			}
+			required_string("#End");
+		}
+
+		if (optional_string("#Beam Weapons"))
+		{
+			while (required_string_either("#End", "$Name:")) {
+				// AL 28-3-98: If parse_weapon() fails, try next .tbl weapon
+				if (parse_weapon(WP_BEAM, Parsing_modular_table) < 0) {
+					continue;
+				}
+			}
+			required_string("#End");
+		}
+
+		if (optional_string("#Countermeasures"))
+		{
+			while (required_string_either("#End", "$Name:"))
+			{
+				int idx = parse_weapon(WP_MISSILE, Parsing_modular_table);
+
+				if (idx < 0) {
+					continue;
+				}
+
+				//Make sure cmeasure flag is set
+				Weapon_info[idx].wi_flags |= WIF_CMEASURE;
+
+				//Set cmeasure index
+				if (!strlen(Default_cmeasure_name)) {
+					//We can't be sure that index will be the same after sorting, so save the name
+					strcpy_s(Default_cmeasure_name, Weapon_info[idx].name);
+				}
+			}
+
+			required_string("#End");
+		}
+
+		// Read in a list of weapon_info indicies that are an ordering of the player weapon precedence.
+		// This list is used to select an alternate weapon when a particular weapon is not available
+		// during weapon selection.
+		if ((!Parsing_modular_table && required_string("$Player Weapon Precedence:")) || optional_string("$Player Weapon Precedence:"))
+		{
+			Num_player_weapon_precedence = stuff_int_list(Player_weapon_precedence, MAX_WEAPON_TYPES, WEAPON_LIST_TYPE);
+		}
+
+		// add tbl/tbm to multiplayer validation list
+		fs2netd_add_table_validation(filename);
+	}
+	catch (const parse::ParseException& e)
+	{
+		mprintf(("TABLES: Unable to parse '%s'!  Error message = %s.\n", filename, e.what()));
 		return;
 	}
-
-	read_file_text(filename, CF_TYPE_TABLES);
-	reset_parse();
-
-	if(optional_string("#Primary Weapons"))
-	{
-		while (required_string_either("#End", "$Name:")) {
-			// AL 28-3-98: If parse_weapon() fails, try next .tbl weapon
-			if ( parse_weapon(WP_LASER, Parsing_modular_table) < 0 ) {
-				continue;
-			}
-		}
-		required_string("#End");
-	}
-
-	if(optional_string("#Secondary Weapons"))
-	{
-		while (required_string_either("#End", "$Name:")) {
-			// AL 28-3-98: If parse_weapon() fails, try next .tbl weapon
-			if ( parse_weapon(WP_MISSILE, Parsing_modular_table) < 0) {
-				continue;
-			}
-		}
-		required_string("#End");
-	}
-
-	if(optional_string("#Beam Weapons"))
-	{
-		while (required_string_either("#End", "$Name:")) {
-			// AL 28-3-98: If parse_weapon() fails, try next .tbl weapon
-			if ( parse_weapon(WP_BEAM, Parsing_modular_table) < 0) {
-				continue;
-			}
-		}
-		required_string("#End");
-	}
-
-	if(optional_string("#Countermeasures"))
-	{
-		while (required_string_either("#End", "$Name:"))
-		{
-			int idx = parse_weapon(WP_MISSILE, Parsing_modular_table);
-
-			if(idx < 0) {
-				continue;
-			}
-
-			//Make sure cmeasure flag is set
-			Weapon_info[idx].wi_flags |= WIF_CMEASURE;
-
-			//Set cmeasure index
-			if(!strlen(Default_cmeasure_name)) {
-				//We can't be sure that index will be the same after sorting, so save the name
-				strcpy_s(Default_cmeasure_name, Weapon_info[idx].name);
-			}
-		}
-
-		required_string("#End");
-	}
-
-	// Read in a list of weapon_info indicies that are an ordering of the player weapon precedence.
-	// This list is used to select an alternate weapon when a particular weapon is not available
-	// during weapon selection.
-	if ( (!Parsing_modular_table && required_string("$Player Weapon Precedence:")) || optional_string("$Player Weapon Precedence:") )
-	{
-		Num_player_weapon_precedence = stuff_int_list(Player_weapon_precedence, MAX_WEAPON_TYPES, WEAPON_LIST_TYPE);
-	}
-
-	// add tbl/tbm to multiplayer validation list
-	fs2netd_add_table_validation(filename);
 }
 
 //uses a simple bucket sort to sort weapons, order of importance is:
@@ -4832,7 +4845,14 @@ void weapon_process_post(object * obj, float frame_time)
 			//create the warphole
 			vm_vec_add2(&warpout,&obj->pos);
 			wp->lssm_warp_idx=fireball_create(&warpout, FIREBALL_WARP, FIREBALL_WARP_EFFECT, -1,obj->radius*1.5f,1,&vmd_zero_vector,wp->lssm_warp_time,0,&obj->orient);
-			wp->lssm_stage=2;
+
+			if (wp->lssm_warp_idx < 0) {
+				mprintf(("LSSM: Failed to create warp effect! Please report if this happens frequently.\n"));
+				// Abort warping
+				wp->lssm_stage = 0;
+			} else {
+				wp->lssm_stage = 2;
+			}
 		}
 
 		//its just entered subspace subspace. don't collide or render
@@ -6065,9 +6085,9 @@ void weapon_hit( object * weapon_obj, object * other_obj, vec3d * hitpos, int qu
 	int			weapon_type = Weapons[num].weapon_info_index;
 	int			expl_ani_handle;
 	weapon_info	*wip;
-	weapon      *wp;
+	weapon *wp;
 	bool		hit_target = false;
-    
+
 	object      *other_objp;
 	ship_obj	*so;
 	ship		*shipp;
@@ -6167,7 +6187,7 @@ void weapon_hit( object * weapon_obj, object * other_obj, vec3d * hitpos, int qu
 			}
 		}
 	}
-    
+
 	// For all objects that had this weapon as a target, wipe it out, forcing find of a new enemy
 	for ( so = GET_FIRST(&Ship_obj_list); so != END_OF_LIST(&Ship_obj_list); so = GET_NEXT(so) ) {
 		other_objp = &Objects[so->objnum];

code/windows_stub/config.h

@@ -64,8 +64,8 @@
 
 
 // don't verbose stub funtions unless we're debugging
-#define STUB_FUNCTION nprintf(( "Warning", "STUB: %s in "__FILE__" at line %d, thread %d\n", __FUNCTION__, __LINE__, getpid() ))
-#define DEBUGME(d1) nprintf(( "Warning", "DEBUGME: %s in "__FILE__" at line %d, msg \"%s\", thread %d\n", __FUNCTION__, __LINE__, d1, getpid() ))
+#define STUB_FUNCTION nprintf(( "Warning", "STUB: %s in " __FILE__ " at line %d, thread %d\n", __FUNCTION__, __LINE__, getpid() ))
+#define DEBUGME(d1) nprintf(( "Warning", "DEBUGME: %s in " __FILE__ " at line %d, msg \"%s\", thread %d\n", __FUNCTION__, __LINE__, d1, getpid() ))
 
 
 #define _cdecl

code/wxfred2/wxfred2.cpp

@@ -15,7 +15,7 @@
 #include <wx/image.h>
 #include <wx/string.h>
 //#include <wx/xrc/xmlres.h>
-#include <wx/wx.h>
+	#include <wx/wx.h>
 
 IMPLEMENT_APP(wxFRED2)
 
@@ -32,4 +32,4 @@ bool wxFRED2::OnInit()
 	frame->Show(TRUE);
 
 	return true;
-}
+}

code/wxfred2/wxfred2.h

@@ -4,7 +4,7 @@
  * Created by Ian "Goober5000" Warfield for the FreeSpace2 Source Code Project.
  * You may not sell or otherwise commercially exploit the source or things you
  * create based on the source.
- */
+ */ 
 
 #include <wx/wx.h>
 
@@ -20,4 +20,4 @@ class wxFRED2 : public wxApp
 
 DECLARE_APP(wxFRED2)
 
-#endif
+#endif

configure.ac

@@ -39,6 +39,8 @@ AC_SUBST(LDFLAGS)
 
 PKG_PROG_PKG_CONFIG()
 
+dnl lets see if we support c++11
+AX_CXX_COMPILE_STDCXX_11([noext], [optional])
 
 dnl The configuration options
 dnl -------------------------
@@ -151,7 +153,7 @@ case "$target" in
 		CPPFLAGS="$CPPFLAGS -I/opt/csw/include"
 		;;
 	*freebsd* | *openbsd*)
-		# FreeBSD 9.1
+		# FreeBSD 10.1
 		echo "Using Unix defines (for $host_os $host_cpu)"
 		echo "************************************************************"
 		echo "************************ NOTE ******************************"
@@ -163,7 +165,7 @@ case "$target" in
 		fs2_os_bsd="yes"
 		if test "$host_cpu" = "amd64"
 		then
-			D_CFLAGS="$D_CFLAGS -m64 -march=athlon64 -ansi"
+			D_CFLAGS="$D_CFLAGS -m64 -march=athlon64"
 		fi
 		D_CFLAGS="$D_CFLAGS -DLUA_USE_LINUX"
 		LDFLAGS="$LDFLAGS -L/usr/local/lib"

m4/ax_cxx_compile_stdcxx_11.m4

@@ -0,0 +1,133 @@
+# ============================================================================
+#  http://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx_11.html
+# ============================================================================
+#
+# SYNOPSIS
+#
+#   AX_CXX_COMPILE_STDCXX_11([ext|noext],[mandatory|optional])
+#
+# DESCRIPTION
+#
+#   Check for baseline language coverage in the compiler for the C++11
+#   standard; if necessary, add switches to CXXFLAGS to enable support.
+#
+#   The first argument, if specified, indicates whether you insist on an
+#   extended mode (e.g. -std=gnu++11) or a strict conformance mode (e.g.
+#   -std=c++11).  If neither is specified, you get whatever works, with
+#   preference for an extended mode.
+#
+#   The second argument, if specified 'mandatory' or if left unspecified,
+#   indicates that baseline C++11 support is required and that the macro
+#   should error out if no mode with that support is found.  If specified
+#   'optional', then configuration proceeds regardless, after defining
+#   HAVE_CXX11 if and only if a supporting mode is found.
+#
+# LICENSE
+#
+#   Copyright (c) 2008 Benjamin Kosnik <[email protected]>
+#   Copyright (c) 2012 Zack Weinberg <[email protected]>
+#   Copyright (c) 2013 Roy Stogner <[email protected]>
+#
+#   Copying and distribution of this file, with or without modification, are
+#   permitted in any medium without royalty provided the copyright notice
+#   and this notice are preserved. This file is offered as-is, without any
+#   warranty.
+
+#serial 3
+
+m4_define([_AX_CXX_COMPILE_STDCXX_11_testbody], [
+  template <typename T>
+    struct check
+    {
+      static_assert(sizeof(int) <= sizeof(T), "not big enough");
+    };
+
+    typedef check<check<bool>> right_angle_brackets;
+
+    int a;
+    decltype(a) b;
+
+    typedef check<int> check_type;
+    check_type c;
+    check_type&& cr = static_cast<check_type&&>(c);
+
+    auto d = a;
+])
+
+AC_DEFUN([AX_CXX_COMPILE_STDCXX_11], [dnl
+  m4_if([$1], [], [],
+        [$1], [ext], [],
+        [$1], [noext], [],
+        [m4_fatal([invalid argument `$1' to AX_CXX_COMPILE_STDCXX_11])])dnl
+  m4_if([$2], [], [ax_cxx_compile_cxx11_required=true],
+        [$2], [mandatory], [ax_cxx_compile_cxx11_required=true],
+        [$2], [optional], [ax_cxx_compile_cxx11_required=false],
+        [m4_fatal([invalid second argument `$2' to AX_CXX_COMPILE_STDCXX_11])])dnl
+  AC_LANG_PUSH([C++])dnl
+  ac_success=no
+  AC_CACHE_CHECK(whether $CXX supports C++11 features by default,
+  ax_cv_cxx_compile_cxx11,
+  [AC_COMPILE_IFELSE([AC_LANG_SOURCE([_AX_CXX_COMPILE_STDCXX_11_testbody])],
+    [ax_cv_cxx_compile_cxx11=yes],
+    [ax_cv_cxx_compile_cxx11=no])])
+  if test x$ax_cv_cxx_compile_cxx11 = xyes; then
+    ac_success=yes
+  fi
+
+  m4_if([$1], [noext], [], [dnl
+  if test x$ac_success = xno; then
+    for switch in -std=gnu++11 -std=gnu++0x; do
+      cachevar=AS_TR_SH([ax_cv_cxx_compile_cxx11_$switch])
+      AC_CACHE_CHECK(whether $CXX supports C++11 features with $switch,
+                     $cachevar,
+        [ac_save_CXXFLAGS="$CXXFLAGS"
+         CXXFLAGS="$CXXFLAGS $switch"
+         AC_COMPILE_IFELSE([AC_LANG_SOURCE([_AX_CXX_COMPILE_STDCXX_11_testbody])],
+          [eval $cachevar=yes],
+          [eval $cachevar=no])
+         CXXFLAGS="$ac_save_CXXFLAGS"])
+      if eval test x\$$cachevar = xyes; then
+        CXXFLAGS="$CXXFLAGS $switch"
+        ac_success=yes
+        break
+      fi
+    done
+  fi])
+
+  m4_if([$1], [ext], [], [dnl
+  if test x$ac_success = xno; then
+    for switch in -std=c++11 -std=c++0x; do
+      cachevar=AS_TR_SH([ax_cv_cxx_compile_cxx11_$switch])
+      AC_CACHE_CHECK(whether $CXX supports C++11 features with $switch,
+                     $cachevar,
+        [ac_save_CXXFLAGS="$CXXFLAGS"
+         CXXFLAGS="$CXXFLAGS $switch"
+         AC_COMPILE_IFELSE([AC_LANG_SOURCE([_AX_CXX_COMPILE_STDCXX_11_testbody])],
+          [eval $cachevar=yes],
+          [eval $cachevar=no])
+         CXXFLAGS="$ac_save_CXXFLAGS"])
+      if eval test x\$$cachevar = xyes; then
+        CXXFLAGS="$CXXFLAGS $switch"
+        ac_success=yes
+        break
+      fi
+    done
+  fi])
+  AC_LANG_POP([C++])
+  if test x$ax_cxx_compile_cxx11_required = xtrue; then
+    if test x$ac_success = xno; then
+      AC_MSG_ERROR([*** A compiler with support for C++11 language features is required.])
+    fi
+  else
+    if test x$ac_success = xno; then
+      HAVE_CXX11=0
+      AC_MSG_NOTICE([No compiler with C++11 support was found])
+    else
+      HAVE_CXX11=1
+      AC_DEFINE(HAVE_CXX11,1,
+                [define if the compiler supports basic C++11 syntax])
+    fi
+
+    AC_SUBST(HAVE_CXX11)
+  fi
+])

projects/MSVC_2010/Freespace2.sln

@@ -1,6 +1,6 @@
 
 Microsoft Visual Studio Solution File, Format Version 11.00
-# Visual Studio 2010
+# Visual Studio 2010
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "Freespace2", "Freespace2.vcxproj", "{A8030FA3-CEAB-4297-99E3-CD2CFB89830B}"
 EndProject
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "libjpeg", "libjpeg.vcxproj", "{42A241F2-7996-4AAF-8491-FB885E2DC37D}"