refactor(workflow): only run action on manual trigger

Bumps [electron](https://github.com/electron/electron) from 29.2.0 to 30.0.2.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](https://github.com/electron/electron/compare/v29.2.0...v30.0.2)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/FUNDING.yml

@@ -1 +1 @@
-liberapay: barbapapa
+custom: https://my.fsf.org/donate

.github/workflows/build.yml

@@ -1,27 +1,24 @@
 on:
-  push:
-    branches:
-      - master
-  pull_request:
-  workflow_dispatch:
+  workflow_dispatch
 
 jobs:
   build:
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - name: Check out repositoty
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
+          cache: 'npm'
+          node-version: 20
 
       - name: Set up npm project
         run: npm install
 
       - name: Build project
-        run: npm run buildall
+        run: npm run build
 
       - name: Move x64 exe
         run: cp ./dist/SteamDepotDownloaderGUI*.exe ./SteamDepotDownloaderGUI-${{ github.run_number }}.exe
@@ -39,7 +36,7 @@ jobs:
         run: cp `ls -d1 dist/* | grep -E "steamdepotdownloadergui-[0-9]+\.[0-9]+\.[0-9]+\-arm64.zip"` ./SteamDepotDownloaderGUI-${{ github.run_number }}-arm64.zip
 
       - name: Upload artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: SteamDepotDownloaderGUI-${{ github.run_number }}
           path: SteamDepotDownloaderGUI-${{ github.run_number }}*.*

.github/workflows/github-repo-stats.yml

@@ -14,6 +14,6 @@ jobs:
     steps:
       - name: run-ghrs
         # Use latest release.
-        uses: jgehrcke/github-repo-stats@v1.4.1 # Don't use latest release for security reasons (what if the workflow gets taken over by a malicious party)
+        uses: jgehrcke/github-repo-stats@v1.4.2
         with:
           ghtoken: ${{ secrets.ghrs_github_api_token }}

README.md

@@ -4,12 +4,13 @@
 <h4 align="center">A graphical wrapper for DepotDownloader, designed to make downloading older versions of Steam games easy. built using <a href="https://www.electronjs.org" target="_blank">Electron</a>.
 <br><br>
 →<a href="https://www.youtube.com/watch?v=H2COwT5OUOo" target="_blank"><b>Tutorial</b></a> ~ 
+<a href="https://github.com/mmvanheusden/SteamDepotDownloaderGUI/tree/steamdeck-dotnet#steamdepotdownloadergui-for-steam-deck" target="_blank"><b>Steam Deck</b></a> ~ 
 <a href="https://www.youtube.com/watch?v=ogiDAuH3VdY" target="_blank"><b>Subnautica</b></a>←
 </h4>
 
 
 
-<p align="center"><a href="https://github.com/mmvanheusden/SteamDepotDownloaderGUI/releases/latest"><img src="https://img.shields.io/github/downloads/mmvanheusden/SteamDepotDownloaderGUI/total?color=orange&label=downloads" alt="Download count badge"></a><a href="https://img.shields.io/github/last-commit/mmvanheusden/SteamDepotDownloaderGUI?color=crimson"><img src="https://img.shields.io/github/last-commit/mmvanheusden/SteamDepotDownloaderGUI?color=crimson" alt="Last contribution badge"></a><a href="https://github.com/mmvanheusden/SteamDepotDownloaderGUI/releases/latest"><img src="https://img.shields.io/badge/Download -ffbd03?style=for-the-badge&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAABmJLR0QA/wD/AP+gvaeTAAABd0lEQVRoge2XwUrDQBCGPz3Ee++2UBSvdsGbeLHeFX0lPQhei+8g2AfwSVREK+LJ1oqHUGjRQ7Z0laRJNtldKPPBwoTM7D9/sks2IAiCsKrsAK/AC7DtSmTd1cTAKbAJtIAzVyIuDURGvOFKxKUBL4iB0IiB0IiB0IiB0IiB0IiB0IiB0IgBoA08Ak+AKpCvdO6AGn416zBwDGyRGLljuQmlc9pAEzipKl6HgVtgpOMGSYOdlLyOvtfQ1yPgpgb9WlDAEPjRYwj0jet+yv0iy80ru8AHiyazxiewF6jHXPJMeG3+CoiBy5J1/5dTlWVzAXwD5yXrAJho4YlFbdqesFnzsa6PLWr/PD0bFPAA3GO/YXN7WMspLpLnktweVvooMTPiKDPLHabmLCtpmYF3I96v3E55Doz4zWaCaxYb6Bno4udNRMCR1pzr92wmagFfZH+UfI0xycHPim5gE2Pg0Lb5OU2SVzgAph6anmqtHhWevCAIgh9+AdLMtu/CZhHJAAAAAElFTkSuQmCC" alt="Download latest release badge"></a><a href="https://img.shields.io/endpoint?url=https%3A%2F%2Fhits.dwyl.com%2Fmmvanheusden%2Fsteamdepotdownloadergui.json&color=lightblue"><img src="https://img.shields.io/endpoint?url=https%3A%2F%2Fhits.dwyl.com%2Fmmvanheusden%2Fsteamdepotdownloadergui.json&color=lightblue" alt="Visitor count badge"></a><a href="https://liberapay.com/barbapapa"><img src="https://img.shields.io/badge/Donate-black?logo=liberapay" alt="Donation badge"></a><a href="https://www.codefactor.io/repository/github/mmvanheusden/steamdepotdownloadergui/badge/master"><img src="https://www.codefactor.io/repository/github/mmvanheusden/steamdepotdownloadergui/badge/master" alt="CodeFactor badge"></a></p>
+<p align="center"><a href="https://github.com/mmvanheusden/SteamDepotDownloaderGUI/releases/latest"><img src="https://img.shields.io/github/downloads/mmvanheusden/SteamDepotDownloaderGUI/total?color=orange&label=downloads" alt="Download count badge"></a><a href="https://img.shields.io/github/last-commit/mmvanheusden/SteamDepotDownloaderGUI?color=crimson"><img src="https://img.shields.io/github/last-commit/mmvanheusden/SteamDepotDownloaderGUI?color=crimson" alt="Last contribution badge"></a><a href="https://github.com/mmvanheusden/SteamDepotDownloaderGUI/releases/latest"><img src="https://img.shields.io/badge/Download -ffbd03?style=for-the-badge&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAABmJLR0QA/wD/AP+gvaeTAAABd0lEQVRoge2XwUrDQBCGPz3Ee++2UBSvdsGbeLHeFX0lPQhei+8g2AfwSVREK+LJ1oqHUGjRQ7Z0laRJNtldKPPBwoTM7D9/sks2IAiCsKrsAK/AC7DtSmTd1cTAKbAJtIAzVyIuDURGvOFKxKUBL4iB0IiB0IiB0IiB0IiB0IiB0IiB0IgBoA08Ak+AKpCvdO6AGn416zBwDGyRGLljuQmlc9pAEzipKl6HgVtgpOMGSYOdlLyOvtfQ1yPgpgb9WlDAEPjRYwj0jet+yv0iy80ru8AHiyazxiewF6jHXPJMeG3+CoiBy5J1/5dTlWVzAXwD5yXrAJho4YlFbdqesFnzsa6PLWr/PD0bFPAA3GO/YXN7WMspLpLnktweVvooMTPiKDPLHabmLCtpmYF3I96v3E55Doz4zWaCaxYb6Bno4udNRMCR1pzr92wmagFfZH+UfI0xycHPim5gE2Pg0Lb5OU2SVzgAph6anmqtHhWevCAIgh9+AdLMtu/CZhHJAAAAAElFTkSuQmCC" alt="Download latest release badge"></a><a href="https://img.shields.io/endpoint?url=https%3A%2F%2Fhits.dwyl.com%2Fmmvanheusden%2Fsteamdepotdownloadergui.json&color=lightblue"><img src="https://img.shields.io/endpoint?url=https%3A%2F%2Fhits.dwyl.com%2Fmmvanheusden%2Fsteamdepotdownloadergui.json&color=lightblue" alt="Visitor count badge"></a><a href="https://my.fsf.org/donate"><img src="https://img.shields.io/badge/Donate-%23A42E2B?logo=gnu" alt="Donation badge"></a><a href="https://www.codefactor.io/repository/github/mmvanheusden/steamdepotdownloadergui/badge/master"><img src="https://www.codefactor.io/repository/github/mmvanheusden/steamdepotdownloadergui/badge/master" alt="CodeFactor badge"></a></p>
 
 
 <p align="center">
@@ -23,6 +24,7 @@
   - Windows
   - <s>macOS</s> (in development™)
   - Linux
+  - [Steam Deck](https://github.com/mmvanheusden/SteamDepotDownloaderGUI/tree/steamdeck-dotnet#steamdepotdownloadergui-for-steam-deck)
 * **Cross terminal**
   - Gnome Terminal
   - Konsole
@@ -38,6 +40,12 @@
   - Manual: produce a script that can be copy pasted into a terminal of choice
 * **Support for anonymous downloads**
 
+## Rewrite
+Computer resources are not an all-you-can-eat buffet. The executables weigh on average 103 MB.  
+That's why in the future, this project is fully switching to a different toolset, probably [gtk-rs](https://gtk-rs.org/).
+This framework is more suited as we don't need a whole browser engine just to download files.
+
+
 ## Download
 
 ### Windows:
@@ -45,7 +53,8 @@
   Then, download the [latest Windows build](https://github.com/mmvanheusden/SteamDepotDownloaderGUI/releases/latest)
 ### **Linux:**
 #### Arch Linux:
-* An official [AUR package](https://aur.archlinux.org/packages/steamdepotdownloadergui-appimage) has been made. this can be installed using `yay -S steamdepotdownloadergui-appimage`.
+* There is an [AUR package](https://aur.archlinux.org/packages/steamdepotdownloadergui-bin) made. this can be installed using `yay -S steamdepotdownloadergui-bin`.
+  **This is not maintained by me!!**
 #### Other Linux distros:
 * **You'll need `unzip`, .NET SDK 6.0.**
 * **Ubuntu:**
@@ -83,25 +92,15 @@ This software makes use of the following projects:
 
 
 ## Donate
+I prefer not to receive any donations. If you want to make me happy open an issue and say thanks ;)  
+Please donate to the [Free Software Foundation](https://my.fsf.org/donate) instead.
 
-Donations can be made through Liberapay :)
-
-<a href="https://liberapay.com/barbapapa">
-    <img src="https://img.shields.io/badge/Donate-black?logo=liberapay&style=for-the-badge"
-    alt="Donation badge">
-</a>
-
-## On Electron
-Computer resources are not an all-you-can-eat buffet. The executables weigh on average 103 MB.  
-That's why in the future, this project is fully switching to a [different](https://tauri.app/) (multi-platform) toolset. Nothing will change for the user.
 
 ## Contribute
-
 If you would like to contribute to SteamDepotDownloaderGUI, please make sure to follow
-the [contributing instructions and guidelines](contributing.md).
-
-Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.
-
+the [contributing instructions and guidelines](contributing.md).  
+Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.  
 Please make sure to keep code clean and cross-platform compatible.
 
-![forthebadge](https://forthebadge.com/images/featured/featured-built-with-love.svg)
+
+![forthebadge](https://forthebadge.com/images/featured/featured-built-with-love.svg)

downloader.js

@@ -30,6 +30,7 @@ function submitForm() {
 	preDownloadCheck().then(async function () {
 		//console.log(terminal[1][0])
 		document.getElementById("dotnetwarning").hidden = true
+		document.getElementById("dotnetwarning2").hidden = true
 		document.getElementById("emptywarning").hidden = true
 		console.info("dotnet found in PATH")
 		// create variables for the form values
@@ -87,10 +88,12 @@ function submitForm() {
 	}).catch(function (error) {
 		if (error === "noDotnet") {
 			// if dotnet is not found, show the dotnet warning
+			document.getElementById("dotnetwarning2").hidden = true
 			document.getElementById("emptywarning").hidden = true
 			document.getElementById("dotnetwarning").hidden = false
 		} else if (error === "emptyField") {
 			// if a required field is empty, show the empty field warning
+			document.getElementById("dotnetwarning2").hidden = true
 			document.getElementById("dotnetwarning").hidden = true
 			document.getElementById("emptywarning").hidden = false
 		}
@@ -106,6 +109,7 @@ function openRelevantPage(target) {
 	switch (target) {
 	case "dotnet":
 		document.getElementById("dotnetwarning").hidden = true
+		document.getElementById("dotnetwarning2").hidden = false
 		if (os.includes("win")) {
 			console.debug("Opened .NET download page for " + os.charAt(0).toUpperCase() + os.slice(1))
 			void electron.shell.openExternal("https://aka.ms/dotnet/6.0/dotnet-sdk-win-x64.exe")
@@ -131,7 +135,7 @@ function openRelevantPage(target) {
 		break
 	case "donate":
 		console.debug("Opened donation page")
-		void electron.shell.openExternal("https://liberapay.com/barbapapa/")
+		void electron.shell.openExternal("https://my.fsf.org/donate")
 		break
 	case "instructions":
 		console.debug("Opened instructions page")
@@ -333,8 +337,8 @@ window.addEventListener("DOMContentLoaded", () => {
 
 // make sure devtools open in external window.
 window.addEventListener("keydown", (e) => {
-	e.preventDefault()
 	if (e.key === "F12" || (e.ctrlKey && e.shiftKey && e.key === "I")) {
+		e.preventDefault()
 		ipcRenderer.send("open-devtools")
 	}
 })

index.html

@@ -39,6 +39,16 @@
 			Please fill in all required fields.
 		</div>
 	</div>
+
+	<div hidden id="dotnetwarning2">
+		<div class="flash mx-2 mt-2 color-shadow-medium">
+			<svg class="octicon" height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg">
+				<path d="M8 1.5a6.5 6.5 0 100 13 6.5 6.5 0 000-13zM0 8a8 8 0 1116 0A8 8 0 010 8zm6.5-.25A.75.75 0 017.25 7h1a.75.75 0 01.75.75v2.75h.25a.75.75 0 010 1.5h-2a.75.75 0 010-1.5h.25v-2h-.25a.75.75 0 01-.75-.75zM8 6a1 1 0 100-2 1 1 0 000 2z"
+				      fill-rule="evenodd"></path>
+			</svg>
+			Please re-open after installing .NET.
+		</div>
+	</div>
 	<div class="f1-light text-center">Steam Depot Downloader</div>
 
 	<form id="theform">
@@ -144,7 +154,7 @@
 		SteamDB
 	</div>
 
-	<div aria-label="Donate to the authors of the project." class="btn btn-sm ml-2 tooltipped tooltipped-nw mb-1"
+	<div aria-label="Donate to the Free Software Foundation." class="btn btn-sm ml-2 tooltipped tooltipped-nw mb-1"
 	     id="smbtn3">
 		<svg fill="#8B949E" height="16" style="display: inline-block; vertical-align: text-bottom;" viewBox="0 0 16 16"
 		     width="16" xmlns="http://www.w3.org/2000/svg">
@@ -209,8 +219,8 @@
 							<option>cool-retro-term</option>
 							<option selected="selected">Auto</option>
 						</select>
-						found: <span class="Counter"><code id="terminals-found" style="color: black;">none</code></span>
-						<br>default: <span class="Counter"><code id="default-terminal" style="color: black;">none</code></span>
+						found: <span class="Counter"><code id="terminals-found">none</code></span>
+						<br>default: <span class="Counter"><code id="default-terminal">none</code></span>
 					</div>
 				</div>
 			</div>
@@ -228,7 +238,7 @@
 							<option>Print command in console (CTRL-SHIFT-I)</option>
 							<option selected="selected">Auto</option>
 						</select>
-						default: <span class="Counter"><code id="default-os" style="color: black;">none</code></span>
+						default: <span class="Counter"><code id="default-os">none</code></span>
 					</div>
 				</div>
 			</div>

package.json

@@ -1,6 +1,6 @@
 {
   "name": "steamdepotdownloadergui",
-  "version": "2.4.0",
+  "version": "2.4.2",
   "description": "DepotDownloader Electron frontend",
   "main": "main.js",
   "scripts": {
@@ -30,12 +30,12 @@
   },
   "homepage": "https://github.com/mmvanheusden/SteamDepotDownloaderGUI#readme",
   "devDependencies": {
-    "electron": "^28.0.0",
-    "electron-builder": "^24.9.1",
-    "eslint": "^8.56.0"
+    "electron": "^30.0.2",
+    "electron-builder": "^24.13.3",
+    "eslint": "^9.1.1"
   },
   "dependencies": {
-    "follow-redirects": "^1.15.3",
+    "follow-redirects": "^1.15.6",
     "v8-compile-cache": "^2.4.0"
   }
 }

style.css

@@ -31,10 +31,11 @@
     overflow: auto;
     /*noinspection CssUnresolvedCustomProperty*/
     background-color: var(--bgColor-default, var(--color-canvas-default));
-    margin: 15% auto;
+    margin: 5%;
     padding: 25px;
     border: 1px solid #b4dede;
     width: 90vw; /* 90vw -> 90% */
+    height: 90vh; /* 90vh -> 90% */
     box-shadow: 0 10px 20px rgba(0, 0, 0, 0.1), 0 6px 20px rgba(0, 0, 0, 0.1);
 }
 
@@ -45,7 +46,7 @@
 hr {
     border: 0;
     height: 1px;
-    background: #000000 linear-gradient(to right, #000000, #ccc, #000000);
+    background: #0d1117 linear-gradient(to right, #0d1117, #ccc, #0d1117);
 }
 [data-color-mode="light"] hr {
     filter: invert(1);

utils.js

@@ -69,13 +69,13 @@ function download(url) {
 		const fs = require("fs")
 		const path = require("path")
 		const file = fs.createWriteStream(platformpath() + path.sep + url.split("/").pop())
-		https.get(url, function (response) {
+		https.get(url, (response) => {
 			response.pipe(file)
-			file.on("finish", function () {
+			file.on("finish", () => {
 				file.close()
 				resolve()
 			})
-			file.on("error", function (error) {
+			file.on("error", (error) => {
 				console.error(error)
 				reject(error)
 			})
@@ -235,8 +235,12 @@ async function generateRunScript(username, password, appid, depotid, manifestid,
 	let foldername = ""
 
 	// allow enormous strings like &$§"&$="§$/"(§NJUIDW>;!%?aQ52V?*['YsDnRy|(+Q 1h6BmnDQp,(Xr& being used as password.
-	// NOT TESTED
+	// This is very janky and will be replaced with a better solution in the upcoming rewrite.
 	password = password.replace(/"/g, "\"\"")
+	if (process.platform.includes("win")) {
+		// Replace all % with %% because batch scripts use % as a special character. This is not an elegant solution, but it should work.
+		password = password.replace(/%/g, "%%")
+	}
 
 	// if either the username or password fields is empty, anonymous login is used
 	let anonymous = username === "" || password === ""