Commit Graph

1936 Commits

Author SHA1 Message Date
Zack Weinberg
c6a14e6a14 Bug 475535 - don't go through PaintBackgroundWithSC to draw non-native radio buttons and checkboxes; remove special UA pseudo-elements for styling these. r+sr=roc 2009-04-03 10:45:17 +02:00
Dão Gottwald
3f7e05fa09 Backed out changeset cc4fae01938c 2009-04-02 12:03:52 +02:00
Zack Weinberg
0647a435a8 Bug 475535 - don't go through PaintBackgroundWithSC to draw non-native radio buttons and checkboxes; remove special UA pseudo-elements for styling these. r+sr=roc 2009-04-02 09:57:13 +02:00
Jeremy D. Lea
0e51628bd3 Bug 431634 - Part 1 - clean up header pollution; r+sr=roc 2009-04-01 13:59:02 -08:00
Martijn Wargers
ab208487d4 Adding crashtest 2009-03-16 20:52:30 -04:00
Martijn Wargers
1583a61a48 Mochitest for bug 478219 2009-03-16 13:21:28 -04:00
Boris Zbarsky
75b1d6d0f1 Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Dão Gottwald
b0f2cdc142 Backed out changeset 12e163f4f272 2009-03-16 15:00:57 +01:00
Boris Zbarsky
1863ecc5d2 Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Olli Pettay
b6cf78a6a8 Bug 478245 - Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron 2009-03-11 17:43:08 +02:00
Jonas Sicking
5ef7bc5537 Bug 431098: Make pressing 'cancel' in the file picker clear the file upload control. r/sr=bz
--HG--
extra : rebase_source : fb5a6deb1984475e55dd03ef7607044c5ce75bcb
2009-03-09 23:14:57 -07:00
Mats Palmgren
4e7d3753f9 Remove unnecessary #includes. b=462203 r+sr=roc 2009-02-19 21:18:49 +01:00
Boris Zbarsky
a5d5876901 Bug 400226. Do text redisplay as soon as it's safe, not after a trip to the event loop. r+sr=mats 2009-02-17 22:27:25 -05:00
Boris Zbarsky
f5a290d916 Bug 477700. Push a null JSContext around editor init, so it'll work no matter what JS is on the stack. r+sr=smaug 2009-02-16 09:11:41 -05:00
Jesse Ruderman
ea905567dc Add crashtests 2009-02-13 14:54:17 -08:00
Michael Ventnor
8ddfeb2aa2 Bug 477531. Support CSS3 :indeterminate pseudo-class. r+sr=dbaron,r=bzbarsky
--HG--
extra : rebase_source : 03d1be9b5742e8d17114aaeb0b5de20d61926d51
2009-02-11 14:19:37 +13:00
Jesse Ruderman
397e21afab Add a bunch of crashtests 2009-02-10 22:18:05 -08:00
Michael Ventnor
1afd316abf Bug 476738. Implement 'inset' box-shadows. r+sr=roc,r=dbaron 2009-02-10 21:45:13 +13:00
Michael Ventnor
58cd642235 Bug 476308. Box-shadows for buttons should not capture events. r+sr=roc 2009-02-05 21:22:02 +13:00
Arpad Borsos
c0f2dadc80 Bug 474369 - get rid of nsVoidArray; layout part; r+sr=roc 2009-02-03 15:42:18 +01:00
Olli Pettay
ffb38ea35e Bug 476097, ASSERTION: killing mutation events with <input type=file>, r+sr=bz 2009-01-31 14:34:01 +02:00
Michael Ventnor
b9cce93cc2 Bug 475197. box-shadow should work on file input controls. r+sr=roc
--HG--
extra : rebase_source : ca08ac21ddb8c27c7348f87f6963a03cf6fcfa46
2009-01-30 20:10:25 +13:00
Boris Zbarsky
e74ce779cc Adding test for bug 457537 2009-01-29 20:33:55 -05:00
Boris Zbarsky
ff8ff59c94 Bug 335615. Don't do editor init inside frame construction. r=mats, sr=roc 2009-01-29 14:46:17 -05:00
Michael Ventnor
c3c3f9d0be Bug 475197. -moz-box-shadow needs to be hooked up to buttons and fieldsets since they have custom background painting code. r+sr=roc 2009-01-28 22:28:14 +13:00
Michael Ventnor
b119ed9345 Bug 123836 - Implement indeterminate property on checkboxes and radio buttons - r=roc,jst sr=roc 2009-01-22 13:07:44 +13:00
Boris Zbarsky
225d63e68a Bug 473390 part 6. Move the flag-setting for file controls out of the frame constructor and into the frame implementation. r+sr=roc 2009-01-19 13:31:32 -05:00
Boris Zbarsky
ba95458bfd Bug 473390 part 5. Move the checkbox and radio face style code out of the frame constructor and into those frames. r+sr=roc 2009-01-19 13:31:32 -05:00
Boris Zbarsky
5f139eb5e6 Bug 473390 part 3. Move some HTML frame construction assertions out of the frame constructor and into the relevant frame creation methods. r+sr=roc 2009-01-19 13:31:31 -05:00
Boris Zbarsky
454784fb68 Bug 473390 part 2. Call SetInitialChildList on HTML frames even if the child list is empty, to bring HTML in line with everything else. r+sr=roc 2009-01-19 13:31:31 -05:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
ad5d856ae6 Rename flags and methods from space manager to float manager. (Bug 191448) r+sr=roc 2009-01-04 19:39:54 -05:00
L. David Baron
4872871d0b Fix some missed renames from bug 471356. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
4690547534 Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
Olli Pettay
28cb4846da Bug 469720 - tabindex of -1 set in javascript ignored on file input, r+sr=bz 2008-12-17 09:33:33 +02:00
Aiko
f2e176127e Combobox steals mouse event after menu is closed with Alt+Up. b=348236 r=mats sr=bzbarsky 2008-12-14 11:17:06 +01:00
Graeme McCutcheon
5a486a7210 Bug 345339. Make nsPresState not use a hashtable in favor of using less memory and only storing the things it really wants to store. Switch box objects to their own hashtable. r+sr=roc 2008-12-12 14:25:22 -05:00
Robert O'Callahan
1f1a970697 Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats 2008-12-12 21:34:43 +13:00
L. David Baron
4260a65399 Avoid discontinuity when options drop to height:0 by using CalcFallbackRowHeight only when GetNumberOfOptions() == 0, thus eliminating the last caller of CalcFallbackRowHeight passing a non-zero option count. (Bug 467084) sr=roc r=bzbarsky a=blocking1.9.1+ 2008-12-04 08:09:53 -08:00
L. David Baron
2dccf4784c Pass the user font set through more reliably and make it a required parameter. (Bug 467084) r+sr=roc a=blocking1.9.1+ 2008-12-04 08:09:53 -08:00
Graeme McCutcheon
38c89ebd70 Bug 215405. Restore scroll position, but not form state, on no-store and SSL no-cache sites. r+sr=bzbarsky 2008-12-03 12:55:14 -05:00
Markus Stange
1b2252f6c6 Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
7a0477cfbf Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc 2008-10-27 20:27:55 -04:00
Theppitak Karoonboonyanan
88e1b95b7b Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Mats Palmgren
0abae51687 Ignore the keypress event if DOMEventToNativeKeyEvent() fails. b=456273 r=Olli.Pettay sr=jonas 2008-10-15 12:50:42 +02:00
Taras Glek
e4062632a7 Bug 456099: outparamdel nsIPrivateDOMEvent r+sr=jst 2008-10-09 16:23:07 -07:00
Boris Zbarsky
562d828fdd Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Boris Zbarsky
9599df476b Backing out changesets 2ea77fa990af, 7d2d8869e73c, 93441e4f521e, 43d2ee100f3b, a2d84821ea71 to see whether they're causing the Windows Txul or Mac Tp regressions 2008-09-29 08:51:29 -04:00
Boris Zbarsky
a6aec54eaf Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Taras Glek
ba02fffe86 bug 455536: s/NS_ERROR_FAILURE/NS_ERROR_OOM/ outparamdelled nsNodeInfoManager::GetNodeInfo r+sr=jsr 2008-09-25 15:46:52 -07:00
Boris Zbarsky
328c7cdf4b Bug 455451. Don't notify from inside frame construction. r+sr=jst 2008-09-25 16:35:46 -04:00
Zack Weinberg
473726ed0c Bug 456792 - Two more API cleanups for nsCSSRendering; patch 1; r+sr=roc 2008-09-25 17:53:27 +02:00
Zack Weinberg
97bef90839 Bug 456152 - slight API cleanup for nsCSSRendering::PaintBackground; r+sr=roc 2008-09-24 06:07:22 +02:00
Arpad Borsos
18b833c041 Bug 452797 - Clean up unused variables in layout/; v6; r+sr=roc 2008-09-20 15:42:03 +02:00
Robert O'Callahan
775dd33c74 Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron 2008-09-18 21:47:21 +12:00
Arpad Borsos
87878e68eb Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Taras Glek
74132a5585 bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Robert Kaiser
b3901a31af bug 451601 - kill MOZILLA_LOCALE_VERSION, main mozilla-central patch to kill xpfe-style chrome versions, r=ted sr=Neil 2008-09-11 01:08:57 +02:00
Ted Mielczarek
ff7706a544 bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Taras Glek
cfb7b89b10 bug 454292:prbool fixes for layout r+sr=dbaron 2008-09-09 10:07:26 -07:00
timeless@mozdev.org
2cf6a7ee79 Backed out changeset 54215f2cbc66
to fix Bug 454186
SM crashes when try to download file [@ nsString::ToInteger - nsTreeBodyFrame::PaintProgressMeter]
2008-09-08 16:00:32 +02:00
Arpad Borsos
95c1e86113 Bug 452797 - Clean up unused variables in layout/; r+sr=roc 2008-09-06 20:38:31 +02:00
Robert O'Callahan
c04d96c610 Bug 376662. Convert nsIFrame::GetOffsetTo to not use views. We need to ensure that for popups and scrollframes, views and frames are kept in sync at *all* times. Also fixes bugs in tests for NS_FRAME_NO_MOVE_FRAME. r+sr=bzbarsky 2008-09-06 20:52:56 +12:00
Robert O'Callahan
8d8390a5b5 Backing out changeset 1bdd5da49865 (for bug 376662) due to regression bug 453661 2008-09-05 15:40:06 +12:00
Robert O'Callahan
82aa805186 Bug 376662. Make nsIFrame::GetOffsetTo not explicitly use views. r+sr=bzbarsky 2008-09-04 09:35:52 +12:00
Robert O'Callahan
519c75bf87 Bug 331088. Handle file-control frame being torn down while the dialog is up. r=smaug,sr=mats 2008-08-15 22:21:31 +12:00
Boris Zbarsky
ced05f04cb Bug 210094. Make min-height and max-height work on fieldset. r+sr=dbaron 2008-08-08 01:18:00 -04:00
Zack Weinberg
300f48fbd4 Bug 446498 – use new border rendering for focus rectangles, and strip dead code. r+sr=vlad 2008-08-06 12:33:18 +02:00
Mats Palmgren
8bbc56fcbc Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:36:21 -07:00
Mats Palmgren
8534784f1c Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:34:11 -07:00
Zack Weinberg
a1072e86a3 Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron 2008-07-17 16:37:12 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
7d3343e0fa Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
86c186dbd8 Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
269c2d355a Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
John Daniels
b006229ae6 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
neil@parkwaycc.co.uk
64491786fd Bug 444466 – Crash [@ nsTextControlFrame::PreDestroy()], r+sr=bz 2008-07-12 11:26:40 +02:00
Mats Palmgren
86d4cc0003 Use the post-reflow GetUsedMargin() value when placing the legend. b=433700 r+sr=dbaron 2008-07-09 17:42:44 +02:00
vladimir@pobox.com
ea318bc762 b=431081; native selection box frame missing in fx3 - vista content only; r+sr=roc,a=beltzner 2008-04-28 20:55:07 -07:00
jst@mozilla.org
4b69a276d4 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
dbaron@dbaron.org
4589e85ab3 Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons 2008-04-14 18:04:18 -07:00
roc+@cs.cmu.edu
0a70ba3e53 Bug 425253. Propagate reflow-depth tracking through XUL box layout. r+sr=dbaron,a=damon 2008-04-09 21:39:41 -07:00
reed@reedloden.com
3ada7e2c40 Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-08 11:52:48 -07:00
timeless@mozdev.org
b0e4df4591 Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-06 05:28:34 -07:00
mats.palmgren@bredband.net
747c16c7c6 Disconnect the frame selection object from the pres shell earlier. b=421083 r+sr=roc a1.9=beltzner 2008-04-02 19:42:20 -07:00
masayuki@d-toybox.com
2a69e80bd1 Bug 424989 Cannot use reconversion of IMEs from system menu at the focus being on textarea r+sr=roc, b1.9=jonas 2008-03-29 12:38:05 -07:00
jruderman@hmc.edu
8c070d91b8 Adding crashtest 2008-03-26 21:27:43 -07:00
timeless@mozdev.org
7f880e43ef reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
timeless@mozdev.org
022712406a Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
bzbarsky@mit.edu
0526293212 Don't use fieldset pref widths as min widths, since pref widths can be unconstrained. Incidentally makes it possible for text to legends to wrap if the page wants it to. Bug 404123 and bug 354502, r+sr=dbaron, a=beltzner. 2008-03-14 13:48:23 -07:00
dbaron@dbaron.org
fe0cb896ea Give radio buttons and checkboxes a useful baseline, and switch checkboxes from text-bottom to baseline alignment (to match radios). b=402940 r+sr=bzbarsky a=blocking1.9+ 2008-03-07 09:57:34 -08:00
dbaron@dbaron.org
0d8b560733 Fix the weird Get* API on nsStyleSides in favor of returning structs by value, to avoid further occurrences of bug 420069. b=420069 r+sr=roc a=beltzner 2008-03-05 16:05:26 -08:00
roc+@cs.cmu.edu
20504d8ff0 Bug 405952. Add scrollbar width to pref and min widths for overflow:scroll elements but for no other overflow values. r+sr=bzbarsky,dbaron,dholbert, a=beltzner 2008-02-28 12:37:06 -08:00
masayuki@d-toybox.com
1c98c2e245 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner 2008-02-28 07:28:37 -08:00
masayuki@d-toybox.com
076b8bba8e backing out the previous patch, becaused qm-centos5-01 dep unit test is orange 2008-02-28 05:59:25 -08:00
masayuki@d-toybox.com
600836e7ed Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner 2008-02-28 03:01:56 -08:00
roc+@cs.cmu.edu
709741beff Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep 2008-02-21 18:24:04 -08:00
reed@reedloden.com
36a557fc04 Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures. 2008-02-20 03:10:16 -08:00
reed@reedloden.com
61f93061b0 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep] 2008-02-20 02:19:31 -08:00
jag@tty.nl
05cdb6aefe Bug 73353: Clean up our MODULE/REQUIRES story. rs=dbaron, a=brendan 2008-02-18 00:50:04 -08:00
reed@reedloden.com
2eddcd6e28 Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745). 2008-02-15 12:20:55 -08:00
reed@reedloden.com
636da4197c Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner] 2008-02-14 21:30:34 -08:00
Olli.Pettay@helsinki.fi
065cc2d962 Bug 411212, cannot prevent file-picker from showing on <INPUT TYPE=FILE>, r+sr=roc+bzbarsky, a=mtschrep 2008-01-10 13:55:38 -08:00
reed@reedloden.com
4438253756 Bug 409587 - "input[type="file"] cropped when narrow width specified" [p=kinetik@flim.org (Matthew Gregan) r+sr=roc a1.9=beltzner] 2008-01-07 14:18:06 -08:00
jruderman@hmc.edu
a3a9a27d42 Add crashtest. 2008-01-06 15:55:24 -08:00
jruderman@hmc.edu
e3e6daec9d Add a crashtest 2008-01-05 22:42:00 -08:00
jruderman@hmc.edu
7623693bdb Add a crashtest (plus another crashtest I apparently forgot to check in before). 2008-01-05 22:10:06 -08:00
bzbarsky@mit.edu
dc7ecebfee Make image controls splittable just like regular images. Bug 409659, r+sr=roc, a=dsicore 2008-01-04 22:44:38 -08:00
neil@parkwaycc.co.uk
b22e83627e Make XUL elements really native anonymous b=410119 r=smaug sr+a=sicking 2008-01-04 03:24:41 -08:00
roc+@cs.cmu.edu
f8b25558e4 Bug 407889. Reduce dynamic memory allocations during event handling by having nested invocations of HitTest share a single buffer for reordering display items; this buffer is an nsAutoTArray so it's mostly stack-allocated. r+sr=mats 2008-01-03 18:08:29 -08:00
reed@reedloden.com
58044dcad7 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-29 12:43:27 -08:00
jruderman@hmc.edu
a4f1249a90 Add crashtests 2007-12-23 17:51:54 -08:00
dholbert@cs.stanford.edu
749290b928 Bug 408772: Replace nscoord_MAX-unsafe arithmetic with safe call to NSCoordSaturatingSubtract, in nsComboboxControlFrame::GetIntrinsicWidth. r+sr=bzbarsky a=mtschrep 2007-12-18 11:26:35 -08:00
jruderman@hmc.edu
92a6869573 Add crashtest 2007-12-17 23:19:21 -08:00
jruderman@hmc.edu
7776306efe Add crashtest 2007-12-17 16:35:42 -08:00
jruderman@hmc.edu
4e01cf307d Add crashtests 2007-12-16 17:23:03 -08:00
jruderman@hmc.edu
52ddf37f76 When you stare into the crashtest, the crashtest also stares back into you. 2007-12-16 17:20:41 -08:00
jruderman@hmc.edu
ab6324c078 Add a crashtest 2007-12-16 17:16:39 -08:00
jruderman@hmc.edu
1ec381ac10 Add crashtest 2007-12-16 17:13:30 -08:00
jruderman@hmc.edu
d55e3fc736 Old MacDonald had a farm, EIEIO. And on that farm he had some crashtests, EIEIO. With an mlk here and an assert there, here a crash, there a hang, everywhere a big bang. Old MacDonald had a farm, EIEIO. 2007-12-16 17:10:36 -08:00
jruderman@hmc.edu
9721d132c9 Add crashtest 2007-12-16 16:52:49 -08:00
jruderman@hmc.edu
3d0e339d2d Add crashtest 2007-12-16 14:10:22 -08:00
jruderman@hmc.edu
87a923acb3 Add two crashtests 2007-12-16 14:08:46 -08:00
jruderman@hmc.edu
f1e1824f10 Crashtest! 2007-12-15 20:55:06 -08:00
jruderman@hmc.edu
040eb53289 Add crashtests 2007-12-15 15:45:02 -08:00
reed@reedloden.com
27a55e7707 Back out patch from bug 406047, as it is causing orange on Linux and Tp regression on Mac. 2007-12-14 00:55:08 -08:00
reed@reedloden.com
71fe589716 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-13 23:20:32 -08:00
roc+@cs.cmu.edu
0b1d5ef941 Bug 407015. Dropdown listboxes should not propagate computed height from the scrollframe to its scrolled content. r+sr=dbaron 2007-12-06 16:10:31 -08:00
enndeakin@sympatico.ca
e45f5c2aab Bug 401627, better way of handling click to close menu so that it doesn't reopen the menu again, r+sr=roc 2007-12-03 08:33:42 -08:00
bzbarsky@mit.edu
55cae0276c Landing part of bug 363858 that somehow got misplaced. pending r=dbaron 2007-12-02 23:38:48 -08:00
bzbarsky@mit.edu
365fb40b8c Don't do arithmetic with unconstrained widths when reflowing comboboxes. Bug 363858, r+sr=dbaron 2007-12-02 22:41:38 -08:00
roc+@cs.cmu.edu
f6a0bf6aa0 Bug 405305. Fix z-ordering of legend background so it's in the block-backgrounds layer. r+sr=mats 2007-12-01 00:32:51 -08:00
reed@reedloden.com
5847c7c368 Bug 363696 - "Crash [@ nsHTMLReflowState::ComputeContainingBlockRectangle] with file upload control in xul" [p=kinetik@flim.org (Matthew Gregan) r=bzbarsky sr=roc a=blocking1.9+] 2007-11-26 19:35:50 -08:00
reed@reedloden.com
9f32f05195 Bug 373623 - "Unicode … should be used instead of three separate dots: ..." (browser locales) [p=hendrik.maryns@uni-tuebingen.de (Hendrik Maryns) r=mconnor a1.9=beltzner] 2007-11-26 18:44:44 -08:00
Olli.Pettay@helsinki.fi
a0a74f16e7 Bug 368760, r=mats, sr=roc, a=blocking1.9+ 2007-11-22 12:47:33 -08:00
aaronleventhal@moonset.net
f98359daf4 Bug 385070. Accessible subtrees for anonymous content need to be shut down. Patch by Evan Yan. r=aaronlev, r+sr=roc for layout part, a=dsicor 2007-11-20 12:39:36 -08:00
Evan.Yan@Sun.COM
b93b199daf back out patch of bug 385070 which broke accessible tree, to make nightly build safe 2007-11-16 01:12:58 -08:00
aaronleventhal@moonset.net
f80f334157 Bug 385070. Nodes in anonymous content trees that are hidden not being shut down. Patch by Evan Yan. r=aaronlev, r+sr=roc, a=mconnor 2007-11-15 17:38:33 -08:00
reed@reedloden.com
04dfd4f2cf Bug 402198 - Use async version of Invalidate() to avoid flushing pending notifications [p=mats.palmgren@bredband.net (Mats Palmgren) r+sr=roc a1.9=schrep] 2007-11-13 08:44:48 -08:00
mats.palmgren@bredband.net
a641627d36 Backing out relevant part of bug 402198 to see if it fixes Orange on Windows Tinderbox... 2007-11-09 20:23:26 -08:00
mats.palmgren@bredband.net
e33b99bebb Use async version of Invalidate() to avoid flushing pending notifications. Also, document this aspect of the Invalidate() API. b=402198 r+sr=roc a=mtschrep 2007-11-09 16:51:02 -08:00
reed@reedloden.com
2c03a2b214 Bug 336153 - Fix fieldset content-block sizing when a specified height is given [p=roc r+sr=bzbarsky a=blocking1.9+] 2007-11-07 20:04:32 -08:00
neil@parkwaycc.co.uk
67f7e866a9 Bug 399968 Back out some parts from bug 258875 that have no effect r+sr+a=roc 2007-10-19 01:51:27 -07:00
roc+@cs.cmu.edu
2763f9f7df Backing out fix for bug 345339 because of test failures 2007-10-09 20:39:16 -07:00
roc+@cs.cmu.edu
24f20d0cd0 Bug 345339. Stop using a generic hashtable to store element session history state in nsPresState. patch by Karthik Sarma, r+sr=roc,a=sicking 2007-10-09 19:15:23 -07:00
Olli.Pettay@helsinki.fi
7a162df868 Bug 388558, 'change' event isn't dispatched if user selects input field value from the autocomplete list, r=jst, sr=sicking, a=mconnor 2007-10-02 09:56:07 -07:00
aaronleventhal@moonset.net
c773b68f7e bug 397644. File control not exposed correctly to a11y apis. r+sr+a=roc 2007-09-27 18:09:14 -07:00
roc+@cs.cmu.edu
4f984e3fae Bug 392629. Be a bit more clever about invalidating listboxes and combobox dropdowns when the focus ring moves. r+sr=bzbarsky 2007-09-27 16:06:31 -07:00
joshmoz@gmail.com
a91716eeae extra measure of security for password textfields on Mac OS X. b=394107 r=smorgan sr=roc 2007-09-27 09:01:32 -07:00
bzbarsky@mit.edu
ee74eef160 Only update the select command for focused text inputs. Bug 394792, r=roc, sr=neil, a=roc 2007-09-14 15:33:40 -07:00
bzbarsky@mit.edu
93b33bcffa When selectedIndex is set, make sure to display the corresponding text in the display area. Bug 330554, r+sr=mats, a=dbaron 2007-08-21 20:25:42 -07:00
bzbarsky@mit.edu
ddcdc2b80d Make maxlength not affect initial values or scripted sets. Bug 345267, r+sr=mats, a=dbaron 2007-08-21 20:22:21 -07:00
bzbarsky@mit.edu
4a0892e86f Make auto-height abs-pos textfields with top and bottom offsets both set use their intrinsic height, per spec. Bug 385870, r+sr+a=dbaron 2007-08-21 20:07:25 -07:00
bzbarsky@mit.edu
e51e8403e6 Make sure to process style updates before reflow, and both before painting. Bug 375436, r+sr=roc, a=dbaron 2007-08-21 19:57:06 -07:00
bzbarsky@mit.edu
34769343d2 When a file has already been selected, correctly prefill the filepicker with that file. Bug 374013, r+sr=sicking, a=dbaron 2007-08-14 11:42:10 -07:00
enndeakin@sympatico.ca
5340e19698 Bug 390420, select dropdowns appearing in the wrong place in some cases, r+bz,a=dbaron 2007-08-10 05:42:06 -07:00
bzbarsky@mit.edu
77efa38741 Account for the padding on our anonymous div when sizing. Bug 388086, r+sr+a=dbaron 2007-08-02 15:06:00 -07:00
bzbarsky@mit.edu
f96769770e Don't optimize away necessary reflows. Bug 388374, r+sr+a=dbaron 2007-08-02 15:02:25 -07:00
bzbarsky@mit.edu
9c59e9e4cc Introduce a setter for nsHTMLReflowState::mComputedHeight so that we're sure to
update the resize flags properly.  Bug 388084, r+sr+a=dbaron
2007-08-02 11:08:05 -07:00
roc+@cs.cmu.edu
a28eeaaafd Bug 379349. Add support for 'overflow containers' --- special frame continuations that do not map any content of their own, but serve only as containers for laying out children that overflowed their parents' content height. patch by fantasai, r+sr=eli,roc 2007-07-25 21:03:29 -07:00
bzbarsky@mit.edu
bea1e960d8 Avoid doing some work when initializing textfields. Bug 221150, patch by
peterv and a little bit me, r=me, sr=roc
2007-07-24 17:11:22 -07:00
Olli.Pettay@helsinki.fi
076594c97a Bug 355367, textbox onchange doesn't fire if user tabs out and value changed in onkeydown, r=jst, sr=sicking 2007-07-20 16:19:19 -07:00
bzbarsky@mit.edu
b66e0608e5 Update the visual look of a file input when privileged script sets its value.
Bug 387978, r+sr=sicking
2007-07-13 21:46:09 -07:00
peterv@propagandism.org
f7ff5666a6 Fix for bug 386496 (Clicking on link in designMode document does follow that link now). r/sr=bz. 2007-07-11 06:05:05 -07:00
mrbkap@gmail.com
cf72287e8c Backing out this change to see if it fixes the test failures. 2007-07-09 16:05:44 -07:00
mrbkap@gmail.com
bc4b050f93 Attempt to re-enable async reflow and painting in editor. bug 174823, r+sr=roc 2007-07-09 14:55:18 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
bzbarsky@mit.edu
4786dc1f42 Fix bug 387154 -- rendering of narrow buttons (for which we need to scoot the
text over to the left) regressed.  r+sr=dbaron
2007-07-06 17:48:29 -07:00
mats.palmgren@bredband.net
42a227c78a Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst 2007-07-03 19:15:31 -07:00
bzbarsky@mit.edu
e7710fdc6c Fix parent style context warnings by being consistent about parent contexts.
Bug 380116, r+sr=dbaron
2007-06-15 22:11:20 -07:00
aaronleventhal@moonset.net
2d4c33954a Fixing bustage 2007-06-14 06:47:23 -07:00
aaronleventhal@moonset.net
9987549b99 Bug 384265. No accessible focus events fired during incremental find in an HTML <select>. r=mats, sr=neil 2007-06-14 06:18:16 -07:00
joshmoz@gmail.com
d6015ce03e don't let comboboxes render their labels over the native combobox button on Mac OS X. b=382043 r/sr=roc 2007-05-28 22:31:04 -07:00
joshmoz@gmail.com
37c5a30cdd clean up unused methods and virualized methods in nsButtonFrameRenderer. Patch by Rob Arnold. b=315347 r/sr=roc 2007-05-23 13:32:56 -07:00
joshmoz@gmail.com
d12acf85cf don't add scrollbar width to getPrefWidth in nsComboboxControlFrame if the themed widget has set the internal button width to 0. b=381669 r/sr=roc 2007-05-23 12:16:27 -07:00
joshmoz@gmail.com
f5147def1c Don't paint the background for the text frame in comboboxes if the combobox is themed. b=381268 r/sr=roc 2007-05-22 12:42:01 -07:00
joshmoz@gmail.com
79ffe0b1d1 don't put a dropmarker in comboboxes if nsITheme says not to. b=370282 r/sr=roc 2007-05-17 20:04:04 -07:00
mats.palmgren@bredband.net
fa393167a2 Protect against frame destruction during event handling and document when that can occur. b=378670 r+sr=bzbarsky 2007-05-17 04:12:30 -07:00
Olli.Pettay@helsinki.fi
7817abfbca Bug 363089, Remove nsIDOMEventReceiver (this time passes mochitest), r+sr=jst 2007-05-14 02:11:38 -07:00
Olli.Pettay@helsinki.fi
40178e46a3 backout Bug 363089 2007-05-11 06:34:05 -07:00
Olli.Pettay@helsinki.fi
e1fb8b073b Bug 363089, Remove nsIDOMEventReceiver, r+sr=jst 2007-05-11 04:15:11 -07:00
bzbarsky@mit.edu
1b5f6b30b6 Change the FrameNeedsReflow API to pass the dirty flags to be added directly tothe method, instead of setting them before calling the method. That way we canavoid reflowing the ancestor of a reflow root which is not itself dirty but hasdirty children. This also makes it harder to set dirty bits inconsistentlywith the FrameNeedsReflow call. Bug 378784, r+sr=dbaron, pending rbs' reviewon the mathml parts. 2007-05-06 12:16:51 -07:00
bzbarsky@mit.edu
b2ab6a6008 Fixing build bustage 2007-05-04 23:37:05 -07:00
bzbarsky@mit.edu
bf4922535e Don't cut off the right-hand side of empty comboboxes. Bug 364510, r+sr=dbaron 2007-05-04 23:20:10 -07:00
bzbarsky@mit.edu
9cd2a580d0 Make computed style handle "normal" for line-height by computing an actualnumeric height. Bug 371041, r+sr=dbaron 2007-05-04 22:30:10 -07:00
dbaron@dbaron.org
ace3611ec9 Add support for -moz-intrinsic, -moz-min-intrinsic, -moz-shrink-wrap, and -moz-fill for width, min-width, and max-width. b=311415 r+sr=bzbarsky 2007-05-03 16:11:00 -07:00
bzbarsky@mit.edu
086c2eb0c0 Introduce a GetPrimaryShell() API on nsIDocument. Convert existing callers ofGetShellAt(0) to using this API. Bug 378780. API introduction part by me,r+sr=jst. Mass-changes done by taras using squash, r+sr=me 2007-05-01 15:24:20 -07:00
bzbarsky@mit.edu
9beffcc014 Make assertion reflect reality better. Bug 357044, r+sr=roc 2007-04-25 18:17:05 -07:00
benjamin@smedbergs.us
baab01ada6 Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me 2007-04-23 07:21:53 -07:00
sharparrow1@yahoo.com
f1300f32f7 Bug 378129: Consistently pass the right frame to InvalidateInternal. r+sr=roc. 2007-04-20 16:51:12 -07:00
bzbarsky@mit.edu
eeaa1a101b Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
joshmoz@gmail.com
ed5252f114 remove app-specific code from tier-9 code. add a pref to handle native popup windows on Mac OS X instead. b=323062 r=smorgan sr=bsmedberg 2007-03-30 12:51:51 -07:00
Olli.Pettay@helsinki.fi
a1dca72a56 375196, r+sr=roc 2007-03-25 22:38:22 -07:00
hg@mozilla.com
05e5d33a57 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00
dbaron%dbaron.org
405d600298 When drawing images, track full source and dest regions (unclipped) or use floats, to avoid rounding problems with advanced image resizing algorithms. b=371434 r=vlad r+sr=roc 2007-03-20 00:58:20 +00:00
bugzilla%standard8.demon.co.uk
6272626282 Bug 373240 Uppercase the VK_* bits for consistency with the rest of the codebase (Dv1, layout) p=Serge Gautherie <sgautherie.bz@free.fr>,r/sr=dbaron 2007-03-19 20:00:12 +00:00
Olli.Pettay%helsinki.fi
1f2499afdc Bug 373586 , r+sr=roc 2007-03-19 10:23:29 +00:00
Olli.Pettay%helsinki.fi
c9355efc94 Backout bug 373586 2007-03-19 08:13:01 +00:00
Olli.Pettay%helsinki.fi
de33e16799 Bug 373586 , r+sr=roc 2007-03-19 06:30:41 +00:00
sharparrow1%yahoo.com
edd46f382e Bug 373381: Rendering of radios/checkboxes with auto width has regressed. r+sr=roc. 2007-03-14 02:47:05 +00:00
bzbarsky%mit.edu
7bf5f8b7a1 Make the display frame resize correctly when the <select>'s width changes. Bug
370422, r+sr=dbaron
2007-02-28 03:04:38 +00:00
dbaron%dbaron.org
9d7f938b99 Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc 2007-02-24 18:33:33 +00:00
mats.palmgren%bredband.net
ca7914d49f Make nsFileControlFrame, nsIsIndexFrame and nsLegendFrame QI to kBlockFrameCID. b=370933 r+sr=bzbarsky 2007-02-24 04:42:53 +00:00
sharparrow1%yahoo.com
4862938c93 Bug 370379: Create views less frequently. Stops creating views for -moz-hidden-unscrollable, opacity, fixed backgrounds, and scrollbars, plus removes some unneeded methods from views and view managers. r+sr=roc. 2007-02-24 00:23:42 +00:00
bzbarsky%mit.edu
997dd25704 deCOMtaminate SetBounds(), GetChildBox(), GetNextBox(), GetParentBox(),
GetVAlign(), GetHAlign().  Remove GetInset().  Bug 243370, patch by Andreas
Lange <anlan@lange.cx>, r+sr=roc
2007-02-22 18:05:14 +00:00
asqueella%gmail.com
d3c60663af fix 370967 - crash when focusing the input of an <isindex> and then reloading the document
(move the (mInputContent)->RemoveEventListenerByIID call from the destructor to Destroy() so that it actually gets called.)
r+sr=roc
2007-02-20 20:25:14 +00:00
bzbarsky%mit.edu
ad75d79f05 Make blocks whose ancestors are not blocks have the NS_BLOCK_MARGIN_ROOT and
NS_BLOCK_SPACE_MGR bits as necessary.  Bug 354600, r+sr=roc
2007-02-18 23:53:25 +00:00
asqueella%gmail.com
284a5ea424 bug 257868 - remove the nsIPresShell::SetAnonymousContentFor() API, make the frames store strong refs to the anonymous content instead. Decomtaminate nsIAnonymousContentCreator.
r+sr=roc
2007-02-18 17:34:09 +00:00
asqueella%gmail.com
e70812ddff bug 370371 - remove nsIImageControlFrame, have the frame set the last clicked point as a property on its mContent instead.
r+sr=roc
2007-02-18 16:49:54 +00:00
martijn.martijn%gmail.com
c4b0d07d4c Bug 336147 � Changing innerHTML for input type=button causes miss-rendering, patch by Ryan Jones, r+sr=roc 2007-02-17 14:14:08 +00:00
joshmoz%gmail.com
ad35697de6 extend nsITheme to support native focus drawing. b=370549 r=dbaron sr=roc 2007-02-16 01:53:43 +00:00
sharparrow1%yahoo.com
db47d007bc Bug 370303: Cleanup in layout/forms. r+sr=roc. 2007-02-15 10:58:31 +00:00
smontagu%smontagu.org
2932d47653 Remove obsolete state bit NS_BLOCK_SHRINK_WRAP. Bug 369243, r=bz, sr=dbaron 2007-02-15 05:07:57 +00:00
joshmoz%gmail.com
12ad810794 cleanup. r+sr=dbaron 2007-02-14 21:00:15 +00:00
sharparrow1%yahoo.com
fc5994f67d Bug 370185: clean up view header includes (trivial). rs=bzbarsky. 2007-02-12 19:31:59 +00:00
sharparrow1%yahoo.com
76a64e5c22 Bug 177805: Fix the use of units in Gecko. r+sr=roc 2007-02-07 07:46:44 +00:00
Olli.Pettay%helsinki.fi
b3361bf8f9 Bug 243370, deCOMtaminate parts of nsIFrame that come from nsIBox, part 2, p=anlan@lange.cx, r+sr=roc 2007-01-31 16:02:42 +00:00
bzbarsky%mit.edu
4fcbe6d913 Remove some no longer needed code. Bug 368273, r+sr=dbaron 2007-01-30 05:52:27 +00:00
cvshook%sicking.cc
a39ff30284 Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128 2007-01-30 00:06:41 +00:00
bzbarsky%mit.edu
baec9bd166 Make mComputedWidth private, with a getter/setter, and make the setter update
the resize flags.  Bug 367442, r+sr=dbaron
2007-01-26 00:05:12 +00:00
dbaron%dbaron.org
f6245f0ed9 Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc 2007-01-23 04:06:56 +00:00
bzbarsky%mit.edu
c563021eab Remove some redundant (but not quite identical, hence asserting) logic. Bug
367587, r+sr=roc
2007-01-22 04:29:35 +00:00
bzbarsky%mit.edu
7a61f6f940 Don't do XUL collapsing stuff with HTML text inputs or HTML scrollframes. Bug
335628, r+sr=roc
2007-01-22 04:27:31 +00:00
bzbarsky%mit.edu
3ef8c518f2 Fix painting of focus outline for empty <select>s. Bug 362995, r+sr=roc 2007-01-17 23:17:30 +00:00
bzbarsky%mit.edu
3f669c3420 Fix the width computations for the dropdown to actually account for the border
and padding.  Bug 365837, r+sr=dbaron
2007-01-11 17:59:41 +00:00
bzbarsky%mit.edu
a5fc5ca803 Notify correctly about legend frames being added -- need to mark all our
ancestors as having a dirty child, not just the immediate ancestor.  Bug
366537, r+sr=dbaron
2007-01-11 17:56:25 +00:00
bzbarsky%mit.edu
5bb5b8f623 deCOMtaminate nsIFrame::GetMinSize/GetPrefSize/GetMaxSize. Bug 243370, patch
by Andreas Lange <anlan@lange.cx>, r+sr=roc
2007-01-08 02:57:59 +00:00
mats.palmgren%bredband.net
3737d80b97 OnChange is sometimes triggered for scripted changes. b=265047 r+sr=jst 2007-01-05 16:31:07 +00:00
jwatt%jwatt.org
bbb6339dc9 Fixing bug 334587. Unify event handling for links and fix various XLink bugs. r=olli.pettay@gmail.com, r=dbaron@mozilla.com, sr=bugmail@sicking.cc 2007-01-04 10:53:59 +00:00
timeless%mozdev.org
4e651390ef Bug 355300 There should be only one nsGkAtoms creature
r=dbaron
2006-12-26 17:47:52 +00:00
dbaron%dbaron.org
2084e073f8 Eliminate nsStyleBorderPadding and add margin/padding/content rect APIs to nsIFrame. b=332922 r+sr=roc 2006-12-20 01:23:45 +00:00
bzbarsky%mit.edu
3688023262 Remove the consumers of GetScrollBarDimensions so that we can work on removing
the API too.  Bug 364301, r+sr=roc
2006-12-19 15:08:34 +00:00
dbaron%dbaron.org
d5af630c22 Better API for used padding/border/margin: remove deprecated Calc*For on nsStyleStructs and add GetUsed* to nsIFrame. b=332922 r+sr=roc 2006-12-13 23:04:57 +00:00
uriber%gmail.com
3faa594f22 Use the containing block's direction (LTR/RTL) instead of this frame's direction when deciding on default alignment of the frame. bug=328181 r+sr=dbaron 2006-12-13 16:16:25 +00:00
roc+%cs.cmu.edu
6c862f2172 Bug 344894. Process mContentFrame before mLegendFrame in nsFieldSetFrame::BuildDisplayList, because mContentFrame might have out-of-flow frames whose placeholders are in mLegendFrame and we always need to visit out-of-flow frames before their placeholders while building display lists. r+sr=dbaron 2006-12-10 21:53:53 +00:00
dbaron%dbaron.org
31f1898810 Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00
mats.palmgren%bredband.net
df6357f4ed Make sure text input onchange handler is called before onblur. b=357684 r=Olli.Pettay sr=bzbarsky 2006-11-28 13:08:23 +00:00
bzbarsky%mit.edu
b856b2c477 Back out bug 354600 to fix regressions. 2006-11-19 20:23:56 +00:00
Olli.Pettay%helsinki.fi
8b6f4c022e Consolidate NS_MOUSE_***_UP/DOWN/CLICK/DBLCLICK events, r=jst,roc,josh,sergei_d,emaijala,mkaply 2006-11-16 21:35:39 +00:00
bzbarsky%mit.edu
cbcaad14b4 Make block frames that are not kids of blocks automatically have space managers
(and margin roots, except in the columns case) so we don't have to play
whack-a-framestate-flag.  Bug 354600, r+sr=roc
2006-11-16 17:51:53 +00:00
bzbarsky%mit.edu
f0ebd23c1e Additional tweak to the patch for bug 355931 -- fix QI too. 2006-11-13 22:20:39 +00:00
bzbarsky%mit.edu
c4e415d4a7 Don't use frames to implement interfaces, dammit. Just don't! Bug 355931, r+sr=roc 2006-11-13 22:05:25 +00:00
masayuki%d-toybox.com
d0d3a21ea2 Bug 359496 focus outline on combobox <select>s is always drawn in black r+sr=dbaron 2006-11-04 17:28:39 +00:00
bzbarsky%mit.edu
1adfb9e915 Fix combobox outlines. Bug 328340, r+sr=dbaron 2006-11-03 00:22:31 +00:00
bzbarsky%mit.edu
618c586548 When setting the textfield value via the filepicker, tell it that it's not
focused so that onchange will fire as it should.  Bug 355362, r+sr=jst
2006-10-15 15:39:35 +00:00
Olli.Pettay%helsinki.fi
e570a5020d Bug 328907, Remove selectHas(No)Groups events, r+sr=sicking 2006-10-03 20:16:51 +00:00
mats.palmgren%bredband.net
c9b7b60dce Make sure we fire onchange also after selectedIndex was set to -1 through DOM. Thanks to Pablo Greco for helping fix this. b=317078 r+sr=roc 2006-09-30 05:07:49 +00:00
bzbarsky%mit.edu
feea3a45cc Reinstate reflow count painting when it's needed. Bug 352851, r+sr=roc 2006-09-19 04:26:20 +00:00
bzbarsky%mit.edu
b7a3c71cc9 Remove the business about not knowing our collapsed state at first. We do know
it, and we're collapsed.  Bug 352394, r=mats, sr=roc
2006-09-14 00:54:44 +00:00
sayrer%gmail.com
9395f31ee3 bug 348669. Remove inappropriate nsCRT::free usage. r=timeless, sr=dbaron 2006-09-08 04:35:17 +00:00
timeless%mozdev.org
97d86b0df2 Bug 106386 Correct misspellings in source code
r=bernd rs=brendan
2006-08-28 20:12:37 +00:00
uriber%gmail.com
f4ebea5c4c When the control is RTL, align the drop-down with the right edge of the control. bug=203353 r=smontagu sr=bzbarsky 2006-08-13 19:34:58 +00:00
Olli.Pettay%helsinki.fi
2cfe84ecc4 Bug 231830, crash on style.display = 'none' for select element when event onchange occurs [@ nsStyleContext::GetRuleNode ][@ nsIFrame::Invalidate ], r+sr=bz 2006-08-11 12:09:30 +00:00
smontagu%smontagu.org
2a6805b2f8 Remove unnecessary hack for right-to-left file inputs. Bug 346726, r=uriber, sr=roc 2006-08-07 06:31:55 +00:00
bzbarsky%mit.edu
5c42810570 Don't convert non-breaking spaces to spaces in text controls. Bug 218277,
patch by jst and jpl24 <jlurz24@gmail.com>, r=bryner, sr=dbaron
2006-08-07 03:27:49 +00:00
pkasting%google.com
2070e797b8 Bug 339127: Add "spellcheck" attribute to control spellchecking.
r=brettw
sr=sicking
2006-07-29 00:04:40 +00:00
Olli.Pettay%helsinki.fi
a24156b7d9 Bug 345600, Crash [@ nsTextInputListener::UpdateTextInputCommands] using onselect and removing textarea, r+sr=roc 2006-07-26 07:58:18 +00:00
aaronleventhal%moonset.net
793d61f079 Bug 241015. Remote XUL is not accessible. Patch by Alexander Surkov. r=aaronlev. Chrome r='s by neil and mano 2006-07-24 16:12:08 +00:00
mats.palmgren%bredband.net
fa2d17a758 Ignore mLegendFrame as previous sibling since it does not live in the content area frame. b=345249 r+sr=bzbarsky 2006-07-20 04:54:51 +00:00
cvshook%sicking.cc
e75ee7f41a Fix error in last checkin for bug 344050. 2006-07-19 08:55:36 +00:00
cvshook%sicking.cc
3a9a287253 Bug 344050: Kill nsITextContent and move the methods to nsIContent. r/sr=jst 2006-07-19 04:36:36 +00:00
uriber%gmail.com
3bef115769 Fix bidi behavior of ctrl+backspace and ctrl+del. bug=344226 r=smontagu sr=roc 2006-07-18 07:28:38 +00:00
sharparrow1%yahoo.com
6bd7f4c9bc Bug 344471: cleanups for checkbox and radio frames. r+sr=roc. 2006-07-13 05:05:54 +00:00
mats.palmgren%bredband.net
47bd18fde6 Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part) 2006-07-06 10:43:51 +00:00
jst%mozilla.jstenback.com
00c06594f0 Fixing bug 313337. Make input control onchange events only fire when the change is made by the user, not by script. r=bzbarsky@mit.edu, sr=bugmail@sicking.cc 2006-07-05 22:15:01 +00:00
mats.palmgren%bredband.net
153ab238ca Fix crash when recreating <caption> frames. Add ASSERTIONs to detect similar frame construction errors in the future. b=341382 r+sr=bzbarsky 2006-06-29 02:32:36 +00:00
roc+%cs.cmu.edu
6b2853f825 Fixing bustage 2006-06-08 03:22:44 +00:00
roc+%cs.cmu.edu
597d8bc582 Bug 339889. Propagate invalidation through the frame hierarchy to topmost widgets. r+sr=bzbarsky 2006-06-08 01:11:43 +00:00
timeless%mozdev.org
a768026fc9 Bug 337917 Make consumers stop using cids from other modules
r=smontagu sr=darin
2006-06-03 23:35:59 +00:00
Olli.Pettay%helsinki.fi
cb1f0a0bb9 Bug 338122, Crash [@ nsIMEStateManager::IsActive] when window gets removed on mousedown at button, r+sr=roc 2006-05-19 10:26:44 +00:00
Olli.Pettay%helsinki.fi
b9c2cdd0a8 Bug 336381, Crash [@ nsRange::InsertNode] involving ranges in detached nodes, r=sicking,glazman,sr=bz 2006-05-15 19:35:12 +00:00
timeless%mozdev.org
8a642d2bf0 Bug 336975 Function: nsIsIndexFrame::GetEncoder does not dereference "encoder" after assigning to *encoder
r=bz sr=bz
2006-05-11 13:23:55 +00:00
darin%meer.net
0318b8c707 landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb 2006-05-10 17:30:15 +00:00
cvshook%sicking.cc
d3ec0aa5c5 Bug 335911: Change nsIContent::IsContentOfType to nsINode::IsNodeOfType. r/sr=bz 2006-05-05 06:52:21 +00:00
aaronleventhal%moonset.net
e4210b85b2 Bug 336162. Don't fire DOM events from layout. r+sr=bz 2006-05-03 17:02:37 +00:00
mrbkap%gmail.com
907b2f702d Only call GetCharCode for KeyPress events to avoid triggering a warning in nsDOMKeyEvent.cpp. bug 309316, r+sr=dbaron 2006-04-29 00:39:03 +00:00
roc+%cs.cmu.edu
aac1b0d44f Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc 2006-04-26 02:01:07 +00:00
bzbarsky%mit.edu
2c105676af Give HTMLButtonControlFrames their own frame type. Bug 335419, r+sr=dbaron 2006-04-25 19:56:45 +00:00
cvshook%sicking.cc
e9a820078f Bug 334977. Separate mFileName from mValue. r/sr=bz 2006-04-25 09:18:42 +00:00
leon.sha%sun.com
0960e6fd1d Bug 333896
Convert GetAttr calls to AttrValueIs and FindAttrValueIn.
Patch by alfred.peng@sun.com.
roc: review+
roc: superreview+
2006-04-24 05:40:11 +00:00
bzbarsky%mit.edu
0104eded40 Handle our single focused option being removed. Bug 325321, r=roc, sr=dbaron 2006-04-20 02:37:31 +00:00
roc+%cs.cmu.edu
22c06ad594 Bug 333817. Give listbox focus display item correct bounds. r+sr=bzbarsky 2006-04-18 02:41:42 +00:00
roc+%cs.cmu.edu
a7f03736a9 Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc 2006-04-10 00:16:29 +00:00
dbaron%dbaron.org
04b8c33eda Remove uses of MOZ_DECL_CTOR_COUNTER, which is always defined to nothing. b=332745 rs=roc,bzbarsky 2006-04-05 00:00:44 +00:00
bzbarsky%mit.edu
43bcb1c2fe Make sure to not use a localized label if the value is explicitly set to the
empty string.  Bug 330469, r+sr=sicking
2006-04-04 22:34:10 +00:00
roc+%cs.cmu.edu
0a10a79f62 Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc 2006-03-26 21:30:36 +00:00
Olli.Pettay%helsinki.fi
ee372ff167 Bug 330710, Replace obsolete preventBubble/preventCapture with stopPropagation, r=neil, r=mconnor, sr=jst 2006-03-25 22:03:49 +00:00
cvshook%sicking.cc
1b3207b1d5 Relanding patches that (hopefully) don't affect Tdhtml 2006-03-24 00:09:50 +00:00
cvshook%sicking.cc
e26140ab7d Back out a few of my patches to see if any caused the Tdhtml regression in bug 331364. 2006-03-23 08:21:21 +00:00
bzbarsky%mit.edu
4b74ae14f8 Fix crash bug 322348 by making ReParentStyleContext more sane. r+sr=dbaron 2006-03-16 01:30:38 +00:00
dbaron%dbaron.org
c37d9a2cf3 Change our scrolling code so that it is capable of scrolling above and to the left of the viewport, and then use that capability for nsHTMLScrollFrames with RTL directionality. This removes the invariant that the child of a scrollframe (::scrolled-canvas canvas or ::scrolled-content block) will be stretched to fill the entire scrollable area and stops enforcing it, a change that's likely to cause some regressions not yet fixed within the patch. This also fixes directionality detection for the scrollframe holding the canvas (changing which side the scrollbar appears on) and fixes an old bug in the code that paints the focus ring around the canvas (so it's now again visible on all sides, even when the canvas is scrollable). b=192767 r+sr=roc 2006-03-15 16:55:19 +00:00
pavlov%pavlov.net
131e8794e2 backing out roc's patch for bug 328926 due to crash running tests on vc8 machines. 2006-03-15 06:43:36 +00:00
roc+%cs.cmu.edu
557b089a47 Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc 2006-03-15 03:14:02 +00:00
roc+%cs.cmu.edu
4a3998fc32 Fixing bustage 2006-03-14 21:02:42 +00:00
roc+%cs.cmu.edu
6fd863f2dd Bug 330300. Move mFrame from nsDisplayItem subclasses up to nsDisplayItem itself, and make GetUnderlyingFrame an inline non-virtual function. Patch by Alfred Peng, r+sr=roc 2006-03-14 20:43:18 +00:00
roc+%cs.cmu.edu
514265e536 Bug 329465. Don't hold a strong ref to the event queue service from nsComboboxControlFrame. r+sr=roc, patch by Marc Liddell. 2006-03-09 19:24:54 +00:00
roc+%cs.cmu.edu
c2801ebbd7 Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell 2006-03-09 18:55:21 +00:00
cvshook%sicking.cc
de7a063b91 Bug 325426: Only use baseURI to resolve relative uris. r=bz sr=jst 2006-03-08 05:01:16 +00:00
Olli.Pettay%helsinki.fi
f79ea0115b Bug 234455, Centralize event dispatch r=jst, sr=bz 2006-03-07 17:08:51 +00:00
roc+%cs.cmu.edu
fe8a1f2ea2 Bug 328898. deCOMtaminate signatures on nsIListControlFrame.h. Patch by Marc Liddell, r+sr=roc 2006-03-01 01:00:29 +00:00
roc+%cs.cmu.edu
1fac9c6d76 Backing out changes for bug 326944, really this time\! 2006-02-27 04:13:51 +00:00
roc+%cs.cmu.edu
e1862a3c80 Putting nsIComboboxControlFrame.h back in preparation to revert checkin for bug 326944. 2006-02-27 03:20:30 +00:00
roc+%cs.cmu.edu
9f17ed46e8 Bug 326944. Remove nsIComboboxControlFrame. r+sr=roc, patch by Marc Liddell 2006-02-27 02:45:20 +00:00
roc+%cs.cmu.edu
b7126ee8e0 Bug 326944. Remove nsIComboboxControlFrame. r+sr=roc, patch by Marc Liddell 2006-02-27 02:33:26 +00:00
timeless%mozdev.org
426f83aecc Bug 298277 remove useless references to nsVoidArray
r=dbaron sr=dbaron
2006-02-23 10:30:59 +00:00
sharparrow1%yahoo.com
aa0cb36648 Trivial; attempt to fix linux bustage 2006-02-21 01:27:11 +00:00
sharparrow1%yahoo.com
eb67fd0b3d Bug 327868: nsIFrameSelection cleanup. r+sr=roc 2006-02-21 00:49:04 +00:00
roc+%cs.cmu.edu
62c2f9c90b Bug 326827. Don't allow mouse events to target button contents. r+sr=dbaron 2006-02-19 20:14:11 +00:00
sharparrow1%yahoo.com
4b04b00311 Bug 326843 DeCOMtaminate some of nsComboboxControlFrame. Patch by marcldl+mozbugs@gmail.com. r+sr=roc. 2006-02-18 01:52:03 +00:00
sharparrow1%yahoo.com
eb31b955a4 Bug 326883 - Cleanup unused methods. r+sr=roc 2006-02-16 00:30:29 +00:00
bzbarsky%mit.edu
1e868102bd Use GetValue() instead of GetAttr(nsGkAtoms::value) for getting the button
value.  And make the value determination consistent for initial and
value-changed.  Bug 326250, r=sicking, sr=roc
2006-02-13 19:42:08 +00:00
bzbarsky%mit.edu
504bb277ba More usage of already_AddRefed. Fix leaks too. Bug 325378, r=sicking, sr=jst 2006-02-09 16:23:32 +00:00
bzbarsky%mit.edu
0345a6719d Make it possible to enable spell-check for text inputs too (not just
textareas).  Make the pref controlling the whole thing live.  Bug 151040, patch
by Julian Pellico <jpellico@yahoo.com>, r=bzbarsky, sr=bryner
2006-02-09 03:50:53 +00:00
dbaron%dbaron.org
00eb53b26a Remove old native widget code that we were only keeping around for viewer. b=326417 r+sr=roc 2006-02-08 20:09:19 +00:00
bzbarsky%mit.edu
eee69b1bb3 Add comment as promised; still bug 326019. 2006-02-06 22:27:58 +00:00
bzbarsky%mit.edu
ef908b8b14 Fix bug 326019. r+sr=roc 2006-02-06 22:08:10 +00:00
bzbarsky%mit.edu
73e9a89031 Make sure to always produce our value. Bug 324377, r+sr=roc 2006-02-03 18:45:01 +00:00
cbiesinger%web.de
c2d981f764 bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones
r+sr=darin
2006-02-03 14:18:39 +00:00
bzbarsky%mit.edu
f96a096c2c Fix leak bug 324969 -- make sure to call virtual destructors. 2006-01-29 18:48:58 +00:00
roc+%cs.cmu.edu
fa09c4074a Bug 324852. Clean up missing uses of NS_DISPLAY_DECL_NAME for a tiny space saving with frame display lists 2006-01-26 22:58:22 +00:00
roc+%cs.cmu.edu
77bca74243 Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others 2006-01-26 02:29:17 +00:00
roc+%cs.cmu.edu
c91034f873 Bug 323946. nsFieldSetFrame doesn't need to support having a space manager. r+sr=dbaron 2006-01-22 23:20:56 +00:00
cvshook%sicking.cc
15c2397445 Bug 323910: Merge atom lists in gklayout
r/sr=jst
2006-01-19 00:58:12 +00:00
bmlk%gmx.de
e84cd27fac Avoid reframing inside button frames and move the frame creation entirely into the frame constructor, bug 51767, r=mats sr=roc 2006-01-13 07:58:12 +00:00
joshmoz%gmail.com
10ce46bcd5 Enable popup windows in Cocoa widgets. This puts 2 app-specific ifdefs in tier 9 code, but we plan to take care of those soon. We can use a pref so that the same binary can serve the needs of Camino and other Cocoa widget consumers. b=316076 r=mento sr=pinkerton 2006-01-11 19:09:20 +00:00
cvshook%sicking.cc
7db01c8d27 Bug 321294: Remove unused ReplaceFrame codepaths.
r/sr=roc
2006-01-10 22:58:37 +00:00
bzbarsky%mit.edu
199fb02ff4 Make sure to return in the error condition, not just pop the JSContext stack
and continue.  Bug 321494, r=sicking, sr=brendan
2006-01-06 23:32:21 +00:00
dbaron%dbaron.org
12dbe4ba1a Give the extra reflow state a correct parent so it doesn't confuse the auto-offset code. b=317502 r+sr=roc 2005-12-21 03:31:47 +00:00
mrbkap%gmail.com
4bad6f49dc bug 315752: Crashes and assertions happening in DoDeletingFrameSubtree when <select>s are in the air. The fix is to make DoCleanupFrameReferences clean up additional child lists. Patch by bzbarsky. r=roc/mats/mrbkap sr=roc 2005-12-20 02:06:14 +00:00
roc+%cs.cmu.edu
18647b7ec2 Bug 320337. Remove mFrameConstructor member from nsListBoxBodyFrame. patch by Vidar Harr, r+sr=roc 2005-12-16 02:56:36 +00:00
roc+%cs.cmu.edu
06dd46b7c7 Fixing bustage 2005-12-13 00:57:56 +00:00
roc+%cs.cmu.edu
b65c655ed9 Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc 2005-12-12 23:53:06 +00:00
bzbarsky%mit.edu
f9bea49aa1 Remove the mGoodToGo goop. Its main effect seems to be to cause crashes when
HTML <select>s are used in XUL.  Bug 319796, r+sr=roc
2005-12-11 20:45:58 +00:00
bzbarsky%mit.edu
88a01f50af Fix crash bug 282707. Patch by Mats Palmgren <mats.palmgren@bredband.net>, r+sr=bzbarsky 2005-12-08 19:01:20 +00:00
bzbarsky%mit.edu
5c508f5e01 Remove no longer needed event hack. Bug 146399, patch by Vidar Haarr
<vhaarr+bmo@gmail.com>, r=dbaron, sr=rbs
2005-12-08 01:44:30 +00:00
roc+%cs.cmu.edu
a710fcd15d Bug 316281. Rework GetContentAndOffsetsFromPoint. r=uriber,sr=roc,patch by Eli Friedman 2005-12-07 23:08:39 +00:00
bzbarsky%mit.edu
8fa76d37ac Don't store the "normal" frame state for the root scrollframe, for now. Bug
318709, r+sr=roc
2005-12-06 23:56:17 +00:00
brettw%gmail.com
b9193728c5 Bug 302050: inline spellchecking for textboxes backend. r=bryner sr=bzbarsky 2005-12-05 18:07:33 +00:00
neil%parkwaycc.co.uk
0d29adadea Bug 317937 Get rid of some unnecessary CIDs and change some possibly unsafe nsCOMPtr usage into the equivalently unsafe static casts r=darin sr=jst 2005-12-02 12:02:44 +00:00
jst%mozilla.jstenback.com
8f1863159b Fixing bug 316794. Moving HandleDOMEvent() and Get/SetDocShell from nsIScriptGlobalObject to nsPIDOMWindow. r=mrbkap@gmail.com, sr=peterv@propagandism.org 2005-11-28 23:56:44 +00:00
bzbarsky%mit.edu
994feafbae Treat inline and block buttons more uniformly. Bug 304004, r+sr=dbaron 2005-11-22 23:39:48 +00:00
timeless%mozdev.org
1c34e68034 Bug 106386 Correct misspellings in source code
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
2005-11-20 22:05:24 +00:00
bzbarsky%mit.edu
0f66d83269 Relanding bug 305705. Patch still by mats, r+sr=me. 2005-11-15 04:03:08 +00:00
bzbarsky%mit.edu
a946ffec4a Back out bug 305705 to test performance impact. 2005-11-15 02:16:25 +00:00
bzbarsky%mit.edu
3608df15a6 Make sure to do a constrained reflow after having done an unconstrained one.
Bug 305705, patch by Mats Palmgren <mats.palmgren@bredband.net>, r+sr=bzbarsky
2005-11-14 21:51:17 +00:00
bsmedberg%covad.net
78f6d0683d Bug 313309 part 2 - change the NS_DEFINE_STATIC_IID_ACCESSOR macro to NS_DECLARE, and make a NS_DEFINE_ macro that's outside the class declaration, r=shaver 2005-11-11 14:36:26 +00:00
bzbarsky%mit.edu
27c439cb3c Remove the dummy frame stuff from selects. Replace it with smarter focus rect
painting and sizing for empty selects.  Bug 314879, r+sr=dbaron
2005-11-04 23:36:27 +00:00
roc+%cs.cmu.edu
520b30a7f7 Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell 2005-11-04 02:38:33 +00:00
roc+%cs.cmu.edu
a5f65bfee7 Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell 2005-11-01 20:40:54 +00:00