Filippos Karapetis
d76fe85af4
LAB: Prevent duplicate processing of input
2016-01-11 01:50:11 +02:00
Filippos Karapetis
38df43fe55
LAB: Prevent excessive screen updates when checking for events
2016-01-11 01:50:10 +02:00
Torbjörn Andersson
e5189bad67
LAB: Initialise _displayBuffer to silence Valgrind warning
...
Otherwise, its contents will be undefined on the first screen
update. That could probably be fixed by introducing some sort of
"dirty rect" mechanism, but I don't think it's a bad idea to
initialise it regardless.
2015-12-31 10:58:09 +01:00
Filippos Karapetis
a7959a4ed4
LAB: Remove superfluous mouse show/hide calls
...
Our mouse cursor is drawn in a separate layer, so we can draw on the
screen without needing to hide it beforehand
2015-12-27 22:50:09 +02:00
Filippos Karapetis
c5f5fbc208
LAB: Refactor the music code
2015-12-27 21:16:43 +02:00
Willem Jan Palenstijn
a49ffcd87b
LAB: Remove some unnecessary casts
2015-12-27 13:52:34 +01:00
Willem Jan Palenstijn
90ac7a2bcb
LAB: Clean up Image._imageData memory handling
2015-12-26 21:59:10 +01:00
Strangerke
ce81ddbb4e
LAB: Rename 'im' to 'img' for naming consistency
2015-12-26 20:32:29 +01:00
Strangerke
2560fdb191
LAB: Make private some DispMan functions and variables, some renaming
2015-12-26 14:27:53 +01:00
Willem Jan Palenstijn
ae519716a2
Merge branch 'master' of github.com:scummvm/scummvm
2015-12-26 14:20:15 +01:00
Willem Jan Palenstijn
01d99d213d
LAB: Reduce passing around of pointers to the near-global _closeDataPtr
2015-12-26 14:18:44 +01:00
Strangerke
07b554b847
LAB: Add an access function to make _headerData a private member of Anim
2015-12-26 13:53:11 +01:00
Filippos Karapetis
0b9126f774
LAB: Remove superfluous sound effect stopping code
2015-12-26 12:42:45 +02:00
Filippos Karapetis
d3369808f5
LAB: Document where some scene transitions are used
2015-12-26 12:39:18 +02:00
Filippos Karapetis
a5553b3197
Use Common::Keycode and enums in interface buttons
2015-12-24 19:12:02 +02:00
Filippos Karapetis
19303c49cf
LAB: Rename closeFont() to freeFont()
2015-12-24 18:30:54 +02:00
Willem Jan Palenstijn
d98d39c315
LAB: Move dispBitMap to Anim
2015-12-24 16:51:02 +01:00
Willem Jan Palenstijn
dacbf9881c
LAB: Make _dispBitmap handling more explicit
2015-12-24 16:16:48 +01:00
Willem Jan Palenstijn
442c1538a2
LAB: Clean up diff chunk handling
2015-12-24 16:02:22 +01:00
Willem Jan Palenstijn
82c610d160
LAB: Remove now-unused variable
2015-12-24 15:32:24 +01:00
Willem Jan Palenstijn
a08dd694e5
LAB: Improve whitespace handling in flowText
...
flowText was handling presence/absence of whitespace after lines
inconsistently. This caused end-of-string to be missed, which broke
last-page detection in the journal. It also introduced extra spaces at the
beginning of pages.
2015-12-24 15:27:48 +01:00
Filippos Karapetis
f8bf5ed867
LAB: Simplify flowText() a bit
...
Since the extra image buffer is only used in one place, we can save
ourselves one assignment
2015-12-24 13:07:18 +02:00
Filippos Karapetis
4b3e671de5
LAB: Merge flowTextToMem() inside flowText()
2015-12-24 12:27:56 +02:00
Filippos Karapetis
7216bddd56
LAB: Merge setPen() into rectFill()
2015-12-24 12:08:51 +02:00
Strangerke
1206fe22b8
LAB: Fix out of bound in writeColorRegs
2015-12-24 08:30:50 +01:00
Strangerke
746f494c85
LAB: Fix bug in doTransWipe
2015-12-24 08:10:30 +01:00
Strangerke
997150e76e
LAB: Change the initial valueof _screenBytesPerPage, use it in Journal functions
2015-12-24 01:12:39 +01:00
Filippos Karapetis
6f6c92d470
LAB: Prevent the Image destructor from deleting the drawing buffer
2015-12-24 01:32:22 +02:00
Filippos Karapetis
7a7a25c91d
LAB: The maxHeight parameter of readPict() is no longer used
2015-12-24 01:32:22 +02:00
Filippos Karapetis
7c33862a09
LAB: The second parameter of fade() is always 0
2015-12-24 00:44:16 +02:00
Filippos Karapetis
52c7fcbfe5
LAB: Rename overlayRect() to checkerboardEffect()
2015-12-23 21:43:17 +01:00
Filippos Karapetis
5327b6f545
LAB: Use byte instead of char in overlayRect()
...
This matches the idea that colors are in range of 0 - 255. Thanks to
LordHoto
2015-12-23 21:43:17 +01:00
Filippos Karapetis
60f7849c20
LAB: Improve the palette assignment in writeColorRegs()
...
Thanks to LordHoto
2015-12-23 21:43:17 +01:00
Filippos Karapetis
c66d5eca3a
LAB: setAmigaPal() is always using 16 colors
2015-12-23 21:43:17 +01:00
Filippos Karapetis
29d85c8d50
LAB: Use int in for loops, instead of uint16
2015-12-23 21:43:17 +01:00
Filippos Karapetis
9dae9eb811
LAB: Implement the scroll buffer of doScrollWipe() and doScrollBounce()
...
This was left out from previous refactoring. Also, simplify
doScrollBounce()
2015-12-23 21:43:17 +01:00
Strangerke
34b59256fc
LAB: Replace g_system by _system
2015-12-23 21:43:16 +01:00
Filippos Karapetis
8de38a8d10
LAB: Greatly simplify doScrollBlack() using scrollDisplayY()
...
This also fixes a crash when crossing the street
2015-12-23 21:43:16 +01:00
Filippos Karapetis
7a81e03b25
LAB: Prevent the Image destructor from deleting external scroll buffers
2015-12-23 21:43:16 +01:00
Filippos Karapetis
f7395ba0ab
LAB: Rewrite the action message functionality (_doNotShowMessage)
2015-12-23 21:43:16 +01:00
Filippos Karapetis
f59ccf534c
LAB: Get rid of the _doNotDrawMessage hack (from the original)
...
This is actually a nasty hack in the original to avoid duplicate
messages, but it ended up hiding some game messages. This hack isn't
really necessary at all for game functionality, so it has been
removed, without any notable side-effects
2015-12-23 21:35:35 +01:00
Strangerke
be4c436dca
LAB: Move event update functions out of updateMusic
2015-12-23 21:35:34 +01:00
Strangerke
fa222f0ca8
LAB: Make string check more readable, remove a useless c_str()
2015-12-23 21:35:32 +01:00
Strangerke
2eeb027604
LAB: Revert previous commit as suggested by wjp
2015-12-23 21:35:32 +01:00
Strangerke
eba44d3094
LAB: Close _curBitmap before deleting it
2015-12-23 21:35:32 +01:00
Strangerke
b53735ba06
LAB: Constify some parameters
2015-12-23 21:35:32 +01:00
Strangerke
cff1f99b26
LAB: Set a default to the second parameter of readPict
2015-12-23 21:35:32 +01:00
Strangerke
4dfc428bac
LAB: Some cleanup and refactoring
2015-12-23 21:35:32 +01:00
Strangerke
cc039ef113
LAB: Fix crash in intro
2015-12-23 21:35:32 +01:00
Strangerke
7e047b45b7
LAB: Fix a delete[] pointed out by eriktorbjorn
2015-12-23 21:35:31 +01:00