The contained data corresponds to Revolution's original assembly sources, scummvm's initial file contained one incorrect reference.
This will stop Officer Blunt from swimming in the lake without any further sideeffects.
This is the corresponding source change to create a fixed sky.cpt binary. The binary is exactly the same as the manually patched one attached to the bug ticket.
In order to fix the bug while beint least invasive, I suggest replacing the binaries (the one from the ticket should be the new, official binary) and we will put a workaround in the code anyways to deal correctly with potentially outdated binaries floating around the web and linux distributions.
The error was initially introduced with the long term conversion of Revolution's assembly sources to C++ sources, then to textual resource data and then a precompiled binary.
The EGA version of Gobliiins, similar to Little Red Riding Hood,
claims a few resources are larger than they actually are. The original
happily reads past the resource structure, but we'll instead fix
the size of the resource after loading.
This fixes bug #7162.
The delay occurred when trying to interrupt the animation while at
the start of the first scene with Igor. After the interruption (skipping
the intro, return to launcher or quitting ScummVM) it would continue
to play the animation for a bit longer than necessary.
GCC 6's -Wmisleading-indentation warns about the debugC() statement
being wrongly indented, as if belonging into the else's branch, which
it clearly doesn't.
I tried to cover most of the things that seem to be interesting
for the end user. I excluded the SCI32 stuff because a) it's not
officially supported and b) I don't have the slightest clue what
most of the changes to the SCI32 engine do. :)
Please excuse if you made a noteworthy contribution I missed
to mention in this NEWS update. It was not on purpose.
Some games load palettes that include color 255, but this is
hardcoded to white in SSCI, so just ignore it during merges since
it is ignored when the hardware palette is updated anyway.
Avoid forcing the screen to refresh after a palette change if the
screen is also about to be drawn to, as the palette change + draw
is intended to be an atomic operation.
Changes theme stx files to specify TabWidget's type. That fixes wrong TabWidget height.
Changes TabWidget's getHeight() to return not only "children" height, but also tabs height. That fixes wrong clipping area.
Changes Widget's findWidget to use getHeight(). That fixes bug when widgets in the bottom of TabWidget were not reacting to the mouse events.
Subtitle box should now always use color 255, which should be
white all the time. Normally it uses color 7, which is white
most of the time, but for example pink/purple at the start of
chapter 5.
With the addition of the transparent pic type code, the _type
property would be read uninitialised by setType if _pictureId was
set to kPlanePic.
CID 1357230, 1357231.
