libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2025-02-24 05:01:43 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
16,681 Commits 6 Branches 5 Tags
Commit Graph

16681 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Torbjörn Andersson
59b6f0f715 Fixed a potential bug that could cause memory to be read out-of-bounds. 
(Unfortunately, this does not fix the Kyra bug I'm looking for.)

In the most extreme case:

* DR and RR will point to &DR_TABLE[60], and AR will point to &AR_TABLE[60]
* SLOT->KSR will be 0
* CH->kcode will be 15

In that case, it will attempt to access AR[15], RR[15] and DR[15], i.e.
AR_TABLE[75] and DR_TABLE[75]. So these arrays need to be 76 elements, not 75.

We used to initialise element 75, but this was changed to 74 to match the size
of the arrays. Buf if my reasoning is correct, it was the arrays that were too
small.

svn-id: r21301
 2006-03-14 20:09:32 +00:00
Johannes Schickel
c12a5a35be - Deletes wrong spaces in debugC calls in resource.cpp 
- Adds support for amiga .pak files (and a filelist)

svn-id: r21299
 2006-03-14 19:48:08 +00:00
Torbjörn Andersson
ee6f7626bf Fix typo in comment. 
svn-id: r21298
 2006-03-14 19:08:09 +00:00
Max Horn
e6f329e3fc To the best of my knowledge, it's really 'C64' and not 'C-64' 
svn-id: r21296
 2006-03-14 15:36:04 +00:00
Max Horn
f319865837 Merged two consecutive 'if's with identical condition 
svn-id: r21295
 2006-03-14 15:25:29 +00:00
Johannes Schickel
fa4471fae4 - Fixes a bug in update_primaryEffect (wrong sound from the birds outside brandons home is fixed with this) 
- Changes _tempo, tempo, position, unk41, unk32, unk18, unk19, _unkValue3 to unsigned (should be correct this time)

svn-id: r21293
 2006-03-14 15:15:04 +00:00
Max Horn
3582efc5d2 Fixes for the DC backends (see patch #1436898) 
svn-id: r21292
 2006-03-14 14:52:36 +00:00
Max Horn
0a3e4f04e5 Use SDL_GetError in an attempt to display slightly more information about the reason(s) SDL_SetVideoMode failed 
svn-id: r21291
 2006-03-14 14:37:13 +00:00
Johannes Schickel
a68e8c2db9 Fixes wrong sound then showing the death screen. 
svn-id: r21290
 2006-03-14 14:25:13 +00:00
Travis Howell
68bc8ea52e Update comment about use of procC64 by C-64 version 
svn-id: r21289
 2006-03-14 14:10:33 +00:00
Max Horn
0cc41c7cbb Renamed & documented the LIGHTMODE flags 
svn-id: r21288
 2006-03-14 14:06:44 +00:00
Johannes Schickel
9673573bec Fixes _unkTables, I made a mistake while extracting those last time it seems. 
svn-id: r21287
 2006-03-14 13:37:15 +00:00
Max Horn
ee087df293 Enhance the new getCurrentLights to work for V6+ games, too, making it possible to remove several special cases throughout the code 
svn-id: r21286
 2006-03-14 13:36:13 +00:00
Max Horn
ab1694aef9 Compute the full game title when detecting games & creating engine instances, and also use that for savegames (all for debugging) 
svn-id: r21285
 2006-03-14 13:28:28 +00:00
Max Horn
d68b64184e Add a virtual destructor to class SoundDriver of the CINE engine (fixes a warning) 
svn-id: r21284
 2006-03-14 13:26:06 +00:00
Travis Howell
4f10a71b98 An actor is completely reset by showActor() in SCUMM1-2 games. Fixes bug #902391 
svn-id: r21283
 2006-03-14 13:16:11 +00:00
Oystein Eftevaag
53c5b8cf47 Actually, removing the --disable-altivec from the 
help output, it is potentially only useful in very specific
situations.

svn-id: r21282
 2006-03-14 12:26:48 +00:00
Travis Howell
4b1e03f37a Remove unused var, to prevent compiler warning 
svn-id: r21281
 2006-03-14 12:19:17 +00:00
Oystein Eftevaag
c3d8674a26 Adds support for building on Intel Macs, using a modified 
version of patch 1448395 by Aubin and some of my 
own changes.

Notably:
* Two elements of a struct in backends/midi/quicktime.cpp
needed to be forced to BE.
* NASM set to build Mach-O binaries
* configure now checks for Altivec support on Darwin hosts,
instead of assuming it. Altivec support can also be disabled (not 100% sure if t
his is actually needed, but might be handy for crosscompiling).
* The aliasing of the symbols contained in the .asm files
done on Windows were also needed on MacOS.

Note that while the asm code is properly compiled and linked
in, HQ2/3x support will still not work properly on Intel macs
if NASM is enabled.

svn-id: r21280
 2006-03-14 12:18:04 +00:00
Travis Howell
c822f49676 Remove unused vars, to prevent compiler warnings 
svn-id: r21279
 2006-03-14 12:13:27 +00:00
Travis Howell
3d0e69a495 Adjust one last spot, for previous VAR_CURRENT_LIGHTS changes 
svn-id: r21278
 2006-03-14 12:11:16 +00:00
Travis Howell
be7a28f65e Avoid all scumm var conflicts in C64 maniac 
svn-id: r21277
 2006-03-14 12:06:37 +00:00
Travis Howell
806ee522d1 Move unused scumm vars in C64 maniac to safe position, to prevent conflicts for now 
svn-id: r21276
 2006-03-14 10:35:01 +00:00
Torbjörn Andersson
660c23ba3f Updated comment with more circumstantial evidence that the low-frequency note 
bug is a bug in our fmopl.cpp. Ken Silverman's Adlib emulator doesn't seem to
exhibit the bug either. (But is apparently less feature complete than MAME's.)

svn-id: r21275
 2006-03-14 09:55:41 +00:00
Travis Howell
f6d69c6d45 Camera scrolling only effects subtitles in SCUMM4-6 games. Fixes bug #1329482. 
svn-id: r21274
 2006-03-14 09:33:37 +00:00
Travis Howell
c196543572 Fix regression in C64 zak, script 5 was not been run when room changed 
svn-id: r21273
 2006-03-14 07:45:46 +00:00
Eugene Sandulenko
a483083f35 Tweaked a little scumm main dialog and scumm save/load dialog. Still plenty 
to do.

svn-id: r21271
 2006-03-14 03:52:29 +00:00
Eugene Sandulenko
60793c0e64 Positioned logo properly, added different version number rendering and 
got rid of antialiasing artifacts

svn-id: r21270
 2006-03-14 03:08:14 +00:00
Eugene Sandulenko
b45dcc4df3 Fix logo drawing. 
svn-id: r21269
 2006-03-14 02:55:54 +00:00
Eugene Sandulenko
c9970b78b5 Rearrange launcher. 
Logo is still shown weirdly.

svn-id: r21268
 2006-03-14 02:19:38 +00:00
Torbjörn Andersson
784728bf8d Further clarifications to the comment about the "low-frequency notes at 
beginning of music" bugs. As an experiment, I tried hooking up ScummVM with the
most recent version of the FMOPL code, and the bug went away.

Unfortunately, I believe we are stuck with the ancient version for license (and
performance?) reasons.

svn-id: r21267
 2006-03-13 23:53:15 +00:00
Eugene Sandulenko
94f5bd81ad Fix Chooser dialog. 
svn-id: r21266
 2006-03-13 23:18:22 +00:00
Torbjörn Andersson
221263e275 Cleaned up the comments in unkOutput2(), and added a big note about the bug 
where low-frequent noises are playing at the beginning of some new sounds.

svn-id: r21265
 2006-03-13 23:05:11 +00:00
Lars Persson
d66d7ff76b Changed type for samplesleft in order for MIN macro to work properly on all platforms 
svn-id: r21264
 2006-03-13 21:38:20 +00:00
Johannes Schickel
ccd0a09f7a - Fixed regression when moving waitTicks to delay (removes wrongly drawn shapes and wrongly call of the kyragame fading in the outro) 
- Removes a new line from a warning in seqplayer.cpp

svn-id: r21263
 2006-03-13 17:19:19 +00:00
Torbjörn Andersson
9399a2b58e Things continue to fall into place. In other words, more renamings: 
unk3  -> spacing1
unk7  -> spacing2
unk12 -> fractionalSpacing

updateCallback4()  -> update_setNoteSpacing()
updateCallback9()  -> update_stopChannel()
updateCallback15() -> update_stopOtherChannel()
updateCallback17() -> update_setupInstrument()
updateCallback28() -> update_setFractionalNoteSpacing()
updateCallback43() -> update_nop1()
updateCallback47() -> update_nop2()

svn-id: r21261
 2006-03-13 13:56:19 +00:00
Travis Howell
71a7754a37 Fix a valgrind warning 
svn-id: r21260
 2006-03-13 11:58:01 +00:00
Torbjörn Andersson
480aee83aa I was going to hold off on this until the "Pool of Sorrow" music had been fixed 
but it seems that it drifts out of sync after a few repeats even with the
original interpreter. It's a feature!

This cleanup clears up some of the more confusing break/continues in the
callbackProcess() function, and gets rid of _continueFlag.

svn-id: r21259
 2006-03-13 11:57:09 +00:00
Travis Howell
b8cf88622b Fix a few valgrind warnings 
svn-id: r21258
 2006-03-13 11:52:16 +00:00
Paul Gilbert
c5d90e026f Fix to remove warning on validating frame offsets in animation decoder 
svn-id: r21257
 2006-03-13 11:40:40 +00:00
Paul Gilbert
c44069fdfc Added further disassembly of animation decoder routine 
svn-id: r21256
 2006-03-13 11:33:17 +00:00
Paul Gilbert
3c303c0dfd Add proper handling for animations with frame offset tables during decoding 
svn-id: r21255
 2006-03-13 11:20:58 +00:00
Paul Gilbert
92eb7b7aa5 Changed temp variable from byte to word to fix decoding of some animation resources 
svn-id: r21254
 2006-03-13 11:18:18 +00:00
Travis Howell
c6082389a2 Confirmed it is safe to remove workaround for Macintosh HE99 version of water. 
svn-id: r21253
 2006-03-13 10:00:10 +00:00
Travis Howell
8f8d7b6e07 Add opcode difference in setObjectName opcode for C64 maniac 
svn-id: r21251
 2006-03-13 07:46:54 +00:00
Travis Howell
06dddefe90 Add masking support for C64 maniac, not perfect 
svn-id: r21250
 2006-03-13 06:06:51 +00:00
Travis Howell
833e343059 Fix object glitches in C64 maniac 
svn-id: r21249
 2006-03-13 03:52:26 +00:00
Travis Howell
d0f834ee40 Update and restore old debug code for masking 
svn-id: r21248
 2006-03-13 02:22:22 +00:00
Torbjörn Andersson
1d439592dd Until now, we have confusingly used the terms "state" or "table" where we 
really mean "channel". Fixed that:

OutputState     -> Channel
_curTable       -> _curChannel
_outputTables[] -> _channels[]

The biggest change was modifying all the "state" and "table" local variables
and function parameters.

Ahd, at no extra charge:

_outputTable[]  -> _regOffset[]

svn-id: r21247
 2006-03-12 23:21:01 +00:00
Torbjörn Andersson
2ab85f9ea6 Renamed callback1 to primaryEffect and callback2 to secondaryEffect. 
svn-id: r21246
 2006-03-12 22:47:51 +00:00