Christoph Mallon
e35b4f20c1
GRAPHICS: Simplify the interface of Graphics::loadThumbnail().
...
Now it returns the Surface, so the caller does not need to create one and pass it.
2011-08-07 15:19:09 +02:00
Christoph Mallon
0e6751372a
SCI: Simplify allocation of ResourceManager.
2011-08-07 15:19:08 +02:00
Christoph Mallon
f3afb32ee6
SCI: Remove unnecessary cast.
2011-08-07 15:19:08 +02:00
Christoph Mallon
23a0f5318c
JANITORIAL: Remove trailing empty lines.
2011-08-07 13:53:33 +02:00
Eugene Sandulenko
78f1ea7690
OSYSTEM: extended installTimerProc() with timer ID parameter
2011-08-06 11:28:35 +01:00
Willem Jan Palenstijn
85a056f382
SCI: Fix kFormat's handling of %c with a 0 argument
...
SSCI used a sprintf to handle %c, appending the result to the output,
which is effectively a nop for a zero argument.
This is bug #3368821 . Thanks to digitall for tracing it to KFormat
and testing this patch.
2011-07-18 23:36:56 +02:00
Willem Jan Palenstijn
3e38e6e221
SCI: Restore deleted LSL6 workaround for crash on loading
...
This was probably accidentally removed in
194081e7ae
. The TODO/CHECKME on it still
applies. Reported in bug #3366329 .
2011-07-13 22:43:21 +02:00
D G Turner
6355ccc677
SCI: Added Missing Detection Entry for "Slater And Charlie Go Camping"
...
This should fix bug #3359182 ("Game not found by 1.3.0")
2011-07-10 03:51:06 +01:00
Filippos Karapetis
72da8ef5ad
SCI: Applied patch #3357096 with minor modifications
...
This prevents a string pointer from getting invalidated under some
circumstances in kString(Dup).
Thanks to lephilousophe for the patch.
2011-07-07 03:43:06 +03:00
Johannes Schickel
933ee5b156
GRAPHICS: Remove default values from FontSJIS::drawChar.
...
drawChar is overloaded in FontSJIS. One takes a "Surface &" as first
parameter another one "void *", they furthermore have the exact same
number of required parameters. The one "void *" just had a few extra
parameters with default values. This resulted in a bug in SCUMM, where
"VirtScreen *" (a subclass of Surface) was passed instead of "VirtScreen &"
and thus the method taking "void *" was incorrectly used.
To make it easier to spot such bugs in the future I just removed the default
values and thus disallow such calls.
2011-07-01 05:42:54 +02:00
Filippos Karapetis
168ba00ea3
SCI: Fixed script bug #3292327 - "SCI: HOYLE4: Cribbage bug"
2011-06-28 12:56:09 +03:00
Willem Jan Palenstijn
bc4691a23e
SCI: Fix incorrect usage of sizeof
...
Thanks to salty-horse for the reports.
2011-06-25 21:16:12 +02:00
Filippos Karapetis
7432cc4dd9
SCI: Fixed bug #3325512 : "EcoQuest 1: Audio settings are not saved"
2011-06-25 12:43:32 +03:00
Filippos Karapetis
f46be3394a
SCI: Added the Mac versions of LSL1, LSL5 and Dr. Brain 1
...
Taken from bug reports #3328251 , #3328262 and #3328257 .
Thanks to omer_mor for reporting these
2011-06-25 10:43:41 +03:00
Littleboy
b694a78f62
ANALYSIS: Add static casts to is* functions
...
This fixes a potential problem with passing char values that would be sign-extended and yield unexpected results.
See http://msdn.microsoft.com/en-us/library/ms245348.aspx
2011-06-23 08:52:52 -04:00
Julien
dd21952f98
SCI: Allocate decompression buffers on the heap
2011-06-23 15:11:38 +08:00
Max Horn
f646ab3c86
SCI: Mark sq6 as a CD game
2011-06-22 11:50:14 +02:00
Max Horn
dae19afbfb
SCI: Let fallback detector set GUIO_NOSPEECH appropriately
2011-06-20 01:28:10 +02:00
Max Horn
88913c0139
ALL: Remove trailing whitespaces
...
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-20 00:59:48 +02:00
Eugene Sandulenko
94ad45b058
Merge pull request #30 from tsoliman/configure-enhancement-warning-clean
...
Configure enhancement warning clean
2011-06-17 10:19:57 -07:00
Max Horn
2e2676526d
SCI: Improve 'extra' strings generated by fallback detector
2011-06-17 14:21:18 +02:00
Max Horn
c2bbab4fec
SCI: Improve fallback detection for KQ7
2011-06-17 14:21:17 +02:00
Max Horn
055820c94b
SCI: Improve fallback detection for GK2 demo
2011-06-17 14:21:17 +02:00
Max Horn
cef5506e9f
SCI: Change fallback detector to use allFiles hashmap
2011-06-17 14:21:17 +02:00
Max Horn
520b18d2ac
SCI: Use ScopedPtr to handle temporary resMan instance on the heap
2011-06-17 10:38:16 +02:00
Tarek Soliman
69a45b434f
SCI: flag all WIP games with ADGF_UNSTABLE
...
SCI32 games
2011-06-16 13:37:57 -05:00
Max Horn
879c3c7817
DETECTOR: Pass allFiles to AdvancedMetaEngine::fallbackDetect()
...
Also reorder the parameters of composeFileHashMap, placing the "return value"
first.
2011-06-14 18:52:11 +02:00
Max Horn
7c992d6598
DETECTOR: Merge ADParams into AdvancedMetaEngine
2011-06-14 18:17:01 +02:00
Filippos Karapetis
bfa26ffc44
SCI: Reverted commit db7dea3
...
The original check was correct, and the associated MG bug (#3049515 ) has
actually been fixed with another commit.
Fixes bug (regression) #3315639 - "Character Glitches in KQ4 SCI".
Many thanks to waltervn and wjp for their help on this
2011-06-13 16:43:04 +03:00
Willem Jan Palenstijn
4c70d39933
SCI: Shrink rectangle updated by DrawControl(Text)
...
This fixes dialogs in Jones CD (bug #3297111 ) together
with 9e2c7f26d2
.
This grow was probably accidentally added in
6fda9a5067
. Assembly of KQ5CD and JonesCD
confirms it shouldn't be there.
2011-06-13 01:24:28 +02:00
Willem Jan Palenstijn
8e2f2e3730
SCI: Remove workaround that caused graphics corruption
...
This fixes coins disappearing in Mother Goose SCI1.1 (bug #3051136 ).
Filippos has confirmed the workaround is no longer necessary for the
menubar in LSL6 for which it was added.
2011-06-12 20:26:07 +02:00
Willem Jan Palenstijn
9e2c7f26d2
SCI: Treat all priorities above 15 as none
...
Before only 255 was treated this way. This fixes part of the broken
dialog boxes in Jones CD (bug #3297111 ) which use priority 254,
and matches Jones CD disassembly.
2011-06-12 20:25:46 +02:00
md5
60943efafd
SCI: Fixed bug #3295931 - "SCI: JONES: Disabled commands are available using shortcuts"
2011-06-12 17:58:25 +03:00
md5
c5610182a6
SCI: Some fixes for the find_callk command
2011-06-12 15:36:08 +03:00
md5
7ab6dfc00e
SCI: Fixed the show_saved_bits console command
...
This is achieved by hiding the graphical debugger overlay temporarily in
order to show the command's results
2011-06-12 15:07:42 +03:00
Willem Jan Palenstijn
4ec20f857f
SCI: Add FIXME for bug #3051136
2011-06-12 02:02:06 +02:00
Willem Jan Palenstijn
4296ac6d15
SCI: Fix sign in disasm of relative jumps
2011-06-12 02:00:09 +02:00
Willem Jan Palenstijn
50176e7c5f
SCI: Add saved_bits/show_saved_bits console commands
2011-06-12 01:55:30 +02:00
md5
ece449298d
SCI: Fixed script bug #3313962 - "ECOQUEST2 Spanish: Crash near beginning"
2011-06-11 14:34:47 +03:00
md5
1f0f0595c4
SCI: Added the Spanish version of EcoQuest 2 (bug #3313962 )
2011-06-11 14:33:06 +03:00
md5
eea48434f5
SCI: Changed order of script and room in error messages
...
This matches the order in which workarounds are stored in workarounds.cpp
2011-06-11 14:00:02 +03:00
Max Horn
b99d76acdb
SCI: Switch to alternate AdvancedMetaEngine, avoid ADParams
2011-06-10 22:15:44 +02:00
Max Horn
4827cc914a
ENGINES: Change incorrect use of 'target' to 'gameid'
2011-06-10 22:15:40 +02:00
Walter van Niftrik
ae4f63a256
SCI: Add more debug output to AmigaMac sound driver
2011-06-07 13:34:59 +02:00
Walter van Niftrik
12366c91e5
SCI: Use Sound debug channel in AmigaMac sound driver.
2011-06-07 01:39:00 +02:00
Walter van Niftrik
4628833a32
SCI: Set Mac versions of LSL1 and LSL5 to screen height 190.
...
This fixes bug #3310782 . However, as I was unable to get the games working in
a Mac emulator, this is an educated guess at this point.
2011-06-04 15:32:57 +02:00
Max Horn
aec2ea9661
ENGINES: Remove some uses of g_engine
2011-06-03 18:21:58 +02:00
Max Horn
11bd6da595
SCI: Switch some char* to Common::String&
2011-06-03 16:16:38 +02:00
Max Horn
477d6233c3
ENGINES: Change 2nd param of Engine::saveGameState to Common::String
2011-06-02 18:31:59 +02:00
Walter van Niftrik
05ac17f7b9
SCI: Fix up start/end points when pathfinding with opt == 0.
...
Fixes bug #3304901 : "SCI: Freddy Pharkas - Stuck in the brothel door".
2011-05-31 16:26:38 +02:00