Commit Graph

41 Commits

Author SHA1 Message Date
Max Horn
3b21db1618 SCUMM: Fix parts of bug #3087898 (SCUMM: Code analysis warnings)
svn-id: r53567
2010-10-18 16:00:07 +00:00
Max Horn
1d4c82885d DEBUGGER: Simplify how our console debugger works / is used
* Remove _isAttached member var and isAttached method
* Engines now always call the onFrame method; whether it does
  something is decided by the debugger class resp. its subclasses
* Make detach() protected instead of private, so that subclasses
  can invoke it
* Remove _detach_now member var (call detach() instead).
* Rename _frame_countdown to _frameCountdown and properly
  document it.
* Add more doxygen comments
* Cleanup

svn-id: r50963
2010-07-17 18:38:42 +00:00
Eugene Sandulenko
b8df22646b Patch #2959341: Minor update to SCUMM debugger command 'passcode'
svn-id: r49221
2010-05-25 20:47:48 +00:00
Max Horn
970745e60c Move DebugChannel related code to new header
svn-id: r48935
2010-05-04 11:59:22 +00:00
Max Horn
460d69e885 COMMON: Move DebugChannel stuff into a new DebugMan singleton
svn-id: r48821
2010-04-27 21:40:52 +00:00
Johannes Schickel
aed02365ec Strip trailing spaces/tabs.
svn-id: r47541
2010-01-25 01:39:44 +00:00
Eugene Sandulenko
544a92a468 Patch #2895458: "SCUMM: Add support for SEGA-CD MI Passcodes"
svn-id: r46516
2009-12-23 21:12:15 +00:00
Torbjörn Andersson
cc19ed27a1 Made the "drafts" debugger command work with the PC-Engine version. The drafts
appear to be stored in the same variables as in the DOS CD version. Other than
that, I only have the DOS floppy version, so other versions still may or may
not work as intended.

svn-id: r45358
2009-10-24 09:51:28 +00:00
Johannes Schickel
70f7c46f42 Add newline after "Available debug channels" in Cmd_Debug, now all debug channels will be listed in separate lines.
svn-id: r44463
2009-09-29 14:36:46 +00:00
Johannes Schickel
b3c6751b9b Strip trailing whitespaces in the whole code base.
svn-id: r40867
2009-05-24 15:17:42 +00:00
Max Horn
5181546c63 Rewrote Common::List iterator code to ensure const correctness is preserved.
We tried to implement the list iterators in a clever way, to reduce code
duplication. But this is essentially impossible to do properly, sadly --
this is one of the places where the ugly drawbacks of C++ really show.
As a consequence, our implementation had a bug which allowed one to
convert any const_iterator to an iterator, thus allowing modifying
elements of const lists.

This rewrite reintroduces code duplication but at least ensures that no
const list is written to accidentally.

Also fix some places which incorrectly used iterator instead of const_iterator
or (in the kyra code) accidentally wrote into a const list.

svn-id: r39279
2009-03-09 22:26:02 +00:00
Willem Jan Palenstijn
2294621e5a clarify scumm debugger error message
svn-id: r38439
2009-02-17 19:53:04 +00:00
Max Horn
7cb437b56f Renamed SpecialDebugLevel to DebugChannel
svn-id: r36142
2009-01-30 05:10:24 +00:00
Max Horn
76deee02d6 Some more 'special debug levels' tweaks
svn-id: r36140
2009-01-30 04:52:53 +00:00
Max Horn
de7c89e381 Some work on the 'special debug levels' aka 'engine debug levels' code
svn-id: r36139
2009-01-30 04:42:30 +00:00
Johannes Schickel
2ef8a32a01 Fixed various g++ warnings ("format not a string literal and no format arguments").
svn-id: r35096
2008-11-16 20:20:31 +00:00
Max Horn
a6502da9ac * got rid of CDECL
* got rid of scumm_strrev
* added DISABLE_TEXT_CONSOLE flag which disables printf, warning, debug (but not error)

svn-id: r35038
2008-11-13 11:26:47 +00:00
Max Horn
0be985ce83 Changed class File (and derived classes) to only support read-only access; added a new class DumpFile for writing
svn-id: r33412
2008-07-29 16:09:10 +00:00
Johannes Schickel
cc08a4953d Cleaned up engine debug level code.
svn-id: r32195
2008-05-20 16:37:32 +00:00
Eugene Sandulenko
2d94049bea Workaround for bug #1804278: "MONKEY: Mouse is invisible after loading"
svn-id: r30160
2008-01-02 18:44:20 +00:00
Nicola Mettifogo
258901bab9 Merged common/stdafx.h into common/scummsys.h. All referencing files have been updated.
svn-id: r28966
2007-09-19 08:40:12 +00:00
Max Horn
0cccbb29d6 Some cleanup (yay for whomever had the brilliant idea to let SVN work over HTTPS and hence through proxies&firewalls :)
svn-id: r28877
2007-09-08 11:15:27 +00:00
Max Horn
218e132e37 Updated legal headers in source files, based on what Pidgin (the IM client formerly knowns as Gaim) does; added new (incomplete) COPYRIGHT file; updated copyright dates in a few spots
svn-id: r27024
2007-05-30 21:56:52 +00:00
Max Horn
5b65897cd3 Switch SCUMM engine to use the common special debug flags support (thus making it possible to use --debugflags with it)
svn-id: r25381
2007-02-04 12:41:49 +00:00
Max Horn
53432b2bbe Use Actor::getRealPos instead of Actor::getPos in the debugger
svn-id: r25371
2007-02-04 01:52:50 +00:00
Max Horn
be052be462 Rewrote the actor walk code for SCUMM V0-V2 games: Now it uses the C64 character coordinates internally, not pixel coordinates. This should fix some walk bugs, but also might cause some regressions. Watch out
svn-id: r25370
2007-02-04 01:24:43 +00:00
Max Horn
4ce7b74085 Changed ScummEngine::_actors from an Actor array to a an array of Actor points (i.e. indirection)
svn-id: r24922
2006-12-25 15:03:36 +00:00
Gregory Montoir
487391edef passing the room as an argument to putActor is optionnal here
svn-id: r24911
2006-12-21 15:18:26 +00:00
Gregory Montoir
cfd4ffb321 fixed bug #1620023 (script calls putActorAtXY with y == -1)
svn-id: r24910
2006-12-21 15:09:13 +00:00
Max Horn
c210aff40c * Made Actor::_pos protected, added public Actor::getPos() method
* Added default params to Actor::putActor()
* Removed Actor::getActorXYPos

svn-id: r24742
2006-11-19 00:39:48 +00:00
Max Horn
32f891f724 SCUMM: Avoid crash in debugger when omitting the state value in 'object state VALUE'
svn-id: r24572
2006-10-29 18:43:16 +00:00
Max Horn
dd7e4ff3e7 SCUMM: walbox related cleanup
svn-id: r24365
2006-10-18 13:33:42 +00:00
Max Horn
51017cf1b2 Renamed ScummEngine::res to _res and allocate the ResourceManager on the heap (i.e. _res is a pointer now)
svn-id: r23922
2006-09-17 20:36:48 +00:00
Max Horn
8df3ca9e65 cleanup
svn-id: r23891
2006-09-16 17:26:40 +00:00
Max Horn
919092e5fc Overhaul of the debugger code
* Moved Common::Debuggger to GUI::Debugger (mainly to satisfy linker
  restrictions)
* Change the base Debugger class to *not* be a template class anymore;
  instead, a thin (template based) wrapper class is used to hook up
  debugger commands
* Removed duplicate Cmd_Exit and Cmd_Help methods in favor of a single
  version of each in GUI::Debugger
* New Cmd_Help doesn't word wrap after 39/78 chars, but rather queries
  the console to determine when to wrap
* Debugger::preEnter and postEnter aren't pure virtual anymore

svn-id: r23890
2006-09-16 16:58:27 +00:00
Max Horn
0d67640a58 Behold, the new SCUMM detector finally has arrived. Unified detection & engine instantiation, reduced code duplication, more powerful detection in case MD5 is not known / can't be computed, and many other nifty improvements.
svn-id: r22110
2006-04-23 17:33:16 +00:00
Max Horn
68cb7f52c8 - Renamed ConfigManager::getActiveDomain to getActiveDomainName, and added a new getActiveDomain method that returns a pointer to the actual active *domain*
- Added Engine::_targetName whose value is computed from the name of the active domain
- Removed GameDetector::_targetName, instead code now uses either Engine::_targetName or the name of the active domain
- This in turn allowed for removing usage of GameDetector in many places

svn-id: r21916
2006-04-15 20:36:41 +00:00
Gregory Montoir
575c831684 fixed wrong computation of decflag in AkosRenderer::drawLimb (HE specific, bug #1416186).
svn-id: r21454
2006-03-25 20:15:41 +00:00
Max Horn
81e8a2860e Moved iMUSE code to the new directory engines/scumm/imuse/
svn-id: r20801
2006-02-20 20:57:26 +00:00
Max Horn
e389bcf497 Replaced _gameId, _version, _heversion, _features, _midi, _platform with a simple ScummGameSettings instance: _game
svn-id: r20795
2006-02-20 16:51:30 +00:00
Max Horn
26ee630756 Moved engines to the new engines/ directory
svn-id: r20582
2006-02-11 22:45:04 +00:00