Max Horn
b446a7dcc2
ALL: code formatting fixes
...
svn-id: r53764
2010-10-24 13:09:56 +00:00
Max Horn
5fbca853aa
SCUMM: Turn global g_cmsEmu into a member var of Player_V2CMS
...
svn-id: r53763
2010-10-24 13:05:03 +00:00
Max Horn
c975ed11a1
ALL: Fix various typos (patch #3093266 )
...
svn-id: r53762
2010-10-24 13:04:33 +00:00
Max Horn
0d54400806
SCUMM: Skip endian conversion on little endian systems (instead of assigning values back to themselves)
...
svn-id: r53739
2010-10-23 15:47:23 +00:00
Max Horn
3534cff8ef
ALL: Fix indention (whitespaces -> tabs)
...
svn-id: r53738
2010-10-23 15:46:50 +00:00
Travis Howell
3f4655c03f
SCUMM: Disable multiplayer option in Backyard Baseball 2001.
...
svn-id: r53731
2010-10-23 13:39:04 +00:00
Travis Howell
402fac9ed4
SCUMM: Add workaround to allow saved games to be shared between Macintosh and Windows versions of Backyard Baseball 2001.
...
svn-id: r53729
2010-10-23 06:27:16 +00:00
Travis Howell
afd677c2c7
SCUMM: Fix buffer overflow, that was causing crashes when saving in Backyard Baseball 2001/2003.
...
svn-id: r53726
2010-10-23 02:18:08 +00:00
Florian Kagerer
a82b0435a2
SCUMM/FM-TOWNS JAPANESE: fix font drawing in MI1 intro
...
svn-id: r53725
2010-10-23 00:30:21 +00:00
Florian Kagerer
031e0167e4
SCUMM/FM-TOWNS JAPANESE: fix another font spacing issue
...
(fixes MI1 character talk text)
svn-id: r53704
2010-10-22 19:28:12 +00:00
Max Horn
89fc06d878
SCUMM: Remove redundant call to checkArrayLimits
...
svn-id: r53672
2010-10-21 09:32:00 +00:00
Max Horn
66fabfa049
SCUMM: Document ScummEngine_v90he::sortArray
...
svn-id: r53671
2010-10-21 09:31:42 +00:00
Travis Howell
cca5504b6c
SCUMM: Fix bug #2984000 - SPYFOX3 (French): Crash when using fingernail machine.
...
svn-id: r53669
2010-10-21 08:51:10 +00:00
Travis Howell
e5c3b67ddb
SCUMM: Correct a copy and paste error in compareByteArray/compareByteArrayReverse code.
...
Thanks to clone2727 for noticng this error.
svn-id: r53663
2010-10-21 05:17:16 +00:00
Travis Howell
01ea6f86bd
SCUMM: Revert revision 45302, which caused regressions when random team is selected in Backyard Football.
...
svn-id: r53662
2010-10-21 05:13:32 +00:00
Florian Kagerer
64c0d2a1d1
SCUMM/FM-TOWNS: minor graphics fix
...
This fixes a graphics glitch that occured when leaving the Scumm Bar in MI1 for the first time (before the cut scene with LeChuck).
svn-id: r53645
2010-10-20 15:39:08 +00:00
Matthew Hoops
21a29d3b45
SCUMM: Have o6_getRandomNumber() use the absolute value of the argument
...
The Backyard Baseball series calls the function with negative numbers, but expects a positive result. The games are now actually playable.
Thanks to Kirben for assistance in tracking this bug down.
svn-id: r53630
2010-10-20 03:01:03 +00:00
Florian Kagerer
f6a43d980a
SCUMM/FM-TOWNS JAPANESE: minor fix in last commit
...
svn-id: r53617
2010-10-19 17:03:36 +00:00
Florian Kagerer
1d87f434a2
SCUMM/FM-TOWNS JAPANESE: implement flipped text
...
(used in the MI1 circus scene after Guybrush gets shot out of the cannon)
svn-id: r53616
2010-10-19 16:58:27 +00:00
Florian Kagerer
f05110f3f6
SCUMM/FM-TOWNS JAPANESE: fix font spacing issues
...
(improves MI1 intro)
svn-id: r53597
2010-10-18 23:54:35 +00:00
Max Horn
ceae152531
SCUMM: Silence MSVC 2010 code analysis warning
...
svn-id: r53582
2010-10-18 19:29:56 +00:00
Eugene Sandulenko
dd7a2f75c0
SCUMM: INSANE: fix a long standing bug discovered by static code analysis
...
svn-id: r53581
2010-10-18 19:19:28 +00:00
Max Horn
277113f600
SCUMM: Fix out of bound access (discovered by Code Analysis in MS VS2010; thanks to aquadran for helping verify the fix)
...
svn-id: r53575
2010-10-18 19:03:24 +00:00
Max Horn
cda2c950d6
SCUMM: Simplify SO_LOAD_STRING code
...
svn-id: r53574
2010-10-18 18:56:40 +00:00
Max Horn
32f1a9ad8b
SCUMM: Add paranoia check
...
svn-id: r53573
2010-10-18 18:56:20 +00:00
Max Horn
6175c2bb19
SCUMM: Fix potential bug in ScummEngine::resStrLen.
...
In particular, it might happen that ScummEngine::resStrLen is called
while the _scriptPointer is stale. In that case, it would be working
with the stale pointer. If the code calling it then uses fetchScript*()
methods to read the string whose length was just computed, then it would
read potentially *different* data (e.g. copyScriptString or
loadPtrToResource could have been affected).
I am not sure if this actually could have caused bugs somewhere; it might
even be provable that a script relocation cannot happen in all places
that invoke resStrLen. But for now it's much easier to make the code
safe than to verify that theory ;).
Also simplified some related code.
svn-id: r53572
2010-10-18 18:55:24 +00:00
Max Horn
d69a63c145
SCUMM: Move common code from ScummEngine::fetchScript* to new method.
...
The new method is called refreshScriptPointer(). Also renamed
getScriptEntryPoint() to resetScriptPointer() in an attempt to highlight
both the similarity and difference between the two.
svn-id: r53571
2010-10-18 18:43:13 +00:00
Max Horn
3b21db1618
SCUMM: Fix parts of bug #3087898 (SCUMM: Code analysis warnings)
...
svn-id: r53567
2010-10-18 16:00:07 +00:00
Travis Howell
ada933c2ad
SCUMM: Check the sound channel is valid, before checking the sound channel.
...
svn-id: r53562
2010-10-18 04:25:53 +00:00
Travis Howell
34ff826918
SCUMM: Check the sound channel is valid, before checking the sound channel.
...
svn-id: r53561
2010-10-18 04:23:30 +00:00
Travis Howell
f40e427ab0
SCUMM: Correct incorrect demo entry for Backyard Football 2002.
...
svn-id: r53560
2010-10-18 00:43:49 +00:00
Florian Kagerer
1d60fc45f2
SCUMM/FM-TOWNS: more improvements to japanese font drawing
...
(MI1 intro is still not right)
svn-id: r53558
2010-10-17 23:52:33 +00:00
Travis Howell
3dc498c5ec
SCUMM: Fix Macintosh demo of Putt-Putt Joins the Parade.
...
svn-id: r53557
2010-10-17 23:45:57 +00:00
Florian Kagerer
c841c3fb7c
SCUMM/FM-TOWNS: more improvements to japanese font drawing
...
- made use of LordHotos graphics/sjis code to reduce code duplication
- japanese mode for version 3 and 5 works fine now with few exceptions (some line spacing glitches in MI1 intro etc.)
svn-id: r53554
2010-10-17 13:08:00 +00:00
Travis Howell
728a231d7b
SCUMM: Fix bug #2952298 - HE (16Bit): Inventory items (Cursors) have wrong color.
...
svn-id: r53552
2010-10-17 12:44:56 +00:00
Florian Kagerer
63c30e959f
SCUMM/FM-TOWNS: fix regression in non Japanese SCUMM 3 games
...
svn-id: r53523
2010-10-15 23:28:09 +00:00
Florian Kagerer
af52d3a7f6
SCUMM/FM-TOWNS: fix display of dialogue options in Indy 4 Japanese
...
svn-id: r53519
2010-10-15 21:48:46 +00:00
Florian Kagerer
87b5598720
SCUMM/FM-TOWNS: fix up/down inventory arrows in Indy 4 Japanese
...
svn-id: r53518
2010-10-15 21:26:05 +00:00
Florian Kagerer
b184d7bbdb
SCUMM/FM-TOWNS: improve japanese font drawing in SCUMM 3 games
...
svn-id: r53510
2010-10-15 19:10:18 +00:00
Max Horn
4ccce19876
ENGINES: Enhance namespace comments a bit
...
svn-id: r53484
2010-10-15 12:48:19 +00:00
Travis Howell
42f2a13155
Reverted revision 53456, as requested.
...
svn-id: r53483
2010-10-15 12:41:11 +00:00
Eugene Sandulenko
ea5bf685fc
SCUMM: Fix bug #2952298 with 16-bit HE cursors on Amiga
...
Bug #2952298 : "HE (16Bit): Inventory items (Cursors) have wrong color"
This appeared to be generic BE bug. Thanks to jvprat for nailing it down
and providing the patch.
svn-id: r53456
2010-10-14 18:19:51 +00:00
Florian Kagerer
2f86c7a45c
SCUMM/FM-TOWNS: start fixing japanese font drawing
...
svn-id: r53196
2010-10-12 22:17:00 +00:00
Florian Kagerer
2c691e1168
LOOM PC-Engine: fix mouse cursor
...
svn-id: r53117
2010-10-10 14:22:10 +00:00
Florian Kagerer
8e6ce812d1
LOOM PC-Engine: fix regression
...
svn-id: r53113
2010-10-10 10:26:49 +00:00
Florian Kagerer
89fd5b31c1
SCUMM/FM-TOWNS: minor fix for sfx code
...
svn-id: r53103
2010-10-09 16:39:56 +00:00
Florian Kagerer
88416b870d
SCUMM/FM-TOWNS: cleanup sfx code
...
svn-id: r53095
2010-10-09 01:36:38 +00:00
Florian Kagerer
b58bbd719c
SCUMM/FM-TOWNS: fixed threading issue in sfx code
...
svn-id: r53074
2010-10-08 16:31:08 +00:00
Florian Kagerer
4ad65e5179
SCUMM/FM-TOWNS: fixed possible invalid mem access in sfx code
...
svn-id: r53073
2010-10-08 13:50:11 +00:00
Florian Kagerer
a214e08c0d
SCUMM/FM-TOWNS: minor change in sfx code
...
svn-id: r53061
2010-10-07 22:20:22 +00:00