Max Horn
73f04118f3
COMMON: Rename Error to ErrorCode, introduce new Error class
2011-04-18 18:22:02 +02:00
Johannes Schickel
64c4e65201
KYRA: Enforce use of American English in comments.
2011-04-14 14:03:07 +02:00
Max Horn
0ce2ca4e00
COMMON: Replace MKID_BE by MKTAG
...
MKID_BE relied on unspecified behavior of the C++ compiler,
and as such was always a bit unsafe. The new MKTAG macro
is slightly less elegant, but does no longer depend on the
behavior of the compiler.
Inspired by FFmpeg, which has an almost identical macro.
2011-04-12 16:53:15 +02:00
Johannes Schickel
d9441aeb80
KYRA: Add some assertion to prevent out of bounds access.
2011-04-11 00:36:03 +02:00
Johannes Schickel
073da68efa
KYRA: Constify static data table in LoL code.
2011-04-11 00:35:28 +02:00
Johannes Schickel
93f591580a
KYRA: Get rid of non-const static variable in Kyra2 code.
2011-04-11 00:34:16 +02:00
Johannes Schickel
8fe9f8e73a
KYRA: Cleanup.
2011-04-11 00:31:24 +02:00
Johannes Schickel
ee4699a495
KYRA: Get rid of non-const static variables in HoF.
2011-04-11 00:21:18 +02:00
Max Horn
6cf1de87ac
DEVTOOLS: Renamed 'tools' directory to 'devtools'
2011-04-09 23:47:35 +02:00
Johannes Schickel
eb731514f7
KYRA: Slight cleanup.
...
This more or less silently fixes the silent music introduced with f19e201
, by
me setting volume to "true" instead of "255". Whoops.
2011-04-07 01:09:52 +02:00
Johannes Schickel
f19e2019b8
KYRA: Cleanup background music looping of Kyra3.
2011-04-07 01:01:55 +02:00
Johannes Schickel
6d0bb19a51
KYRA: Cleanup static variable usage in LoK.
2011-04-07 00:11:36 +02:00
Johannes Schickel
f4dde64406
KYRA: Slight cleanup.
2011-04-07 00:11:36 +02:00
dhewg
d83a83ef50
JANITORIAL: Remove/comment unused vars
...
Found by GCC 4.6's -Wunused-but-set-variable
2011-03-29 21:57:56 +02:00
Max Horn
29847ea42d
AUDIO: Change several fake MidiDrivers to MidiDriver_BASE subclasses
...
Many engines follow the advice in audio/midiparser.h and create a
"pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny
subset of the MidiDriver capabilities, namely those found in
MidiDriver_BASE. So we try to subclass from that whenever possible; this
allows us to remove many stub methods, and enables further future
simplifications.
2011-03-23 15:25:47 +01:00
Max Horn
8982fff1b7
AUDIO: Add pure virtual MidiDriver::isOpen() method
...
This in turn enables modifying MidiDriver_MPU401::close() to allow
it to be called on a midi driver that has not yet been opened.
The specific issue that triggered me to make these changes was a
crash-upon-quit in HUGO, caused by it instantiating a midi driver,
then encountering an error (missing hugo.dat) *before* having
opened the new midi driver; the general cleanup code then tries
to close the (not yet opened) midi driver -> kaboom
Also fixed some engines which were leaking MidiDriver instances.
2011-03-22 23:51:47 +01:00
Johannes Schickel
16be240ab1
KYRA: Fix regression in Screen::setInterfacePalette.
...
This fixes an out of bounds write introduced with 9216c7e
.
2011-02-20 21:37:39 +01:00
Johannes Schickel
e21d6e0d11
Merge branch 'osystem-palette' of https://github.com/lordhoto/scummvm into master
...
Conflicts:
backends/platform/android/android.cpp
engines/sci/graphics/screen.cpp
engines/sci/graphics/transitions.cpp
2011-02-19 21:46:45 +01:00
Johannes Schickel
b5d1c66915
KYRA: Set type for NULL MIDI driver to PC Speaker.
...
This avoids a dialog about MT-32 to General MIDI conversion shown when running
Kyrandia 1. Formerly the NULL MIDI output type was set to General MIDI, which
caused the aforementioned dialog to show up, because Kyrandia 1 has no General
MIDI tracks.
2011-02-16 23:30:03 +01:00
athrxx
e23696d900
KYRA/LOL: add comments for last commit
2011-02-16 16:31:22 +01:00
athrxx
d7e700f370
KYRA/LOL: fixed hand item cursor bug
...
This fixes a bug when loading savegames with different active hand items via GMM. The mouse cursor was not set to the active hand item in these cases.
2011-02-16 16:23:44 +01:00
Johannes Schickel
9216c7e3de
KYRA: Adapt to setPalette/grabPalette RGBA->RGB changes.
2011-02-14 17:08:32 +01:00
Johannes Schickel
24eab0ac73
KYRA: Rename KyraEngine_MR::runDialog to doDialog to avoid name clashes with Engine::runDialog.
...
svn-id: r55864
2011-02-10 01:19:48 +00:00
Johannes Schickel
a9361da157
KYRA: Remove superfluous const in type conversion.
...
svn-id: r55863
2011-02-10 01:19:24 +00:00
Max Horn
42ab839dd6
AUDIO: Rename sound/ dir to audio/
...
svn-id: r55850
2011-02-09 01:09:01 +00:00
Max Horn
2d1c8a3533
ALL: Fix whitespaces / indention
...
svn-id: r55818
2011-02-07 23:01:06 +00:00
Max Horn
ab039812e7
COMMON: OSystem now has a PaletteManager
...
svn-id: r55806
2011-02-07 17:52:38 +00:00
Johannes Schickel
d925e38acf
KYRA: Hopefully fix valgrind warnings in the HoF intro when text is disabled.
...
svn-id: r55623
2011-01-29 19:03:50 +00:00
Johannes Schickel
2cc3bd880f
KYRA: Clean up main menu code in Kyra2/Kyra3.
...
svn-id: r55620
2011-01-29 18:40:04 +00:00
David Turner
450dac35c7
KYRA: Fix Valgrind Uninitialized Memory Read at end of VQA Playback.
...
svn-id: r55619
2011-01-29 18:20:38 +00:00
David Turner
f050e2d66f
KYRA: Close Memory Leaks in Kyra 3 (Malcolm's Revenge) Menu.
...
svn-id: r55618
2011-01-29 18:18:29 +00:00
Florian Kagerer
8347b44fb2
KYRA FM-TOWNS: improved cd audio music fading
...
svn-id: r55039
2010-12-25 22:10:51 +00:00
Max Horn
6edc86a19b
DEBUG: Let GUI::Debugger::preEnter and postEnter (un)pause the engine
...
svn-id: r54815
2010-12-07 18:54:21 +00:00
Jordi Vilalta Prat
d5a4f554af
ALL: Fix a few typos
...
svn-id: r54716
2010-12-01 20:03:05 +00:00
Max Horn
2180b2d6b5
COMMON: Split common/stream.h into several headers
...
svn-id: r54385
2010-11-19 17:03:07 +00:00
Max Horn
a0df86955f
ALL: Push down deps on stream.h from .h to .cpp files
...
svn-id: r54358
2010-11-19 01:37:04 +00:00
Max Horn
ee4770ffb6
ENGINES: Change 'colour' to 'color'
...
Only changed this in engines where 'color' was/is already used
almost exclusively
svn-id: r54288
2010-11-17 12:22:08 +00:00
Max Horn
059944e59c
COMMON: Push #include audiocd.h in system.h out to .cpp files
...
svn-id: r54148
2010-11-08 23:07:42 +00:00
Max Horn
82e473bc3b
BACKENDS: Partial merge of gsoc2010-opengl: Audio CD changes only
...
This commit contains the AudioCDManager changes from the gsoc2010-opengl
branch. The other changes in that branch are restricted to the backends
directory only (plus configure).
The Nintendo DS and Dreamcast ports still need to be ported over to
the new Audio CD system, but that should be fairly easy to do.
svn-id: r54147
2010-11-08 22:53:36 +00:00
Florian Kagerer
97a98cf9db
LOL: fixed minor text displayer bug
...
svn-id: r54132
2010-11-08 00:08:38 +00:00
Max Horn
4d3a07b494
COMMON: Rename and tweak MD5 functions
...
* names now comply to our naming conventions
* the function computeStreamMD5AsString which computes the MD5
as a hex string now returns it as a Common::String
* add doxygen comments
svn-id: r54121
2010-11-07 17:16:59 +00:00
Max Horn
18d40017e8
ENGINES: Unify code layout of all ADParams instances
...
svn-id: r54105
2010-11-07 01:01:18 +00:00
Johannes Schickel
8252fc30ce
KYRA: Pause engine when the debugger is open.
...
svn-id: r54032
2010-11-01 22:19:16 +00:00
Max Horn
a984fb17c2
GUI: Add GCC_PRINTF to GUI::Debugger::DebugPrintf & fix resulting warnings
...
svn-id: r54007
2010-11-01 16:03:35 +00:00
Max Horn
e27b05ef35
COMMON: Rename String::printf() to String::format()
...
This is a first step towards getting rid of all uses of regular printf,
fprintf, vprintf, vfprintf, puts, fputs, etc. in our codebase.
The name format() reflects the purpose of the function, and parallels
String.format() in Java, boost::format, and others.
svn-id: r54004
2010-11-01 16:02:28 +00:00
Florian Kagerer
ec680ef8aa
LOL: fixed bug #3099321
...
(Crash in Yvel tavern basement)
svn-id: r53973
2010-10-31 00:20:30 +00:00
Florian Kagerer
a04b4e6517
LOL: workaround for bug #3098935
...
(Vaelan's Cube can be duplicated at Scotia's Barrier)
This is a bug in the game data of early unpatched floppy versions.
This can also be fixed by applying the official patch (ftp://ftp.westwood.com/pub/lands1/updates/lolus123.exe).
svn-id: r53954
2010-10-30 18:37:15 +00:00
Florian Kagerer
c9442e26ad
KYRA: match music settings with latest launcher code changes.
...
(Last commit got trunkated somehow)
svn-id: r53927
2010-10-29 19:00:37 +00:00
Florian Kagerer
67566890bd
KYRA: match music settings with latest launcher code changes.
...
(Users will get AdLib music at default unless they have specified a MIDI device in the launcher (MT-32 for KYRA, GM for HOF and LOL.)
svn-id: r53926
2010-10-29 18:57:19 +00:00
Johannes Schickel
07e9c6a035
KYRA: Minor formatting cleanup.
...
svn-id: r53915
2010-10-29 00:40:35 +00:00
Johannes Schickel
32338876f8
KYRA: Rename KyraEngine::saveGameState to KyraEngine::saveGameStateIntern.
...
This is to avoid name similarity between KyraEngine::saveGameState(Intern)
and Engine::saveGameState.
svn-id: r53912
2010-10-28 23:57:24 +00:00
Johannes Schickel
607920c869
KYRA: Fix some code errors reported by ICC (i.e. subclasses not overwriting methods by missing a const.)
...
svn-id: r53911
2010-10-28 23:56:36 +00:00
Florian Kagerer
bf5ae45490
KYRA/PC98: workaround for missing delay opcodes
...
The sequence data for the forest sequence in the Kyra PC-98 intro has no delay opcodes making it play way too fast on modern systems. This workaround adds the same delay opcodes to the sequence data that the other Kyra versions have.
svn-id: r53761
2010-10-24 13:00:47 +00:00
Florian Kagerer
09f77eb464
LOL: - fix invalid mem access
...
- also extend LordHoto's recent item code changes to LOL
svn-id: r53740
2010-10-23 16:01:40 +00:00
Max Horn
3534cff8ef
ALL: Fix indention (whitespaces -> tabs)
...
svn-id: r53738
2010-10-23 15:46:50 +00:00
Florian Kagerer
d6e4c07dac
LOL: fix possible regressions
...
svn-id: r53700
2010-10-22 13:10:41 +00:00
Johannes Schickel
b816a81c02
KYRA: More cleanup.
...
svn-id: r53699
2010-10-22 02:11:50 +00:00
Johannes Schickel
5ff20cb12d
KYRA: Cleanup.
...
svn-id: r53698
2010-10-22 02:11:00 +00:00
Johannes Schickel
03e2d54ca7
KYRA: Adapt Kyra2+3 to use the newly added item type too.
...
svn-id: r53697
2010-10-22 02:10:22 +00:00
Johannes Schickel
3653613443
KYRA: Add a datatype for the item ids and convert Kyra1 to use it.
...
svn-id: r53696
2010-10-22 02:09:16 +00:00
Johannes Schickel
38463e6161
KYRA: A little refactoring (name change).
...
svn-id: r53695
2010-10-22 02:08:26 +00:00
Florian Kagerer
1d87f434a2
SCUMM/FM-TOWNS JAPANESE: implement flipped text
...
(used in the MI1 circus scene after Guybrush gets shot out of the cannon)
svn-id: r53616
2010-10-19 16:58:27 +00:00
Florian Kagerer
c841c3fb7c
SCUMM/FM-TOWNS: more improvements to japanese font drawing
...
- made use of LordHotos graphics/sjis code to reduce code duplication
- japanese mode for version 3 and 5 works fine now with few exceptions (some line spacing glitches in MI1 intro etc.)
svn-id: r53554
2010-10-17 13:08:00 +00:00
Johannes Schickel
36d7ec96b9
KYRA: Fix valid warnings of bug #3087837 "KYRA: Code analysis warnings".
...
svn-id: r53494
2010-10-15 14:14:10 +00:00
Max Horn
4ccce19876
ENGINES: Enhance namespace comments a bit
...
svn-id: r53484
2010-10-15 12:48:19 +00:00
Johannes Schickel
75e8452b6e
OPENGL: Merged from trunk, from rev 52105 to 53396.
...
This includes an rather hacky attempt to merge all the recent gp2x backend
changes into the branch. I suppose the gp2x backend and probably all new
backends, i.e. gph, dingux etc., might not compile anymore.
Since I have no way of testing those it would be nice if porters could look
into getting those up to speed in this branch.
svn-id: r53399
2010-10-13 03:57:44 +00:00
Torbjörn Andersson
54b2a8c98d
JANITORIAL: Cleanup (mostly whitespace)
...
svn-id: r53161
2010-10-12 04:19:58 +00:00
Florian Kagerer
5ce63fb78f
KYRA: fix regression in Screen_v2::generateOverlay()
...
(very noticeable in LOL PC-98)
svn-id: r53102
2010-10-09 14:55:33 +00:00
Florian Kagerer
ca767d5913
KYRA2/LOL PC-98: fix sfx rate
...
svn-id: r52842
2010-09-21 16:05:33 +00:00
Johannes Schickel
ec80b95580
KYRA: Fix RTL from LoL's main menu.
...
svn-id: r52835
2010-09-20 22:36:19 +00:00
Torbjörn Andersson
c91a07229a
JANITORIAL: Removed most punctuation at end of warning() and error()
...
Our warning() and error() functions always add an exclamation mark
to the end of the message anyway.
svn-id: r52791
2010-09-18 10:55:16 +00:00
Johannes Schickel
b9a74a7915
KYRA: Send GM reset on startup.
...
svn-id: r52737
2010-09-15 22:00:43 +00:00
Johannes Schickel
c6afdbdca3
KYRA3: Add some sound debug output.
...
svn-id: r52699
2010-09-13 12:19:19 +00:00
Florian Kagerer
8448c50c71
LOL FLOPPY: silence pointless warnings in character selection
...
svn-id: r52627
2010-09-07 18:50:48 +00:00
Florian Kagerer
c87b7aafd8
LOL: Add md5 for another English floppy version
...
svn-id: r52597
2010-09-06 16:50:20 +00:00
Johannes Schickel
f69bfaf355
KYRA: Get rid of local static non-POD object.
...
This fixes crashes with the plugins branch for dhewg.
svn-id: r52579
2010-09-05 22:56:25 +00:00
Johannes Schickel
b6663bb942
KYRA: Constify some tables.
...
svn-id: r52578
2010-09-05 22:56:03 +00:00
Johannes Schickel
c23f597f50
KYRA: Cleanup.
...
svn-id: r52348
2010-08-24 15:48:43 +00:00
Johannes Schickel
51939fe743
KYRA: Implement new handling of KYRA3's TLK files.
...
This speeds up loading of KYRA3's TLK files by a lot, since only the index
table will be load now. This should help the startup time for KYRA3 when
playing from CD or other slow storages.
svn-id: r52347
2010-08-24 15:48:17 +00:00
Johannes Schickel
501d7cbb84
KYRA: Simplify PAK/INS/TLK loading.
...
This also reduces the number of seeks done while loading TLK files.
svn-id: r52346
2010-08-24 15:47:53 +00:00
Johannes Schickel
feff6fecdf
KYRA: Cleanup.
...
svn-id: r52340
2010-08-24 13:41:24 +00:00
Johannes Schickel
c913ffe83f
KYRA: Add support for playing KYRA3 from CD.
...
svn-id: r52336
2010-08-24 13:11:12 +00:00
Florian Kagerer
b55a70acb8
KYRA/TOWNS: fix memory leak and some cleanup
...
svn-id: r52232
2010-08-20 17:04:32 +00:00
Johannes Schickel
d8d8857276
KYRA: Remove superfluous music fade out on Kyra 3 startup.
...
svn-id: r52201
2010-08-19 02:39:07 +00:00
Johannes Schickel
2985d27e40
KYRA: Cleanup.
...
svn-id: r52200
2010-08-19 02:38:42 +00:00
Eugene Sandulenko
4d64004aa7
KYRA: Fix array index out of bounds
...
svn-id: r52147
2010-08-17 11:00:53 +00:00
Alejandro Marzini
b0409d6739
Merge trunk, from r51777 to r52105
...
svn-id: r52108
2010-08-16 00:21:07 +00:00
Florian Kagerer
581935dda4
KYRA: add new GUIO_MIDIAMIGA flag to amiga targets
...
svn-id: r51996
2010-08-11 18:56:50 +00:00
Florian Kagerer
054c586bcc
KYRA/TOWNS: some minor sound improvements
...
(some cleanup to internal driver volume control, minor frequency change for fm-towns)
svn-id: r51930
2010-08-08 17:34:32 +00:00
Florian Kagerer
f4d38ccd40
LOL: added english floppy version
...
svn-id: r51834
2010-08-07 14:38:07 +00:00
Alejandro Marzini
33e40e1a20
Merged from trunk, from r51495 to r51775
...
svn-id: r51776
2010-08-06 03:21:21 +00:00
Johannes Schickel
9cd333152b
KYRA: Add support for subtitle options changes via GMM.
...
svn-id: r51757
2010-08-05 14:41:00 +00:00
Florian Kagerer
e5ffc7847c
AUDIO: Implement volume and balance control for the AudioCD manager (needed for music fading in Kyra 1 FM-Towns and probably other FM-Towns games). This addition applies to emulated CD audio only for now. I haven't found a way to implement this for real CDs yet. SDL doesn't seem to support this (but it might be just me? If anyone knows more about this, just tell me).
...
svn-id: r51741
2010-08-04 16:53:09 +00:00
Florian Kagerer
3fc3a59139
KYRA/TOWNS: replace some music stops with fadeouts (based on original code)
...
svn-id: r51708
2010-08-03 18:19:25 +00:00
Florian Kagerer
824a5f32a0
LOL: fixed possible crash in environmental sfx code
...
svn-id: r51706
2010-08-03 16:54:39 +00:00
Johannes Schickel
13824582d1
LOL: Minor adjustment to latest generateOverlay changes.
...
svn-id: r51705
2010-08-03 16:43:57 +00:00
Johannes Schickel
64585b40eb
KYRA: Get rid of Screen_LoL::generateLevelOverlay.
...
This function is actually exactly the same as Screen_v2::generateOverlay,
after I fixed the implementation of the latter last commit.
svn-id: r51704
2010-08-03 16:22:12 +00:00
Johannes Schickel
14c9522d77
KYRA: Fix Screen_v2::generateOverlay implementation.
...
svn-id: r51703
2010-08-03 16:21:45 +00:00
Johannes Schickel
b149ca89d5
KYRA3: Fix bug in Screen_v2::generateOverlay.
...
Uncovered by a valgrind warning.
svn-id: r51698
2010-08-03 15:09:39 +00:00
Florian Kagerer
5962b0bbe2
KYRA/TOWNS: implement music/sfx volume control via GUI/GMM
...
svn-id: r51695
2010-08-03 14:58:01 +00:00
Johannes Schickel
4e33b7a3be
GRAPHICS: Renamed skipThumbnailHeader to skipThumbnail.
...
svn-id: r51668
2010-08-02 22:28:30 +00:00
Florian Kagerer
2964e9213d
KYRA2: fix warning
...
svn-id: r51650
2010-08-02 19:00:46 +00:00
Florian Kagerer
9c8b465505
KYRA: FM-Towns audio driver rewrite
...
- FM-Towns euphony driver completely rewritten based on KYRA FM-Towns and LOOM towns disasm.
- Split all the emu and driver code from sound_towns.cpp into different files to make things a bit less confusing.
- Move the driver code to common space since the exact same euphony driver is used by LOOM which means we could get rid of the outdated and incomplete ym2612 driver/emu implementation (which doesn't even do things like instrument loading, pan position, etc). I haven't tried to add this to the Scumm engine yet, since I am not familiar with it and my priority was to get the driver finished first. But from the look of disasm it shouldn't be difficult to do.
- Introduce a generic FM-Towns audio interface based on FM-Towns system file disasm which was necessary for the euphony driver rewrite. Every FM-Towns game I have seen so far seems to access the audio hardware via these system functions. This interface implementation will also allow reasonably simple creation of new FM-Towns audio drivers (e.g. this could be used for Kings Quest 5 FM-Towns or others).
- Move the PC98 driver to common space, too, since I have a strong feeling that this driver is also used in the PC98 version of Future Wars
- This also improves KYRA FM-Towns music quality, sound effects accuracy and music fading.
svn-id: r51645
2010-08-02 18:30:25 +00:00
Alejandro Marzini
fb4086cadb
Merged from trunk, from Rev 50841 to HEAD
...
svn-id: r51495
2010-07-30 05:28:09 +00:00
Johannes Schickel
93e8daec20
KYRA: Formatting.
...
svn-id: r51368
2010-07-27 13:25:35 +00:00
Johannes Schickel
3c0765ae78
KYRA: Fix assertion when using "enter" to scene with instant death.
...
svn-id: r51324
2010-07-26 17:03:45 +00:00
Johannes Schickel
9fc67f5c0b
KYRA: Mark Kyra 1 Mac as General MIDI only.
...
It might be noteworthy that we do not support the music yet, but that might
change one day. We also do not mark the Kyra 1 Mac CD as GM only, since
that uses the included DOS sound files for now.
svn-id: r51221
2010-07-23 20:55:44 +00:00
Johannes Schickel
6da04bc13b
KYRA: Implement support for selecting the VQA quality via "video_quality".
...
svn-id: r51187
2010-07-23 00:39:23 +00:00
Johannes Schickel
cef77cdae2
KYRA: Formatting fixes.
...
svn-id: r51186
2010-07-23 00:38:52 +00:00
Johannes Schickel
ba8ec806ba
KYRA: Cleanup.
...
svn-id: r51183
2010-07-23 00:13:21 +00:00
Johannes Schickel
6cf1b59742
KYRA: Implemented some missing timers for object creation.
...
svn-id: r51182
2010-07-23 00:12:52 +00:00
Johannes Schickel
795062d8e7
KYRA: Cleanup.
...
svn-id: r51181
2010-07-23 00:12:29 +00:00
Johannes Schickel
4b2fca203e
KYRA: Implement missing dialog code.
...
This finally enables animations for all of Darm's talk sequences.
svn-id: r51179
2010-07-22 23:16:33 +00:00
Johannes Schickel
7fb37db81e
KYRA: Move LoL specific static data to its own file.
...
svn-id: r51175
2010-07-22 22:00:46 +00:00
Johannes Schickel
d776498282
KYRA: Cleanup.
...
svn-id: r51173
2010-07-22 21:46:39 +00:00
Johannes Schickel
4e02acec85
KYRA: Implement proper fade out when skipping the intro at any position.
...
svn-id: r51172
2010-07-22 21:46:17 +00:00
Johannes Schickel
9f1c8f149d
KYRA: Free hand shapes after the Kallak writing sequence.
...
svn-id: r51171
2010-07-22 21:45:55 +00:00
Johannes Schickel
a3b3febb96
KYRA: Prevent fast fade to black when skipping the intro.
...
svn-id: r51170
2010-07-22 21:45:33 +00:00
Johannes Schickel
f48cb3cbb5
KYRA: Remove superfluous palette update on quit.
...
svn-id: r51169
2010-07-22 21:45:12 +00:00
Johannes Schickel
2e14869867
KYRA: Properly short-circuit after the SC/MP logo on quit.
...
svn-id: r51163
2010-07-22 20:34:09 +00:00
Johannes Schickel
9b347782ed
Display the MacPlay Gold logo for Macintosh versions which include it.
...
svn-id: r51161
2010-07-22 20:11:09 +00:00
Johannes Schickel
44aab95eb9
KYRA: Fix mute setting with MIDI and FM-Towns/PC98 output.
...
svn-id: r51105
2010-07-21 20:26:40 +00:00
Johannes Schickel
e95ef4f5f8
KYRA: Respect mute setting on engine startup.
...
svn-id: r51098
2010-07-21 19:20:10 +00:00
Johannes Schickel
fcc9de35e2
Strip trailing whitespaces.
...
svn-id: r51093
2010-07-21 18:15:39 +00:00
Max Horn
1d4c82885d
DEBUGGER: Simplify how our console debugger works / is used
...
* Remove _isAttached member var and isAttached method
* Engines now always call the onFrame method; whether it does
something is decided by the debugger class resp. its subclasses
* Make detach() protected instead of private, so that subclasses
can invoke it
* Remove _detach_now member var (call detach() instead).
* Rename _frame_countdown to _frameCountdown and properly
document it.
* Add more doxygen comments
* Cleanup
svn-id: r50963
2010-07-17 18:38:42 +00:00
Johannes Schickel
bf17cc1053
In the help of making the new C++ standard a better one, we will now no longer rely on using parent class names in friend classes of a subclass.
...
svn-id: r50952
2010-07-16 23:30:29 +00:00
Torbjörn Andersson
17dcf79936
Cleanup
...
svn-id: r50949
2010-07-16 23:09:13 +00:00
Torbjörn Andersson
4a52413a46
Removed unused variable.
...
svn-id: r50948
2010-07-16 23:04:59 +00:00
Alejandro Marzini
609e08d5db
Merged from trunk, from Rev 49499 to HEAD
...
svn-id: r50840
2010-07-13 04:31:15 +00:00
Florian Kagerer
02cac2d5aa
KYRA/PC98: fix music volume
...
svn-id: r50772
2010-07-09 21:36:59 +00:00
Florian Kagerer
aefc42ab0e
KYRA/PC98 Audio: fix invalid mem access
...
svn-id: r50608
2010-07-03 00:06:54 +00:00
Florian Kagerer
a6e07f01bb
KYRA/PC98: fix long standing bug were certain sound effects would bring each other out of tune
...
svn-id: r50604
2010-07-02 21:27:36 +00:00
Florian Kagerer
022808fda6
KYRA/PC98: cleanup
...
svn-id: r50603
2010-07-02 19:47:14 +00:00
Florian Kagerer
5625c6d1ee
KYRA/PC98: fix sfx volume control
...
svn-id: r50602
2010-07-02 19:08:22 +00:00
Florian Kagerer
eb84a130ad
KYRA/PC98: minor cleanup
...
svn-id: r50563
2010-07-01 18:34:14 +00:00
Florian Kagerer
cc243bae34
KYRA/PC98: implement proper volume control (which distinguishes between music and sfx)
...
svn-id: r50561
2010-07-01 17:47:46 +00:00
Florian Kagerer
a0f42b07ce
KYRA: change audio detection flags setting (since most users don't own a real mt-32/lapc1/cm32l/cm64 device and our emulator is incomplete)
...
svn-id: r50452
2010-06-28 17:03:04 +00:00
Florian Kagerer
c35e350531
AUDIO: get rid of MDT_PREFER_MIDI since it should be sufficient to either select MDT_PREFER_MT32 or MDT_PREFER_GM
...
svn-id: r50288
2010-06-25 20:51:57 +00:00
Florian Kagerer
6561b93f1e
KYRA: fixed typo
...
svn-id: r50283
2010-06-25 19:06:10 +00:00
Florian Kagerer
e34d7342f5
KYRA: implement new gui option flags
...
svn-id: r50282
2010-06-25 18:57:50 +00:00
Max Horn
bbad3f333a
Patch #1956501 : "GUI/LAUNCHER: Midi device selection"
...
svn-id: r50128
2010-06-21 21:36:36 +00:00
Eugene Sandulenko
44a39ffbc6
AdvancedDetector: Add new parameter directoryGlobs.
...
Without this parameter mass detection gave tons of false alarms.
Use globbing for narrowing down the depth search.
svn-id: r49788
2010-06-15 10:59:23 +00:00
Eugene Sandulenko
d137b4610a
Split out detection code in Kyra engine.
...
svn-id: r49695
2010-06-15 10:15:51 +00:00
Alejandro Marzini
e1ef3cd9fc
Renamed getAudioCD to getAudioCDManager.
...
svn-id: r49678
2010-06-15 04:13:12 +00:00
Eugene Sandulenko
4d517ed0e9
Extended advancedDetector with depth parameter.
...
Now AD can search nested directories. By default it is turned off,
but there is new parameter to ADParameters struct. Usually value
of 2 is good enough for all purposes.
svn-id: r49653
2010-06-14 14:50:23 +00:00
Alejandro Marzini
e991cd8c53
- Revised abstract AudioCDManager.
...
- Removed AudioCDManager Singleton, and changed code for using AudioCDManager in OSystem.
- Added initialization code for new AudioCDManager in BaseBackend and OSystem_SDL.
svn-id: r49548
2010-06-09 20:09:57 +00:00
Johannes Schickel
0fe2ba6a0d
Some more enforcement of our formatting conventions in KYRA too.
...
svn-id: r49069
2010-05-17 23:29:44 +00:00
Johannes Schickel
7da8c8949b
Replace KYRA's strncpy and strncat usages by strlcpy/strlcat.
...
svn-id: r48954
2010-05-05 17:53:30 +00:00
Max Horn
2149a2383d
Reduce indirect header dependencies further
...
svn-id: r48936
2010-05-04 12:00:16 +00:00
Max Horn
970745e60c
Move DebugChannel related code to new header
...
svn-id: r48935
2010-05-04 11:59:22 +00:00
Max Horn
b3e404109c
Move initGraphics and initCommonGFX from to new header.
...
These functions are only used internally be Engine subclasses, and
by moving them to a separate header we can reduce indirect header
dependencies.
svn-id: r48934
2010-05-04 11:58:12 +00:00
Florian Kagerer
45debce66e
KYRA: fixed some cppcheck warnings
...
svn-id: r48879
2010-05-01 12:55:32 +00:00
Max Horn
460d69e885
COMMON: Move DebugChannel stuff into a new DebugMan singleton
...
svn-id: r48821
2010-04-27 21:40:52 +00:00
Johannes Schickel
23ed4c2a76
Revert "Fix use of "friend" keyword in KYRA for strict C++ compilers."
...
Actually g++ is just fine in this case :-). The thing I missed here
was that I declared the "offending" classes as friends in subclasses
of KyraEngine_v1, thus those friends were allowed to access the
protected elements of KyraEngine_v1 too.
svn-id: r48643
2010-04-12 19:50:40 +00:00
Johannes Schickel
050aca584b
Fix use of "friend" keyword in KYRA for strict C++ compilers.
...
Unlike g++, which does inherit friends (it seems), C++ does
specify that friend is not inherited. I.e. when B is a friend of
A and you have a class C subclassing B, C is not allowed to
access private memebers of A.
svn-id: r48641
2010-04-12 19:10:21 +00:00
Max Horn
a1840bd573
AUDIO: Rename Mixer::playInputStream to playStream
...
svn-id: r48637
2010-04-12 09:14:17 +00:00
Johannes Schickel
b928da4418
Setup and destroy a dummy cursor and palette in the Engine class.
...
The idea behind this is exactly the same as behind r48620,
but it affects all engines, thus engine authors can now use
CursorMan.replaceCursor without having to worry about possible
memory leaks or the like.
svn-id: r48626
2010-04-11 18:30:42 +00:00
Johannes Schickel
175a81ce98
Fix KYRA's cursor handling by pushing a dummy cursor via CursorMan.pushCursor too. Also replace CursorMan.popAllCursors by CursorMan.popCursor to prevent the caller's cursor from being destroyed.
...
svn-id: r48621
2010-04-11 17:27:33 +00:00
Johannes Schickel
cf85c0b318
Fix bug #2985387 "KYRA1: Crash at the end of game".
...
svn-id: r48617
2010-04-11 15:05:26 +00:00
Ori Avtalion
aee05cd21d
Remove extra semicolons
...
svn-id: r48457
2010-04-01 15:03:08 +00:00
Max Horn
4bac9e1b75
COMMON: Cleanup ConfigManager code
...
* get rid of ConfigManager::_emptyString
* get rid of ConfigManager::Domain::get (use getVal instead)
* remove some dead code
svn-id: r48417
2010-03-29 20:31:23 +00:00
Johannes Schickel
5315993ffc
Remove pointer dereferencation in a place, where the result is not used at all.
...
svn-id: r48396
2010-03-24 21:39:02 +00:00
Max Horn
92c896d883
Patch #2973290 : Semicolon cleanup
...
svn-id: r48359
2010-03-22 20:28:08 +00:00
Johannes Schickel
01f5610836
Fix out of bounds access.
...
svn-id: r48338
2010-03-20 20:25:37 +00:00
Max Horn
cac0ac66e2
COMMON: Get rid of Common::StringList
...
svn-id: r48287
2010-03-18 15:54:40 +00:00
Max Horn
d78dba3bca
COMMON: Move Common::RandomSource to common/random.*
...
svn-id: r48279
2010-03-18 15:07:11 +00:00
Max Horn
4e99cfc549
Switch from Common::tag2string(foo).c_str() to tag2str(foo)
...
svn-id: r48276
2010-03-18 15:04:38 +00:00
Torbjörn Andersson
65585f6433
Silenced some harmless cppcheck warnings about unreachable code after a return.
...
In this case, it was always a break after a return in a switch case. There are
similar cases which cppcheck didn't detect, and a couple of cases where we have
a break after a continue in a switch case (where the continue refers to an
outer loop), but I didn't touch those. Not yet, at least.
svn-id: r48218
2010-03-10 06:39:23 +00:00
Max Horn
f24cc1c8be
Tweak makeVOCDiskStream
...
* now takes a SeekableReadStream *pointer* like (almost) all other
audiostream factories
* fix potential memory leak in it
* rename takeOwnershipOfStream to disposeAfterUse for consistency
svn-id: r48184
2010-03-08 10:27:42 +00:00
Johannes Schickel
4221460f6d
Fix item exchange string in Kyra 1 Amiga (both English and German).
...
svn-id: r48159
2010-03-04 16:34:27 +00:00
Yotam Barnoy
ef330ed9b4
Patch for bug 2943361 by littleboy, adding full kb modifier support to all engines + GUI and proper keypad handling
...
svn-id: r48101
2010-02-21 04:04:13 +00:00
Johannes Schickel
049b4384bc
Fix for bug #2954279 "KYRA: Error when loading non-existent savegame".
...
svn-id: r48089
2010-02-19 14:05:55 +00:00
Johannes Schickel
c8470e1d89
Use Common::KEYCODE_* instead of ASCII values for keycode comparison.
...
svn-id: r48079
2010-02-17 16:18:23 +00:00
Johannes Schickel
5d6b9af72a
Use Common::KeyCode instead of int as key type for KeyMap.
...
svn-id: r48078
2010-02-17 16:08:47 +00:00
Florian Kagerer
9b6042efb4
LOL: fixed script bug in castle cimmeria that would cause out of bounds mem access (should fix bug #2948109 )
...
svn-id: r48016
2010-02-09 21:09:29 +00:00
Florian Kagerer
d4a0375f7e
LOL: fixed handling of invalid monster attack sfx in the Urbish mines (should fix bug no #2945950 )
...
svn-id: r47967
2010-02-07 16:12:31 +00:00
Johannes Schickel
fe35d372da
- Rename FlacStream to FLACStream.
...
- Rename makeFlacStream to makeFLACStream.
svn-id: r47846
2010-02-03 09:42:11 +00:00
Johannes Schickel
a505d32eff
Replace use of Audio::makeRawMemoryStream by Audio::makeRawStream.
...
svn-id: r47716
2010-01-30 15:26:54 +00:00
Johannes Schickel
8e69a24783
Fix yet another use of possibly undefined behavior reported by syke.
...
svn-id: r47689
2010-01-29 23:52:58 +00:00
Johannes Schickel
595a2e16f1
Fix use of undefined behavior. (Thanks to syke for reporting)
...
svn-id: r47685
2010-01-29 22:43:23 +00:00
Johannes Schickel
812603e29e
Fix invalid sample position on Timestamp to sample conversion for Stereo streams.
...
svn-id: r47591
2010-01-27 08:08:33 +00:00
Max Horn
1565f14bc1
Moved audio stream implementations (for MP3, FLAC, etc.) to new dir sound/decoders/
...
svn-id: r47579
2010-01-26 22:48:45 +00:00
Johannes Schickel
2eb16caade
Remove HACK, which is obsolete because of r47336.
...
svn-id: r47548
2010-01-25 03:05:39 +00:00
Johannes Schickel
aed02365ec
Strip trailing spaces/tabs.
...
svn-id: r47541
2010-01-25 01:39:44 +00:00
Torbjörn Andersson
45cbc7b265
Fixed warning.
...
svn-id: r47504
2010-01-24 17:24:11 +00:00
Florian Kagerer
4eb077dcf3
LOL: save/load menu speed up
...
svn-id: r47501
2010-01-24 15:40:36 +00:00
Max Horn
4b996e7de7
Reorder params to Audio::makeRawMemoryStream
...
svn-id: r47492
2010-01-23 23:55:35 +00:00
Johannes Schickel
4fcc82e7a6
Paranoia change: add some explicit terminating 0 after some strncpy uses.
...
svn-id: r47479
2010-01-23 16:15:18 +00:00
Max Horn
b036392a7b
Get rid of deprecated makeRawDiskStream variants; rename deprecated makeRawMemoryStream variant to makeRawMemoryStream_OLD; adapt some code to this change
...
svn-id: r47472
2010-01-23 13:34:29 +00:00
Torbjörn Andersson
4818467908
Silenced some more cppcheck warnings. Some of these may seem silly, but the way
...
I figure it the changes are harmless at worst, and making them will make it
easier to find real errors in the (still quite long) list of warnings.
svn-id: r47443
2010-01-22 19:05:02 +00:00
Max Horn
dc5e08e623
Move raw audio flags from sound/mixer.h to sound/raw.h
...
svn-id: r47395
2010-01-19 22:30:33 +00:00
Max Horn
557bb394de
Get rid of Mixer::FLAG_AUTOFREE.
...
Also fix several recently introduced new/delete vs. malloc/free mismatches.
svn-id: r47369
2010-01-19 00:56:29 +00:00
Max Horn
69be747621
Move raw audio streams to new header sound/raw.h
...
svn-id: r47368
2010-01-19 00:54:06 +00:00
Max Horn
349fcd1d71
Rename 'Linear' audio streams to 'raw'
...
svn-id: r47367
2010-01-19 00:52:41 +00:00
Florian Kagerer
0fd8008296
LOL: minor key map fix
...
svn-id: r47359
2010-01-18 19:15:05 +00:00
Florian Kagerer
4c9f323199
LOL: cleanup last commit
...
svn-id: r47354
2010-01-18 07:21:54 +00:00
Florian Kagerer
371a2a9ee9
LOL: fixed spell array size
...
svn-id: r47353
2010-01-18 00:56:30 +00:00
Johannes Schickel
e11e9338d1
Delay the time a sysEx takes to send instead of the old (incorrect) way of delaying only 45ms between two sysEx calls. (Code thankfully borrowed from waltervn).
...
svn-id: r47336
2010-01-17 02:42:31 +00:00
Max Horn
7ec2da968c
Switch most AudioStream factories to use DisposeAfterUse::Flag
...
svn-id: r47334
2010-01-16 21:36:08 +00:00
Johannes Schickel
0d995c5920
Rename all "Adlib" uses to "AdLib" to match the real name of the sound card / company.
...
Check this for reference:
http://en.wikipedia.org/wiki/Ad_Lib,_Inc .
http://www.crossfire-designs.de/images/articles/soundcards/adlib.jpg (note the upper left of the card)
This commit does not touch "adlib" and "ADLIB" uses!
Also it does not update all the SCUMM detection entries, which still use "Adlib".
svn-id: r47279
2010-01-12 21:07:56 +00:00