Commit Graph

6125 Commits

Author SHA1 Message Date
Willem Jan Palenstijn
f280789afe SCI: Don't suppress loop delta in SCI1 midi
This fixes bug #3293354.
2013-04-16 23:10:09 +02:00
Willem Jan Palenstijn
457f5da095 SCI: Don't suppress end-of-track delta in SCI0 midi
This fixes the main part of bug #3487090.
This seems to be a conversion error from SCI1's channel mixing to SCI0's
channel filtering code.
2013-04-16 23:04:33 +02:00
Matthew Hoops
8a50d87445 SCI: Fix potential memory leak with Mac cursor's hotspot 2013-04-16 11:14:04 -04:00
Matthew Hoops
6c1b019056 SCI: Fix mac cursor memory leak 2013-04-16 11:09:30 -04:00
Willem Jan Palenstijn
0250fd8ee1 SCI: Fix hunk entry leak 2013-04-15 21:46:09 +02:00
Willem Jan Palenstijn
2c9fe1d2c6 SCI: Fix memory leak 2013-04-15 21:40:11 +02:00
Willem Jan Palenstijn
f5a6ad6ab9 SCI: Fix memory leak 2013-04-15 21:38:21 +02:00
Willem Jan Palenstijn
8d184cddf7 SCI: Add missing break 2013-04-15 21:35:18 +02:00
Willem Jan Palenstijn
d17029dca2 SCI: Add missing break 2013-04-15 21:14:32 +02:00
Willem Jan Palenstijn
e34bfce2c2 SCI: Remove useless checks 2013-04-15 21:05:44 +02:00
Willem Jan Palenstijn
fbc1aac6a9 SCI: Fix uninitialized variables 2013-04-15 21:02:27 +02:00
Willem Jan Palenstijn
3f8d2fae8a SCI: Remove unused variable 2013-04-15 20:58:22 +02:00
Filippos Karapetis
0b4ceb8bf7 SCI: Fix the entry of LSL7 French (patch #3610842) 2013-04-15 12:26:22 +03:00
Willem Jan Palenstijn
cdf1900ce0 SCI: Add signal/fade related CHECKME 2013-04-07 18:22:41 +02:00
Willem Jan Palenstijn
6f3c83bd51 SCI: Minor cleanup
(Thanks waltervn)
2013-04-06 22:28:42 +02:00
Willem Jan Palenstijn
1e1cc7309f SCI: Further clarify comment 2013-04-06 22:11:15 +02:00
Willem Jan Palenstijn
173a022f91 SCI: Clarify comment 2013-04-06 20:48:52 +02:00
Willem Jan Palenstijn
d0d9894b22 SCI: Revert "Fixed fading-related bugs #3267956 and #3041738"
This reverts commit bfef0f5a6f.
2013-04-06 20:46:15 +02:00
Willem Jan Palenstijn
6f3716ae74 SCI: Re-initialize more of MusicEntry on play
This fixes bug #3267956.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
18feefbe40 SCI: Notify scripts of completed fade when aborting it
This tweaks a fix/workaround (commit 96540686) for bugs #3266480 and #3041738.
Also add CHECKME to verify the accuracy of this workaround further.

This fixes the regressions #3291115, #3555404, #3596335 and #3610063.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
eb48325248 SCI: Revert "Added a more specific workaround for bug #3267956.[...]"
This reverts commit 5654e12575.

Conflicts:
	engines/sci/sound/soundcmd.cpp
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
da3583f569 SCI: Revert "Clarify comment from rev 5654e12 further"
This reverts commit 9f74a6eda2.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
5a2ef39335 SCI: Revert "Fix script bug #3555404 - "SCI: KQ6 Spider Scene Game Freeze""
This reverts commit 8524ebd699.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
9155e8e1a1 SCI: Revert "Properly fix bugs #3267956 and #3605377"
This reverts commit 17ca8d14b1,
except for a minor unrelated change to the workaround for bug #3605269

Conflicts:
	engines/sci/sound/soundcmd.cpp
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
0f2fae14cc SCI: Revert "Add a hack to fix bug #3596335"
This reverts commit f019d5a488.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
841b6ca540 SCI: Revert "Add a more generic solution for the problem found in bug #3605269"
This reverts commit c6320a28e4.
SSCI does not interpret signals on other channels than 15.

Conflicts:
	engines/sci/sound/soundcmd.cpp
2013-04-05 21:14:55 +02:00
Filippos Karapetis
f019d5a488 SCI: Add a hack to fix bug #3596335
Game scripts are waiting indefinitely for a song, thus we change its dataInc
selector to prevent that from happening
2013-04-04 00:37:43 +03:00
Filippos Karapetis
17ca8d14b1 Properly fix bugs #3267956 and #3605377
SCI: Only stop after fading, if the song to be faded is faded down. Also,
reset the song signal when fading starts. It was set to -1 when fading
started in bug #3267956, thus it stopped immediately.
2013-04-04 00:37:43 +03:00
Filippos Karapetis
c6320a28e4 SCI: Add a more generic solution for the problem found in bug #3605269
We now accept signals from all channels if channel 15 is missing. This
is a very rare edge case, but our behavior is now somewhat closer to what
the original interpreter seems to be doing. Mordack's appearance animation
is now synced properly. The more generic workaround works for songs 1840
and 1843, but not for 1849, which is still problematic and we still resort
to manually changing its dataInc selector
2013-04-02 10:03:48 +03:00
Filippos Karapetis
dc2d8793b9 SCI: Set the song's sound queue signal to -1 when stopping a sound, like SSCI does
Previously, we set the signal of the sound objects themselves to -1, but set the
sound queue's signal to 0. This now matches the original behavior.
2013-04-01 21:31:50 +03:00
Filippos Karapetis
2e93ee2b83 SCI: Fix bug #3605269 - "SCI: KQ5 Windows CD - Game Hangs Before Final Battle"
This is caused because songs 1840, 1843 and 1849 are all missing their special
SCI signaling channel (channel 15), so the game scripts wait indefinitely for
signals which are never set
2013-04-01 21:31:50 +03:00
Filippos Karapetis
5539323e16 SCI: Fix two script bugs in PQ1 (message tuple typos) - bug #3605654 2013-03-30 13:58:53 +02:00
Filippos Karapetis
e376535ad4 SCI: Fix script bug #3606025 - "SCI: Crazy Nick's: King Graham's Challenge Backgammon Crash"
The script in question has a bug - it was fixed for checkers, but not backgammon
2013-03-30 13:34:25 +02:00
Filippos Karapetis
d54a57ccee SCI: Stop and clear sounds that have no data. Fixes an issue in KQ6 Mac
Thanks to waltervn and clone2727 for the original patch. Tested LSL5
with this change, and the problematic sound in the mud wrestling scene
is handled correctly
2013-03-29 01:25:35 +02:00
Filippos Karapetis
51b1ec3139 SCI: Fix drawing in SCI21 hires games without breaking lowres SCI2/SCI21 games 2013-03-28 20:28:51 +02:00
Filippos Karapetis
b4df7868a1 SCI: Remove some useless checks in the MIDI driver 2013-03-27 23:06:27 +02:00
Filippos Karapetis
df751fc80b SCI: Add the Italian version of KQ6 (bug #3606719) 2013-03-22 00:33:19 +02:00
Filippos Karapetis
045b10efb6 SCI: Fix loading in Jones
This has been broken for a (very) long time, a regression from commit 6ff4dd2
2013-03-21 21:27:14 +02:00
Willem Jan Palenstijn
2d1fd3b554 ALL: Fix typo (existant->existent) 2013-02-23 22:07:32 +01:00
Filippos Karapetis
61ec6c998f SCI: Fix bug #3538416 - "SCI: SQ4 CD text glitches in introduction" 2013-02-17 20:45:16 +02:00
Filippos Karapetis
d830b27404 SCI: Fix bug #3604944 - "SCI: QFG1VGA: Missing dialogue when speaking to Kaspar" 2013-02-17 20:44:31 +02:00
Willem Jan Palenstijn
e37be9f535 SCI: Use correct priority selector in SoundCmd
It was using 'pri' instead of 'priority', apparently due to a
selector number->name translation error from 544daa5c31.

Thanks to waltervn for spotting this.
2013-01-29 20:55:40 +01:00
Willem Jan Palenstijn
f5e43484a0 SCI: Fix kReadNumber sign/hex behaviour
Negative numbers now work, and hex overflow is handled like SSCI.
Thanks to waltervn for testing.
2013-01-25 00:57:50 +01:00
Filippos Karapetis
5691a40380 SCI: Update documentation on bug #3585189 and remove an invalid TODO
Thanks wjp for pointing out some extra parameters related to pathfinding in SCI
2013-01-24 23:23:48 +02:00
Willem Jan Palenstijn
498fe75dc5 SCI: Fix shadow warning 2013-01-24 22:12:15 +01:00
Willem Jan Palenstijn
89cd5e7416 SCI: Add GetAngle for SCI1 that matches SSCI
Thanks to waltervn for creating a scis test script to verify.
2013-01-24 22:10:20 +01:00
Filippos Karapetis
b0cfe968b0 SCI: Fix bug #3585189 - "SCI: QFG1VGA - game hangs in the tavern" 2013-01-24 22:25:09 +02:00
Filippos Karapetis
0143a5d938 SCI: Bugfix for commit 0968acc: only filter out missing messages for the jar
This is to properly fix bug #3601090 without removing any functionality.
The additional check ensures that the look and hand icons work with the
jar. Many thanks to lskovlun for debugging this and providing a fix
2013-01-23 21:31:26 +02:00
Filippos Karapetis
0968acccfd SCI: Fix script bug #3601090 - "SCI: Pepper's Adventures in Time: Game becomes unsolvable"
Many thanks to lskovlun for debugging this problem and finding the
offending script code that caused it.
2013-01-23 03:17:10 +02:00
Filippos Karapetis
b1ff5ba247 SCI: Slight cleanup in kMessage() 2013-01-23 03:17:10 +02:00