Commit Graph

29525 Commits

Author SHA1 Message Date
Willem Jan Palenstijn
fbc1aac6a9 SCI: Fix uninitialized variables 2013-04-15 21:02:27 +02:00
Willem Jan Palenstijn
3f8d2fae8a SCI: Remove unused variable 2013-04-15 20:58:22 +02:00
Willem Jan Palenstijn
250967a63f WINTERMUTE: Fix warnings and improve const-correctness 2013-04-15 20:44:41 +02:00
Willem Jan Palenstijn
d4982381d2 WINTERMUTE: Fix side effect of assert 2013-04-15 20:36:03 +02:00
Willem Jan Palenstijn
e7b38a7c2a PARALLACTION: Cleanup 2013-04-15 20:35:43 +02:00
Sven Hesse
642708de4c GOB: Fix a misplaced continue / fallthrough 2013-04-15 19:07:55 +02:00
Sven Hesse
fc50db1545 GOB: Change strcpy/strcat to strlcpy/strlcat for safety 2013-04-15 19:00:26 +02:00
Einar Johan Trøan Sømåen
3ea0e7c68c WINTERMUTE: Fix leak on incomplete image load. 2013-04-15 18:57:46 +02:00
Einar Johan Trøan Sømåen
92dd483e9e WINTERMUTE: Fix comparison in renderTicket. 2013-04-15 18:57:41 +02:00
Sven Hesse
61b1a594b8 GOB: Change strcpy to strlcpy for safety 2013-04-15 18:49:00 +02:00
Sven Hesse
bbe4372f5b GOB: Add another sanity check 2013-04-15 18:42:46 +02:00
Sven Hesse
2a1308b4e1 GOB: Add a sanity check 2013-04-15 18:36:44 +02:00
Sven Hesse
e589bd4525 GOB: Fix another potential array overrun 2013-04-15 18:35:33 +02:00
Sven Hesse
3540b943cf GOB: Fix a potential array overrun 2013-04-15 18:30:12 +02:00
Sven Hesse
eb55db436d GOB: Fix a leak 2013-04-15 18:25:01 +02:00
Sven Hesse
658608d0dd GOB: Correct a delete/delete[]-mismatch 2013-04-15 18:24:09 +02:00
Sven Hesse
c053f715d6 GOB: Remove unused member variable in SaveLoad_v6 2013-04-15 18:22:49 +02:00
Sven Hesse
172aed0441 GOB: Remove unused member variables in SaveLoad_Fascination 2013-04-15 18:22:18 +02:00
Einar Johan Trøan Sømåen
dfb59711ff Merge pull request #317 from JenniBee/wintermute
WINTERMUTE: Add detection entry for Dreamscape
2013-04-15 07:01:17 -07:00
Filippos Karapetis
0b4ceb8bf7 SCI: Fix the entry of LSL7 French (patch #3610842) 2013-04-15 12:26:22 +03:00
Paul Gilbert
c13a84d7a4 HOPKINS: Renamed fields and methods in ObjectsManager 2013-04-14 15:30:37 -04:00
Paul Gilbert
ceab6a71d3 HOPKINS: Renamed remaining fields of GraphicsManager class 2013-04-14 14:21:05 -04:00
JenniBee
a8a7276c18 WINTERMUTE: Add detection entry for Dreamscape 2013-04-14 10:54:49 -04:00
athrxx
35ac7d8683 KYRA: fix bug #3610247
(KYRA2: Intro doesn't skip righ/Game won't start on first run)
2013-04-14 13:12:09 +02:00
athrxx
66a3b2b2ac KYRA: (EOB) - add debug function to export save files in original format 2013-04-14 13:12:08 +02:00
athrxx
a33045f4fa KYRA: (EOB) - fix bug #3600348
(EOB1: Crash when moving in German version)
2013-04-14 13:12:06 +02:00
JenniBee
dab51f1d89 WINTERMUTE: Add Reversion: The Escape 1.3 and fix previous detection entires. 2013-04-14 01:50:23 -04:00
Strangerke
cdefd6428f HOPKINS: Apply a couple of renamings suggested by wjp 2013-04-13 23:24:13 +02:00
JenniBee
848f44f72a WINTERMUTE: Added detection entries for Reversion: The Meeting 2013-04-13 15:27:52 -04:00
Einar Johan Trøan Sømåen
5bd1bf1d6d WINTERMUTE: Use {} instead of () in detection entries, fix build. 2013-04-13 14:49:34 +02:00
Einar Johan Trøan Sømåen
875cfa6e58 Merge pull request #295 from JenniBee/wintermute_md5_checksum
WINTERMUTE: added md5 checksum for version 1.1 of Reversion: The Escape
2013-04-13 05:37:13 -07:00
JenniBee
08520377da WINTERMUTE: Fixed the Reversion 1.1 Entries 2013-04-13 02:05:21 -04:00
Matthew Hoops
78f5e986ce PEGASUS: Add a workaround in case the player doesn't get the card bomb 2013-04-12 15:06:14 -04:00
Filippos Karapetis
95f92ed9de TINSEL: Add support for enhanced music in the Mac version of DW1 2013-04-12 19:31:11 +03:00
uruk
cfeda28885 MOHAWK: Prevent left mouse click handling if the cursor isn't visible.
This fixes bug #3488327 - "LB: Mouse events processed when they
shouldn't be".
2013-04-12 15:57:40 +01:00
Filippos Karapetis
687e47d332 TINSEL: Remove the unused ghost palette 2013-04-12 07:19:53 +03:00
Filippos Karapetis
94b328fa7f TINSEL: Fix black/white colors in the Mac version of DW1 2013-04-12 07:19:53 +03:00
Filippos Karapetis
53e82436e6 TINSEL: Simplify overflow calculation inside MacDrawTiles()
Thanks to wjp for noticing this
2013-04-12 07:19:52 +03:00
Filippos Karapetis
a9886f1c26 TINSEL: Fix typo 2013-04-12 07:19:52 +03:00
Filippos Karapetis
d45534d29d TINSEL: Remove the unused noFadeTable parameter from the fader functions 2013-04-12 07:19:52 +03:00
Eugene Sandulenko
8b315aeb49 HOPKINS: Fix warning 2013-04-11 14:58:07 +03:00
Strangerke
54e3df0140 HOPKINS: Constify some functions and members 2013-04-11 12:17:06 +02:00
Strangerke
e56123b18f HOPKINS: Make ObjectsManager even more readable 2013-04-11 00:15:10 +02:00
Strangerke
caa90241ad HOPKINS: Make ObjectsManager a bit more readable 2013-04-10 20:38:48 +02:00
Strangerke
531b3cb376 HOPKINS: Fix crash when skipping intro animations (regression in one of the lock/unlock commits) 2013-04-10 18:16:21 +02:00
Strangerke
2709ac9fcb HOPKINS: Reduce verbosity of displaySprite() 2013-04-10 15:15:31 +02:00
Strangerke
c09e0c26ec HOPKINS: Remove some magic values used by _eventMode checks 2013-04-10 13:26:26 +02:00
Strangerke
9149f363a6 HOPKINS: Finish lock/unlockScreen() cleanup. Set them as private. 2013-04-10 13:03:53 +02:00
Strangerke
bccb460e36 HOPKINS: Add lockScreen() and unlockScreen() in copyVideoVbe16() 2013-04-10 12:59:39 +02:00
Strangerke
094a0617ac HOPKINS: Add lockScreen() and unlockScreen() in copy16bFromSurfaceScaleX2() 2013-04-10 12:55:20 +02:00
Strangerke
1b081457c9 HOPKINS: Remove some useless lockScreen() and unlockScreen() around copy16BitRect() 2013-04-10 12:51:13 +02:00
Strangerke
1ac0c06bf6 HOPKINS: Reduce the use of lockScreen() and unlockScreen() by adding them in clearScreen() 2013-04-10 12:25:36 +02:00
Strangerke
5ae15d1e10 HOPKINS: Make the use of _mouseCursorId less verbose 2013-04-10 11:57:48 +02:00
Strangerke
55938b3975 HOPKINS: Make engine less verbose by reducing some object names 2013-04-10 10:27:06 +02:00
Strangerke
ef12ba27e5 HOPKINS: Janitorial: Remove useless code 2013-04-10 09:02:37 +02:00
Strangerke
f7771844f1 HOPKINS: Remove useless object reference in DialogsManager 2013-04-10 09:01:35 +02:00
Strangerke
9f4a35b011 HOPKINS: Move _oldInventoryPosX to DialogsManager, remove a useless variable 2013-04-10 09:00:08 +02:00
Strangerke
9e956d888e HOPKINS: Improve readability in DialogsManager 2013-04-10 00:24:27 +02:00
Strangerke
3e9068bb5b HOPKINS: Janitorial: Remove useless line of code 2013-04-09 23:25:24 +02:00
Paul Gilbert
260a6bbc24 HOPKINS: Renamed remaining GraphicsManager methods 2013-04-09 09:47:48 -04:00
Paul Gilbert
bfe63b71e9 HOPKINS: Renaming some of the remaining graphics methods 2013-04-09 09:17:11 -04:00
Strangerke
4d3748fb24 HOPKINS: Make Hopkins sleep a bit in order to reduce CPU usage 2013-04-09 08:31:47 +02:00
Strangerke
11183ee982 HOPKINS: Fix initialization of timers in EventsManager 2013-04-09 08:31:46 +02:00
Sven Hesse
3e1622d68a GOB: Add another Spanish DOS version of Geisha
As supplied by alestedx in bug report #3610207
2013-04-08 11:05:50 +02:00
Strangerke
5516357a8e HOPKINS: Fix glitch in Ocean Maze initialization 2013-04-08 08:07:29 +02:00
sylvaintv
9e44cd6641 HOPKINS: Add French Win95 version detection 2013-04-07 23:48:19 +02:00
Torbjörn Andersson
e08ddf70b2 KYRA: Don't restore music volume right after it has faded down
Since the music volume is set in playTrack(), it shouldn't be
necessary to set it back to the default level when a fade out has
been completed.

This change prevents the volume from spiking right before quitting
the game. I hope it doesn't cause regressions.
2013-04-07 22:10:48 +02:00
JenniBee
f9e436a1b7 WINTERMUTE: added md5 checksums for version 1.1 of Reversion: The Escape 2013-04-07 14:16:44 -04:00
Willem Jan Palenstijn
cdf1900ce0 SCI: Add signal/fade related CHECKME 2013-04-07 18:22:41 +02:00
Strangerke
0a4494a760 HOPKINS: Fix glitch when exiting computer in FBI rooms 2013-04-07 09:16:13 +02:00
Willem Jan Palenstijn
6f3c83bd51 SCI: Minor cleanup
(Thanks waltervn)
2013-04-06 22:28:42 +02:00
Willem Jan Palenstijn
1e1cc7309f SCI: Further clarify comment 2013-04-06 22:11:15 +02:00
Willem Jan Palenstijn
173a022f91 SCI: Clarify comment 2013-04-06 20:48:52 +02:00
Willem Jan Palenstijn
d0d9894b22 SCI: Revert "Fixed fading-related bugs #3267956 and #3041738"
This reverts commit bfef0f5a6f.
2013-04-06 20:46:15 +02:00
Willem Jan Palenstijn
6f3716ae74 SCI: Re-initialize more of MusicEntry on play
This fixes bug #3267956.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
18feefbe40 SCI: Notify scripts of completed fade when aborting it
This tweaks a fix/workaround (commit 96540686) for bugs #3266480 and #3041738.
Also add CHECKME to verify the accuracy of this workaround further.

This fixes the regressions #3291115, #3555404, #3596335 and #3610063.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
eb48325248 SCI: Revert "Added a more specific workaround for bug #3267956.[...]"
This reverts commit 5654e12575.

Conflicts:
	engines/sci/sound/soundcmd.cpp
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
da3583f569 SCI: Revert "Clarify comment from rev 5654e12 further"
This reverts commit 9f74a6eda2.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
5a2ef39335 SCI: Revert "Fix script bug #3555404 - "SCI: KQ6 Spider Scene Game Freeze""
This reverts commit 8524ebd699.
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
9155e8e1a1 SCI: Revert "Properly fix bugs #3267956 and #3605377"
This reverts commit 17ca8d14b1,
except for a minor unrelated change to the workaround for bug #3605269

Conflicts:
	engines/sci/sound/soundcmd.cpp
2013-04-06 20:31:34 +02:00
Willem Jan Palenstijn
0f2fae14cc SCI: Revert "Add a hack to fix bug #3596335"
This reverts commit f019d5a488.
2013-04-06 20:31:34 +02:00
Strangerke
a0d34fd294 HOPKINS: Partially revert 63b669cfc4 as it causes a regression in ComputerManager 2013-04-06 08:23:14 +02:00
Kirben
7e290c963f SCUMM: Add Italian Windows version of Freddi Fish 4. 2013-04-06 08:10:28 +11:00
Willem Jan Palenstijn
841b6ca540 SCI: Revert "Add a more generic solution for the problem found in bug #3605269"
This reverts commit c6320a28e4.
SSCI does not interpret signals on other channels than 15.

Conflicts:
	engines/sci/sound/soundcmd.cpp
2013-04-05 21:14:55 +02:00
Strangerke
89bf72ff5d HOPKINS: JANITORIAL: Remove trailing spaces and tabs 2013-04-05 08:17:26 +02:00
Strangerke
2ee8b1e342 HOPKINS: Misc cleanup 2013-04-05 07:54:56 +02:00
Strangerke
0b16ea3f3b HOPKINS: Remove useless casts, fix 2 crashes 2013-04-05 07:54:55 +02:00
Strangerke
e79a51c208 HOPKINS: Remove g_PTRNUL 2013-04-05 07:54:54 +02:00
anotherguest
f9247f0bce WINTERMUTE: Use template with MIN 2013-04-04 15:39:54 +02:00
Strangerke
4b21ec23d0 HOPKINS: Refactor searchCat to remove the use of g_PTRNUL, add a parameter to clarify the result of the function 2013-04-03 23:58:11 +02:00
Filippos Karapetis
f019d5a488 SCI: Add a hack to fix bug #3596335
Game scripts are waiting indefinitely for a song, thus we change its dataInc
selector to prevent that from happening
2013-04-04 00:37:43 +03:00
Filippos Karapetis
17ca8d14b1 Properly fix bugs #3267956 and #3605377
SCI: Only stop after fading, if the song to be faded is faded down. Also,
reset the song signal when fading starts. It was set to -1 when fading
started in bug #3267956, thus it stopped immediately.
2013-04-04 00:37:43 +03:00
Strangerke
177df0802a HOPKINS: Standardize the use of g_PTRNUL 2013-04-03 08:23:31 +02:00
Kirben
b22a9b119e SCUMM: Add Italian Windows demos of Freddi Fish 4 and Putt-Putt Enters the Game. 2013-04-03 11:36:59 +11:00
sylvaintv
f75ad49c67 HOPKINS: Fix rendering of French accentuated characters 2013-04-03 00:25:28 +02:00
Filippos Karapetis
c6320a28e4 SCI: Add a more generic solution for the problem found in bug #3605269
We now accept signals from all channels if channel 15 is missing. This
is a very rare edge case, but our behavior is now somewhat closer to what
the original interpreter seems to be doing. Mordack's appearance animation
is now synced properly. The more generic workaround works for songs 1840
and 1843, but not for 1849, which is still problematic and we still resort
to manually changing its dataInc selector
2013-04-02 10:03:48 +03:00
Torbjörn Andersson
a1168e932c SCUMM: Hardly-even-worth-mentioning cleanup. 2013-04-02 08:20:33 +02:00
Strangerke
c7d7c74753 HOPKINS: Remove useless check in loadLinkFile, remove comment. Thanks SylvainTV for pointing it 2013-04-02 07:58:12 +02:00
Strangerke
992aa0d707 HOPKINS: Rework OPTI_ONE to make it more readable, rename it 2013-04-02 00:29:20 +02:00
Strangerke
dac4cb9e67 HOPKINS: More renaming in ObjectsManager 2013-04-02 00:20:54 +02:00