Commit Graph

664 Commits

Author SHA1 Message Date
Max Horn
abe1959d36 COMMON: Simplify DECLARE_SINGLETON macro
This makes it possible to write
  DECLARE_SINGLETON(foo);
instead of
  DECLARE_SINGLETON(foo)
without causing a warning about an extra semicolon.
The extra semicolon helps some editors at parsing the C++ code.

svn-id: r54258
2010-11-16 08:23:13 +00:00
Paul Gilbert
db24b2a014 LURE: Fix for Valgrind identified memory leaks
svn-id: r54236
2010-11-14 00:35:13 +00:00
Max Horn
90b6cdfbdf LURE: Remove all uses of (f)printf; cleanup
svn-id: r54106
2010-11-07 01:03:03 +00:00
Max Horn
9a350f4398 ENGINES: Get rid of some (f)printfs
svn-id: r54011
2010-11-01 16:04:47 +00:00
Max Horn
a1dd7a07a1 ENGINES: Remove some 'using' statements
svn-id: r54001
2010-11-01 16:00:17 +00:00
Max Horn
c975ed11a1 ALL: Fix various typos (patch #3093266)
svn-id: r53762
2010-10-24 13:04:33 +00:00
Paul Gilbert
e868dcd804 LURE: Fix for #3087842 - Code analysis warnings
This is a somewhat cleaner version than my previous commit

svn-id: r53516
2010-10-15 21:13:35 +00:00
Max Horn
4ccce19876 ENGINES: Enhance namespace comments a bit
svn-id: r53484
2010-10-15 12:48:19 +00:00
Paul Gilbert
63cb051351 LURE: Fix for #3087842 - Code analysis warnings
Only the warning for res_struct.cpp is valid to be fixed

svn-id: r53469
2010-10-15 08:29:23 +00:00
Paul Gilbert
655e4a961a LURE: Bugfix for characters getting stuck in Abbey doorway
svn-id: r53402
2010-10-13 10:12:35 +00:00
Paul Gilbert
b15f51ad7b LURE: Fix for #3062794 - Diermot cannot leave room 7
svn-id: r53039
2010-10-06 09:55:41 +00:00
Paul Gilbert
c19c9482b2 LURE: Bugfix for #3008511 - Goewin stuck at counter
svn-id: r53029
2010-10-05 10:50:22 +00:00
Paul Gilbert
61afea6cbe LURE: Bugfix for #3060480 - Ratpouch alternating between rooms
svn-id: r53026
2010-10-05 09:14:18 +00:00
Paul Gilbert
f94752f752 LURE: Partial fix for #3008511 Goewin getting stuck
This workaround prevents the Weregate from closing whilst Goewin is still within it

svn-id: r52971
2010-10-02 00:08:13 +00:00
Johannes Schickel
6588398ce6 MIDI: Send a reset MIDI device signal on startup.
This is currently done in the engine code. I adapted AGI, AGOS, DRACI,
GROOVIE, LURE, MADE, QUEEN, SAGA, SKY, TINSEL and TOUCHE to send a reset
device on startup. The sound output still works fine (started up a game
from every engine), so this should hopefully not introduce any regressions.

As far as I can tell it seems that SCUMM does send a proper device reset, so
I did not touch it. KYRA only sends a proper reset for MT-32 currently. I am
not sure about SCI though.

This fixes bug #3066826 "SIMON: MIDI notes off when using RTL after SCI".

svn-id: r52736
2010-09-15 22:00:20 +00:00
Paul Gilbert
5e66329117 LURE: Workaround for bug #3047234 in English EGA version
svn-id: r52378
2010-08-25 09:28:29 +00:00
Johannes Schickel
e3d1ec482c LURE: Make LURE respect the mute settings.
svn-id: r51101
2010-07-21 20:12:35 +00:00
Max Horn
1d4c82885d DEBUGGER: Simplify how our console debugger works / is used
* Remove _isAttached member var and isAttached method
* Engines now always call the onFrame method; whether it does
  something is decided by the debugger class resp. its subclasses
* Make detach() protected instead of private, so that subclasses
  can invoke it
* Remove _detach_now member var (call detach() instead).
* Rename _frame_countdown to _frameCountdown and properly
  document it.
* Add more doxygen comments
* Cleanup

svn-id: r50963
2010-07-17 18:38:42 +00:00
Florian Kagerer
c35e350531 AUDIO: get rid of MDT_PREFER_MIDI since it should be sufficient to either select MDT_PREFER_MT32 or MDT_PREFER_GM
svn-id: r50288
2010-06-25 20:51:57 +00:00
Max Horn
bbad3f333a Patch #1956501: "GUI/LAUNCHER: Midi device selection"
svn-id: r50128
2010-06-21 21:36:36 +00:00
Eugene Sandulenko
44a39ffbc6 AdvancedDetector: Add new parameter directoryGlobs.
Without this parameter mass detection gave tons of false alarms.
Use globbing for narrowing down the depth search.

svn-id: r49788
2010-06-15 10:59:23 +00:00
Eugene Sandulenko
4d517ed0e9 Extended advancedDetector with depth parameter.
Now AD can search nested directories. By default it is turned off,
but there is new parameter to ADParameters struct. Usually value
of 2 is good enough for all purposes.

svn-id: r49653
2010-06-14 14:50:23 +00:00
Max Horn
2149a2383d Reduce indirect header dependencies further
svn-id: r48936
2010-05-04 12:00:16 +00:00
Max Horn
970745e60c Move DebugChannel related code to new header
svn-id: r48935
2010-05-04 11:59:22 +00:00
Max Horn
b3e404109c Move initGraphics and initCommonGFX from to new header.
These functions are only used internally be Engine subclasses, and
by moving them to a separate header we can reduce indirect header
dependencies.

svn-id: r48934
2010-05-04 11:58:12 +00:00
Max Horn
460d69e885 COMMON: Move DebugChannel stuff into a new DebugMan singleton
svn-id: r48821
2010-04-27 21:40:52 +00:00
Paul Gilbert
eb4e7b4c77 Bugfix for making Goewin more smoothly follow player out of the caves
svn-id: r48813
2010-04-27 11:00:43 +00:00
Paul Gilbert
5a4df6fc95 Minor bugfix for the shop-keeper sequence when you're viewing through the window - it was supposed to check whether Gwyn, rather than Goewin, is not in the room before sticking his fingers in his ears
svn-id: r48812
2010-04-27 10:59:28 +00:00
Torbjörn Andersson
2e89d9607d Fixed GCC warning about 'hotspotId' shadowing a member of 'this'. Let's call
the variable 'charId' instead, like in the debug messages where it's used.

svn-id: r48759
2010-04-21 05:30:38 +00:00
Paul Gilbert
dead0db8d8 Corrected a debug statement that could use an object field after the object was destroyed
svn-id: r48741
2010-04-20 10:13:27 +00:00
Paul Gilbert
f1979f936f Bugfix for correctly returning follower to player when they're blocked from acting
svn-id: r48709
2010-04-19 09:40:20 +00:00
Paul Gilbert
f7ac94db12 Added code to de-activate town NPCs once the player makes it to the castle, since they're no longer needed
svn-id: r48661
2010-04-16 10:00:49 +00:00
Paul Gilbert
cbee83a536 Added a default case for characters that don't have a message set, but try to display one
svn-id: r48656
2010-04-14 09:33:27 +00:00
Ori Avtalion
003922f43d Remove unnecessary 'extern' keywords
svn-id: r48598
2010-04-09 13:46:10 +00:00
Paul Gilbert
4aacbc5351 Corrected check to ensure return isn't issued if it's already in progress
svn-id: r48535
2010-04-05 07:27:16 +00:00
Paul Gilbert
29a8cb651a Bugfix for correctly getting a follower to return to player when blocked from exiting a room 5 times
svn-id: r48533
2010-04-05 06:07:14 +00:00
Paul Gilbert
7555461ac3 Application of patch #2981748 - Make VGA detection entries take precedence over EGA for command line detection
svn-id: r48532
2010-04-05 01:49:00 +00:00
David Turner
067fbe23f6 Fix for Lure memory error indicated by Valgrind on Restart/Restore Screen (Temptress over Castle).
This screen is displayed if you lose the fight with the Skorl in the Dragon Caves etc.

This fix should be reviewed and then backported to v1.1.0 branch.

svn-id: r48421
2010-03-30 02:13:49 +00:00
Paul Gilbert
b39222d611 Corrected deallocated of menu data reported by Valgrind
svn-id: r48412
2010-03-27 22:00:16 +00:00
Paul Gilbert
8dfd670b22 Added explicit initialisation of NPC directions in the hotspot constructors
svn-id: r48406
2010-03-26 22:16:45 +00:00
Max Horn
92c896d883 Patch #2973290: Semicolon cleanup
svn-id: r48359
2010-03-22 20:28:08 +00:00
Max Horn
cac0ac66e2 COMMON: Get rid of Common::StringList
svn-id: r48287
2010-03-18 15:54:40 +00:00
Max Horn
d78dba3bca COMMON: Move Common::RandomSource to common/random.*
svn-id: r48279
2010-03-18 15:07:11 +00:00
Johannes Schickel
40562798d6 Fix our DECLARE_SINGLETON macro to conform to the C++ specs.
We need to use a namespace Common { } there to make strict C++ compilers
like clang++ and comeau happy. I also added a slight comment about why
that is needed to the macro definition and a note that you need to use
it from the global namespace.

svn-id: r48254
2010-03-13 21:55:49 +00:00
Yotam Barnoy
ef330ed9b4 Patch for bug 2943361 by littleboy, adding full kb modifier support to all engines + GUI and proper keypad handling
svn-id: r48101
2010-02-21 04:04:13 +00:00
Johannes Schickel
bfcdbae648 Change some comments to use "AdLib" instead of "adlib".
svn-id: r47534
2010-01-25 00:39:46 +00:00
Arnaud Boutonné
1f79fd5788 Some more header modifications ("Graphic Adventure Engine" and the legal property paragraph)
svn-id: r47489
2010-01-23 22:50:24 +00:00
Torbjörn Andersson
4818467908 Silenced some more cppcheck warnings. Some of these may seem silly, but the way
I figure it the changes are harmless at worst, and making them will make it
easier to find real errors in the (still quite long) list of warnings.

svn-id: r47443
2010-01-22 19:05:02 +00:00
Max Horn
bce959e046 LURE: Remove evil 'using namespace' from header files
svn-id: r47396
2010-01-19 23:48:55 +00:00
Torbjörn Andersson
428f8d6955 Fixed some cppcheck warnings.
svn-id: r47393
2010-01-19 20:41:51 +00:00