7918 Commits

Author SHA1 Message Date
Johannes Schickel
282ebbb0e5 Commit of patch #2207782 "ARCHIVE: New method 'getMember'".
svn-id: r34871
2008-11-01 12:49:29 +00:00
Nicola Mettifogo
cd3011e408 Fixed assorted leaks in NS Amiga.
svn-id: r34870
2008-11-01 12:39:01 +00:00
Nicola Mettifogo
73cf59b518 Removed reference to Common::File in music code, and small cleanup.
svn-id: r34861
2008-10-29 08:16:13 +00:00
Nicola Mettifogo
8c5f9f9451 Cleanup of Nippon Safes disk code.
svn-id: r34860
2008-10-29 07:57:48 +00:00
Filippos Karapetis
26642748f9 Removed FIXME and reverted commit #34855, as it's now possible to add a subfolder to a non-existing folder without crashes with the change in commit #34857
svn-id: r34858
2008-10-27 11:04:36 +00:00
Filippos Karapetis
ea8e06fcf9 Implemented FR #2038951: "ALL: visible warning when CD music missing"
svn-id: r34856
2008-10-26 19:27:26 +00:00
Filippos Karapetis
c03f0219ca Using getChild() with getChild() throws an assertion (a regression of the latest FS node changes). Commenting out this line with a FIXME so that SAGA games can work once again under Windows
svn-id: r34855
2008-10-26 18:40:59 +00:00
Filippos Karapetis
b7a219ebc6 Renamed engine feature kSupportsDirectLoad to kSupportsLoadingDuringStartup, as discussed in patch #2122869
svn-id: r34854
2008-10-26 16:42:08 +00:00
Torbjörn Andersson
331c38e1c7 Added semi-ugly workaround for bug #2182450 ("BS1 Demo: Crash due to missing
speech segment").

svn-id: r34853
2008-10-26 15:20:24 +00:00
Torbjörn Andersson
c8312fdacc Another attempt at making the Broken Sword 1 savegame list in the launcher match
the in-game one. Only show savegames which actually have a corresponding save
file. (That's a trick the in-game dialog doesn't know yet.) The match isn't
perfect, though: The launcher lists the first save slot as 0, while the in-game
dialog lists it as 1. But changing the launcher one will make it set the wrong
"save_slot" value.

svn-id: r34851
2008-10-26 11:19:10 +00:00
Nicola Mettifogo
064b816b08 Cleaned up disk code after recent updates to Common::SearchSet.
svn-id: r34848
2008-10-26 09:15:57 +00:00
Torbjörn Andersson
e3312288d7 Removed obsolete FIXME.
svn-id: r34846
2008-10-23 16:58:01 +00:00
Max Horn
d387206175 Pushed down some header deps
svn-id: r34845
2008-10-23 07:59:10 +00:00
Travis Howell
de8dedf3c3 Add missing break to processSpecialKeys().
svn-id: r34843
2008-10-23 00:26:45 +00:00
Kari Salminen
5252f07305 Remove unnecessary function overloadings for loadBg16 and loadBg256.
svn-id: r34840
2008-10-22 20:45:25 +00:00
Kari Salminen
4d4042df36 Shut up MSVC and add FIXMEs to Sword's listSaves and ThemeEngine's loadThemeXML.
svn-id: r34839
2008-10-22 20:29:17 +00:00
Kari Salminen
b9709b5793 Make incrustMask and incrustSprite only draw to the current background in Operation Stealth.
svn-id: r34838
2008-10-22 19:56:38 +00:00
Johannes Schickel
7d331b7341 Committed updated version of my patch #2184529 "SearchSet: Get rid of SharedPtr usage".
svn-id: r34837
2008-10-22 17:44:12 +00:00
Johannes Schickel
cd38ddc542 Cleanup.
svn-id: r34831
2008-10-21 11:42:08 +00:00
Johannes Schickel
a5a73ff9d6 Formatting.
svn-id: r34830
2008-10-20 21:55:20 +00:00
Torbjörn Andersson
07220529dc Fix - at least partially - the list of savegames for the launcher's load dialog.
But I suspect there are still bugs lurking in that code. I really dislike how
Broken Sword 1 handles savegames...

svn-id: r34829
2008-10-20 21:47:46 +00:00
Torbjörn Andersson
871375d4b5 I believe this fixes bug #2162345 ("BS1: Can't overwrite savegame"), but I'd
really appreciate it if someone would test it further, in case I missed
something. (Broken Sword 1 stores the names of the savegames in a separate file,
and that has to be in sync with the individual savegame files. In my experience,
that sort of thing can really attract bugs...)

svn-id: r34828
2008-10-20 04:39:10 +00:00
Kari Salminen
c501ef1450 Cleanup (Removed an extra 'return 0').
svn-id: r34826
2008-10-19 08:52:04 +00:00
Benjamin Haisch
53163a4284 Implemented visual effects 1, 3, 4, 5, 6, 7 and 16
svn-id: r34823
2008-10-18 21:28:05 +00:00
Max Horn
61b04725a1 Another tweak to HE: Use SearchMan.openFile instead of a raw FSNode
svn-id: r34804
2008-10-14 19:39:33 +00:00
Kari Salminen
c949eb2dac Patch #2131406: AGI: Fix Crash with Apple][ Instruments.
Applied the patch as it is, thanks clone2727.
Now Apple IIGS AGI games don't crash anymore if the
instruments (They're in *.SYS16) or the instrument
samples (They're in SIERRASTANDARD) aren't found.

svn-id: r34798
2008-10-13 19:17:51 +00:00
Torbjörn Andersson
c2066b9c20 Fixed crash after using cutscene subtitles. (Now I *know* no one has used that
feature before. :-)

svn-id: r34796
2008-10-13 18:41:12 +00:00
Max Horn
4686615edf Fix for bug #2162342: FREDDI1: Game does not start
svn-id: r34793
2008-10-13 10:26:26 +00:00
Florian Kagerer
e25265425d - fix installer file support for Kyra 2 and 3
- fix bug in pc98 audio driver

svn-id: r34791
2008-10-13 06:29:14 +00:00
Torbjörn Andersson
dc75da4348 Use the save file manager's listSavefiles() function to find out if any savegames
exist at all. (The old method was to potentially try and open a hundred files,
though it would stop after finding the first one.)

svn-id: r34790
2008-10-13 04:24:18 +00:00
Torbjörn Andersson
4cd3adb690 Increased maximum subtitle line length for SimSaw. That code really should be
made more robust some day, but until now I don't think anyone actually used it.

svn-id: r34787
2008-10-12 22:14:30 +00:00
Max Horn
19b6289688 Don't call Common::List::size() if you don't have to (it's an expensive operation, which has to iterate the whole List, while empty() works in constant time)
svn-id: r34786
2008-10-12 22:06:31 +00:00
Max Horn
4747f8dc01 Fix warning
svn-id: r34780
2008-10-12 21:51:52 +00:00
Nicola Mettifogo
1002b82022 Changed BRA to use the new Common:Archive infrastructure.
svn-id: r34777
2008-10-12 07:01:09 +00:00
Max Horn
ec874705ff Use Common::File instead of FilePtr
svn-id: r34769
2008-10-11 21:23:53 +00:00
Travis Howell
104b39ef67 Add patch from Quietust - Correct music speed in Amiga V2/V3 games.
svn-id: r34767
2008-10-11 02:25:55 +00:00
Nicola Mettifogo
15d94dd614 Fixed crash when existing BRA: fonts were deallocated twice.
svn-id: r34766
2008-10-11 02:23:13 +00:00
Vicent Marti
1f2ce8b188 Manual merge of the GSoC2008 GUI branch. (71 files)
svn-id: r34757
2008-10-09 11:49:35 +00:00
Max Horn
6a2f3dc0b9 Added new type Engine::Feature; pushed down some #include dependencies
svn-id: r34755
2008-10-06 12:48:52 +00:00
Vicent Marti
000eedb073 Merged revisions 34748,34750 via svnmerge from
https://tanoku@scummvm.svn.sourceforge.net/svnroot/scummvm/scummvm/trunk

........
  r34748 | dreammaster | 2008-10-05 12:25:35 +0200 (Sun, 05 Oct 2008) | 1 line
  
  Changed NPC schedules to be loaded when an NPC is activated - this avoids an issue with the Castle Skorl's pre-activation room number being invalid room #99
........
  r34750 | fingolfin | 2008-10-05 14:18:16 +0200 (Sun, 05 Oct 2008) | 1 line
  
  Fixed ambiguous 'else'
........

svn-id: r34752
2008-10-05 20:31:18 +00:00
Vicent Marti
5f30b1f320 Merged several revisions from SVNMerge.
Fixed theme loading to use the new ArchiveMember class.

Original SVNMerge.py log:
=====================
Merged revisions 34686,34688-34689,34691-34698,34700-34705,34707-34713,34715-34722,34725-34727,34731-34732,34734-34738,34746 via svnmerge from 
https://tanoku@scummvm.svn.sourceforge.net/svnroot/scummvm/scummvm/trunk

........
  r34686 | cyx | 2008-09-29 21:09:56 +0200 (Mon, 29 Sep 2008) | 1 line
  
  add constructor to SearchSet::Node for proper init of structure members with gcc 3.4.x (see tracker items #2120595, #2106292)
........
  r34688 | cyx | 2008-09-29 22:08:26 +0200 (Mon, 29 Sep 2008) | 1 line
  
  restrict _heXmapNum to HE versions, should fix #2135822
........
  r34689 | eriktorbjorn | 2008-09-29 22:40:58 +0200 (Mon, 29 Sep 2008) | 4 lines
  
  Since no one has come up with any better suggestion... this should fix #2123258
  ("COMI: Crash after video (SAN) play"). The eos() function won't return true
  until we've tried to read *past* the end of the stream.
........
  r34691 | tanoku | 2008-09-30 00:29:07 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Ported ZipArchive::getAllNames() implementation from GUI branch.
........
  r34692 | fingolfin | 2008-09-30 11:07:03 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Order alphabetically
........
  r34693 | fingolfin | 2008-09-30 11:08:17 +0200 (Tue, 30 Sep 2008) | 1 line
  
  SAGA: Removed patchesCount from SAGAGameDescription
........
  r34694 | fingolfin | 2008-09-30 11:09:39 +0200 (Tue, 30 Sep 2008) | 1 line
  
  SCUMM HE: Use FilesystemNode::openForReading() instead of 'new Common::File' (didn't cover all instances, though)
........
  r34695 | fingolfin | 2008-09-30 11:11:25 +0200 (Tue, 30 Sep 2008) | 1 line
  
  SAGA: Forgot to commit saga.h
........
  r34696 | fingolfin | 2008-09-30 11:12:02 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Added multiple new open() methods to Common::File, which make it possible to use this class as a generic convenience wrapper around all kinds of SeekableReadStream; also renamed the name() method to the less confusing getName()
........
  r34697 | fingolfin | 2008-09-30 13:33:43 +0200 (Tue, 30 Sep 2008) | 1 line
  
  cleanup
........
  r34698 | tanoku | 2008-09-30 13:53:37 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Fixed functionality of ZipArchive::getAllNames(). Now it expects a possibly non-empty string list and returns the amount of new filenames added to it.
........
  r34700 | fingolfin | 2008-09-30 14:27:38 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Renamed Engine::quit to Engine::shouldQuit (previously, it was easily confused with Engine::quitGame); also cleaned up engine.h a bit
........
  r34701 | fingolfin | 2008-09-30 14:37:28 +0200 (Tue, 30 Sep 2008) | 1 line
  
  cleanup
........
  r34702 | fingolfin | 2008-09-30 14:38:44 +0200 (Tue, 30 Sep 2008) | 1 line
  
  AdvancedDetector: Do not (ab)use paths to keep track of files, rather, use FSNodes -- partial (?) fix for bug #2137680
........
  r34703 | fingolfin | 2008-09-30 14:58:27 +0200 (Tue, 30 Sep 2008) | 1 line
  
  SAGA: Some code cleanup
........
  r34704 | fingolfin | 2008-09-30 14:59:29 +0200 (Tue, 30 Sep 2008) | 1 line
  
  SKY: Fix detector to not (ab)use FSNode::getPath; if you want to open a FSNode, just pass it to File::open
........
  r34705 | thebluegr | 2008-09-30 15:19:14 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Fixed crash when starting IHNM, a regression from commit #34693
........
  r34707 | fingolfin | 2008-09-30 17:42:19 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Fixing ConfigManager::loadConfigFile
........
  r34708 | fingolfin | 2008-09-30 18:23:35 +0200 (Tue, 30 Sep 2008) | 1 line
  
  AGI: Another case where it is better to use FSNodes directly, instead of converting them to path strings
........
  r34709 | fingolfin | 2008-09-30 18:34:38 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Modified FilePluginProvider to use FSNodes (instead of raw filenames / paths) in its API
........
  r34710 | fingolfin | 2008-09-30 18:38:46 +0200 (Tue, 30 Sep 2008) | 1 line
  
  AGI: Got rid of yet another unwarranted use of FSNode::getPath
........
  r34711 | fingolfin | 2008-09-30 18:53:04 +0200 (Tue, 30 Sep 2008) | 1 line
  
  AGI: Simplify WagFileParser by not reading data into a memory stream first (this was there to improve performance on systems with slow seeking; those systems should use another approach, see scummvm-devel)
........
  r34712 | thebluegr | 2008-09-30 18:55:10 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Fix crash when starting ITE, a regression from commit #34705
........
  r34713 | fingolfin | 2008-09-30 19:09:41 +0200 (Tue, 30 Sep 2008) | 1 line
  
  Fix ThemeBrowser to use FSNodes, not getPath()
........
  r34715 | Kirben | 2008-10-02 16:41:50 +0200 (Thu, 02 Oct 2008) | 1 line
  
  Correct HE version for Putt-Putt Enters the Race (French/Windows).
........
  r34716 | fingolfin | 2008-10-02 18:58:59 +0200 (Thu, 02 Oct 2008) | 1 line
  
  Renamed FilesystemNode -> FSNode
........
  r34717 | fingolfin | 2008-10-02 19:08:15 +0200 (Thu, 02 Oct 2008) | 1 line
  
  cleanup
........
  r34718 | fingolfin | 2008-10-02 19:17:18 +0200 (Thu, 02 Oct 2008) | 1 line
  
  Ignore String::deleteLastChar when called on an empty string
........
  r34719 | fingolfin | 2008-10-02 19:20:21 +0200 (Thu, 02 Oct 2008) | 1 line
  
  Fix for bug #2142743: Assertion on clicking "Theme" in Options
........
  r34720 | fingolfin | 2008-10-02 19:48:01 +0200 (Thu, 02 Oct 2008) | 7 lines
  
  Engine class changed:
  - Moved initCommonGFX() && GUIErrorMessage() out of class Engine
  - got rid of the _autosavePeriod member (this prevented users from
    changing the autosave period during runtime)
  - Got rid of an evil 'using GUI::Dialog' statement
  - Clarified some Doxygen comments
........
  r34721 | fingolfin | 2008-10-02 19:52:29 +0200 (Thu, 02 Oct 2008) | 1 line
  
  Add the current dir to the global SearchSet, i.e. to SearchMan (this should fix the problems on Windows, and maybe other systems, see 'bug' #2137680)
........
  r34722 | fingolfin | 2008-10-02 19:55:08 +0200 (Thu, 02 Oct 2008) | 1 line
  
  Forgot to mention yet another Engine class change: mainMenuDialog -> openMainMenuDialog; and also forgot to commit this related file :/
........
  r34725 | fingolfin | 2008-10-02 20:11:40 +0200 (Thu, 02 Oct 2008) | 1 line
  
  typo
........
  r34726 | thebluegr | 2008-10-03 00:04:34 +0200 (Fri, 03 Oct 2008) | 1 line
  
  Merged loadHotSpotsMads() and loadHotSpotsM4()
........
  r34727 | lordhoto | 2008-10-03 02:16:21 +0200 (Fri, 03 Oct 2008) | 2 lines
  
  Fixed typos (thanks to Raziel^ for spotting them).
........
  r34731 | fingolfin | 2008-10-03 18:07:57 +0200 (Fri, 03 Oct 2008) | 1 line
  
  Fixed Engine::hasFeature to use proper types (i.e., MetaEngine::MetaEngineFeature instead of int)
........
  r34732 | fingolfin | 2008-10-03 18:14:12 +0200 (Fri, 03 Oct 2008) | 1 line
  
  SCUMM: Added french Monkey VGA variant, see bug #2129199
........
  r34734 | lordhoto | 2008-10-03 18:57:40 +0200 (Fri, 03 Oct 2008) | 2 lines
  
  Committed slightly modified patch #2034983 "Case-insensitivy and directory handling for engines".
........
  r34735 | lordhoto | 2008-10-03 20:18:42 +0200 (Fri, 03 Oct 2008) | 2 lines
  
  Check all 'kyra.dat' files in setup paths instead of only the first one found.
........
  r34736 | lordhoto | 2008-10-03 20:23:57 +0200 (Fri, 03 Oct 2008) | 2 lines
  
  Cleanup.
........
  r34737 | dreammaster | 2008-10-04 13:10:25 +0200 (Sat, 04 Oct 2008) | 1 line
  
  Bugfix to prevent NPC characters managing to walk beyond room exits without leaving the room, and thus getting stuck
........
  r34738 | fingolfin | 2008-10-04 15:09:01 +0200 (Sat, 04 Oct 2008) | 1 line
  
  Renamed some MetaEngine feature flags; removed explicit numbers from this feature flag list (nothing should rely on their specific values, anyway); added a note that Engine::hasFeature should become independant of MetaEngine::hasFeature
........
  r34746 | john_doe | 2008-10-04 23:40:14 +0200 (Sat, 04 Oct 2008) | 3 lines
  
  - Declared all stack functions as inline
  - Sleep some ms after 500 opcodes to reduce CPU load
  - Fixed odd bug in LGoP2 where text disappeared quickly without waiting for user input by returning 0x38 in sfShowPage
........

svn-id: r34749
2008-10-05 11:21:07 +00:00
Paul Gilbert
b9a0e32c3c Changed NPC schedules to be loaded when an NPC is activated - this avoids an issue with the Castle Skorl's pre-activation room number being invalid room #99
svn-id: r34748
2008-10-05 10:25:35 +00:00
Benjamin Haisch
99f8add65c - Declared all stack functions as inline
- Sleep some ms after 500 opcodes to reduce CPU load
- Fixed odd bug in LGoP2 where text disappeared quickly without waiting for user input by returning 0x38 in sfShowPage

svn-id: r34746
2008-10-04 21:40:14 +00:00
Max Horn
b41cd58cee Renamed some MetaEngine feature flags; removed explicit numbers from this feature flag list (nothing should rely on their specific values, anyway); added a note that Engine::hasFeature should become independant of MetaEngine::hasFeature
svn-id: r34738
2008-10-04 13:09:01 +00:00
Paul Gilbert
8706081b82 Bugfix to prevent NPC characters managing to walk beyond room exits without leaving the room, and thus getting stuck
svn-id: r34737
2008-10-04 11:10:25 +00:00
Johannes Schickel
d89ff31450 Cleanup.
svn-id: r34736
2008-10-03 18:23:57 +00:00
Johannes Schickel
f3469eae94 Check all 'kyra.dat' files in setup paths instead of only the first one found.
svn-id: r34735
2008-10-03 18:18:42 +00:00
Johannes Schickel
e417471177 Committed slightly modified patch #2034983 "Case-insensitivy and directory handling for engines".
svn-id: r34734
2008-10-03 16:57:40 +00:00
Max Horn
4b236a787f SCUMM: Added french Monkey VGA variant, see bug #2129199
svn-id: r34732
2008-10-03 16:14:12 +00:00
Max Horn
84229ee79c Fixed Engine::hasFeature to use proper types (i.e., MetaEngine::MetaEngineFeature instead of int)
svn-id: r34731
2008-10-03 16:07:57 +00:00